- 07 Oct, 2020 40 commits
-
-
Daniel Hosseinian authored
Instead of just clearing the canvas when going out of view, remove it. Recreate the canvas once needed again. Bug: 1134057 Change-Id: I11131d7bf584eb51c94f4fd24484ba9f6675e75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451387Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#814803}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I71bddb7d051200b4d816d16e4344c7033029e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814802}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010070700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/uWbmcEtWADarsG0HhmvlhXO-JRde7y_pepUaXfu4TDAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170162418 Tbr: help-app@grotations.appspotmail.com Change-Id: I02decd1ec740760753a917696c443c297ed89b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456014Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814801}
-
dpapad authored
Bug: None Change-Id: I53e732ac6f968583838b12a965c70cb3f56f5dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457326 Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#814800}
-
Vladimir Levin authored
This patch increases the viewport intersection margin for content-visibility: auto to 150% of the viewport. This prevents excessive 'checkerboarding' from lack of rendered content on quick flings. R=chrishtr@chromium.org TEST=Tested with scrollBy({ top: 10000, behavior: 'smooth' }) on FB. Change-Id: I70d3ef371d5aeb943dca26d6decae97184db446b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453029 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814799}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91ab730685a6..3419b3b485ba 2020-10-07 primiano@google.com Merge "build: Remove no-op calls to set_sources_assignment_filter" 2020-10-07 ddrone@google.com Merge "Manually copy Chrome extensions to Perfetto" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I44914bbe29b3d8a0a6a74343dfba64a366507760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457390Reviewed-by:
-
Scott Violet authored
BrowserControlsOffsetCallback landed in 88, not 87. I merged the restore code to 87: https://chromium-review.googlesource.com/c/chromium/src/+/2454639 so the version checks need to be updated. Lastly, I named a method wrong in Browser. This fixed that. BUG=none TEST=this only updates comments. Change-Id: I073dc8986588853c27aed906ed0f5ccee71f923c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454837Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814797}
-
Jose Dapena Paz authored
Fix build error: ../../components/omnibox/browser/on_device_head_model.h:68:15: error: ‘vector’ in namespace ‘std’ does not name a template type Bug: 957519 Change-Id: Idad1853af6afbf31faf288b6b5a73007497338a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453452Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#814796}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be parameterized Bug: 1065748 Change-Id: I70940f9fe74c1865003ce42d421c36f34515f47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454778 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814795}
-
Caroline Rising authored
Bug: 1109316 Change-Id: I51cda7d729f1039c8f9edd33ca36a11ece4a73b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456287Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#814794}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/a388d56d9968..28ae1471bf2c 2020-10-07 dsinclair@chromium.org Exclude spirv-tools from the all build target. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: kainino@google.com Change-Id: I702c5e4e8a973d1689f9e191393033513aa13f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457386Reviewed-by:
-
Aaron Leventhal authored
The index was sometimes too large due to a previous child not being inserted when it was already aria-owned by another parent. Bug: 1135887 Change-Id: If43ff07b6601f024d6d358779cb51d2214aaafb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457548 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814792}
-
Sebastien Lalancette authored
Set-up response creation in JavaScript and handling in CRWTextFragmentsHandler, allowing the collection of success/failure metrics and measurement of the JavaScript library's rate of success. Bug: 1136043 Change-Id: I01eea5d85e2827a496b011d116592bebb74bd92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448683 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#814791}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e66f55b48608..79960a9c04c8 2020-10-07 tvanderlippe@chromium.org Typecheck sources/UISourceCodeFrame.js with TypeScript 2020-10-07 aerotwist@chromium.org Remove unnecessary empty string 2020-10-07 jacktfranklin@chromium.org Use :host-context within component for dark mode 2020-10-07 tvanderlippe@chromium.org Typecheck sources/AddSourceMapURLDialog.js with TypeScript 2020-10-07 tvanderlippe@chromium.org Typecheck sources/InplaceFormatterEditorAction.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I183c0f74cdadf1e0561151d76523353d5494c361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457166Reviewed-by:
-
Jeffrey Young authored
This reverts commit a81c2688. Reason for revert: b:170312454 Original change's description: > ambient: cache two backup photos > > Handle failure cases better by having backup photos on disk. > Refresh these images after user logs in. > > BUG=b:167332126 > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: I7046a20ed9606638e851247f8c213d112af6c30b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429585 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813904} TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,cowmoo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:167332126 Change-Id: I378bec2d00d0a857418e368d77b1afee0f9fc92e Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457048Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#814789}
-
Kyle Williams authored
Move Flags into a more appropriate directory to better follow chromium directory structure conventions. Rename directory to avoid unnecessary acrynomn https://google.github.io/styleguide/cppguide.html#General_Naming_Rules BUG=b:169582550 TEST='build chrome' Change-Id: I9f9f8e506109bd27724f879489cb6088a4e9b132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448684Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#814788}
-
John Williams authored
This change fixes a crash caused by trying to show the same supplemental notification twice when dismissing a media notification. Showing the notification once causes a different problem, where instead of closing, the dialog stays open with the closed notification replaced by the previously-hidden supplemental notification. The fix is to only show supplemental notifications when they are created, and thereafter only hide them in response to the creation of a non-supplemental notification. The original design for supplemental notifications was based on the idea of supplementatal notifications being persistent in order to trigger the display of the media control icon in the toolbar. In the course of the code review, the design was changed to create supplemental notifications in a just-in-time manner to avoid showing the media control icon, so there is no longer any need to show a supplemental notification that was previously hidden. Bug: 1107164, b/161612881 Change-Id: I9a9b60b1e1023ef4d8085ca4df949645f999efdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453440Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#814787}
-
Xinghui Lu authored
This method is called when users click the enhanced protection link in security interstitials. Also add a new access point named kSecurityInterstitial for logging metrics. Bug: 1130721 Change-Id: I02725db2c9557a7d6440584b8f9145a696affff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434089Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814786}
-
Keren Zhu authored
* Rename MatchCountLabel to FindBarMatchCountLabel and move it to top file level, because builder does not support inner class. * Add builder support to it. Bug: 1130078 Change-Id: I6ada19042466ca1216c60858f5542d17cf0c1626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441491 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#814785}
-
Xinghui Lu authored
See the failure in https://crbug.com/1135290#c1. Explicitly enable the SAFE_BROWSING_SECURITY_SECTION_UI flag to show "Privacy and security". Bug: 1135290 Change-Id: I28d4656e8df987d79312dad2e00d67f861465c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450665Reviewed-by:
-
Sammie Quon authored
See bug for specs. Focus ring was already done as part of virtual desks. Since alt tab shares UI with overview, it is done implicitly as well. Test: manual Bug: 1128760, 1128757 Change-Id: I194b6e92ca8b406fea7bc05733e295f16adfc648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446838 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#814783}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //courgette. R=huangs@chromium.org Bug: 1113033 Change-Id: Ia24b5ca4b977524c79c245e78f14d86981aa029d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454274 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#814782}
-
Tommy Nyquist authored
The test is flaky on Android P. See bug for details. Bug: 1135837 Change-Id: I7b5d41cbeda97bb1cb568d09e89b833487bd46f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454889 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#814781}
-
Jun Mukai authored
On some system / device configuration, the accelerometer device file exists but can't be read by the browser process. When this happens, it generates error log repeatedly, which is not great. This CL tries to address this issue in a way. On initializing accelerometer configuration, it tries to read the device file at that time, and when it fails to read, it just stops the initialization and reports an error message. This happens once, and does not generate repeated logs. Also, when an error happens, now it can obtain the errno and print it as a part of the log, so it would be more understandable why it fails. On my case, it is just permission denied, for some reasons. Bug: 1134527 Test: manually with nautilus device in the lab Change-Id: Ib9823631a70fc54d3e3abc35067aff56a7d7ee50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454840Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#814780}
-
Boris Sazonov authored
This reverts commit 243dbcb1. Reason for revert: breaks tests (https://crbug.com/1136112 & https://crbug.com/1135658) Original change's description: > Include translate information in onProvideAssistContent. > > Assistant will use this information to determine whether or not to show a translate prompt when Assistant is opened over Chrome. > > This is controlled by the "TranslateAssistContent" Feature and is off by default. > > Design doc here: https://docs.google.com/document/d/1xZR09XTTGgY0F00_lFOEX7nUc0oqgSrCs5lZFU9INA0/edit > > Bug: 1110943 > Change-Id: I213f55af0efdaa2762f4524b74f942b99123f64b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442360 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Commit-Queue: Josh Simmons <jds@google.com> > Cr-Commit-Position: refs/heads/master@{#813999} TBR=isherman@chromium.org,mthiesse@chromium.org,sclittle@chromium.org,sweilun@chromium.org,jds@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110943, 1136112, 1135658 Change-Id: I51739eb23c0c7ec34a35463ebb498290d853d605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457086Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#814779}
-
Ella Ge authored
No-try: true Tbr: masonfreed@chromium.org Bug: 1135978 Change-Id: Ic03a6fc8a95668d93bc6316cf296f786cf0b365d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457946Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#814778}
-
Nate Fischer authored
No change to logic. This autogenerates VizFeatures.java from the C++ feature definitions using java_cpp_features. This updates ProductionSupportedFlagList and AwContentsTest to depend on the new constants. This rewrites some feature definitions to conform to java_cpp_features's supported syntaxes. Fixed: 1132494 Test: autoninja -C out/Default system_webview_apk Test: run_webview_instrumentation_test_apk -f AwContentsTest.* Change-Id: Ibf085e45d93beeb323d3bc5ce90eaeb2b1ec8f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432111Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814777}
-
edchin authored
Re-enables disabled test ReplaceScrolledOffScreenCell. Uses hardcoded number of items in test instead of flakey dynamic approach. Bug: 1104872 Change-Id: Ic7ca34b7fa8936452fbc6efaee12563803eb023e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450812Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814776}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I2771fd429b8d5467de13b79242bf3b9bf005ed33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457286Reviewed-by:
-
Brian Malcolm authored
A device can be managed by either a Dasher domain, in which case the manager will be a domain (foo.com), or by a FlexOrg, in which case the manager will be an email address (user@foo.com). BUG=chromium:1081272 Change-Id: Id777fb511f1a305ea27ded8f79ac4a206bd9c738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446592 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#814774}
-
Kevin Ellis authored
CL 2425167 introduced a regression where unparseable longhand values could be erroneously accepted. This patch fixes the regression by ensuring that a ParameterResolver is valid before inserting into the set of input properties. This patch also ensures that errors parsing the resolved values in the computed keyframe are quietly rejected. Bug: 1134868 Change-Id: Ieca37bb6f7f3cad2c34bb2601a2148ffe8a34747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448057Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#814773}
-
Collin Baker authored
The WebUITabStrip feature is controlled by an external field trial. However, this field trial includes all devices, including ones that can't enter tablet mode. This CL adds a synthetic field trial that mirrors the feature's state, but is only recorded if the device is a tablet. Bug: 1134713 Change-Id: I866f5dc7814f01c18a8ef1a77f7886c08708d63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446520Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#814772}
-
Dirk Pranke authored
In retrospect, my prior attempt at documenting ways of disabling tests was too ambiguous. This rewrite collapses a couple of cases and provides clearer examples of the various mechanisms. Hopefully this will be more useful. Change-Id: I024ef5398c9a1fe9024e923a367a1b2ad1e23daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443632Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#814771}
-
Jamie Madill authored
Re-re-land with these tests disabled on CrOS devices. Re-land with these tests disabled on Lacros. Uses the new 'use_isolated_scripts_api' feature added here: https://crrev.com/c/2425210 to switch the tests to the ANGLE standalone testing harness. Bug: angleproject:5124 Change-Id: I0b147c2c6d95c2ea80f31ea401aa8c8578a8390a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454396Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#814770}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I858a313836bf23e282cf5884a80e6a3ebe0f70ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456933Reviewed-by:
-
Christian Dullweber authored
Fix PageInfoRow alignment. Use equal icon sizes. Limit dialog height to 90%. Show faded edge when scrolled content is available. Remove bottom padding for main page. Bug: 1135124 Change-Id: I89e36162a9b5348485f7d9c4e4c0ba535b018212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456806Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#814768}
-
Tomasz Wiszkowski authored
This change removes the SuggestionViewDelegate interface, placing the corresponding onSuggestionClicked/onSuggestionLongClicked methods in SuggestionHost, enabling us to decouple the OmniboxSuggestion and underlying URL object - and as effect enabling the aggregate suggestions (such as Query Tiles or Most Visited Tiles) to work. Note: aggregate suggestions may hold multiple URLs, but users interacting with these may open only 1 URL by interacting with these. Bug: 1106109 Change-Id: I4973f8aee689714cf670e16408e1cea0c0adc7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453459Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#814767}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ifbdd19b49dc253d188eab3b3dafecb3beaf51f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456151Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#814766}
-
Ella Ge authored
Test is flaky timeout on linux win and mac, not only leak sanitization Move to TestExpections file. No-try: true Tbr: xidachen@chromium.org Bug: 1135405 Change-Id: I966eebbee3eafd9c4b96850b6169a0dbcc42ab73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457587 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
-
Shakti Sahu authored
This CL adds : 1- Replaces thumbnails to use AsyncImageView on IPH card, and list view. 2- Removes the dependency on LargeMediaPlayButton style from downloads. Bug: 1134412 Change-Id: Ibd9e5dbaeddd47564406ce201e10ec207df785b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444536 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#814764}
-
