- 15 Jul, 2020 40 commits
-
-
Jack Franklin authored
https://crrev.com/c/2297395 ships a new breadcrumbs component that includes its own unit tests and DevTools frontend also has an e2e test for the breadcrumbs. Therefore we don't need to also maintain these layout tests in Chromium. Change-Id: Ifefb09a545442d3681a9b4921d4d708c636943d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300081 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#788568}
-
Hans Wennborg authored
Bug: 1105518 Change-Id: I267708d4990adbbdb7d9fe3642fb40d077cad7f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297525Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#788567}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594640123-fdf8a72e5b13627e142e52b62a8ba89cbc874f73.profdata to chrome-win64-master-1594771186-8c7f3834398f8caaba6f32c369440926161c5207.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I2d30330f7effe85b6f644920ad5629c9af89a189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788566}
-
Alice Wang authored
This CL updates the icon to expand the account list in the collapsed bottom sheet used in web sign-in flow. Screenshot: https://crbug.com/1103328#c1 Bug: 1103328 Change-Id: I4ce657ce917cb3b3f87dde62009cf026f4c62c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288378 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#788565}
-
Sara Kato authored
invalid. On a focus event, AXTreeSource searches the first a11y focusable node under the event source. When no focusable node is found, it sets the focus on the event source node, but it invoked undesired behavior. For instance, in ArcSettings application focus was requested, by sending a requestFocus() event. This results in android_focused_id_ being computed again in ax_tree_source_arc. However as this is forced focused event, sometimes the new node is not valid. In this case, rather than default back to the event_source (and move the focus there), the focus should remain unchanged. Removing requestFocus() would cause undesired behaviors in other areas of the app. This CL adds a change, so that when no focusable node is found under the focus event source node, we don't change focus so that it won't invoke unexpected behavior. Note that the a11y event of type FOCUSED can be dispatched in various ways (e.g. via ViewParent#requestSendAccessibilityEvent is another way to request the a11y event). Also, even if it's not the "forced" focus event, technically FindFirstFocusableNode can return null as we're doing different computation than the Android framework. This change also fixes HasText() computation in CanBeAccessibilityFocused. AX-Relnotes: n/a. Bug: b:156562991 Test: Manual. Open arc settings and observe no scrolling Test: AXTreeSourceArcTest.* Change-Id: If07e0c342dab929bf6f516a1753beda31bd9522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291552 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#788564}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e7083de3589..b92d53afbead 2020-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d98afb787a24 to 4ad0f250a010 (9 revisions) 2020-07-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2a68959f to c28de0e5 (434 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105609 Tbr: nifong@google.com Change-Id: I0fc1cb4ae797f2de93ddf514339eb78c2ab1c553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299067Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b31f5e717e2d..3b17f0bde80c 2020-07-15 jiawei.shao@intel.com Optimize B2T and T2B copies with multiple texture layers on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I27fe01df5e836dd03a2a1969bf5e9b360780794c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299493Reviewed-by:
-
Mugdha Lakhani authored
Bug: 898955 Change-Id: Id85bc95c44ad553911dacf731630b5750d4779e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290930 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#788561}
-
Gabriel Kerneis authored
Bug: 750948 Test: CQ Change-Id: Ic11aec698c70d8d562ab51c16859b248b430b0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299620 Commit-Queue: Gabriel Kerneis <kerneis@google.com> Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Gabriel Kerneis <kerneis@google.com> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#788560}
-
Aya ElAttar authored
Added EnterpriseClipboardDlpController to apply data-leak prevention on clipboard confidential data according to the policy rules set by the admin. Bug: 1096458 Change-Id: Idcdba108918e59ecebd50546f78ebf2a9d50c15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275907 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#788559}
-
Miyoung Shin authored
It has been flaky on the chrome os bots since https://crrev.com/c/2215650 landed. As this change has a WebUI Mojo pipe, the order in which WebUI's Send API is called has changed, and the test is failed when 'hideOobeDialog' is called through WebUI's Send and IME's state is updated to show the sign-in screen before the test's result is checked. Bug: 1104861 Change-Id: Iccaf905dd63f4e1e22b8ca399079e1e6a3cee08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297207 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788558}
-
Mugdha Lakhani authored
Bug: 1104943, 1104926 Change-Id: Id4b32c31de3cd5fb8765e79f5824e679ac4b285e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297385Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#788557}
-
Manuel Rego Casasnovas authored
Similar to what we have in NGOutOfFlowLayoutPart constructor we should have an early return in NGOutOfFlowLayoutPart::Run() when we have no positioned descendants. We already have it a few lines later, but we can move it to the beginning of the method to avoid any extra operation. We also add a check for fragmentainer descendants to avoid doing extra work if we don't have any. BUG=1098231 Change-Id: I2d233c1c79a903d1696099c26029c2d09d59a728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279759Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#788556}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a61a55a444b3..8516651130b5 2020-07-14 thestig@chromium.org Add FPDFEditEmbedderTest.ExtractImageBitmapIgnoresSetMatrix. 2020-07-14 nigi@chromium.org Remove unused integer fill flags and converter functions. 2020-07-14 nigi@chromium.org Change FX_FillMode type parameters in CXFA_Graphics. 2020-07-14 tsepez@chromium.org Make CFXJSE_Context delete its own CXFA_ThisProxies. 2020-07-14 thestig@chromium.org Use ScopedFPDFBitmap in FPDFEditEmbedderTest(). 2020-07-14 nigi@chromium.org Replace more integer fill types with CFX_FillRenderOptions::FillType. 2020-07-14 nigi@chromium.org Remove usage of FXFILL_WINDING and FXFILL_ALTERNATE in CPDF_ClipPath. 2020-07-14 tsepez@chromium.org Put CJX_Objects into V8 object embedder slots If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1269c3a627baa9ab4557c3005b8fcf38679f8d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299484Reviewed-by:
-
Koji Ishii authored
Similar to what r784356 crrev.com/c/2275281 did to |ScrollableOverflow|, this patch adds dirty-tree guard to |AddOutlineRects|. This is another operation that walks though post-layout fragment tree. We already use |PostLayoutChildren| since r662988 <crrev.com/c/1624010>, but skipping |NGFragmentItem| was not done yet. This patch adds this. Bug: 1101086 Change-Id: Iac9ef846a03ea6e2a9fbd6aad196b13e14991e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299320 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788554}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/49d9f039e26b..f4db4dad69d7 2020-07-15 cduvall@chromium.org Allow running perf tests with trichrome and standalone WebView 2020-07-15 wvw@google.com [ftrace importer] Add thermal parser If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103896,chromium:1105096 Tbr: skyostil@google.com Change-Id: I23403549fef60f12ef21bad9bc8231e9bf9739b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299479Reviewed-by:
-
Thiemo Nagel authored
The logic has changed here: https://chromium-review.googlesource.com/c/chromium/src/+/2038774 Bug: 888981 Change-Id: I02f4ca33477c3e6f3e77fd3021764b9ae96a99cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298003Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788552}
-
Kent Tamura authored
It has no reasons to use the legacy layout. Bug: 1040826 Change-Id: I2adf8160551d5ec5fa77d506b1e8d930bff43416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299659 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Aya ElAttar authored
Added Clipboard data leak prevention controller to be used on Chrome OS on every clipboard read to validate whether it's allowed. Bug: 1096458 Change-Id: Ibf5441dc80ecc82e46fc20b68053b697a1920d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275445 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788550}
-
Noel Gordon authored
Selection menu button is an action-icon and it should also have a 48px tap target per the files-ng spec. Again borrow the tap target CSS used for {#gear,#sort}-button, since they are action-icon. Bug: 1066727 Change-Id: Ibcb1ae00f70e0dd33a870be4c90563d6976cb6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299661 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788549}
-
Richard Knoll authored
This makes sure any observed Widgets are removed when this class is destroyed. Found by adding a CHECK in its destructor in crrev.com/c/2254598. Bug: 1104876 Change-Id: I58def066b80c314a15d21bf75fd790b16bf54247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296981Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#788548}
-
Eleonora Rocchi authored
Add an illustration in the Password Check button which will be shown until the user has clicked 3 times the button. This CL also adds a test to verify the illustation is shown the correct number of times. Bug: 1101720,1092444 Change-Id: I88c666ba9015e112e55bbac3802fa33662cb54de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283323Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#788547}
-
Dominic Schulz authored
They've moved from .clangd/index to .cache/clangd/index in https://github.com/llvm/llvm-project/commit/9b55bc4d1197aedd76b0f4e04270265cb74cd0b8 Change-Id: I4b3e351940ef3abfc3bfbc393c66a78c7ded3f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297710Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Dominic Schulz <dominicschulz@google.com> Cr-Commit-Position: refs/heads/master@{#788546}
-
Wolfgang Beyer authored
Relevant DevTools CL: https://crrev.com/c/2297420 Bug: https://crbug.com/1101262 Change-Id: I29b37d6c30ea2600129f80935a7e1fca85c8e3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299220Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788545}
-
Alex Rudenko authored
The order in which stylesheets are added can be arbitrary. This CL sorts stylesheets by the content to avoid flakiness. Fixed: 1104260 Change-Id: I4b57e588374bc14ae3d6dd1ee8f5644e12eac093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299719Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#788544}
-
Ramin Halavati authored
DownloadManagerService used a common coordinator for all OTR profiles. It is updated to have separate coordinators per profile. Bug: 1099577 Change-Id: I5532a0de7484670543a318335d4db07018bd170a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297422Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#788543}
-
Bartek Nowierski authored
As it turns out, the PartitionAlloc tag support was abstracted well enough that existing CheckedPtr2Impl can be trivially extended to handle MTECheckedPtr as well. Only the CHECKED_PTR2_AVOID_BRANCH_WHEN_CHECKING_ENABLED case can't be handled by MTECheckedPtr, because it requires a tag to be at a constant offset from the slot beginning. Bug: 1073933 Change-Id: Ib5e72feb76175489bf057637dbadbd5cdf3f1715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291304 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788542}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/a65cf8adc4eb..ca11026a032c $ git log a65cf8adc..ca11026a0 --date=short --no-merges --format='%ad %ae %s' 2020-07-14 junyer Make Regexp::Simplify() return a null pointer when stopped early. 2020-07-05 junyer Bump SONAME, which missing ')' versus unexpected ')' needed. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I3bd0a0e93edc585e0af07e45b186cead85c9e618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299459 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#788541}
-
Noel Gordon authored
Share button is an action-icon, and they should have a 48px tap target per the files-ng spec. Use the same CSS used for {#gear,#sort}-button, since they are action-icon. Bug: 1066727 Change-Id: I22ba784fb7357be29a6e62c659f64b008ac588aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299559 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: -
Alex Rudenko authored
Prevents races with regards to location updates and stylesheet updated. Fixed: 1104333 Change-Id: I78e17444482f16f97503e8c89ea42208c01d21c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299619Reviewed-by:
-
Alex Rudenko authored
The test became flaky because it was relying on the order in which stylesheets are created on the backend. This CL changes the test to rely on sourceURL instead of stylesheetId (incremental) to make the test not flaky. Drive-by: adds .cache created by clangd to .gitignore Fixed: 1104288 Change-Id: I243d97018c2153d228f78e07bd55b625265ec8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299219Reviewed-by:
-
Caitlin Fischer authored
Opening tabs was used as a workaround to avoid continuous animations problems crbug.com/640977. Bug: 1033726 Change-Id: I9962f219e955fe7026666134aee4c3d444a68822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297316 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788537}
-
Viktor Semeniuk authored
This change adds Information button to the SettingCheckCell. This button will be used to display popovers with detailed information about error. It will be used both by Safety and Password Checks. Bug: 1075494 Change-Id: Ife3f06614b98929ca7df544032d284d3e62a063a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279883Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#788536}
-
Thomas Guilbert authored
This CL changes preservesPitch tests to wait until the audioElement's currentTime is at least 0.5 seconds before trying to detect the pitch. Without this check, the test can try to detect the pitch before the audio has played enough, which can return a dominant frequency of 0Hz and fail the test. The CL also makes a few stylistic changes, and fixes an off-by-one error in the number of increments used to calculate frequencies. Bug: 1096238 Change-Id: I6e98e172862a47bea1c4026737138293914f7906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298281 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#788535}
-
Swapnil authored
There are a few errors which occur when parsing of update manifest for force installed extensions. According to the statistics, one of the most common failure reason is MISSING_UPDATE_CHECK_TAG. In that case update server usually provides non-OK app status. Update check tag should be parsed only if app status is OK. To get more details about the types of app status error, UMA statistics are added. Following histogram is added: Extensions.ForceInstalledFailureManifestInvalidAppStatusError Extensions.ForceInstalledFailureManifestInvalidErrorDetail histogram is deprecated. Extensions.ForceInstalledFailureManifestInvalidErrorDetail2 histogram is added due to addition of new failure. Bug: 1100931 Change-Id: Ie45d01b358429fcc4505ee4dcd251b8f2df16f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276417Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#788534}
-
Yutaka Hirano authored
Put a link for slides describing the relationship between the fetch spec and Chromium loading implementation from some README.md files. Bug: None Change-Id: I21cdc8cd005f74152e7908dfb58a1b34b7041d32 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298886 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#788533}
-
Amr Aboelkher authored
Bug: 1100210 Change-Id: Ia86facd2e4a7716ca8b81348f829e5b4fb8b3044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270563 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#788532}
-
Amr Aboelkher authored
Bug: 1100210 Change-Id: I4f87d3649f46238dcc02157050cf1690b41dde4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272300 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4290f3d1534f..a0f7f4611c4c 2020-07-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I929d35c9062ae154f3b7eab82e0a21f774e3508f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299070Reviewed-by:
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=jdoerrie@chromium.org Change-Id: I5b949189dc4a977897dc31bbb36df8fedd1e2e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298780 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#788529}
-
