- 01 Jul, 2020 40 commits
-
-
Sean Topping authored
As an added privacy measure, we want to ensure that JS console logs are not appended to the ADB logs by default. This option is configurable for debugging purposes. is disabled. Bug: internal b/143000339 Test: Verify that JS console logs aren't appended to logcat when option Change-Id: I8618f4202106f0aaa96e746d24825daa82b16ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276625Reviewed-by:Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#784542}
-
Johann authored
This is unused since crrev.com/c/1838477 Change-Id: I338fbae5cb8225deb735dcfa5b9b5e1708417d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269613 Auto-Submit: Johann Koenig <johannkoenig@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784541}
-
Maria Kazinova authored
in PasswordController. The lack of this check was causing a crash. Bug: 1100356 Change-Id: Ifd7c394d25acc74a19645a047f104fbe67995ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277736Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#784540}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 67960cdc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I0cc559cbc0795c83d32bb9fe0a01384f06e25fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277936Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784539}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/47daa4df3387..5fe20ec7dd89 $ git log 47daa4df3..5fe20ec7d --date=short --no-merges --format='%ad %ae %s' 2020-07-01 gramner x86: Split AVX2 and AVX-512 mc asm into separate files 2020-06-30 gramner Fix compilation with nasm 2.15 2020-06-29 epirat07 meson: Workaround missing aarch64 normalisation 2020-06-28 code CLI: Fix help text 2020-06-29 gramner x86: Add minor mc 8-tap optimizations 2020-06-24 gramner CI: Fix PIC test on 32-bit x86 2020-06-25 gramner x86: Fix 32-bit build with PIC enabled 2020-06-24 gramner x86inc: Improve warnings for use of unsupported instructions 2020-06-24 gramner x86inc: Add missing 'blsr' BMI1 instruction 2020-06-09 gramner x86inc: Add template defines for EVEX broadcasts Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Bug: 1100411 Change-Id: Ib303e8ec8da37a5f85191b73cb179d662e64dbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278132Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784538}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c50b1e5063fe..5dd8a62dc322 2020-07-01 lalitm@google.com Merge "tp: fix being able to use .eq, .geq etc on id columns" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If27ca49224bdd9b154f4a6562b0138166f7b6106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784537}
-
Tom Anderson authored
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1066670 Design doc: https://docs.google.com/document/d/190l8eBJrtb-8TyJZLzdRiQEH-gW1XvBVH0gWy0zHiNM/edit?usp=sharing Chrome Eng approval: https://groups.google.com/a/google.com/g/chrome-eng-review/c/TY2zqz7uICI/m/MwHdJv4HAQAJ BUG=1066670 Change-Id: I4fdb7c2169a2b116cb57dec4e436aa832112dd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267923 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784536}
-
Antonio Gomes authored
... instead of WebMediaStream. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I185363683e117ddde65439934f41c03fcf590236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277971 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#784535}
-
Jon Mann authored
This corrects the name of the datatype from "wifiConfiguration" to the correct "wifiConfigurations". Bug: 966270 Change-Id: Ib595f6de752eda561492e4677be05875d9653ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276631Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#784534}
-
Sorin Jianu authored
Change-Id: I64808b274438776fe3c6ce94a27bcf43b84a6639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278305 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784533}
-
John Z Wu authored
- Have PasswordManager inherit from PasswordManagerInterface as a concrete subclass. Bug: 1097353 Change-Id: Ie6a4c89cb017cdfd47c78c825ef26d3ffbb2c274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259512Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#784532}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593604378-7ad12f7ebd4d045f1c25dd8b02b7f9ffca2fcf89.profdata to chrome-mac-master-1593625986-e568525003def338889bcd9398a1bc63224c08c6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I09ec2463ed861232fd2bcb4906f6330ae22af30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278208Reviewed-by:
-
Nico Weber authored
This is apparently used by ffmpeg's robosushi tool, when doing ffmpeg rolls -- except they currently pull the SDK off a GCS bucket instead of using cipd like Chromium normally does nowadays. This makes it possible to make robosushi use the more common method. Bug: 1098899 Change-Id: I0a2aea6cd0316e536bb3501801831817a5290def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277455 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Microsoft::WRL::ComPtr<T>::GetAddressOf() is banned due to the ease of causing memory leaks. Also replace CopyTo(foo.GetAddressOf()) with As(&foo) since CopyTo(&foo) does not work if we are copying to different interfaces. Also replace QueryInterface(foo.GetAddressOf()) with QueryInterface(IID_PPV_ARGS(&foo)). Tbr: zmo@chromium.org,thestig@chromium.org,juncai@chromium.org,jamiewalch@chromium.org Bug: 914910 Change-Id: I52739a601332822c33d07a22027d8b15600131aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271532Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch changes |LayoutBlockFlow:: AddVisualOverflowFromFloats| to use |PostLayoutChildren| to avoid reading stale fragments. DCHECKs were added in r781383 <crrev.com/c/2261092> and these DCHECKs do hit, but we may still read objects that were destroyed or moved out to different location in the tree. Also adds a few more checks to avoid crashes in dirty tree. Bug: 1101449 Change-Id: I3a00052b0a3c86e83789eb542872299d86dbe453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275167Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784528}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifaf7666969c05040b7f35d00e072ab54e113d509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277878Reviewed-by:
-
Joshua Pawlicki authored
There are no plans to implement this, but it is showing up in search results, causing confusion. Bug: 1101487 Change-Id: I9737313f80f6c6a24cce0bf9be976145f3449e96 Fixed: 1101487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278365 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784526}
-
Jordan Bayles authored
Now that the mirroring service has launched, the deprecated MirrorServiceRemoter and MirrorServiceRemotingSource interfaces can be removed. This patch removes these interfaces and associated usages, and adds a new failure reason for remoting start failures. Bug: 1015486 Change-Id: I65f68487acc92afd45402b193be51225592c2cf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265456Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#784525}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba7cbf76d498..b7bfbc299aae 2020-07-01 robertphillips@google.com Move GrRecordingContext.h and GrDirectContext.h into include/gpu 2020-07-01 bsalomon@google.com Remove workaround for not calling SkImage release proc 2020-07-01 brianosman@google.com Change SampleMatrix to SampleUsage 2020-07-01 robertphillips@google.com Make asDirectContext public 2020-07-01 johnstiles@google.com Fix modifier key handling in OS X to allow command-keys to work. 2020-07-01 jvanverth@google.com Fix D3D debug clang build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I2dbcb523ad2fcc21de49657999727e3e6c9ab74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278096Reviewed-by:
-
Christian Biesinger authored
This tests the behavior as specced in https://github.com/w3c/csswg-drafts/issues/5257 R=ikilpatrick@chromium.org Bug: 1045668 Change-Id: I75b945a008b9039b751fc7de54da86cbf399a7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274255 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#784523}
-
Michael Crouse authored
This change adds logic to check that the user has Lite mode enabled for the LiteVideo optimization. This change also checks the network condition before allowing media requests to be throttled. The network must be cellular and have a minimum network quality before allowing throttling to occur. The minimum network parameters are controllable via finch. Bug: 1096193 Change-Id: Ib8f37697fbb0e43da22cc9c824395e86aa213279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275489 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784522}
-
Arno Renevier authored
- loading of facebook page - loading of a picture For desktop only. On desktop, we override performance.measure in order to intercept visual completion mark. We consider the page to be loaded after we have received that mark. We associate that mark with telemetry:reported_by_page:viewable Change-Id: Ic138f91c2eff8980e89fc4daa7d98a62df29693c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222723 Commit-Queue: Arnaud Renevier <arenevier@fb.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784521}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Id1795920fc9ed2de9a5413f6aa9ed3cd97c23707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277112 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Ella Ge authored
Bug: 1007635 Change-Id: Ie0446525178ec1e6e97fd0ec0f3550ea53eb5942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275747Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#784519}
-
Cathy Li authored
Change-Id: I73993e7dd367f68cb9d6f57e18e4615710c0643d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268022 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Auto-Submit: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#784518}
-
Becca Hughes authored
This is a reland of 87f410b6 TBR=steimel@chromium.org Original change's description: > Public side of Windows fix > > BUG=1099250 > > Change-Id: Ia73ff41012a1e4d9a7a524339ea30e0c327f1fe4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269510 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784168} Bug: 1099250 Change-Id: Ide88c07fe6ea556b5eaf3c8951d23fe6c69a6c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277115 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784517}
-
Michael Hansen authored
This lowers the interval for Fast Initiation advertising, and then restores it to a reasonable default when advertising stops. See design document: go/nearby-chrome-bt. Bug: b:154846208 Change-Id: I02720b0ee50ee2bd48f62c010d8da10b8aa6ed2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264623Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#784516}
-
Meilin Wang authored
Bug: b/160202872 Test: unittest. Change-Id: I355c704fd2adda7d96dfbb3c972964e2da7a1e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275342 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#784515}
-
Shengfa Lin authored
Once/Repeating For audio_video_pipeline_device_unittest.cc, changed Bind and Closure to BindOnce and OnceClosure. Modified pass by reference to pass by value for OnceClosure and use std::move when transferring ownership Bug: 1007649 Change-Id: I079c26b8636b451768572ffe355da5ec3325c644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275337Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#784514}
-
Andrew Walbran authored
This adds support for the analog mode, handles thumbstick buttons which give incorrect keycodes on old versions of Android, and marks the mapping as standard. The Android mapping of the thumbstick buttons was fixed in https://android-review.googlesource.com/c/platform/frameworks/base/+/1331927, so the fixed keycodes are also supported. BUG=1073130 Change-Id: Id14e3c7f5d5b35aa565d374860257d1f0960abbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245482 Commit-Queue: Andrew Walbran <qwandor@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#784513}
-
Theresa Wellington authored
Record two new histograms: - Android.PlayServices.Installed - Android.PlayServices.Version Bug: 1099935 Change-Id: I3c91120650c84d791634196b0a651828a38c0a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271109 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#784512}
-
Nate Chapin authored
* Remove Document's IsSandboxed()/GetSandboxFlags(), use the LocalDOMWindow variant instead. * Prefer ExecutionContext/LocalDOMWindow variants to accessing the state on SecurityContext directly *unless* the code needs to handle RemoteFrames, in which can Frame::GetSecurityContext() is the canonical path to accessing state from a SecurityContext. Bug: 1101402 Change-Id: Iffe29c58210b97aa3c6c34fdcc9350b311aad11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276616 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#784511}
-
Eric Orth authored
Move recording of Net.DNS.DnsTransaction.*.*.FailureError to ResolveContext::RecordServerFailure() which is called for all server errors and timeouts rather than just errors where a response is still received. Also fix a bug where ResolveContext::RecordServerFailure() was not being called for all the errors it should be called for. Bug: 1101073 Change-Id: I1e4032589b3ad1cab0e9cfe6f3bc7acc30c7dcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276651Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#784510}
-
Fabrice de Gans-Riberi authored
This reverts commit 3fd89cb3. Reason for revert: Broke android-archive-rel. https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/12848 Original change's description: > Greatly expanded code coverage for cast_auth_util fuzz tests. > > Bug: 796717, b/149843583 > Change-Id: Iee9b406604c923d6109cc9f2391effedb33043d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252691 > Commit-Queue: John Williams <jrw@chromium.org> > Reviewed-by: Doug Steedman <dougsteed@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784502} TBR=mfoltz@chromium.org,dougsteed@chromium.org,jrw@chromium.org Change-Id: I99a5388d1b1a3f7d7b2b94a8d06d734e526dc74c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 796717, b/149843583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278141Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#784509}
-
Fabrice de Gans-Riberi authored
CreativeOriginAdsPageLoadMetricsObserverBrowserTest. CreativeOriginStatusWithThrottlingNestedUnthrottled is flaky on all platforms. Bug: 1099545 TBR=csharrison@chromium.org Change-Id: I823d40894971135d5f5b719eae93a76c78a5052e Change-Id: I2303432fb48cbf4bc4833535cc668fb639f9ba78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278097Reviewed-by:
-
Xinghui Lu authored
This new widget is based on the existing RadioButtonWithDescription widget. It has a separator and an expand arrow on the right. The enabled state of the aux button can be set independently of the enabled state of the entire widget. Screenshots: Both enabled: http://screen/vnEEsHFn22Z Both disabled: http://screen/H1LbVu0yCSY Widget disabled, arrow enabled: http://screen/tkVoWBSuy6M Widget enabled, arrow disabled: http://screen/xKChak8vczO Mocks: go/esb-clank-dd Bug: 1097310 Change-Id: I697712ca46a7f8a6c929d3b39df3c178499c0202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259772 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784507}
-
Christian Larson authored
Updated MFVideoCallback to have a shutdown method to invalidate the pointer to the observer_. Shutdown is needed because MFVideoCallback is a refcounted class and can live longer than the raw pointer to observer_. Added test to validate the crash before the fix and that the code update fixes the issue. Bug: 1099934 Change-Id: I1a80914f720638a4fda2d2155b547ec12bafd08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275493Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Christian Larson <chrila@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784506}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b112fac0033c..57002d0447df 2020-07-01 johnkslang@users.noreply.github.com Merge pull request #2307 from KhronosGroup/location-validation 2020-07-01 johnkslang@users.noreply.github.com Merge pull request #2306 from ben-clayton/licenses If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ic6f558c71e0418c24a136bd2fdc40ca2f67159e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278013Reviewed-by:
-
Sinan Sahin authored
Bug: 1075640, 1088071 Change-Id: I0bfefc0574a66af4d30754ee37c9b6fc709175ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276671Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#784504}
-
Fabrice de Gans-Riberi authored
The test is flaky. Bug: 1100888 TBR=caseq@chromium.org Change-Id: Ie7e0f3ced487e9b75cd78b52ce42aece547cb399 Change-Id: Ieb252751cdddf7c5715820f3e339c3a841843c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277116Reviewed-by:
-
