- 05 Sep, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/065dd27357bc..24b945d60526 git log 065dd27357bc..24b945d60526 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 henrika@webrtc.org Add support of AudioRecord.Builder in the ADM for Android Created with: gclient setdep -r src/third_party/webrtc@24b945d60526 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I517f977780ccf7b52e265c7ca03cf48f6ccca71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693662}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 895b067e. With Chromium commits locally applied on WPT: e7387117 "[sms] Allow SMS Receiver for same origin iframes" 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." afac3266 "Set `Sec-Fetch-Mode` from the network service." 851ab8fb "[WPT/referrer-policy] Regenerate attr-referrer tests" 6facce4a "[WPT/referrer-policy] Regenerate img-tag meta-referrer tests" 9d98088f "[WPT/referrer-policy] Regenerate a-tag tests" c5326d3f "[WPT/referrer-policy] Regenerate img-tag http-rp tests" bb9c94d9 "Simplify fetch-event-within-sw.https.html using async/await" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic15bc082f5b39427877e5720f133e210b7bbe53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693661}
-
Xida Chen authored
Right now when a custom property is not registered, off-thread paint worklet would fall back to the main thread. This is because a non-registered custom property is treated as a CSSUnparsedValue which is then converted into a CrossThreadUnknownType and thus is not supported by off-thread paint. This CL creates a CrossThreadUnparsedValue which contains a string only. After this, we can pass the CrossThreadUnparsedValue cross thread boundaries and make off-thread paint worklet support it. Bug: 996723 Change-Id: Iefed16ad6106570e4a4a62ed718e6b6e4feeca14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778806Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693660}
-
Joel Hockey authored
Change-Id: I4ea3cc88c4c2c4aacfa6c5993b233c43fc43c88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786884 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#693659}
-
Alexander Hendrich authored
This CL upgrades all permissions whitelisted for the Imprivata extensions from dev to stable. Bug: 956540, 945345, 957573, 980171, 980460, 940401, 996125 Change-Id: Ife8b3f37e8e1775275bc3316a52985dfd77f94b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782898Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#693658}
-
Richard Knoll authored
This adds remote devices to the ChromeOS external protocol dialog so users can select devices or installed apps. This preserves any stored preference if users have previously stored a default handler. TBR=dominickn@chromium.org Bug: 993309 Change-Id: Ibcc31a6dfac0fe9f2b3467429edb0a4a8c5dce12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774923 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#693657}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63283689f1bf..d29c5b184087 Created with: gclient setdep -r src-internal@d29c5b184087 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I4bd21b7094b4eb314ed256a544c5dd39d2326bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786580Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693656}
-
Olga Sharonova authored
This reverts commit 67e6ba1c. Reason for revert: Multiple WebSocket* tests failing on MSAN, see https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/15008 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/1909 Original change's description: > [WebSocket] Reduce memcpy at websocket_frame_parser.cc > > This patch removes memcpy at WebSocketFrameParser::Decode to > WebSocketFrameChunk. > To share memory, this changes WebSocketFrame and WebSocketFrameChunk > member type from `scoped_refptr<IOBuffer>` to `char*` referencing > WebSocketStream memory in most cases. > That change needs all users of the classes taking care of reference > life cycle. > WebSocketBasicStream and WebSocketDeflateStream keeps the memory > until next ReadFrames(). > Most tests just copy and hold the memory. > > ToT: 196 MB/s > Patch: 212 MB/s (+8%) > Also this work is accelerated upon more memory consuming flag. > See comments for detail. > > Bug: 865001 > Change-Id: If97651eb61e44805f413fdb7469a5dead5300d21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774420 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Adam Rice <ricea@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693542} TBR=ricea@chromium.org,yhirano@chromium.org,yoichio@chromium.org,crouleau@chromium.org,johnchen@chromium.org Change-Id: I2ad89a78465984491e394ad8881a62efcc9bc9d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787604Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693655}
-
Thomas Tangl authored
This is part of the profile menu revamp. Bug: 995720 Change-Id: Ia81eb5b18c7f8d29e7c14ec42df1e46171afecf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786443Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#693654}
-
Kai Hsien Boo authored
This CL adds an option to save an image's metadata. The design doc is here: go/cca-expert-mode Bug: b:134636934 Test: tast run DUT camera.CCAUIExpert camera.CCAUISettings Change-Id: I2300ba781945e22bbb6217d8c30efa8e1bc4bbcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743874 Commit-Queue: Boo Kai Hsien <kaihsien@google.com> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#693653}
-
Himanshu Jaju authored
Implements different error messages to be shown on Android based on result of trying to share content with other device. Try Again button is in WIP in a follow up CL. Bug: 996322 Change-Id: I8f9e24257202eb76d5431504dbc172ba21c60e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787638Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693652}
-
Yutaka Hirano authored
We're planning to use it to measure the memory impact of the feature. Bug: 1000994 Change-Id: I64406765ab57e11aeb92bead2c50298fecca85db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787029 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693651}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0c35e0f44dbd..ecac2f8fe9bb git log 0c35e0f44dbd..ecac2f8fe9bb --date=short --no-merges --format='%ad %ae %s' 2019-09-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 9b3cc3e05337..19b256616d96 (3 commits) Created with: gclient setdep -r src/third_party/angle@ecac2f8fe9bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I62ca26376fb66e2636bdd61da51e182d5f6966d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786925Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693650}
-
Gauthier Ambard authored
This CL removes some code that was added as a temporary patch to solve a ReadingList bug. The real fix was added in crrev.com/c/1768324. Bug: 988909 Change-Id: I7d85bdfd941d81c9936a127015fc89f399da9107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787321 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#693649}
-
Shik Chen authored
Bug: None Test: Open Hangout and check the capture intent is not unknown. Change-Id: I8659edd9c4b9b5cd3a8964712ef53e00c76d1b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786373Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#693648}
-
Alexander Hendrich authored
This CL upgrades the 'signin_screen' behaviors whitelisted for the Imprivata extensions from dev to stable. Bug: 956540, 945345, 986266 Change-Id: Ib2cd9a28990deb84f83be76358b4d97f5626a542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783139Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#693647}
-
Friedrich Horschig authored
This CL (re-)introduces the modern_blue_700 color which could ensure that text on selected chips meet the proper contrast ratio. (screenshot of this very subtle change in the bug) Bug: 999142 Change-Id: I25ebdfba23abd192e943a09551ba0ac8b62e6585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776049Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693646}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ebac3a0234ee..dc5858f0a40a git log ebac3a0234ee..dc5858f0a40a --date=short --no-merges --format='%ad %ae %s' 2019-09-05 tcwang@google.com afdo: Publish the changes to kernel metadata as a CL. Created with: gclient setdep -r src/third_party/chromite@dc5858f0a40a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I78830d2bc3abbab1eb3a0a2517a59aaaa1b8c931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693645}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread when the ServiceWorkerOnUI feature is enabled. This CL makes browsing_data test utils aware of the core thread instead of assuming the IO thread. Bug: 824858 Change-Id: Idd9d32610776c9b7c48003564dc5e9407a467e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786458Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#693644}
-
Dominic Farolino authored
This reverts commit 95fc19d5. Reason for revert: (To be extra safe for branch point) This CL changes the semantics of SecurityPolicy::GenerateReferrer. Similar logic in the net layer (URLRequestJob::ComputeReferrerForPolicy) must also be updated alongside the SecurityPolicy changes. At the time of writing this CL I was not aware of the URLRequestJob method. Not updating this method alongside my changes caused issues seen in http://crbug.com/1000614. The next step is to introduce the URLRequestJob alongside this CL, as well as a web-platform-test ensuring the issues in the crbug do not crop up. This CL will be re-landed as soon as this is finished, and after the branch point. Original change's description: > Fix `Referer` for descendant module scripts and worklets > > This CL addresses a problem with SecurityPolicy::GenerateReferrer > when it comes to checking the same-origin-ness of a request. The > WebAppSec Referrer Policy Standard defines a same-origin request [1] as > one where the request's origin and current URL are same-origin with > each other. This comparison is done in "determine a request's referrer" > algorithm. > > The analogous place in our implementation is > SecurityPolicy::GenerateReferrer. Before this CL, GenerateReferrer would > determine a request's same-origin-ness by comparing the origin of the > request's referrer string and the origin of the request's current URL. > Most of the time this was sufficient, as the request's referrer string > is almost always same-origin with the request's origin (initiator > in Blink). With descendant module scripts and worklets however, the > origin of the request's referrer string and request's origin (initiator) > could be different, which breaks the correctness of our GenerateReferrer > method. > > This CL introduces a blink::SecurityOrigin parameter to the > GenerateReferrer method, so that correct same-origin comparisons can be > carried out. In all GenerateReferrer call-sites, an appropriate origin > is passed in. > > [1]: https://www.w3.org/TR/referrer-policy/#same-origin-request > > Bug: 786862 > Change-Id: I8cd9ff62790c3b4387ba2dff337e489c5f10da58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768501 > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Dominic Farolino <dom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692554} TBR=kinuko@chromium.org,yhirano@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,dom@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 786862 Change-Id: I7edc6b7ac235a620b3939184883dcfaa6d209403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787482Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#693643}
-
Juan Antonio Navarro Perez authored
AddMeasurement is the new API that will be used to support ad hoc measurements collected by benchmarks. This also helps clients remove their dependency from legacy Telemetry values. Bug: 999484 Change-Id: I7d03c3380ddc99dce27b2200009d824faca82c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780839Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693642}
-
Kent Tamura authored
Bug: 242216,922875 Change-Id: I723ff325ec4f6f7ee14a5d95bf5dccf77d916355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782370 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#693641}
-
Friedrich Horschig authored
This CL allows the bubble to extend over the whole length of the screen. The bubble will still be minimal and point to the highlighted item (see screenshot in the linked bug). The cause of the previous misalignment was, that we used chip as a rootview. This results in a very, very restricted area to put the IPH bubble into (basically the chip's rect instead of the whole activity). This also fixes the issue of IPH bubbles having multiple line breaks for small chips. Bug: 1000041 Change-Id: I21537011a190406b57ddd7a5fe513bfa30d7c56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784718 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#693640}
-
Jit Yao Yap authored
This API function is replaced by chrome.loginState.getProfileType(). The function is currently unused and so is safe to remove. Bug: 995788 Change-Id: I408a81d8f3af032c69700873038cdee4882111bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780733Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#693639}
-
Leon Han authored
This is a reland of 581b273e Original change's description: > [webnfc] Refactor/Refine impl for "Creating Web NFC message" algorithm > > This CL implements strictly the "Creating Web NFC message" algorithm > described at http://w3c.github.io/web-nfc/#creating-web-nfc-message. > > 1. > Changes the Web IDL definition for NDEFRecordData from > "typedef (DOMString or unrestricted double or ArrayBuffer or Dictionary) NDEFRecordData;" > to > "typedef any NDEFRecordData;" > > 2. > Adds verification of NDEFRecordInit when creating NDEFRecord, i.e. makes > NDEFRecord ctor throw exceptions in case of invalid NDEFRecordInit. > Also, the same thing for NDEFMessage and NFCReadingEvent. > > 3. > Changes code flow for Step 10.9 of "9.10.1 The push() method" described > at https://w3c.github.io/web-nfc/#the-push-method. > " > Let output be the notation for the NDEF message to be created by UA, as > the result of passing message to create Web NFC message. If this throws > an exception, reject p with that exception and abort these steps. > " > Previously, > NDEFMessageSource (NDEFMessageInit) -Validity check-> > -Mojo TypeConverter-> Mojom NDEFMessagePtr > Now, > Remove "Validity check" and "Mojo TypeConverter" mentioned above, > instead, we reuse the process of creating NDEFMessage from > NDEFMessageSource (NDEFMessageInit), then the next step converting > NDEFMessage to Mojom NDEFMessagePtr is quite an easy job. > > BUG=520391 > > Change-Id: I628981e556f89ffdd0f883da0cfa99b20a6f8300 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767719 > Commit-Queue: Leon Han <leon.han@intel.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> > Cr-Commit-Position: refs/heads/master@{#693539} Bug: 520391,923974 TBR: dcheng@,reillyg@ Change-Id: I608e28638c0909c9d4f675774514cd990f9878c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787557 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#693638}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9b3cc3e05337..19b256616d96 git log 9b3cc3e05337..19b256616d96 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 zoddicus@users.noreply.github.com For WebGPU<->Vulkan optimization, set correct execution environment (#2834) 2019-09-04 40687079+rumblehhh@users.noreply.github.com Export SPIRV-Tools targets on installation (#2785) 2019-09-04 jmadill@chromium.org GN: Add Chromium GoogleTest deps. (#2832) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@19b256616d96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: I4f45ef71c638ee96c6515e264f1643aa2f76e08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693637}
-
Maksim Sisov authored
This CL adds a simple HeadlessScreen implementation and removes usage of NativeDisplayDelegate. Bug: 891613 Change-Id: I522b500ad32358f4ec7db95e4b58b0774b4cc807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782558 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693636}
-
Fredrik Söderquist authored
When a nested <use> has not yet finished loading we currently defer the expansion of nested <use> altogether. Instead just build nested <use> that are available, skipping those which are still loading. Bug: 997176 Change-Id: I5d7ab737129af289add4e8a510f248dcfc28720f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768712Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#693635}
-
Kent Tamura authored
This CL changes ScrollbarMode to a |enum class|, and make it possible to do forward declaration. This CL adds a forward declaration of ScrollbarMode to document.h, and removes scroll_types.h include. It reduces the estimated pre-processed size of document.h by 0.23MB. Bug: 242216 Change-Id: I4d9264d156db66ddad65d6cf74b66fc45cec762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784637Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#693634}
-
Marc Treib authored
The test and its PRE_ test both injected a bookmark to the fake server, intending them to be the same bookmark. However, they did not set a server ID for the bookmark entity, meaning they were treated as different entities. Depending on timing (whether Sync had already happened or not), this would trigger an assertion on the number of bookmarks. The fix is to assign a consistent server ID. Bug: 998130 Change-Id: Ic1192e0c51a23f8ef257003ade6f41d237c82463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787538 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#693633}
-
Olga Sharonova authored
This reverts commit 41e42bfb. Reason for revert: Not a root cause Original change's description: > Revert "Update V8 to version 7.8.283." > > This reverts commit ae084e61. > > Reason for revert: chromium build failure https://ci.chromium.org/p/chromium/builders/ci/linux-archive-dbg/3414 > > Original change's description: > > Update V8 to version 7.8.283. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/681aa450..9ddd0c4c > > > > Please follow these instructions for assigning/CC'ing issues: > > https://v8.dev/docs/triage-issues > > > > Please close rolling in case of a roll revert: > > https://v8-roll.appspot.com/ > > This only works with a Google account. > > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > > > Change-Id: I5efb235167c182e0425b29399372f0f14883e2b1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786898 > > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > > Cr-Commit-Position: refs/heads/master@{#693524} > > TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > Change-Id: I71e75ae25f1f4d03b60b843a45f17bec2c151ef3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787597 > Commit-Queue: Henrik Boström <hbos@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693598} CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,hbos@chromium.org,olka@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I43ca06d8ff4550d013ed9be447aa67f4c66bef56 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787599 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#693632}
-
Ioana Stefan authored
The Protocol Buffer that will be used for storing BackgroundTasks information was added in a previous CL. One information stored in this Protocol Buffer is the extras fields, used when the BackgroundTask is started. It was decided that these extras will be stored in the Protocol Buffer in a new proto message and in a serialized form. This CL adds the necessary changes for transforming the extras from their original representation (Bundle object) to the representation needed in the Protocol Buffer. Tests are also added to check this conversion. Bug: 970160 Change-Id: Ie2acd83b21ecaa51dff5b2c4b74288dac2ae5166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778488Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ioana Stefan <ioanastefan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693631}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/signin. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 891670 Change-Id: I5fcbf414f1ca4222ed3a1f58efb358ecab32b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786778 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#693630}
-
Matt Falkenhagen authored
This is a follow-up to r691621. It converts code added since then. Bug: 824858 Change-Id: I6aa93cc6f5e2da40e51649c4b0052273db316581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786878Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#693629}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /google_apis/gaia. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=blundell@chromium.org Bug: 891670 Change-Id: I549dadbf2e0cb990ad5f98998a2b2b9f6220caef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787107 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#693628}
-
Juan Antonio Navarro Perez authored
This CL enabled json-test-results to be handled by the results_processor instead of Telemetry. Bug: 981349 Change-Id: Ibe9c31c9839ff858be4d9fb0cb7e6ff77b3c79fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781446Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#693627}
-
Henrique Ferreiro authored
Split //services/identity deps into deps and public_deps. Also, fix include files and some build deps. Bug: 970268 Change-Id: I74cfa6dd0b60dec8b1e8ea8236589dc89d1a8703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712872 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#693626}
-
Lowell Manners authored
This test currently fails with "Check failed: !frame_widget_", so it is disabled for now. Change-Id: I52eeffc41cb33271d90424871840b5b8d8f4c5aa Bug: 993337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782899 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#693625}
-
Maksim Sisov authored
There are some methods in DWTHX11, which either have small or zero delta with the methods implemented in DWTHPlatform. Thus, either remove those or move to DWTHPlatform. Bug: 990756 Change-Id: I4780286d1a68844a304f138c5e829b45f6829ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773071 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693624}
-
Jan Krcal authored
This CL adds missing latency metrics for evaluation of the new feature in Beta. Bug: 955475 Change-Id: I1276331337d7c809a076f4b23de7a3a7edd8a910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771602 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693623}
-