GitLab

Change-Id: I5a04dd3304ea8dbc4e51f4910012d96b1104b3fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343638Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796669}

https://chromium.googlesource.com/angle/angle.git/+log/559d54d0807e..275a495dbb2d

2020-08-10 jmadill@chromium.org Vulkan: Remove TODO.
2020-08-10 jmadill@chromium.org Vulkan: Refactor image dependency commands.
2020-08-10 nguyenmh@google.com Invalid calls' pointer params are no longer captured
2020-08-10 jonahr@google.com Enable required extensions for Chromium to use the Metal backend.
2020-08-10 nguyenmh@google.com Implement param capture for glGetUniform calls and extensions
2020-08-10 lehoangq@gmail.com Metal: Implement CHROMIUM_copy_texture

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1112800
Tbr: ynovikov@google.com
Change-Id: If03c582cd49954d31a2ac22d40f2d209f7d33e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347952Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796668}

This description makes it clearer that the flag is only used to control
the ML model if it exists.

AboutFlagsHistogramTest*

Test: unit_tests --gtest_filter=AboutFlagsTest*,
Bug: 881215
Change-Id: Ia226f98d954ad96c680c593716509796b17d0aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346098
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796667}

We now enforce Tab attributes to be acquired on the UI thread

Bug: 1114377
Change-Id: I7c9d9f6414139a57da616fcc4be2073759e84545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343948Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796666}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Iefeb293e59764b52e8e1216ec51d0fc9f2aa9a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347854Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796665}

This is useful for developers to understand why some tests take
longer time to finish or timeout.

Change-Id: I6e9e83d2c9645bac338c074fa5f1f856d66552a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334473Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796664}

[MBI] Add "[Design Doc] MBI: IsolateScheduler" document and "[Code reading] SequenceManager" document

Add scheduler related documents

Change-Id: Ief971df3c6adaf9a79332e8b0e5090c1745e8661
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342231
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796663}

Bug: 1010217
Change-Id: Ic247386d4ba64c14273d959180f2c29b47f4158b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344325Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#796662}

The test suite is stable in the past 200 builds, and the bots capacity
looks sufficient as well.
And tryjobs in crrev.com/c/2330730 show it works fine on 4-cores bots

Bug: 997376, 1098111
Change-Id: I99bed2c4b4dbf256cba0c7c3564252be038f67ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343789Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#796661}

Inline allocations for unions have been allowed as long as the union
doesn't contain any non-string reference-type fields (i.e. non-handle,
non-POD fields). Exceptions were made for strings since they're copyable
and don't introduce a possibility of recursive types.

InlinedStructPtr however is incompatible with a union's generated
wrapper class when the union's first field is a reference type like a
string. This results in difficult to diagnose crashes in cases that are
meant to be allowed by the bindings.

This change prohibits unions from being allocated inline unless they
contain only POD fields.

Inline allocations could be allowed in these (and other) cases, but
that would require more fundamental refactoring of the wrapper types
and/or StructPtr/InlinedStructPtr.

Fixed: 1114366
Change-Id: I623779f067e777a9240aef67a40decc884948247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347167Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#796660}

before: http://screen/JteFt6rNkc5
after: http://screen/wnMPBjYRwbh

Bug: 1097310
Change-Id: I7e6b98f9510dfc580f59cbc20927da3561d15ca7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342282Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796659}

Previously, we only had prefix (as-you-type) suggestions, and
zero-prefix on-focus suggestions.

Now we will have zero-prefix on-clobber suggestions, that could be
(but currently aren't) distinct from zero-prefix on-focus suggestions.

This CL makes AutocompleteInput use a new OmniboxFocusType multi-valued
enum, which corresponds to the oft= GET parameter passed to the suggest
server.

oft=0 (prefix, as-you-type suggestions)
oft=1 (zero-prefix, on-focus)
oft=2 (zero-prefix, on-clobber)

Bug: 1106096
Change-Id: Ide0dd18d76323384cef2926a0b4f9b033d862548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342268Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796658}

See
https://chromium-review.googlesource.com/c/chromium/src/+/2344008

BUG=None
TEST=try

Change-Id: I0664ec7bd189ad1b44e83ec0391a470349844fc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343962
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796657}

Roll Chrome Mac PGO profile from chrome-mac-master-1597082402-653f85831e858c9a0c668621a5e4055f49c06c11.profdata to chrome-mac-master-1597103970-7949af98f84f094ce49225adb2a5f704b5b255e9.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Iba58da5f5fe9f2749fe6eff4fa85a732d5b6ff05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347323Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796656}

Function to split histograms by prefix

- Amended the histogram_paths.py to prepare for the distributed
directories of histograms after splitting.
- Amended two other files that previously expected a single
histogram.xml file.
- Added sorting of histogram nodes by name in merge_xml.py.

Change-Id: I60101777806584722cbeb778c778553259419122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337155
Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796655}

Bug: 1107003
Change-Id: I15c5a4e8c70fe4e7b535eb698dbde69134dabaae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346998
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796654}

This reverts commit 335a581d.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 796644 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMzNWE1ODFkOTlkOTg4Yzk2MzBmOGRjNDI5ZjcxZGY0N2ZjOTlmZDMM

Sample Failed Build: https://ci.chromium.org/b/8872306316841088512

Sample Failed Step: compile

Original change's description:
> [Android WebAPKs] Fix launching > 1 WebAPK on pre-Android-N
> 
> This CL:
> - Makes WebappLauncherActivity set the correct URI on the launch intent
> for WebAPKs
> - Renames WebappIntentUtils#getId() to make it clear that it only
> applies to homescreen shortcuts
> - Moves WebappRegistry#webApkIdForPackage() to WebappIntentUtils
> alongside WebappIntentUtils#getIdForHomescreenShortcut()
> - Adds a boolean parameter to
> WebApkValidator#disableValidationForTesting() for the sake of tests which
> need to keep validation enabled.
> 
> BUG=1114560
> TEST=WebappLauncherActivityTest.*
> 
> Change-Id: I31552f239f65746c8f8654bdb374ca3f4c6889e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345489
> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796644}


No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=1114560

Change-Id: I23183a3322ef78218ebfebb8a4f4a62aadb6b0e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347977
Cr-Commit-Position: refs/heads/master@{#796653}

This reverts commit 320cb6fc.

Reason for revert: breaks compile on mac-arm64-rel

Original change's description:
> Add support for creating VP9 format extensions for VTVDA.
> 
> Creates a vpcc box based on the configuration info.
> 
> R=​sandersd
> 
> Bug: 1103432
> Test: Updated unittests.
> Change-Id: I3d5152b59c6f6ad82da25e699eba2d8bf5ba44ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346607
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Dan Sanders <sandersd@chromium.org>
> Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796591}

TBR=dalecurtis@chromium.org,sandersd@chromium.org

Change-Id: I00b88a95637db2999f190c5945c97743112344e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1103432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348148Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796652}

This use cases happens after the pre-paint tree walk, so is
safe for GeometryMapper.

Change-Id: I728ea302c026b18d8dacf4a39c177c6f13068da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347251Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796651}

It's flaky.

BUG=1113972
TEST=test only change
TBR=afakhry@chromium.org

Change-Id: If2b41231cd9133f03b00f6388f7a5c666a24f3ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347950Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796650}

This CL fixes UAF in CellularSetupImpl class. This was
caused because of callbacks bound with Unretained reference.
Fixed this using WeakPtrFactory so that callbacks will
not be referenced after CellularSetupImpl is destroyed.

Fixes: 1114066
Change-Id: I6d9e2b7676e21f28861cf5ba78308e3400a4fe6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347923Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796649}

Consolidates code for creating (and destroying) the main PDFiumEngine in
a common base class, PdfViewPluginBase. This base class can be used for
any code which is not specific to the Pepper (OutOfProcessInstance) or
Pepper-free (PdfViewWebPlugin) plugin implementations.

Note that this approach involves multiple inheritance of implementation,
but I believe this is a reasonable trade-off during the migration.

Bug: 1085334
Change-Id: I5b17141972a371e70cf0e6801d7dad2cb0d20aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343573
Commit-Queue: K. Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796648}

As users will no longer be presented the promo to sign-in to Cloud
Print, remove dead code by restricting the sign-in handler to adding new
accounts.

Bug: 1113881
Change-Id: I328b83d4914c0654321a0d5efb616b669d405d1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343229
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796647}

1. Generate only one cmake add_library command.
2. Read all deps from project.json.
3. Update gradle build tool to 4.0.1.
4. Update docs.

Change-Id: I88fd4bcc969c158b1522da210bf815e598e55957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342540
Commit-Queue: Richard He <linyhe@microsoft.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796646}

This histogram records the error code returned by the FUSE mounter
program fuse-zip, which is called when a user tries to open a ZIP file
in the ChromeOS Files App.

cros-disks records this histogram since CL 2294959.

BUG=chromium:912236

Change-Id: Id26e882082a7e1c209e4cf89ab753d80e8df92dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342530Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796645}

This CL:
- Makes WebappLauncherActivity set the correct URI on the launch intent
for WebAPKs
- Renames WebappIntentUtils#getId() to make it clear that it only
applies to homescreen shortcuts
- Moves WebappRegistry#webApkIdForPackage() to WebappIntentUtils
alongside WebappIntentUtils#getIdForHomescreenShortcut()
- Adds a boolean parameter to
WebApkValidator#disableValidationForTesting() for the sake of tests which
need to keep validation enabled.

BUG=1114560
TEST=WebappLauncherActivityTest.*

Change-Id: I31552f239f65746c8f8654bdb374ca3f4c6889e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345489
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796644}

https://dawn.googlesource.com/dawn.git/+log/ccf01e74ec70..cbec3179ef87

2020-08-10 natlee@microsoft.com Implement Queue::WriteTexture in D3D12
2020-08-10 rharrison@chromium.org Roll 3 dependencies

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Icaad0babdd16a2e9920a19a8e77564635d7494dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347948Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796643}

https://skia.googlesource.com/skia.git/+log/0952991c4275..a4b9169fb6b3

2020-08-10 brianosman@google.com Remove 'in' variables from SkRuntimeEffect
2020-08-10 adlai@google.com Migrate GrSurfaceContext readPixels to take direct context
2020-08-10 johnstiles@google.com Reduce processor tree depth back to 1.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: fmalita@google.com
Change-Id: Icb311f92fbbaad8ab2d24acb4472df92cf496e75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796642}

Bug: 1068710
Change-Id: Ifd2df4dcc2ad46c3cd87eeab0066e5224a05849e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347324
Auto-Submit: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796641}

Changes the device printer servers allowlist from using CrosSettings to
using |local_state| for simpler compatibility with the existing user
policy.

Bug: 1100777
Change-Id: Icff5cc3839552ded1ad620279eda5311e98ba37b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300684
Commit-Queue: Matt Menard <mattme@google.com>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796640}

HQP has a provider limit of 3. To make full use of the capacity, this CL
dedupes HQP matches.

The first attempt at HQP deduping (crrev.com/c/2219027) deduped matches
too early in the algorithm which could result in unintionally removing a
suggestion even if its duplicate suggestion would later be trimmed or
scored lower. This was reverted (crrev.com/c/2327955).

This CL implements deduping after trimming and scoring of HQP matches.

Bug: 591981
Change-Id: I27c418e2048c495d2622b7937f080792ba43acc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334819
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796639}

The original CL was landed in one piece and reverted due to apparent
perf regressions.  Reland in sections to try and determine more
precisely whether there is any perf impact.

This CL removes ButtonObserver entirely, which should be unused.

If this causes perf regressions... something about cache alignment??

Bug: none
Change-Id: If9c0f40d50c9122d5830067eab0b2e2d63d00b2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346535
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796638}

Pass this (base::RefCountedDeleteOnSequence) instead of a weakptr
to PostTaskAndReplyWithResult.

This should fix a lot of test flakiness due to a dcheck doing a
PostTaskAndReplyRelay.

Bug: 1093448
Change-Id: I7cb4621009c350a60c3769c6fb691a144c6fd5e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346994Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796637}

Replaces StoragePartition pointer comparisons with InSameStoragePartition()
so that it matches what is in RPHI::IsSuitableHost() and
RPHI::GetProcessHostForSiteInstance(). There is no behavior change here.

Bug: 1015882
Change-Id: Ia574b299bd484e146f5135b1c4d34bd6541342ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347390
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796636}

Bug: N/A
Change-Id: I8e1ff49570262172e14dc0cb8876d03c0f8958a4
Ax-Relnotes: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343766
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Auto-Submit: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796635}

This CL records a new histogram called
SafeBrowsing.DelayedWarnings.Event_UrlElisionDisabled if the user
disabled URL elision by enabling "Always Show Full URLs" option via the
omnibox context menu. Only one of the original
(SafeBrowsing.DelayedWarnings.Event) or new histograms is recorded for
a given interstitial.

Bug: 1109260
Change-Id: I5758d4d1b59592d12532fbe6ac81acfca6553af0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337683
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796634}

This reverts commit 591dc1e9.

This was reverted because it was needed by the revert of
crrev.com/c/2343548. We can reland the original CL after the
reland of that CL.

Original change's description:
> Revert "[blinkpy] Drop mac-retina detection from MacPort"
> 
> This reverts commit 4d9f6afe.
> 
> Reason for revert: Reason for revert: We still have 10.10 bots on the waterfall. This breaks the Mac10.10 bot. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/56807 and the blink_python_tests . Sample error:
> 
> [1690/1762] blinkpy.web_tests.servers.cli_wrapper_unittest.CliWrapperTest.test_main_server_error_after_start failed unexpectedly:
>   Traceback (most recent call last):
>     File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper_unittest.py", line 54, in test_main_server_error_after_start
>       argv=[])
>     File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/servers/cli_wrapper.py", line 87, in main
>       port_obj = host.port_factory.get(options=options)
>     File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/factory.py", line 91, in get
>       self._host, port_name, options=options, **kwargs)
>     File "/b/s/w/ir/third_party/blink/tools/blinkpy/web_tests/port/mac.py", line 71, in __init__
>       assert self._version in self.SUPPORTED_VERSIONS
>   AssertionError
> 
> Original change's description:
> > [blinkpy] Drop mac-retina detection from MacPort
> > 
> > Also remove Retina tags from all expectation files.
> > 
> > Bug: 1104846
> > Change-Id: If16ec3610f4120628f834a72fe02750e70418320
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346855
> > Commit-Queue: Robert Ma <robertma@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Auto-Submit: Robert Ma <robertma@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#796546}
> 
> TBR=wangxianzhu@chromium.org,robertma@chromium.org
> 
> Change-Id: I62bf3d1704dd3740f16a69e3c9bdf834a379a82c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1104846
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347250
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#796563}

TBR=sky@chromium.org,wangxianzhu@chromium.org,robertma@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1104846
Change-Id: Ica9fd2e8c6267dd5c658004fdd90f823178d92e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347930
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796633}

As above - there should be no behaviour change.

Change-Id: If1dd78ee934f2efd8df6033e0a88df41f9fb925f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347929
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796632}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c92cc9537f56..f998c5f44233

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sky@google.com,eirage@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1105693,chromium:1112002
Tbr: sky@google.com,eirage@google.com
Change-Id: I39a1c4f771fbe5ddeb1590a7cce45a73853826d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347193Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#796631}

Disable save-link-as when the target site is not allow for child user
when parent use Family Link App to set up "Allow only certain sites" for
filters on Google Chrome by Family Link app.

Bug: 1095762
Change-Id: I61290ef8eb2da4b8093e5fc9984f02a741d8b4fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335450Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796630}