GitLab

It's quite flaky and I can't immediately figure out how to fix it.

Bug: 1032617,1018849
Change-Id: Ibee6b16aba3947601dd47b3fa290734bf076db23
Tbr: nasko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959932Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723476}

This removes all dependences on the Service Manager from within Ash and
clients of Ash. The "Ash Service" is deleted, and the few interfaces
which the browser bound through it are now bound through a handful of
public helper functions that route through Shell.

The only service interfaces used from within Ash are from the
Device Service, and those are now acquired through ShellDelegate.

Bug: 977637
Change-Id: Ia117241f4adddd14303176af78075d0df6c5b563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956160Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#723475}

GitHub now deletes branches automatically when a PR is merged. As such,
the exporter should no longer try to delete them.

Bug: 1032079
Change-Id: I404764eec3d9abfccd7f128dcd52897b9ac06a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955337Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723474}

This patch moves the BottomSheet component over to the
RootUiCoordinator. A new BottomSheetManager class has been added to
manage the glue code that supports the component.

Bug: 986310, 1002277
Change-Id: I939d04a667ff2166b228b21d2acadd8bf0a1d7d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934243
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723473}

Bug: 1031532
Change-Id: I3bb24e86c146ee86f5eb6d4795b0b5397542d100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959412Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723472}

To match the semantics of the new PendingReceiver / Remote APIs.

Merge-With: eureka-internal/342617
Change-Id: I1cfed9313351dff96307b1e63bb2ed4d1e1053b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959927Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723471}

We'll need this in later CLs, but the code involved is larger and we're
breaking it up into seperable parts.

Bug: 995448
Change-Id: Id415e1cdf9bf67eff1897f53b45494c4121d1d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958906Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723470}

Calling sql::Statement::BindInt() with an int64_t argument silently
downconverted, potentially saving incorrect data to a database.
sql::Statement::BindInt64(int64_t) should be used instead.

Introduce an uncallable sql::Statement::BindInt(int64_t) overload to
fail the compile. This also catches calling BindInt with uint32_t. Fix
up various callers that were silently downconverting.

Bug: 908690
Change-Id: I1472ad5461c7e60bfc011def85a48bc9ca216734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935607
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723469}

This is a reland of 2308d074

Original change's description:
> Support grdp files in translation screenshot presubmit
>
> Translation screenshots project requires Chrome devs to upload UI
> screenshots along with string changes in .grd and .grdp files. These
> are XML files containing all user visible strings in Chrome.
>
> Translation screenshots has a presubmit checks that extracts the
> list of modified strings, looks for image files associated with these
> strings and warns the developer to add them if they are missing.
>
> This presubmit parses .grds to extract the list of modified strings but
> it skips <part> tags which are used to reference .grdp files. As a
> result, the presubmit currently ignores string changes in .grdp files.
> .grdp files contain the majority of UI strings in Chrome, so the lack of
> presubmit checks for them results in low translation screenshot coverage.
>
> This CL changes how .grdp files are loaded in the presubmit: Previously,
> they were written in a temporary directory alongside a fake .grd file
> that referenced the loaded .grdp file. The code loaded the fake .grd file
> which resulted in loading the strings in the actual .grdp file. However,
> test mocks override all os.path methods which in turn breaks temporary
> directory creation. As a result, it was not possible to properly test
> the .grdp loading code, so we skipped <part> tags as a workaround.
>
> The new loading code writes a temporary copy of the .grdp file and wraps
> its contents with proper tags so that it can be loaded as a .grd file
> instead. This avoids the need to create a temporary directory and is
> fully testable.
>
> The end result is that Translation Screenshots presubmit will now ask
> Chrome devs to upload screenshots for changes in .grdp files. This should
> significantly increase the coverage of strings with translation screenshots,
> leading to better quality in string localizations.
>
> Bug: 924652
> Change-Id: Iae7933e8147cefdabc15ef21d2b6daa43d5002bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875554
> Reviewed-by: anthonyvd <anthonyvd@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#714550}

Bug: 924652
Change-Id: Ide7559496fb006724cbed9daa67840c1883a55d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912835Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#716224}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953701
Cr-Commit-Position: refs/heads/master@{#723468}

As per the current status, all descendant classes of blink::Node and
blink::Element are ported to use new downcast helpers. The old
macro-based downcast helper implementation is not in use anymore. This
CL cleans up element.h, node.h and mathml_element.h files.

This CL removes,
- DEFINE_NODE_TYPE_CASTS,
- DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION,
- DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION,
- DEFINE_MATHMLELEMENT_TYPE_CASTS_WITH_FUNCTION

Bug: 891908
Change-Id: I04a3a639e44ee5b15b249ea97f16916bd6b4ece2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958494Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#723467}

None of the existing tests explicitly check that local time is
implemented correctly or even different from UTC. By overriding the time
zone, we can explicitly test for the difference reliably in all physical
time zones. This is currently only supported for Fuchsia, which relies
on ICU rather than the OS for the time zone when exploding time.

Bug: 985946
Change-Id: I397a674236d60c0dcb83b8d7ca80d5185559e172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954551
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723466}

Currently, in arabic, author names that are too long are cutoff when
the text is too long.  This CL ensures that the line height is the
same as the font height so that the author name fits entirely.

Screenshot (before): https://screenshot.googleplex.com/oYJHABz3ej6
Screenshot (after): https://screenshot.googleplex.com/kgFDtyhicRN

Bug: 1029934
Change-Id: Id79283e43bc09ab2706580de1fbfe3da892e732b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959626Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723465}

This CL adds the RemoteObjectGateway mojom interface and its
implementation in a new blink module. Follow-up CLs will add
communicating object deletion to the browser and handling method
invocation.

Bug: 794320
Change-Id: Icad078513d1b3d8449feab77e3ac0f2169307432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918187Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723464}

Since we now support browser_tests on Android, this CL simply ports it over and
cleans up some unused headers.

Change-Id: Ib6a94929f91389a780f459edba0c04c5c1f66b7e
Bug: 970205
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958547
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723463}

They were removed in:
  https://webrtc-review.googlesource.com/c/src/+/154344

Bug: internal b/144781004
Test: CQ
Change-Id: Iec0bc6e6c3ebf2bef238229ce7fe8a6f1dbf716f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955563Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723462}

Refactor only, no user-visible changes.

Following the naming conventions decided in
go/clank-preferences-refactor, this change replaces the "Preferences"
suffix in the Themes Settings fragment.

Also un-nest ThemeSetting inner class for clarity, and rename string
resource.

Bug: 1030446
Change-Id: I9813e0d8a3060d29dcb7e73ad2e3fe02c311b1cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958828
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723461}

This change removes the remaining use-cases for texture allocation using
skia and replaces them with shared images via CanvasResourceProvider. It
also removes all unused code as a result.

R=kbr@chromium.org

Bug: 962630
Change-Id: I5d1deff51a5b66f62dfbdf41348e4f343c7c42a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956250
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723460}

If we move these values into the mojo definition then we can
use it directly in blink and get rid of additional intermediate clases.
ie. WebLoadTimingInfo

Change-Id: I40f369597c4f305979767fb0a0d197282996a9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954298
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723459}

This is a re-land of:
https://chromium-review.googlesource.com/c/chromium/src/+/1868534

The original patch caused a regression and was reverted for
crbug.com/1028817. A test was added for the case at:
https://chromium-review.googlesource.com/c/chromium/src/+/1941451

The problem happened when |HandleOverflow| tried to break a
text item but it didn't fit. |NGLineBreaker| looks for
previous opportunities and rewind, but items it tried to
break were modified, which confused |NGLineBreaker|.

The old patch stopped rewinding there. The new approach is to
restore the original item when it failed to break so that it
can always see the original items.

:: The original description follows ::

This patch removes |NGLineInfo::LineEndFragment|, which was
introduced to support hyphens and ellipsis with the single
code. However, ellipsis was changed to use different code,
and |LineEndFragment| ended up with non-optimal way to handle
hyphens.

Although hyphens appear at most once in a line, storing this
to |NGLineInfo| makes harder to keep it in sync with the
hyphenated item. This patch changes it to a field in
|NGInlineItemResult|.

Bug: 1015297
Change-Id: I1dab0dacd8445ed563527bdc90d58b18470725f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943784Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723458}

Prior to this change, disabling (or marking readonly) an input
would cause input.validity.* to become always true, because
willValidate became false. The spec [1] isn't completely clear
but appears to say that input.validity.* should give the state
of validation, independent of whether the control will actually
be validated. Other browsers, including Firefox, behave this
way already.

This CL also adds testing of most validity.* accessors with
disabled=true, readonly=true, and both true. Most of these
tests fail without this CL in place, confirming the bug.

[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#the-constraint-validation-api

Fixes: 1030749
Change-Id: I3d3bea53c57a87cf49b99acf53e53772395bf6ed
Bug: 1030749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952027
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723457}

The possibility of scheduling a task at an exact time is being added to
the BackgroundTaskScheduler. Previous CLs have handled refactoring,
interface and delegation changes.

This CL adds the functionality that starts a task. A task will be
started at the decided time, the scheduling being handled by
AlarmManager. The start of the task and all the additional actions are
done through a receiver class. The start and the wait for the task are
done in a detached thread, while keeping the CPU on through a wake lock.

Bug: 970160
Change-Id: I5e981ebf34c80b6fff6cdba16e4fe2811720560f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778880
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723456}

Query amount of resource during swap buffers. It should be tracke by a Singleton
to prevent repeats. Reports it to both peak gpu memory monitor and task manager.
TODO: give it a CommandBufferId to separate it from SkiaOutputSurface?

Bug: 899905
Change-Id: Idc39e8d3cc01158580e5e8eca28e35bdb766acae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951137
Auto-Submit: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723455}

Bug: 1032592
Change-Id: If3e59edd7b2c90d95e0d323e5451a9821dc032ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953577
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723454}

The VizDisplayCompositor feature is now 100% launched for all Chrome
browser platforms. Remove the feature from chrome://flags and delete
some of the code to check the feature.

We still need to check the feature flag on Android since WebView
requires it be false. As a follow up the remaining places
IsVizDisplayCompositorEnabled() is still needed should be converted to
check IsUsingVizForWebView() and features::kVizDisplayCompositor can be
deleted entirely.

Bug: 732805, 936425
Change-Id: If6894f62195b7d5593ad890be4f95f2ea8025011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957014Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723453}

Was missed in a previous refactor.

Change-Id: I146abbb2cc490cf4ad94badaf9412930fe27a9c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958593
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723452}

An expectation at the end of this test is failing on iOS.  Removes that
expectation on iOS, similar to how it is already removed on Fuchsia.

BUG=1032568

Change-Id: I8a446c74ba18c9b580ca728900682a25c2fd2b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960525
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723451}

This makes noise in the console :)

Bug: None
Change-Id: I66957eaa0aa9e333a29dc1289de21db8c22a6b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959653Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723450}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/eec373d9e7a4..ebf36174fd09

git log eec373d9e7a4..ebf36174fd09 --date=short --first-parent --format='%ad %ae %s'
2019-12-10 rharrison@google.com Rolling 5 dependencies (#933)

Created with:
  gclient setdep -r src/third_party/shaderc/src@ebf36174fd09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I380c8bc6f9f05b39f6a033fbfde13d19b6e20300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960398Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#723449}

Bug: 1030785
Change-Id: Ib9604bfcfd919b19dd0032bb4ed19a2dfd7636f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959327Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723448}

Context: The Bottom-sheet based PaymentHandler UI is based on the
bottom-sheet, as its name suggested. For a ChromeActivity's
bottom-sheet, when users tap on the scrim, the default behavior is
dismissing the sheet. This behavior, however, would increase the avg
time for users to finish a transaction, because users may accidentally
tap to close the sheet and has to redo the transaction.

Old behavior: tapping the scrim of Payment Handler UI dismisses the
sheet.

Change: Since the sheet dismissal behavior is defined in the
onScrimClick method of the BottomSheet's default scrim-observer,
we override this method to bypass the dismissal.

New behavior: tapping the scrim of Payment Handler UI wouldn't dismiss
the sheet.

Bug: 1029815

Change-Id: If15ab2c7f293387fbc546c79006b2d2e811d6b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935431Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723447}

The legacy Windows printing with GDI/EMF has a different print path
from other desktop platforms, as it spools each page of a document
separately so that the results can go through an extra conversion step
from PDF to EMF before being sent to a device.

With XPS printing path no extra conversion step is required, enabling
Windows to use a similar interface as for other desktop platforms and
get the document metafile and simply spool the job.  This CL enables
that option for XPS to coexist with GDI depending upon the
|kUseXpsForPrinting| feature flag.

This CL uses a NOTIMPLEMENTED in PrintingContextWin::PrintDocument()
as a placeholder for where Skia calls will occur, which is to come in
later CL.

Bug: 1008222
Change-Id: I7d6b0a1ef737eaba358f99ed04e047d24a0e895e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935946Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723446}

This reverts commit ae835890.

Reason for revert: This is not a code duplicate as I initially thought. The override makes a call to MaxTextOffset() faster because it doesn't concatenate the strings returned by GetText().

Once this patch is reverted, I'll add a comment pointing out the optimization to make it explicit.

Original change's description:
> AXNodePosition::MaxTextOffset() is not needed anymore
> 
> https://crrev.com/c/1796047 by Nektarios updated
> AXNodePosition::MaxTextOffset(), making the override execute the exact
> same code as AXPosition::MaxTextOffset() already does by calling
> GetText(). The override is not necessary anymore.
> 
> The override was first introduced by Kevin Babbitt in
> https://crrev.com/c/1730094.
> 
> Bug: 1031271
> Change-Id: If9c7338544cc4d966dd7d82e465b04b03c06a5d9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954548
> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#722733}

TBR=nektar@chromium.org,kschmi@microsoft.com,benjamin.beaudry@microsoft.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1031271
Change-Id: I939981e84827f43760eb462eaaa635500b87bf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959267Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723445}

between_child_spacing was added in an attempt to make FlexLayout
backwards-compatible with BoxLayout. The effort failed, and having this
method which adds behavior that doesn't work like anything else in
FlexLayout and which doubles existing functionality (and isn't actually
used anywhere) seems like a bad idea.

Change-Id: I424c51d3279717dbb504aa948d7acc9934c62447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956540
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723444}

Bug: 1028242
Change-Id: I6c0276a8e7b7930ae2e4af6e71117a9e323fec84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959785
Auto-Submit: Erik Staab <estaab@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723443}

Bug: 1021887
Change-Id: I09c1792a4e9d51c2336e0d00dad6350a41591409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959037Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723442}

Updates the expires_after attribute for 222 histograms that show
frequent access in the past 90 days.  These are the 80% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-06-07.

Change-Id: I038c7543b34c26d6b414b5dff87907f33f679bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958254
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723441}

Recording the MIME type of the main frame of a page will give us more
information about what the page contains. This will be useful to some
of the interventions like tab discarding who handle PDFs and regular
pages differently.

Bug: 1030399
Change-Id: I03cc93e913abb351f070a9cc68f808f601252656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955033
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723440}

base::JSONReader::Read() is a static method, so there is no need to
instantiate a base::JSONReader object. While making this change, also
stop using ReadDeprecated(), and make the code lint error free.

Change-Id: I4ba79d61af6c736e762cb926a04e28ef13fb63fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476413Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723439}

Bug: 1011098
Change-Id: Ic8e0d3d5028004d7c980bf1b8b7e7a61ad4a5bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956262Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723438}

Bug: 1032266
Change-Id: I6b0e0d3328444f24d0dbbd874ec8e951ef86ff20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959768Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723437}