- 02 Oct, 2017 40 commits
-
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: If468bececcb1ea017a75b363c0208b3b6b182e97 Reviewed-on: https://chromium-review.googlesource.com/689108Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505787}
-
David Tseng authored
Bug: 709109 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5a7f10b3cc0d62ad7baab56e380e77a860ca2a5a Reviewed-on: https://chromium-review.googlesource.com/677095Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505786}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bef716c8. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2537 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: If89359128aa57606890bb52787d24e5a0ff141a1 Reviewed-on: https://chromium-review.googlesource.com/694982 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505785}
-
W. James MacLean authored
If we route the GesturePinch events sent from RenderWidgetHostViewMac, then wheel event listeners in OOPIF subframes, and the PDF viewer, can intercept the pinch events in order to implement native pinch zoom behaviour. Bug: 739213 Change-Id: I50db39ef53a988b491b3b7e79fa66a392e86c9b7 Reviewed-on: https://chromium-review.googlesource.com/559650 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505784}
-
Mostyn Bramley-Moore authored
There is another FontMessageFilter in pepper_browser_font_singleton_host.cc Bug: 746953 Change-Id: I2ee0188ac38637b94f9e9aa792dccd42be7d8e9a Reviewed-on: https://chromium-review.googlesource.com/696101Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#505783}
-
David Reveman authored
The new version includes build fix for where math.h was not included correctly. TBR=adlr@chromium.org Bug: Change-Id: I8d7715c20e38dc18aed86be77b4036cf99f2f761 Reviewed-on: https://chromium-review.googlesource.com/693474 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505782}
-
Christopher Grant authored
BUG= R=tiborg Change-Id: Id4180e06908fdb4e07bc73cec25d15204d119bdf Reviewed-on: https://chromium-review.googlesource.com/693222Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#505781}
-
Bin Zhao authored
We are trying to not call chrome.cast.channel.open / chrome.cast.channel.close if in-browser cast discovery is enabled. Currently message observer is only added in open function, if we skip opening, observer wont be added. This patch registered cast socket message observer in send function as well. Extension side change: cl/169416458 Bug: 752310 Change-Id: I96231c98bfbcf7163eee1f90869e4b5ae0941260 Reviewed-on: https://chromium-review.googlesource.com/664085Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505780}
-
Donn Denman authored
Disables the Smart Select Text Classifier for the Omnibox. This prevents a longpress gesture in the Omnibox on Android from suggesting "BROWSER" as an action in the Action Bar. BUG=768594 Change-Id: I2dccb6b7443d9891e4243d7288fd65beb9a9da0f Reviewed-on: https://chromium-review.googlesource.com/686060Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#505779}
-
Gregory Chatzinoff authored
Removes unnecessary view controller parameters from APIs in preparation for boxing. These view Controllers are unnecessary since the |presentingViewController_| variable can be used instead. Bug: none Change-Id: I93805365a20438bfd40a5f6b9dd7b229f700df73 Reviewed-on: https://chromium-review.googlesource.com/691517Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#505778}
-
Steven Holte authored
Bug: 755630 Change-Id: I7b6c1c890a68870311411b5f6c7e084052d80f7c Reviewed-on: https://chromium-review.googlesource.com/609588 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#505777}
-
Peter Boström authored
BUG=chromium:654115 R=bsep@chromium.org Change-Id: Iead94366cb68df77f396d92d1f54bc83677551be Reviewed-on: https://chromium-review.googlesource.com/691178 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#505776}
-
Kevin McNee authored
In order to prevent a child frame from scrolling during an overscroll gesture in the root, we give the root a chance to consume the child's GestureScrollUpdate events before the child. With the new scroll latching behaviour, this is unnecessary, as the child would not consume scroll in this case. We now only filter the child's GestureScrollUpdates when scroll latching is disabled. Bug: 751782 Change-Id: I8aa7d652dda4d8bc5768d659019dd750bf44ad33 Reviewed-on: https://chromium-review.googlesource.com/675167Reviewed-by:
-
Roger McFarlane authored
AngularJS can prefix the value in select elements with a type prefix. Autofill already supports teh "number:" prefix. This CL adds support for "string:". Bug: 770781 Change-Id: I5c2b272ca20a3f3a68e3445166c0df36ad5aa058 Reviewed-on: https://chromium-review.googlesource.com/695941 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#505774}
-
Stephen McGruer authored
This tests the DCHECK fix that was applied in http://crrev.com/1c6d2c6 Bug: 467721, 766140 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I96a2f0e608f4bb22a03e6e6845219de63fba2423 Reviewed-on: https://chromium-review.googlesource.com/668957Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#505773}
-
Qiang Xu authored
click changes: Regression comes from https://chromium-review.googlesource.com/c/chromium/src/+/603547 Tray bubble view is default not active, install pre target event handler (RerouteEventHandler) only when TrayBubbleView is opened by click on the corresponding tray, which must be triggered by PerformAction(). Bug: 765473 Test: device test and added test coverage Change-Id: Icca804f2d134f588d9901c38aaebb7a8d87f6f8e Reviewed-on: https://chromium-review.googlesource.com/677231 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#505772}
-
Vladislav Kaznacheev authored
Make MetalayerMode access Shell::Get()->highlighter_controller() directly (not via PaletteDelegate as it used to do). Move the code responsible for auto-exiting the metalayer mode from PaletteDelegateChromeOS to HighlighterController. This is the first step towards shrinking and possibly removing PaletteDelegate in favor of feature-specific mojo connections. Bug: 769996 Test: ash_unittests --gtest_filter=Palette* Change-Id: Ic2f9f79e5f45b30127c20152b36552c2c6118217 Reviewed-on: https://chromium-review.googlesource.com/692748 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
Matthew Jones authored
BUG= Change-Id: I3af2eab75b5498dad128c792992b43dfed735745 Reviewed-on: https://chromium-review.googlesource.com/692986Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#505770}
-
Albert J. Wong authored
Some accidental uses of ADL for resolving PartitionAlloc API calls accidentally snuck in. This removes them. Bug: 766882 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5998cfa3a13eafc444fe97ff447fbb8f35ef7b4e Reviewed-on: https://chromium-review.googlesource.com/686175Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#505769}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/3c8366886252..d4b32ba384da $ git log 3c8366886..d4b32ba38 --date=short --no-merges --format='%ad %ae %s' 2017-10-02 mtklein roll libpng to 1.6.33 2017-10-02 mtklein fix comments in SkColorSpaceXform.cpp 2017-10-02 egdaniel Update lockTextureProxy to return mipped proxys if mipping is requested. 2017-10-02 scroggo Remove SkReadBuffer::validateAvailable 2017-10-02 benjaminwagner Add Linux nVidia Vulkan jobs. 2017-10-02 brianosman Revert "Revert "Revert "Revert "Revert "Make threaded proxy generation MDB-friendly, and defer instantiation""""" 2017-10-02 reed Revert "Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap""" 2017-09-29 reed Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"" Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I7b01bca0df5c4243a9f5a11ff15bbe589ad2b215 Reviewed-on: https://chromium-review.googlesource.com/695922Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505768}
-
Lucas Garron authored
Bug: Change-Id: If768b70d187f91c091d853bc903fd15ea3fb96b7 Reviewed-on: https://chromium-review.googlesource.com/692583Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#505767}
-
Leonard Grey authored
This is one way that Mac backgrounding differs from Windows and may be responsible for causing a worse experience on Mac for some use cases, including a recent WebRTC regression (crbug.com/753943) and MIDI output (https://bugs.chromium.org/p/chromium/issues/detail?id=679417&desc=2#c48) Bug: 679417 Change-Id: I0edc4a0241090de58b8277c0f6944f30bb671893 Reviewed-on: https://chromium-review.googlesource.com/694983Reviewed-by:
Jayson Adams <shrike@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#505766}
-
Toni Barzic authored
Updates webui based lock screen note launcher to new deimnsions and background color. BUG=767707 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I00106c5d936bedd1ce60927074cb69e816ca80ac Reviewed-on: https://chromium-review.googlesource.com/695805 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#505765}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: I62249bb683f291b34da02bc2c20a2ce2668e6078 Reviewed-on: https://chromium-review.googlesource.com/688173Reviewed-by:
-
Will Chen authored
Audits 2.0 has been a default experiment for a while, and should be permanent now so this is just some clean-up. Drive-by: remove dead code for coverage tests in Main.js. Bug: 717085 Change-Id: I71a30da1616b8f6b9d76341e122d62b42cda1cce Reviewed-on: https://chromium-review.googlesource.com/692987 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505763}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=wjmaclean@chromium.org Bug: 666525 Change-Id: Idb83f3e7ae57c5ec284b8cda2e35b0f393ac3613 Reviewed-on: https://chromium-review.googlesource.com/688770Reviewed-by:
-
Dan Beam authored
The "uber" page was 1 page with many sections, i.e. * settings * history * extensions * about/help It doesn't really exist any more as these sections have slowly but surely been replaced by single-frame Material Design (MD) versions. Remove these generally unused assets. uber_shared is still used from older extensions page (will be changed to MD soon) and the policy page (unsure of MD plans). It'd make sense to simply move uber_shared to policy/shared_style.css or something when old extensions code is removed. R=dpapad@chromium.org BUG=683418 NOPRESUBMIT=true # moving existing deprecated CSS Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6ca6c3b22eb2ac5ec29c839cdd66d3616b8359e3 Reviewed-on: https://chromium-review.googlesource.com/689957 Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#505761}
-
Marijn Kruisselbrink authored
Connect a closed message port to a dangling message pipe to make sure messages posted to the port end up getting lost, even after the message port is transferred to a different process. Bug: 673526 Change-Id: I95467bf5c3e1af316c8781bcca6dfdda29936fe8 Reviewed-on: https://chromium-review.googlesource.com/690981Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#505760}
-
Yuzhu Shen authored
This CL: - implements Pause/ResumeReadingBodyFromNet() for URLLoaderImpl. - extends ThrottlingURLLoader and its delegate interface to support Pause/ResumeReadingBodyFromNet(). - makes browser/renderer SafeBrowsing throttles pause/resume when necessary. BUG=715673 Change-Id: I055c2c5052e3dc50346e53ae9fb2eb6241353ba3 Reviewed-on: https://chromium-review.googlesource.com/679612Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505759}
-
Yuri Wiitala authored
This exposes the GLHelperReadbackSupport instance owned by a GLHelper so that client code can query for platform-supported and performance- optimal readback configurations. This will be used for a number of things in soon-upcoming changes: 1) to avoid unnecessary byte-order swizzling; 2) to avoid extra memcpy()'s in GPU drivers. See crbug for further details. Bug: 770422 Change-Id: I544313f731b313c48f4d8198530e840559285157 Reviewed-on: https://chromium-review.googlesource.com/692853Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505758}
-
CJ DiMeglio authored
This work is helpful in the cc::Surface for Videos work, as it allows easier access to this ContextProvider when obtaining Resources. Bug: 746182 Change-Id: Ie68c180a047abd36885ac5a6f70bd13b0e92af43 Reviewed-on: https://chromium-review.googlesource.com/671200 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505757}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/crc32c.git/+log/9bc7a0cada31..0f771ed5ef83 $ git log 9bc7a0cad..0f771ed5e --date=short --no-merges --format='%ad %ae %s' 2017-09-27 costan Fix SSE4.2 arch flag for MSVC in CMake config. (#8) 2017-09-26 costan C API. (#11) 2017-09-26 costan Add license headers to CMake config files. (#7) 2017-09-26 costan Migrate to 0/1 feature detection macros. (#10) 2017-09-26 costan Travis CI: Bump gcc to 7 and clang to 5. (#9) Also update crc32c's BUILD.gn to work with the 0/1 feature detection macros. Created with: roll-dep src/third_party/crc32c/src Bug: Change-Id: I745abbf18e56a10379163758d06f3f83ec8f7982 Reviewed-on: https://chromium-review.googlesource.com/687881 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#505756}
-
James MacLean authored
This reverts commit d55a0bce. Reason for revert: This was a diagnostic CL to test a hypothesis about a crash. However we never observed any calls to DumpWithoutCrashing, so it's time to remove it. Original change's description: > Add DumpWithoutCrashing to RenderWidgetHostViewChildFrame destructor. > > This is a temporary diagnostic measure to determine if, and why, > RenderWidgetHostViewChildFrame is sometimes destructed without > Destroy() being called. > > Bug: 762511 > Change-Id: If6b77ab85b6aeb35e784943d7437b05d75fa0168 > Reviewed-on: https://chromium-review.googlesource.com/652351 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499998} TBR=creis@chromium.org,kenrb@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 762511 Change-Id: I936517ba47473fb8442b648fce3295b0a87b0293 Reviewed-on: https://chromium-review.googlesource.com/695821Reviewed-by:
-
Kyle Horimoto authored
This change re-styles the "Mobile data" section of network quick settings so that when there are no networks shown in the section, it appears compressed. Without this change, the section takes up a lot of screen real estate, which can be annoying to users who do not plan on using mobile data networks. This CL also removes some obsolete code for being a delegate of TrayInfoLabel. Bug: 758323, 672263 Change-Id: I144bf4b0f314270d8007fc924abfb465c93829dd Reviewed-on: https://chromium-review.googlesource.com/693322 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
sohan authored
glGetSringFn, glGetStringiFn, glGetIntegervFn were mapped to real driver functions instead of RealGLApi, so it was unaware of the disabled extensions. This patch maps the 3 api's to GLApi, and adds proc address for missing bindings. Change-Id: I25e887281eae67a22d721749c2d6e8ae7b8e9ed9 Reviewed-on: https://chromium-review.googlesource.com/681660Reviewed-by:
-
Justin Schuh authored
Change-Id: Ia5fc96510733699712e27769c9dee248f5876aa3 Reviewed-on: https://chromium-review.googlesource.com/693278Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 666525 Change-Id: I81b69d00045c3de5f5ab40fb6b6e2ffac8d31768 Reviewed-on: https://chromium-review.googlesource.com/689019Reviewed-by:
-
Shakti Sahu authored
The ordering of the observer methods causes a difference to the download homeUI. If not handled correctly, it can cause the offline item to show indefinite progress forever. Bug: 769987 Change-Id: Ia7954848bb7f67207eba0e469baea40fb8b8932d Reviewed-on: https://chromium-review.googlesource.com/691186Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505750}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/5ec8f61fde1a..31cacbe5d6d2 $ git log 5ec8f61fd..31cacbe5d --date=short --no-merges --format='%ad %ae %s' 2017-10-02 simonhatch Tracing - Fix add_reserved_diagnostics. 2017-10-02 nednguyen Roll typ to the latest version Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I29139e6dde86e40e9691c9ef4c2dd9029d667a13 Reviewed-on: https://chromium-review.googlesource.com/695906 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505749}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 666525 Change-Id: I6182a024fed44f6f596e1570be839f3cf3cfd891 Reviewed-on: https://chromium-review.googlesource.com/689122Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505748}
-
