GitLab

While writing some new tests I ran into some hard to track down failures
that were a result of:
  1) Using AudioBufferConverter due to different input/output rates
  2) Using "int" for all input/output frame counts

For example, DeliverRemainingAudio() would actually over-deliver since
it didn't take the ratio of input/output rates into account.

To help make things better, use the type system to differentiate between
input and output frame counts. In addition, use simpler input/output
rates to make it easier to calculate expected time and frame values.

BUG=370634

Review URL: https://codereview.chromium.org/403003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284529 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the SSL interstitial only displayed this for the non-overridable pages. Now it displays it for all SSL errors.

BUG=

Review URL: https://codereview.chromium.org/407693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284528 0039d316-1c4b-4281-b951-d872f2087c98

Each GuestView derived type is now responsible for managing it's own construction.

BUG=none

Review URL: https://codereview.chromium.org/409603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284527 0039d316-1c4b-4281-b951-d872f2087c98

Predictor is modified to call functions CanPredictNetworkActionsIO and
CanPredictNetworkActionsUI to comply with user preferences (and consider
network connection state).  This obsoletes Predictor::EnablePredictor.  Also,
bool members Predictor::preconnect_enabled_ and Predictor::predictor_enabled_
now depend solely on command line switches, therefore they are made const.

BUG=334602

Review URL: https://codereview.chromium.org/360733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284526 0039d316-1c4b-4281-b951-d872f2087c98

Remove the remaining overrides of View::GetEventHandlerForRect()
and instead implement ViewTargeterDelegate::TargetForRect().
Make View::GetEventHandlerForRect() non-virtual.

BUG=391845
TEST=none

Review URL: https://codereview.chromium.org/403963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284525 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/391413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=278919
NOTRY=True

Review URL: https://codereview.chromium.org/375133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284523 0039d316-1c4b-4281-b951-d872f2087c98

This file is used by the cq to measure loads and other stats. We want
changes to it to result in a compile and test.

BUG=383609
TEST=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/403393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284522 0039d316-1c4b-4281-b951-d872f2087c98

RTCP sender report has a race condition when then current time is
submitted asynchronously (from another process). This caused the value
for DLRR to be negative.

This code is going to be removed it is fine to just suppress this
condition.

BUG=393042
NOTRY=true

Review URL: https://codereview.chromium.org/410433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284521 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

There's still one call to 'ResourceType::FromTargetType' in
RenderFrameImpl that this CL doesn't remove: that method will be
converted to RequestContext in a future CL.

BUG=390497

Review URL: https://codereview.chromium.org/403323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284520 0039d316-1c4b-4281-b951-d872f2087c98

They were previously only disabled in static_library builds. This is believed
to have been due to problems with old MSVC versions, but it should work now.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Last time I attempted to do this, it broke some tests due to a debug assertion.
Gtest had previously been catching the exception, but with exceptions disabled
it crashed. Those tests were actually broken in static_library Debug builds
too, but we don't seem to have bots for that. After Blink r176189, we no longer
hit that debug assertion, so the tests now pass.

BUG=82385
TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
     content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
     webkit_unit_tests

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/404853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395817
TEST=none
TBR=joth

Review URL: https://codereview.chromium.org/408043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284518 0039d316-1c4b-4281-b951-d872f2087c98

> GN chrome/common build, rename enable_printing.
> 
> This adds the missing conditions to the chrome/common GN build file (previously
> only the basic files were there). Some refactoring of the GYP file to make this
> possible.
> 
> Renames the enable_printing flag to printing_mode since this is an integer
> tri-state.
> 
> Minor improvements to chrome/renderer
> 
> R=jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/400243003

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/409543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284517 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395726
TEST=none
TBR=miu

Review URL: https://codereview.chromium.org/410453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284516 0039d316-1c4b-4281-b951-d872f2087c98

jingle_glue_test_util was added long time ago for P2P API in Pepper.
The API was removed long time ago and we no longer need
jingle_glue_test_util.

Review URL: https://codereview.chromium.org/400093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395796
TEST=none
TBR=elijahtaylor, asargent

Review URL: https://codereview.chromium.org/405233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284510 0039d316-1c4b-4281-b951-d872f2087c98

A check for unused variables was missing for some helper functions.
The main thing that this affects is the "config" function, where
people were confused when setting deps or configs didn't work the
way they expected (because they were unused).

BUG=392026
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/399143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284509 0039d316-1c4b-4281-b951-d872f2087c98

This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.

Renames the enable_printing flag to printing_mode since this is an integer
tri-state.

Minor improvements to chrome/renderer

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/400243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394483

Review URL: https://codereview.chromium.org/398893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284507 0039d316-1c4b-4281-b951-d872f2087c98

This patch is mostly just moving code around. It moves the iterators
from tile manager to be in separate files, renames them to be queues.

It also adds a tile manager client interface for building the queues.

The rest is just fix ups for the tests.

R=reveman

Review URL: https://codereview.chromium.org/406543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284506 0039d316-1c4b-4281-b951-d872f2087c98

The second part of https://codereview.chromium.org/389933004 to disable
some failing unit tests on Windows.

BUG=393733

Review URL: https://codereview.chromium.org/403423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284505 0039d316-1c4b-4281-b951-d872f2087c98

Adds a class ScreenshotTester, which now adds an opportunity to take a screenshot while running a test and then
save it to a directory specified by some switch. it is now fully included in LoginUIVisible test.
Taking screenshots also requires waiting until all the animation finishes loading. To handle with it, a class AnimationDelayHandler
is implemented (in LoginUIVisible).
To turn taking screenshots on,  switch --enable-test-screenshots should be used. To specify the directory where all the screenshots will be
stored, use --screenshot-dest=value, where value is the full path to the directory.
It is planned that working with this class will have two modes: taking a new screenshot and saving it, and taking a screenshot and comparing
it with the previously stored one. Now only the first mode is implemented, and running it also requires a switch --update-golden-screenshots.
Pixel output is usually off in the tests, so before taking screenshots switches --enable-pixel-output-in-tests and --ui-enable-impl-side-painting should be also used. 

BUG=395653

Review URL: https://codereview.chromium.org/405093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393177
TEST=none
TBR=erg

Review URL: https://codereview.chromium.org/402213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284502 0039d316-1c4b-4281-b951-d872f2087c98

Reverting in hopes of getting android telemetry_perf_unittests to
green. Here's output:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14733/steps/telemetry_perf_unittests/logs/stdio

Unhandled exception while running file://scrollable_page.html

Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:533
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:228
    self.WillRunActions(page, tab)
  WillRunActions at tools/perf/measurements/smoothness.py:26
    self._power_metric.Start(page, tab)
  Start at tools/perf/metrics/power.py:77
    self._browser.platform.StartMonitoringPower(self._browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/__init__.py:193
    self._platform_backend.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/android_platform_backend.py:251
    self._powermonitor.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/power_monitor/android_temperature_monitor.py:31
    self._power_monitor.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/power_monitor/power_monitor_controller.py:29
    self._active_monitor.StartMonitoringPower(browser)
  StartMonitoringPower at
  tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py:33
    'Must call StopMonitoringPower().')
AssertionError: Must call StopMonitoringPower().


> Add FailureValue and wire it through PageTestResults.
> 
> BUG=392901
> 
> Review URL: https://codereview.chromium.org/399263003

TBR=chrishenry@google.com

Review URL: https://codereview.chromium.org/393713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284497 0039d316-1c4b-4281-b951-d872f2087c98

To prepare for menus overlapping anchors, add the dismiss menu button to the menu.

BUG=375379
NOTRY=true

Review URL: https://codereview.chromium.org/381133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284496 0039d316-1c4b-4281-b951-d872f2087c98

This broke the linux gn bot:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/9676/steps/compile/logs/stdio

[824/4367 | 164.256] CXX
obj/media/video/capture/media_unittests.fake_video_capture_device_unittest.o
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++
-Wl,--fatal-warnings -m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now
-Wl,-z,relro -B../../third_party/binutils/Linux_x64/Release/bin
-Wl,--icf=none -pthread -Wl,-rpath=\\\$ORIGIN/lib/
-Wl,-rpath-link=lib/ -o ffmpeg_unittests -Wl,--start-group
@ffmpeg_unittests.rsp  -Wl,--end-group  -ldl -lasound -lX11
-lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lXss
-lXtst -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0
-lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lfontconfig
-lfreetype -lpangocairo-1.0 -lpango-1.0 -lcairo 
obj/media/base/media_test_support.test_data_util.o:../../media/base/test_data_util.cc:function
media::StartMediaHttpTestServer():error: undefined reference to
'net::BaseTestServer::kLocalhost'
obj/media/base/media_test_support.test_data_util.o:../../media/base/test_data_util.cc:function
media::StartMediaHttpTestServer():error: undefined reference to
'net::LocalTestServer::LocalTestServer(net::BaseTestServer::Type,
std::string const&, base::FilePath const&)'
obj/media/base/media_test_support.test_data_util.o:../../media/base/test_data_util.cc:function
media::StartMediaHttpTestServer():error: undefined reference to
'net::LocalTestServer::Start()'
clang:error: linker command failed with exit code 1 (use -v to see
invocation)
...

> Have media content and chrome browser tests load data from media/test/data
> 
> Update remaining encrypted media browser tests to use new player app.
> 
> (This is identical to r282795 which got reverted, i.e. revert of revert).
> 
> The fix was submitted separately in r283757
> 
> BUG=379314
> 
> Review URL: https://codereview.chromium.org/398823004

TBR=shadi@chromium.org

Review URL: https://codereview.chromium.org/405803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284495 0039d316-1c4b-4281-b951-d872f2087c98

Second phase of extending the relocation packer for arm64.

Add elf_traits.h to define either Elf32 or Elf64 structs and functions
as ELF traits, depending on macro definitions.  Use ELF:: types in place
of Elf32_ (mechanical).

Widen leb128 to handle 64-bit unsigned values, and revise implementation
for better readability and efficiency (and to match sleb128, coming
later).

Change packer and run length encoder functions and function signatures
to handle the Elf types that represent the items they pack and encode
(mechanical).

Move elf_ assignment to the end of ElfFile::Load(), so that it is
assigned only if loading succeeds.

Factor out FindDynamicEntry() to improve readability.

Use ELF_R_INFO() to set r_info in relocations.

Print elf_errmsg() error string on failure to load.

Do full round-trip pack and unpack check with a single memcmp().

Still to do:
  - Add support for relative relocations with addends (RELA).
  - Add new packing strategy for RELA (requires sleb128).
  - Modify relocation_packer.gyp to build both configurations.
  - Extend unit tests to accommodate.

BUG=385553

Review URL: https://codereview.chromium.org/404553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284493 0039d316-1c4b-4281-b951-d872f2087c98

Previously, selection handles on Android were rendered using a PopupWindow
construct.  This is problematic for a number of reasons, the chief being poor
performance and responsiveness. As an alternative, support a native, composited
layer rendering pipeline for selection handles using the browser compositor.
Also port selection handle-related logic from Java to C++, using a
PopupWindow rendering fallback for WebView, lacking a proper browser compositor.

This change depends directly on selection update and visibility routing through
the compositor: https://codereview.chromium.org/300323005/

BUG=380781,135959,279489,393948

Review URL: https://codereview.chromium.org/335943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387614
TBR=bauerb@chromium.org, tony@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/402133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284490 0039d316-1c4b-4281-b951-d872f2087c98

Update remaining encrypted media browser tests to use new player app.

(This is identical to r282795 which got reverted, i.e. revert of revert).

The fix was submitted separately in r283757

BUG=379314

Review URL: https://codereview.chromium.org/398823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284489 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284488 0039d316-1c4b-4281-b951-d872f2087c98

This picks up one new change:
 - "Don't track platform.xml"

Review URL: https://codereview.chromium.org/406013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284487 0039d316-1c4b-4281-b951-d872f2087c98

Profile_metrics doesn't log signed-in metrics for inactive profiles.
However, since mobile platforms never log active times, the signed-in
metrics never get logged.

Reference CLs: (introduced issue as of M35)
https://codereview.chromium.org/134863002/
https://codereview.chromium.org/141663004

BUG=392948

Review URL: https://codereview.chromium.org/405473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392205
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/403343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284485 0039d316-1c4b-4281-b951-d872f2087c98

Require that FC_SCALABLE is true in Fontconfig queries
(matching Blink) and use Fontconfig's FC_EMBEDDED_BITMAP
setting.

BUG=395313

Review URL: https://codereview.chromium.org/401303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284484 0039d316-1c4b-4281-b951-d872f2087c98

Wrapper class is currently located in the unittest file and is a friend of touch_exploration_controller.

BUG=377040

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283741

Review URL: https://codereview.chromium.org/386043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395169,395739,395743
TBR=nednguyen@google.com

Review URL: https://codereview.chromium.org/404193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284482 0039d316-1c4b-4281-b951-d872f2087c98

Make behavior uniform with other apps on Android,
where after a paste from an editable field, the
insertion handle is hidden and only the cursor
remains visible.

BUG=395645

Review URL: https://codereview.chromium.org/403343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389162
TEST=EventTest.DoubleClickRequiresRelease

Review URL: https://codereview.chromium.org/398393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284479 0039d316-1c4b-4281-b951-d872f2087c98

Enhance the coverage of this unit test to verify that
the gesture handler tracked by RootView is always NULL
after a ui::ET_GESTURE_END event corresponding to the 
release of the final touch point has been dispatched.

BUG=395397
TEST=WidgetTest.GestureHandlerNotSetOnGestureEnd

Review URL: https://codereview.chromium.org/408713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284478 0039d316-1c4b-4281-b951-d872f2087c98