- 01 Aug, 2017 40 commits
-
-
Justin Donnelly authored
Introduces two new test classes in content/public/test. Also, moves the incognito check from the call site to the method itself,for both testability and safety. Bug: 748068 Change-Id: I3b9b883a47e35ee229f811bb524b3f1a4621b22d Reviewed-on: https://chromium-review.googlesource.com/585295 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490994}
-
Charles Harrison authored
This makes the ads test the full integration of subresource_filter, whereas before they were just faking callbacks. Bug: None Change-Id: Ic494324df522594278a6c225719fa0239d4b7b7a Reviewed-on: https://chromium-review.googlesource.com/591912Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#490993}
-
Tim Dresser authored
Following up on https://codereview.chromium.org/2954533002/ which marked a bunch of unused metrics as obsolete. Bug: 677873, 677073, 667588, etc. Change-Id: If6579529d86bd04aca84fa0ccf9f29fb966acd6e Reviewed-on: https://chromium-review.googlesource.com/587466Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#490992}
-
Ramin Halavati authored
Network traffic annotation added to network request of: content/browser/devtools/devtools_url_interceptor_request_job.cc Bug: 656607 Change-Id: I15f38c418e0426638740bd74ab41857ea1bc2dcd Reviewed-on: https://chromium-review.googlesource.com/573740 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490991}
-
Takeshi Yoshino authored
- It's confusing that FetchContext has AddConsoleMessage(const String&) with a default argument while BaseFetchContext has one with ConsoleMessage* argument - Not to depend on the core/ constants, FetchContext has LogMessageType, but maybe it's clearer and not much more code if we just have methods for each level given the amount of combinations is small - Instead, we'll be asking users of the Add.*ConsoleMessage() methods to explicitly specify the MessageType to use - Let WorkerFetchContext also print messages as AddConsoleMessage(ConsoleMessage*) is provided by it too - Unify FrameFetchContext::AddConsoleMessage(ConsoleMessage*) and FrameFetchContext::AddConsoleMessage(const String&, ...) Bug: Change-Id: Ia0bd40c50203b1101ff529eeacc830b504e85d07 Reviewed-on: https://chromium-review.googlesource.com/591187Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#490990}
-
Jinho Bang authored
This refactoring is intented to share a lot of codes when introducing a new event dispatching such as CanMakePaymentEvent[1]. Basically, this change includes the following things: - Introduce StartServiceWorkerForDispatch() to use the same logic when adding a new event here. - There is no reason to create InvocationCallbacks too early. It's better to defer the timing just before dispatching event. - Add a test for when StartRequest() is failed because ServiceWorker is killed for some reasons. [1] https://chromium-review.googlesource.com/c/574992/ Bug: 727828 Change-Id: I02a798fa7f9f6854ef8ab424085d3107b5b5f022 Reviewed-on: https://chromium-review.googlesource.com/594607 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#490989}
-
Ashley Enstad authored
Now that all the benchmarks are set not to upload results until their individual flags are flipped, we can change all the benchmarks to output json of the json-test-results format instead of the old simplified json format. BUG=chromium:748638 Change-Id: I10ad5029f29052aec44a0476fe17db74215f4786 Reviewed-on: https://chromium-review.googlesource.com/589820Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#490988}
-
gambard authored
When the QRCode scanner is shown, the current view is removed from the view hierarchy. As ContentSuggestions is using the topLayoutGuide as part of its constraints, the constraint was removed. So when the QRCode scanner is dismissed, the collection has no constraint for its top anchor. This CL fixes it by setting the constraint relative to its superview instead of the top layout guide. It also implements a delegate for the header controller. Bug: 750648 Change-Id: Iccee2279db686ce2e6f3060ed505defbdc038a0b Reviewed-on: https://chromium-review.googlesource.com/595652Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490987}
-
Charles Harrison authored
Bug: 750443 Change-Id: I51112bceff4ef11cca3ffdb781cef068ffb5f6fe Reviewed-on: https://chromium-review.googlesource.com/592907Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#490986}
-
Jan Krcal authored
The test is flaky on Win7 dbg buildbot. TBR=jkrcal@chromium.org, sammc@chromium.org Bug: 751081 Change-Id: Iaada8582830ebdade9f004bbf572ffed3cb3eed7 Reviewed-on: https://chromium-review.googlesource.com/595631Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#490985}
-
Rune Lillesveen authored
Style sharing code is removed and these stats will always be 0. Bug: 721517 Change-Id: Iae76778bd564ad22645d3d14709c1d8d13d796c6 Reviewed-on: https://chromium-review.googlesource.com/595744Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#490984}
-
Randall Raymond authored
This new class is used to find and validate the payment apps that can handle a a set of url payment method identifiers. In the short term, iOS will be working under the assumption that there is only one payment app that can handle a specified payment method. This however will change in the long run to match Android/Desktop implementations such that any number of payment apps can handle a payment method identifier as specified by payment method manifest. Most of the unittests and parsing are based off of the parsing code originally written here: https://cs.chromium.org/chromium/src/components/payments/content/utility/payment_manifest_parser.cc?rcl=6a53ba2305e2d0196d8f46f8590e0ad1fa45d636 This is another component of this CL that for the short term works fine but in the long term will need to be refactored to avoid code duplication. Bug: 748556 Change-Id: Ib0ce3be91830555cb9a3e1fc919d98b6ad9898f4 Reviewed-on: https://chromium-review.googlesource.com/582494Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Randall Raymond <rayraymond@google.com> Cr-Commit-Position: refs/heads/master@{#490983}
-
James Cook authored
The button is only shown when enabled by enterprise policy prefs, which are observed in chrome in SystemTrayDelegateChromeOS. For go/mustash this code cannot directly call into ash because it runs in a different process. Migrate the prefs observation into ash. Add unit tests for LogoutButtonTray. Remove some unused pref declarations and fix some USE_AURA vs. OS_CHROMEOS confusion. Bug: 747019 Test: ash_unittests Change-Id: Ifae5fedd163d0f3f9913369538856f13ba37c332 Reviewed-on: https://chromium-review.googlesource.com/590154Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#490982}
-
Dominik Röttsches authored
Preparation for updating font-style to behave as in CSS Fonts Level 4 [1]. [1] https://drafts.csswg.org/css-fonts-4/#font-style-prop Bug: 739139 Change-Id: Ia65d84b19d44e15dd8ac9faa194526246434b73d Reviewed-on: https://chromium-review.googlesource.com/579429Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#490981}
-
Oleg Maximenko authored
R=haraken@chromium.org, tkent@chromium.org object but pointer to regular field of PluginData. This caused failing check in HeapObjectHeader::CheckHeader() in debug. PluginListBuilder: :results_ of type Member<...> was assigned not heap Change-Id: Ia5beab6944ebdd0f8251fe86a9670387b7cac59e Reviewed-on: https://chromium-review.googlesource.com/579053Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#490980}
-
Peng Huang authored
In mus, the local surface id is allocated during resize an aura::Window. So we need resize the host_window() first before submitting a frame to it. Otherwise, exo may submit a frame with an invalid local surace id. Bug: None Change-Id: Ie756744073bd4bfb445ae3f596b11257aa85ae9f Reviewed-on: https://chromium-review.googlesource.com/594550Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#490979}
-
Andy Paicu authored
This patch adds functionality to parse the `report-to` csp directive It does not actually do any reporting It does not update the content layer csp version Spec: https://wicg.github.io/reporting/ Bug: 726634 Change-Id: I31546a56a18504684fc292ce76973ae6fab50fec Reviewed-on: https://chromium-review.googlesource.com/563210 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#490978}
-
gaschler authored
Correct traffic annotation that was copied from JsonRequest but not updated. Bug: n/a Change-Id: I9d48fe082467d635d7ec77b13eeadfc83ae27808 Reviewed-on: https://chromium-review.googlesource.com/593653 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#490977}
-
Jan Krcal authored
The tests cause a lot of flakes on Windows 7 dbg buildbot. TBR=horo@chromium.org, jkrcal@chromium.org, adithyas@chromium.org Bug: 443374 Change-Id: Id1145fcb274fc39b7672782ceb45224be0580daa Reviewed-on: https://chromium-review.googlesource.com/595688Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#490976}
-
Mike Case authored
Change-Id: Idf2fe1f593133c4ee2f105fb794afc6fa05bae0d Reviewed-on: https://chromium-review.googlesource.com/592549Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Michael Case <mikecase@chromium.org> Cr-Commit-Position: refs/heads/master@{#490975}
-
gambard authored
Long press on the omnibox should not trigger a context menu, regardless of a possible content below it. Bug: 750646 Change-Id: I762dbc144142775636d8fc4818bd225e12dc9c5e Reviewed-on: https://chromium-review.googlesource.com/595628Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490974}
-
Jan Krcal authored
This reverts commit 59784d15. Reason for revert: it breaks compilation (linking of v8_context_snapshot_generator), see https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/19741 Original change's description: > (Reland)[Bindings] Create and use V8 context snapshots. > > This CL does two things. > > 1. In compile time, creates a snapshot file, which consists of V8 contexts. > 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext(). > > We expect this speeds up context creation for 3 times faster on Android. > Detailed information is described in the design doc [1]. > > > [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30 > > > This CL is a re-land of https://codereview.chromium.org/2841443005 (and the 1st patch is same with it) > Test expectations are changed due to http://crbug.com/705364 > > BUG=588893, 617892, 705364 > TBR=rkc, jochen, dchen, kinuko, eroman, thakis > > Change-Id: If85e68a6498f7d35a0c59f4af9323ba72fc36d5f > Reviewed-on: https://chromium-review.googlesource.com/594608 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490955} TBR=rkc@chromium.org,dcheng@chromium.org,peria@chromium.org,kinuko@chromium.org,thakis@chromium.org,eroman@chromium.org,yukishiino@chromium.org,haraken@chromium.org,jochen@chromium.org Change-Id: I67f166ae37b2103100c066334586a3b49a3a21e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 588893, 617892, 705364 Reviewed-on: https://chromium-review.googlesource.com/596087Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#490973}
-
Takeshi Yoshino authored
- Remove an unused include - Access root_ directly than via Root() Bug: Change-Id: I2b9abe974dd7c3bcfc4921a1bd86833dc0b2efe4 Reviewed-on: https://chromium-review.googlesource.com/586212 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#490972}
-
Emilio Cobos Álvarez authored
Not doing it results in incorrect behavior when there are multiple adjacent text nodes, either script-generated ones or because of display: contents. BUG=746437,657748 Change-Id: If5aa9209d16d5532629a0f0e2f1730d18a193ebf Reviewed-on: https://chromium-review.googlesource.com/575982Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Emilio Cobos Álvarez <ecobos@igalia.com> Cr-Commit-Position: refs/heads/master@{#490971}
-
Julian Pastarmov authored
The value could change during startup when delivered through policy but the backend can not be switched on the fly. So make sure the first seen value is preserved. BUG=736408 Change-Id: Ie608e9735b6009df3cd7070338412bd5b83376f4 Reviewed-on: https://chromium-review.googlesource.com/586688Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#490970}
-
Koji Ishii authored
Change-Id: I8a26eda72944a0c4d043275ffcde814bb6630f4c Reviewed-on: https://chromium-review.googlesource.com/594757Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490969}
-
Andrew Grieve authored
Deletes google_play_services_library GN variable. This should reduce compile times a bit, but mostly is just a good idea in general. Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f Reviewed-on: https://chromium-review.googlesource.com/585450 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Michael Case <mikecase@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490968}
-
gaschler authored
Add FakeContextualSuggestionsFetcher, MockFetchContextualSuggestionsCallback and a unittest for ContextualSuggestionsSource suggestion fetching. Bug: 749988 Change-Id: I958744e74fa54204d5dd764da49fc2ca45d6b9b3 Reviewed-on: https://chromium-review.googlesource.com/593656 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#490967}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ab3909796cf2..de7c9620c374 $ git log ab3909796..de7c9620c --date=short --no-merges --format='%ad %ae %s' 2017-08-01 art-snake Prevent use of null pFileRead in CPDF_DataAvail. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ifbf8ecee9c19109874bb2d0758e547bd4195f9f2 Reviewed-on: https://chromium-review.googlesource.com/595867 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#490966}
-
Roman Sorokin authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/542963a5cdc8..3eac6aef29eb $ git log 542963a5c..3eac6aef2 --date=short --no-merges --format='%ad %ae %s' 2017-06-29 ljusten authpolicy: Add proto for Kerberos files Created with: roll-dep src/third_party/cros_system_api Bug: 737960 Change-Id: I84ac71002f0427e01e8a4f576dc8536237d1b330 Reviewed-on: https://chromium-review.googlesource.com/594050 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#490965}
-
Raphael Kubo da Costa authored
Using wpt-import in Chromium 208c0175. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dom-dev@chromium.org: external/wpt/html domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams TBR=qyearsley@chromium.org No-Export: true Change-Id: I946fd58c943f2535ecbb3229ac94ab8563e38fd9 Reviewed-on: https://chromium-review.googlesource.com/595648 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#490964}
-
Vitalii Iarko authored
Previously, the suggestions were sorted by score. However, pushed suggestions must stay on top independetly of their score. This CL stores suggestion order in the database by recording suggestion position as its rank and then sorting by rank. Score is used as a fallback. Bug: 750100 Change-Id: Ic799f9a2e72d79908435b48185f7c6d74fa2d297 Reviewed-on: https://chromium-review.googlesource.com/593318 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#490963}
-
Patti authored
Site Details shows a 'Usage' section, which describes the amount of storage used by a website. Only show this when #enable-site-settings is on, since it's not in scope for the first version of Site Details. Manual test - With #enable-site-details on and #enable-site-settings off, navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fpermission.site. It should not show the 'Usage' heading, nor the 'Permissions' heading. With both flags on, navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fpermission.site and verify 'Usage' and 'Permissions' headings are both there, most likely with 'No usage data' under 'Usage'. Then navigate to chrome://settings/content/siteDetails?site=https%3A%2F%2Fwww.google.com and again verify both headings are there, probably with a non-zero storage number under 'Usage'. Bug: 656758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2a5dd7de7fcd6f4c3270dce2bb51e22ab6e1cec0 Reviewed-on: https://chromium-review.googlesource.com/587516 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#490962}
-
Xida Chen authored
Right now in ScrollingCoordinator::SetTouchEventTargetRects, we always send TouchAction::kTouchActionNone when we pass the rect to cc. This CL change the kTouchActionNone to the real value associated with that rect. TBR=flackr@chromium.org Bug: 716668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I92c450fac165c59ba01ae1ef9f037c3001d56403 Reviewed-on: https://chromium-review.googlesource.com/581907 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#490961}
-
Xida Chen authored
In the current implementation of MailboxInfo, we keep a RefPtr to Canvas2DLayerBridge, and when the MailboxReleased function gets called, we do a self_ref to keep the Canvas2DLayerBridge alive. Now that the MailboxReleased function is called through a WTF::Bind to a WeakPtr of Canvas2DLayerBridge, we don't need the self_ref anymore. Also, we can remove the mailboxes_ that is kept in this class, we just need to remove the associated resources. Bug: None Change-Id: I7f087a23a7fca32272d0ad05efb66f92d9eabba8 Reviewed-on: https://chromium-review.googlesource.com/579690 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#490960}
-
Hajime Hoshi authored
The test is now timed out on the flakiness dashboard because idle tasks are never called on tests until testRunner.runIdleTasks explcitly (crbug.com/595152). This doesn't leak now. This CL also fixes a comment regarding crbug.com/726218. Bug: 595152, 662477 Change-Id: I757bd5e72063933b28d92dc69cb4a3e42e9e4c56 Reviewed-on: https://chromium-review.googlesource.com/595792Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#490959}
-
Rune Lillesveen authored
After style sharing code was removed, this mode is no longer in use. Bug: 721517 Change-Id: Ia0997792f5641b722d86922f40d631613552c137 Reviewed-on: https://chromium-review.googlesource.com/595728Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#490958}
-
Yutaka Hirano authored
Supporting <link rel="preload" as="fetch" crossorigin> was considered to be hard because we have two CORS handling logic. CORS for preload is checked in ResourceLoader and CORS for xhr is checked in DocumentThreadableLoader. Resource::CanReuse is a function that determines whether we can reuse a resource for a request, and it returns false in such a case. On the other hand, it should be safe to run the CORS check twice. If the CORS check for the existing resource is run in ResourceLoader, we can reuse it for an XHR request. This CL changes Resource::CanReuse in that sense. Bug: 702845 Change-Id: Ifa5580c4465ff683e65455256266cbeeecde3d92 Reviewed-on: https://chromium-review.googlesource.com/582063 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#490957}
-
gambard authored
When rotating the device, the omnibox width should be set to the new width. This width computation needs to take into account the y offset of the collection and its new size. So the calculation needs to be started from the collection. Bug: 750637 Change-Id: I14dc8f878b815f7f32bd33f88691e9b39782e0d4 Reviewed-on: https://chromium-review.googlesource.com/595741Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#490956}
-
Hitoshi Yoshida authored
This CL does two things. 1. In compile time, creates a snapshot file, which consists of V8 contexts. 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext(). We expect this speeds up context creation for 3 times faster on Android. Detailed information is described in the design doc [1]. [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30 This CL is a re-land of https://codereview.chromium.org/2841443005 (and the 1st patch is same with it) Test expectations are changed due to http://crbug.com/705364 BUG=588893, 617892, 705364 TBR=rkc, jochen, dchen, kinuko, eroman, thakis Change-Id: If85e68a6498f7d35a0c59f4af9323ba72fc36d5f Reviewed-on: https://chromium-review.googlesource.com/594608Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#490955}
-