GitLab

BUG=426561
TEST=None

Review URL: https://codereview.chromium.org/682183003

Cr-Commit-Position: refs/heads/master@{#301978}

Automatic deployment of the virtual keyboard. For now we hide this under the flag: auto-virtual-keyboard.

This patch makes the controller a input device observer, instead of a shell observer. It records the presence of internal keyboards, external keyboard, and touchscreens. When the flag is enabled, the keyboard will not be shown if there does not exist a touchscreen device. The keyboard will be shown if the user is in maximized mode, or does not have an internal keyboard present.

BUG=373402
TEST=VirtualKeyboardControllerAutoTest.DisabledIfInternalKeyboardPresent, VirtualKeyboardControllerAutoTest.DisabledIfNoTouchScreen

Review URL: https://codereview.chromium.org/613343005

Cr-Commit-Position: refs/heads/master@{#301977}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/686533002

Cr-Commit-Position: refs/heads/master@{#301976}

In ExistingUserController::PerformLogin(), There was a missing call to
ExistingUserController::PerformLoginFinishedActions(), which should
re-enables clicking on the status tray after it has been disabled in
ExistingUserController::PerformPreLoginActions().

BUG=427047
TEST=manual

Review URL: https://codereview.chromium.org/682103002

Cr-Commit-Position: refs/heads/master@{#301975}

The PageNotificationDelegate will proxy events from the Notification sub-
system to the Web Notification object in Blink for notification whose
lifetime is tied to that of the page.

This patch also moves the NotificationMessageFilter to a new directory
in //content/browser/, as there will be new files when Service Worker
integration is being added in the near future.

BUG=392187

Review URL: https://codereview.chromium.org/681783004

Cr-Commit-Position: refs/heads/master@{#301974}

BUG=427633

Review URL: https://codereview.chromium.org/685303002

Cr-Commit-Position: refs/heads/master@{#301973}

I missed this in https://codereview.chromium.org/685933002/ but it
should also be unnecessary.

R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/690843002

Cr-Commit-Position: refs/heads/master@{#301972}

Whoops, forgot to add this before submitting the last patch.

BUG=410451
TEST=none

Review URL: https://codereview.chromium.org/645373005

Cr-Commit-Position: refs/heads/master@{#301971}

Cr-Commit-Position: refs/heads/master@{#301970}

Chrome depends on SkMultiPictureDraw depends on SkTaskGroup depends on SkCondVar.

BUG=

Review URL: https://codereview.chromium.org/684303002

Cr-Commit-Position: refs/heads/master@{#301969}

This reverts commit 3457f738.

Breaks FileUtilTest.WriteFileWithMode on Android.

BUG=409416,362887

Review URL: https://codereview.chromium.org/687163005

Cr-Commit-Position: refs/heads/master@{#301968}

This is a reland of https://codereview.chromium.org/677113002/ with the
necessary fixes to address the issues in events_unittests.

This CL renames KeyEventConverterEvdev to EventConverterEvdevImpl, adding mouse
support there. It adds converter for mouse events that handles move and button
events. This is useful for simple mouse testing and also systems that don't
want the complexity of gestures library.

I don't have a multipurpose input device just like described in
crbug.com/412996, but I believe this benefits the needed changes towards that
goal as well.

BUG=412996
TEST=Run chrome target on DRI platform on non-CrOS. Also:
     ./events_unittests  --gtest_filter=EventConverterEvdevImplTest.* --single-process-tests

Review URL: https://codereview.chromium.org/692613002

Cr-Commit-Position: refs/heads/master@{#301967}

This makes the synchronous composite path support impl-side painting.
This initial version is intended for converting layout tests, as a real
version for the browser would commit to the active tree directly.

This path is currently not used anywhere (it DCHECKed) and the only
consumer after this patch is a unittest to verify that it works.

Depends on https://codereview.chromium.org/672673003/ so that
WaitForTasksRunningToComplete includes all visible tiles.

Depends on https://codereview.chromium.org/668123003/ for correctness,
as zero copy and masks aren't supported quite yet.

R=danakj@chromium.org,reveman@chromium.org,vmpstr@chromium.org
BUG=381919

Review URL: https://codereview.chromium.org/667793004

Cr-Commit-Position: refs/heads/master@{#301966}

BUG=383125

Review URL: https://codereview.chromium.org/629393002

Cr-Commit-Position: refs/heads/master@{#301965}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=noelutz@google.com

Review URL: https://codereview.chromium.org/685553002

Cr-Commit-Position: refs/heads/master@{#301964}

TBR=yurys
BUG=

Review URL: https://codereview.chromium.org/680273005

Cr-Commit-Position: refs/heads/master@{#301963}

Dragging a browser action off the toolbar results in the button staying in
"pressed" state. Fix it so that it returns to normal state.

BUG=428287

Review URL: https://codereview.chromium.org/690653003

Cr-Commit-Position: refs/heads/master@{#301962}

See: https://codereview.chromium.org/685043002/
R=dcheng@chromium.org,andresantoso@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/687293003

Cr-Commit-Position: refs/heads/master@{#301961}

When updating Chrome, pNacl doesn't refresh the cached whispernet pNacl module
leading to a stale version of the whispernet module being used with the the
whispernet proxy extension. Adding a query parameter and reving it every time
we check in a new version of the module will ensure that pNacl will consider
the module a "new" file and will recreate its cache with it.

The current version of the library corresponds to CL number 77701403.

R=ckehoe@chromium.org
BUG=428424

Review URL: https://codereview.chromium.org/684293002

Cr-Commit-Position: refs/heads/master@{#301960}

- this is part of the implementation of scoring mechanism for next/prev page
  links; details are in http://codereview.chromium.org/661883003.

- add options to standalone content extractor to specify original domain if page
  being processed is a file://
  1) --original-domain pairs with --url
  2) --original-domains pairs with --urls, delimited by ';', 1st domain is for
     1st url, etc.  eval tool will invoke content extractor with this option.

- for --original-domains, different URLs require different DomDistillerOptions
  to be passed to GWT distiller as individual --original-domain:
  1) rename DistillerFactory::CreateDistiller() to CreateDistillerForUrl(GURL)
  2) impl new DistillerFactory class for content extractor to create different
     options for different url's, i.e. a specific original domain for each url.

BUG=425952

Review URL: https://codereview.chromium.org/687183003

Cr-Commit-Position: refs/heads/master@{#301959}

On Chrome OS, the original infobar is still shown.

Use the histogram "SessionCrashed.Bubble" bucket value to verify that the session crash bubble is shown under non-official build.
Under Google Chrome build, this is not tested because
1) a task is posted to the file thread before the bubble is shown
2) it is difficult to make sure that the histogram check runs after all threads have finished their tasks.

BUG=364670

Review URL: https://codereview.chromium.org/691543002

Cr-Commit-Position: refs/heads/master@{#301958}

This workaround should no longer be necessary, and looks like the first tab is created elsewhere.

BUG=374462
TEST=run_tests

Review URL: https://codereview.chromium.org/687143004

Cr-Commit-Position: refs/heads/master@{#301957}

MSVC doensn't like zero-size arrays. Also, the analog of USE_NSS is
USE_OPENSSL_CERTS, not USE_OPENSSL; CertificateViewerUI shouldn't be
built on Windows as we use the system one.

BUG=338884

Review URL: https://codereview.chromium.org/684243002

Cr-Commit-Position: refs/heads/master@{#301956}

Removes the raw AudioRenderer in favor of a RendererImpl which
deduplicates a lot of code.

Notes:
- Time updates are scheduled from StartPlayingFrom() until ended or flush.
- Liveness detection will be moved elsewhere in the chain as part of resolving
http://crbug.com/420025

BUG=410451
TEST=mojo_shell

Review URL: https://codereview.chromium.org/680533004

Cr-Commit-Position: refs/heads/master@{#301955}

is_linux contains chromeos, but chromeos already excludes
_default and _linux files above. This condition seems to
address the desktop linux instead.

BUG=428420
TEST=manually
R=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/686773004

Cr-Commit-Position: refs/heads/master@{#301954}

No behavior change.

BUG=427584

Review URL: https://codereview.chromium.org/685203002

Cr-Commit-Position: refs/heads/master@{#301953}

Channel information is now available statically at build time. There's
no need to call ChromeVersionInfo.init() anymore.

Review URL: https://codereview.chromium.org/668343004

Cr-Commit-Position: refs/heads/master@{#301952}

chrome.browser.openTab allows us to bypass security checks to open
chrome://settings from the app. chrome.tabs is only allowed for extensions, not apps.

BUG=398656
NOTRY=true

Review URL: https://codereview.chromium.org/689723005

Cr-Commit-Position: refs/heads/master@{#301951}

Switching profiler instrumentations from ScopedProfile to ScopedTracker. This will disable the instrumentations in all channels except Canary, and developer build. Instrumentations are only enabled in Browser process.

This will prevent Stable from sending increased amounts of UMA logs. Also, this will let us observe "true" (untouched by instrumentations) jankiness numbers every week in Dev channel.

BUG=401560

Review URL: https://codereview.chromium.org/686963002

Cr-Commit-Position: refs/heads/master@{#301950}

This cleans up the remaining network properties code and sets
up the JS to use getManagedProperties().

It also breaks up 'networkCommand' into separate methods and documents which C++ methods called from JS need to be replaced with networkingPrivate calls or eliminated.

BUG=279351

Review URL: https://codereview.chromium.org/673313003

Cr-Commit-Position: refs/heads/master@{#301949}

BUG=427584

Review URL: https://codereview.chromium.org/684273002

Cr-Commit-Position: refs/heads/master@{#301948}

When drawing video frame on SkCanvas, chromium reuse the same cached SkBitmap
on both software SkCanvas and accelerated SkCanvas. After SkBitmap is used on
both SkCanvas, SkBitmap includes both GrTexture and system memory buffer. It's
weird and looks error-prone. Fortunately, it works well.

In detail, SkCanvasVideoRenderer::Paint(VideoFrame* frame, SkCanvas* canvas, ..)
draws |frame| on |canvas|. Paint() makes SkBitmap by |frame| via YUV
conversion or texture uploading and then caches SkBitmap as |last_frame_|.
Paint() can be used by both software SkCanvas and accelerated SkCanvas, and
|last_frame_| is used by both.
|last_frame_| is based on SkImageGenerator, so it's not defined to software
SkBitmap or accelerated SkBitmap at the creation time. When |last_frame_| is
drawn on software canvas, system memory cache is allocated and kept by
|last_frame_|. When |last_frame_| is drawn on accelerated canvas, GrTexture is
allocated and kept by |last_frame_|.

Although it works now, it's not-documented and unexpected behavior of SkBitmap
and SkImageGenerator. It looks like relying on skia implementation detail. This
issue makes SkCanvasVideoRenderer manage software SkBitmap and accelerated
SkBitmap explicitly.

This CL makes software SkBitmap without SkImageGenerator, which is same to the
code before crrev.com/531353002. It's because SkImageGenerator is introduced
to accelerate YUV to RGB conversion on accelerated SkCanvas, not software SkCanvas.

In addition, this CL speeds up performance when both software and accelerated SkCanvas
call Paint() interleavingly. Previously, |last_frame_| uploads YUV texture and converses
to RGB texture every time on accelerated SkCanvas, because software SkCanvas clears
the texture cache.

TEST=https://codereview.chromium.org/656683007/
BUG=424591, 91208

Review URL: https://codereview.chromium.org/662033002

Cr-Commit-Position: refs/heads/master@{#301947}

There's something weird about this test or one of the other
test cases in the benchmark_smoke_unittest test suite that is
causing this test to hang when it is not run first.

I'm disabling this test for now so we can move on with the typ
cutover and get parallel test execution on the other platforms.

R=tonyg@chromium.org, ykyyip@chromium.org, dtu@chromium.org
BUG=428207

Review URL: https://codereview.chromium.org/683393002

Cr-Commit-Position: refs/heads/master@{#301946}

TBR=tonyg@chromium.org

BUG=428098

Review URL: https://codereview.chromium.org/688113003

Cr-Commit-Position: refs/heads/master@{#301945}

Comments suggest this was Vista-only, I believe the small inset of
separator shown e.g. in
http://www.tomshw.it/guides/ictbusiness/business/20070102/images/vista_diary_1st_entry_classic_mode_with_start_menu_large.jpg .

This never appears to be set to true any more, I guess since the Aura-
style menus. (We're also looking to homogenize Vista & XP to be
as close as possible.)

R=sky@chromium.org
BUG=426573

Review URL: https://codereview.chromium.org/688073003

Cr-Commit-Position: refs/heads/master@{#301944}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/684283002

Cr-Commit-Position: refs/heads/master@{#301943}

We require this because of the underlying GCM implementation. The sender Id
can be provided through a manifest (which the browser tests uses already). Make
sure that the registration request is rejected with a descriptive error if
none has been provided.

BUG=428277

Review URL: https://codereview.chromium.org/686133003

Cr-Commit-Position: refs/heads/master@{#301942}

Yngve Pettersen reports better compatibility with this value at the end of the list and OpenSSL had a bug around process it when it was first.

(I pondered moving the reneg SCSV to the end also but that code is from upstream and reneg SCSV is only sent for SSLv3, which is not a going concern any longer.)

BUG=none

Review URL: https://codereview.chromium.org/678413002

Cr-Commit-Position: refs/heads/master@{#301941}

Currently Chrome has two fullscreen overlays. There is a
hidden optimization where Android detects transparent areas
on top of SurfaceViews and removes them from SurfaceFlinger
compositing. In order to get the most from this
optimization, we need to set all views in the viewport to
be either:
a.) Not visible (+layout to trigger it)
b.) setWillNotDraw(true) with no visible back/foreground.

ContentViews in general don't draw, so we remove
setWillNotDraw(false). For WebView we do need this now
though, so move setWillNotDraw(false) into AwContents.

BUG=342541

Review URL: https://codereview.chromium.org/675313002

Cr-Commit-Position: refs/heads/master@{#301940}

This is to solve the problem that the app could be uninstalled and
then reinstalled immediately. We do not want the app to encounter
ASYNC_OPERATION_PENDING error. We now wait till the unregistration
completes and then triggers the pending registration.

BUG=371880
TEST=new test added

Review URL: https://codereview.chromium.org/683913005

Cr-Commit-Position: refs/heads/master@{#301939}