- 30 Mar, 2020 40 commits
-
-
Nico Weber authored
This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes in cases where the call to EARL_GREY_TEST_DISABLED is unconditional. earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED, says: This macro should be used when the configuration for which the test should be disabled can only be determined at runtime. Disabling at compile-time is always preferred. So this matches the official guidance, and there are many egtests that use DISABLED_ already. Bug: 346399 Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#754468}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be1957b9b903..8df96b104065 Created with: gclient setdep -r src-internal@8df96b104065 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9e3a044413d9a5c973629489ff2940bbfb361426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754467}
-
Samuel Huang authored
To accommodate .aab files and TriChrome, we'd like SuperSize to handle multiple "containers" and store data in a single .size file. This CL performs refactoring archive.py to prepare for extending SuperSize for multiple containers. Details: * Move temp-file extraction logic with |args.minimal_apks_file| depper, into _DeduceMainPaths(). * Remove |args.extracted_minimal_apk_path|. * CreateSizeInfo(): * Change params to take lists of {metadata, section_sizes, raw_symbols}. * Implementation TODO; keep old behavior by simply using the first element of the above. * _DeduceMainPaths(): * Change to a generator that yield multiple param sets, one for each container. * Resolve |apk_prefix| and |apk_path| as separate concepts. * Move most of the logic to _Inner() function. * Split out _DeduceAuxPaths(). * Run(): * Merge with _RunInternal(). * Main action changes: * Visits param sets generated from _DeduceMainPaths(). * Potentially create multiple {metadata, section_sizes, raw_symbols}, now stored into |*_list| variables. Bug: 900259, 1040645 Change-Id: Ib158f3d5c8b11567f09826fd0c0b31729f4e065c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125388Reviewed-by:Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#754466}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/47e3be4efd27..50a47bd99229 git log 47e3be4efd27..50a47bd99229 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 55f01953d6e9..9a0f2d99fd5d (4 commits) 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 02e15b249b12..1c29477aa06e (19 commits) 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src cc481ef27631..b0c27ce32864 (2 commits) Created with: gclient setdep -r src/third_party/angle@50a47bd99229 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7030f1176bc428a313c07aaababa6310f381b883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754465}
-
Peng Huang authored
Tested with swiftshader on Windows 10. Bug: 1065499,963988 Change-Id: Ibce9fbca12332aec8fbc98ed838dfcc9d457ac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125302Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754464}
-
Viktor Semeniuk authored
This change adds Show/Hide password functionality to the compromised credentials list menu. Bug: 1061054 Change-Id: I4823aa4edf6f9690f2e17d977123d82b75c245d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116178 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#754463}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/81431f5034b4..29d712f9de99 git log 81431f5034b4..29d712f9de99 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 natlee@microsoft.com D3D12 Immediately release pending commands Created with: gclient setdep -r src/third_party/dawn@29d712f9de99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iee0a2812545c1d55bcced7d116670107d7750d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126733Reviewed-by:
-
Robert Sesek authored
This is a reland of 0bd64fcf Original change's description: > Move custom tabs off notSecureIsIntentChromeOrFirstParty() > > Instead, use the CCT session token to determine the connected client > package and verify using that instead. > > Bug: 832124 > Change-Id: I96f9c6831f7dcbf801e3ee48d59904a4788d97b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1324910 > Reviewed-by: Peter Conn <peconn@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754033} Tbr: peconn@chromium.org Bug: 832124 Change-Id: I6c9c765e9b055dc660fe2ac653e0e86530359e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127246 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#754461}
-
Fan Yang authored
R=bnc@chromium.org Change-Id: I545916f7602955dae6b9200ee0c3a7f37f76b518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125070Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754460}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5a40bf3491e..0ccd8de267fe git log e5a40bf3491e..0ccd8de267fe --date=short --first-parent --format='%ad %ae %s' 2020-03-30 tvanderlippe@chromium.org Fix logging of page errors in e2e-test Created with: gclient setdep -r src/third_party/devtools-frontend/src@0ccd8de267fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87f9f14dc2f6feec00e80e593e38edbbd61a3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126732Reviewed-by:
-
Tim Schumann authored
On ChromeOS and Linux non-dbg builders. BUG:1065399 TBR=rdevlin.cronin@chromium.org Change-Id: I8537c16f154489e1137da612251edf3e9193a802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124316 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#754458}
-
Anders Hartvoll Ruud authored
There is currently a bug where font-relative units in the base style are not responsive to font-affecting animations (even with issue 437689 fixed) _if_ the element hits the MatchedPropertiesCache. This can easily happen if two identical elements (with the same MatchResult) undergo the same CSS animation. The reason this bug exists is in StyleResolver:: CascadeAndApplyMatchedProperties. Notice that, when cache_success.IsFullCacheHit() is true in that function, we return immediately, and never Analyze the MatchResult. In other words, the MatchResult is _there_, fully populated (we're using it as the cache key after all), but we never let the StyleCascade actually Analyze it, which is the source of the bug. When we later apply animations (see StyleResolver::ApplyAnimatedStandardProperties), we Analyze the animations/transitions _only_. This was done on purpose, as too much Analyzing is expensive. Hence, during ApplyAnimatedStandardProperties, I assumed that either: - We would hit the base computed style optimization, and hence the MatchResult would be empty, and there is no need to analyze it, or - We would not hit the base computed style optimization, and the MatchResult object would be populated and Analyzed already. But of course, I forgot about the third option: based computed style optimization miss, but a hit on the matched properties cache. In that case the we have a non-empty MatchResult that haven't been Analyzed. To fix this, we could have simply Analyzed the MatchResult in ApplyAnimatedStandardProperties (potentially a second time). But this is inefficient. I don't want to do that. Instead, this CL moves the MatchResult ownership (and CascadeInterpolation ownership) to StyleCascade itself. It also adds flags which tells us what needs to be analyzed. Using this, we can now analyze-on-demand during Apply, which means we analyze exactly the amount we need to analyze, also in the case where an animation frame hits the MatchedProperties cache. It also makes for a far more sensible (but still not perfect) StyleCascade API, compared to "manually" analyzing. Note that this CL also removes filtering Analyze-time. This means that e.g. for ::marker, we add declarations to the CascadeMap that we know aren't going to be applied (as they are filtered in the Apply step). This is because analyze-on-demand is not easily compatible with this kind of filtering. For example, when dealing with inherited-only cache hits, we first try to apply the inherited properties only. If the font or zoom was modified, we need to apply the non-inherited properties after all. And for that second apply pass, we obviously need all properties to have been analyzed before, not just the inherited properties. Bug: 1065387, 437689 Change-Id: I7e9b7f33fc12f055603e789d3ae700d5a7a3dbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124649Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#754457}
-
Roman Sorokin authored
Moved DemoSetup* and EnableDebugging* tests to OobeBaseTest Bug: 987587 Change-Id: I1b0860861720d1cbd77be9e2c007c74a7e2f8801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124608Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754456}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a7a5ec8. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 6719ca2d "[AspectRatio] Add parsing support for aspect-ratio: X / Y" 9e853511 "Remove broken icon rendering for loading="lazy" images while loading" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I961486f981badaf81b16b758cdfd0e103b0eeba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125666Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754455}
-
Raul Tambre authored
std::auto_ptr is deprecated since C++11 and removed in C++17. Fortunately the strange behaviour of std::auto_ptr isn't used here and we can simply replace it with std::unique_ptr. ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(502,8): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> buffer(new wchar_t[length]); ~~~~~^ ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(543,8): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> sanitized_url(new wchar_t[url.length() * 3 + 1]); ~~~~~^ ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(616,8): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> browser_path(new wchar_t[length]); ~~~~~^ ../../chrome/browser/browser_switcher/bho/browser_switcher_core.cc(635,10): error: no member named 'auto_ptr' in namespace 'std' std::auto_ptr<wchar_t> expanded_path(new wchar_t[expanded_size + 2]); ~~~~~^ Bug: 752720 Change-Id: I040bd8412aebebeadfd70008930fbe457f9b8b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124568 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#754454}
-
Finnur Thorarinsson authored
By default, the test will wait for 3 seconds to create the decoder process, which (at least in the emulators) brushes up against the actual time it takes to create the process, so these tests are frequently flaky when run locally. Bug: 656015 Change-Id: Ib8a4ea139d0c79eb41595811c000b6cf54574bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124377 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#754453}
-
Michael Ershov authored
TBR=tiborg@chromium.org,ajgo@chromium.org Bug: 1065812 Change-Id: Ia597186e7488eaf18913ebc1fcdeb8937e13df62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124838Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#754452}
-
Raul Tambre authored
A missing noexcept specifier is an error when compiling in C++17 mode. STDMETHOD adds one, but we're missing it in the implementation. ../../chrome/browser/browser_switcher/bho/bho.cc(41,35): error: 'SetSite' is missing exception specification '__attribute__((nothrow))' [-Werror,-Wmicrosoft-exception-spec] STDMETHODIMP CBrowserSwitcherBHO::SetSite(IUnknown* site) { ^ ../..\chrome/browser/browser_switcher/bho/bho.h(53,13): note: previous declaration is here STDMETHOD(SetSite)(IUnknown* site); ^ Bug: 752720 Change-Id: I1cfe0c27a9caeb6b450c752a721a7532d872567a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124709 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: -
Mikhail Khokhlov authored
Stop triggering mac and win builders on every commit. Change test type from 'script' to 'gtest_test'. Bug: 1050517 Change-Id: Id7905d9787e0a78fb407f7ecfdeb0409cc2f8310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124456 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#754450}
-
Timothy Loh authored
Currently the Plugin VM installer will have the progress bar go from 0 to 100 three times, for the three main stages. This CL updates it so that it has a single progression, which is less confusing for the user. The percentage allocated to each step is an estimate based on an installation I performed. We also remove the time left message (which similarly goes to 0 three times), but retain the download progress message. Bug: 1041311 Change-Id: Ifeab1a7c501407574499b9c90b7fadecbd370d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125909 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#754449}
-
Christos Froussios authored
Bug: 1063918 Change-Id: Ida94f8108d820ce99713ea59fada582d031bc4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120712Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#754448}
-
Richard Knoll authored
This will show images in native macOS notifications and display relevant text in the progress notification. The final image notification now properly closes the progress one. Bug: 1059290 Change-Id: I4e2793db60b0f5b2465d2349df1aca12a06e5c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125047Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754447}
-
Alex Ilin authored
This CL adds two more tests for the email confirmation dialog, checking "This was me" and "cancel" dialog options. Bug: 1008893 Change-Id: I4c4207c40a142badce586921b0070aa03775993a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126669Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754446}
-
Mark Cogan authored
Updates the MetricsMediator API to accept a list of active scenes instead of a single interface provider. The updated method will report the total number of open tabs across all scenes, and will search all scenes for the active scene to determine if the first action recorder should be set. Change-Id: I58865d1ecaee79d7baa2f8ebf2bf4d63fe0e7f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124450 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754445}
-
Guido Urdaneta authored
This data was intended to be added in a more structured manner as part of a proper metadata structure to replace the additionalData field. However, the final version of the structure has not been decided, so this CL exposes these fields so that they are available in M83. All this is behind an experimental flag/origin trial. Bug: 1052765 Add ssrc Change-Id: I114171a221b20f2312f043cee84722783c8dbcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124448Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#754444}
-
henrika authored
Allows us to: - Track when remote WebRTC media streams are being rendered - Adds volume state of the audio element (including mute state) - Measures audio level of the rendered stream - Adds an "alive" check - etc. Example of new log output: https://paste.googleplex.com/6323608609619968 Added tags: WMPMS, MSRFI, WRAR Bug: 1017219 Change-Id: Ifba1367ce29f2f59e801d688fd26b8a0d6cb361e No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093443 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#754443}
-
Gauthier Ambard authored
This CL modifies the place where the customUserAgent is updated, changing it from the request to -decidePolicyForNavigationAction:. This prevents issues where the page is loaded but not from a request (for example after a back/forward navigation). Fixed: 1059235 Change-Id: I83205c80a49e51ebfa194d12bae016bf48b52b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107555 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#754442}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cef0a5f63a68..be1957b9b903 Created with: gclient setdep -r src-internal@be1957b9b903 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1065799 Tbr: jbudorick@google.com Change-Id: I993e1704684ad8b2e87e3421392534fdf1a9defa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126729Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b2dd6f92a6b..47e3be4efd27 git log 1b2dd6f92a6b..47e3be4efd27 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 99508c1ce389..344bd0889ac9 (4 commits) Created with: gclient setdep -r src/third_party/angle@47e3be4efd27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I92b59b87b7acd1ce7b4b74ecda2beb0d6e7270c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126484Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca9a03f92fbd..e5a40bf3491e git log ca9a03f92fbd..e5a40bf3491e --date=short --first-parent --format='%ad %ae %s' 2020-03-30 jacktfranklin@chromium.org Add basic unit tests to CookieParser Created with: gclient setdep -r src/third_party/devtools-frontend/src@e5a40bf3491e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia708fb6010ef2451195063b87eaabdf70a2aff60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126727Reviewed-by:
-
Michael Ershov authored
TBR=wychen@chromium.org,katie@chromium.org Bug: 1065825 Change-Id: I19858cf52988230c5807883dc29fbd38b754f677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126668Reviewed-by:
-
Roman Aleksandrov authored
BUG=1065732 Change-Id: I585bb20a2fe7b546043fe4b032dfb1cbcbe91bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126228 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754437}
-
Adam Rice authored
The method blink::IncomingStream::ReadFromPipeAndEnqueue() can be called re-entrantly when 1. A read() is pending 2. OnHandleReady() calls ReadFromPipeAndEnqueue() 3. Enqueue() results in a call to pull() (to re-fill the queue) 4. pull() calls ReadFromPipeAndEnqueue() Since there cannot be two calls to BeginReadData() in progress, this causes a fatal error. Add a flag |in_two_phase_read_| which causes ReadFromPipeAndEnqueue() to return early. Add another flag |read_pending_| which indicates that ReadFromPipeAndEnqueue() has returned early and that it should be called again when the current read completes. Also add a unit test for this condition. BUG=1064434 Change-Id: I7b367e466a0c5c2e1abccc0a688d2098e17143f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124331 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#754436}
-
Mugdha Lakhani authored
PageInfo and PageInfoUI have already been refactored into parts that can be shared among embedders, and chrome-specific parts. This CL simply moves the former to components. In addition, this moves some vector icons to components,and creates a a new build target in components/resources to house all resources for components resources that are mapped to an Android resource. Permissions code is updated to depend on this new target. Bug: 1052375 Change-Id: Icd80244bf64b52794412b6ece47fe2d52937b3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091496Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Side Yilmaz authored
DataReductionMainMenuItem. Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates DataReductionMainMenuItem class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Ibb4e881346548c89158f810e35f7f5a6575e6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112359Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#754434}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates OfflinePageUtils class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Ia9651a04eee766f344a2d335ef4b24dc3851159b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122058Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#754433}
-
Anders Hartvoll Ruud authored
We are approaching our current 16-bit limit for flags, and last time I exceeded this limit locally (and hence redefined CSSProperty::Flags to uint32_t), it took a while to understand why things didn't work. The reason was that the Longhand/Shorthand constructors truncated the integer to uint16_t. No new flags are planned at the moment, but I still want to eliminate this trap for when we _do_ add a new flag. Change-Id: I4527b7ed16b9f289135a3a37665cbcf319d8bb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124252Reviewed-by:
-
Tim van der Lippe authored
This updates the version of clang-format to a more recent version, as the previous version was almost 3 years old. R=hans@chromium.org CC=thakis@chromium.org Fixed: 993206 Change-Id: I2b8944197948c91287d5f49f515137445a0e7ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124653Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#754431}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d1dae2a33653..e7603d3ab878 git log d1dae2a33653..e7603d3ab878 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 eseckler@google.com chromium: Fix reference to license file. Created with: gclient setdep -r src/third_party/perfetto@e7603d3ab878 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065336 Tbr: perfetto-bugs@google.com Change-Id: Ide77fb2be9e161c914be47bb6f7c1547b6f9f52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126486Reviewed-by:
-
arthursonzogni authored
V8 provides two primitives for Chrome to block/allow 'eval': 1) AllowCodeGenerationFromStrings(bool) 2) SetModifyCodeGenerationFromStringsCallback(callback). Different parts of the Chrome codebase independently call either of those, effectively stepping on each others toes. This patch makes the |callback| to be called independently from the execution context's CSP. There is only one location where CSP are checked for eval: CodeGenerationCheckCallbackInMainThread (and only one) AllowCodeGenerationFromStrings is kept for disabling temporarily eval checks for: - Inspector's injected scripts. - Extensions's injected scripts. Bug: 1024786 Change-Id: I668107242e6c2923951b91d0a35f1befbaf35827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007451Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#754429}
-
