- 08 Mar, 2018 40 commits
-
-
Max Morin authored
Bug is identical to the last :/. No idea why it's much more frequent with mojo, possibly a race is likely to happen when destroying a frame: |callback_| is destroyed due to frame being destroyed, and authorization is failed for the same reason. With the per process message filter, authorization wouldn't fail due to the frame being destructed. Bug: 819277 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic17dc96d2c83a08732b43094bac2f2c3fa7035ad Reviewed-on: https://chromium-review.googlesource.com/951774 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541801}
-
Finnur Thorarinsson authored
This adds support for encoding the launch id for the context menu item, in a similar way as for the button index (context menu click is treated by the Action Center as a button click). This also removes the check for native notifications being enabled while processing the command line at startup. Main reason for that is that the notification activator does not enable native notifications when it passes the command line to Chrome, but native notifications are already implied anyway (otherwise the notification activator wouldn't be used). So, we can remove the check. Bug: 734095 Change-Id: I629dabaab290fba9043114bf2403daba2b8b7f0c Reviewed-on: https://chromium-review.googlesource.com/952446 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#541800}
-
Theresa authored
This test appears to be causing NewTabPageTest#testRender to flake. Spectulatively disabling. BUG=813589 Change-Id: I0bdd566c14d1e6d3521e00e097e55a9f079e76a1 Reviewed-on: https://chromium-review.googlesource.com/954333Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#541799}
-
Moe Ahmadi authored
This CL changes the autofill_agent in iOS so that it expects a vector of This makes it easier to fiddle the displayed type prediction (e.g., from overal to server) and makes the interface more similar to that of Desktop. autofill: :FormDataPredictions instead of a vector FormStructure pointers. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I79d45ae585d98621b03d2753829405ee47bae8d3 Reviewed-on: https://chromium-review.googlesource.com/953206Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541798}
-
Jennifer Apacible authored
This OWNERS file was added temporarily to fix a broken OWNERS chain. Remove now that we no longer need it. Part two of a two part fix for c/b/ui/views/overlay/OWNERS. BUG: 819870 Change-Id: I5f3c280c2a97e504b96f7dbad7331ae930324fed Reviewed-on: https://chromium-review.googlesource.com/954341Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#541797}
-
Peter K. Lee authored
Bug: 813821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I82a9c0cc52f783964841ecf3ae656769620b852e Reviewed-on: https://chromium-review.googlesource.com/954544Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541796}
-
Gauthier Ambard authored
This CL adds an Earl Grey test to check the interactions between the infobars and the bottom adaptive toolbar. Bug: 804747 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ife30026fd1390d4b86896aca2f7f0f33407926cc Reviewed-on: https://chromium-review.googlesource.com/955023 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Eric Willigers authored
We use count - CSS.paintWorklet - PaintWorkletGlobalScope.devicePixelRatio - PaintWorkletGlobalScope.registerPaint BUG=578252 Change-Id: I188c980816c3c1f205de0209dd2226e39a7e7475 Reviewed-on: https://chromium-review.googlesource.com/892941 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#541794}
-
Mihai Sardarescu authored
This CL shows the sync confirmation dialog before sync actually starts if the user is enabling sync for a non enterpriser account. This is acceptable as the sync cannot be disable by administrator for such accounts. Bug: 814113 Change-Id: I49dff5c3a4ed10689c022162edd6b84162b3382c Reviewed-on: https://chromium-review.googlesource.com/951587Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#541793}
-
Yuqian Li authored
Bug: chromium:817110 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If267c55bba4880319dbd171b21663928ebc24d20 Reviewed-on: https://chromium-review.googlesource.com/952708 Commit-Queue: Yuqian Li <liyuqian@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#541792}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16d3f07a..dc2d3bb9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I8045167d204fe57d60e46ae79102061392dbad09 Reviewed-on: https://chromium-review.googlesource.com/955402Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#541791}
-
Jennifer Apacible authored
This OWNERS was missed when moving c/b/ui/overlay to c/b/overlay. With the previous change (see crbug), c/b/ui/views/overlay/OWNERS now points to an OWNERS file that no longer exists. Rather than reverting the previous patch, this will be less disruptive while fixing the OWNERS chain. Part one of a two part fix for c/b/ui/views/overlay/OWNERS. BUG: 819870 Change-Id: I0fb9baf6a65a9e0afbfb2e2e26cfca745b5d984a Reviewed-on: https://chromium-review.googlesource.com/954325Reviewed-by:
-
clamy authored
Moves some tests away from the untriaged ones now that they have a bug assigned to them. TBR=jam@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5351246477fe0ed35c5c87b1e937bc27006d354d Reviewed-on: https://chromium-review.googlesource.com/955583 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541789}
-
Adam Goode authored
Subpixel positioning is not (yet) enabled for all situations in Chrome. Currently, the choice of enabling this for the UI is made on a platform specific basis in ui/gfx/font_render_params_*.cc. Separately, the choice for enabling this for blink is made in third_party/WebKit/Source/platform/fonts/WebFontRenderStyle.cpp, third_party/WebKit/Source/platform/fonts/FontPlatformData.cpp, and third_party/WebKit/Source/platform/fonts/*/FontPlatformData*. Typically the choice comes down to user and system preferences and the device scale factor. For example, some hinting algorithms hint glyphs in the horizontal direction, fitting precisely to the grid. Subpixel positioning should be disabled in this case. Newer hinting algorithms hint only vertically, so glyphs should be subpixel positioned. (See https://www.freetype.org/freetype2/docs/glyphs/glyphs-5.html#section-2) When subpixel positioning is disabled, we need to round an entire run of text at a time. Otherwise, spacing between some letters becomes position dependent. Offset and extent rounding is currently done with the use of hb_font_set_funcs, but positions affected by kerning cannot be rounded unless the font uses a legacy 'kern' table instead of 'gpos'. Bug: 740385 Change-Id: Ie34134c33b52889b8d7bfcec05fc7d24e0180596 Reviewed-on: https://chromium-review.googlesource.com/933805 Commit-Queue: Adam Goode <agoode@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#541788}
-
Juan Antonio Navarro Perez authored
To disable on multiple platforms, each disable must be listed separately as a new entry. Also update docs to make this a bit more explicit. TBR=sullivan@chromium.org,nednguyen@google.com NOTRY=true Bug: 819552 Change-Id: I0f033a9ea11d8df6a27fcbbfaa5cc98d408ac2f1 Reviewed-on: https://chromium-review.googlesource.com/955682Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#541787}
-
Luke Zielinski authored
Added the skeleton trigger class, defined the associated ReportType and ThreatType enums, and plugged the class into TriggerCreator. This CL is a no-op. The trigger requires quota in order to be instantiated and the default quota is 0, so it does not get created at the moment. Bug: 817377 Change-Id: Ied66b2ecf9dc4eaf59b1d3e87d761996eb8a9d85 Reviewed-on: https://chromium-review.googlesource.com/941362Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Max Morin authored
Just testing the factory is a bit tricky, so I test it as part of the audio::OutputStream tests. Doc: go/audio-service-streams-design Bug: 803102 Change-Id: I463e7adbda7de1a8a5724fa23fc98015cb425a3c Reviewed-on: https://chromium-review.googlesource.com/939179 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#541785}
-
Sylvain Defresne authored
The deprecated method GetToolbarVoiceSearchButtonImageId() was confusing and forced client code to check return value. Instead use GetToolbarVoiceSearchButtonImages() that always return the correct value to use. Bug: none Change-Id: I80b6a8b493950c054374f5faee8c907c2055d44c Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/952449 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#541784}
-
arthursonzogni authored
With NavigationMojoResponse, we are seeing a regression in Navigation.ReadyToCommitUntilCommit. The method ContinueForNavigation() is called in a PostTask(). In a busy renderer, it causes the loading of the main resource to be delayed. This CL replaces the PostTask by a callback that is called at the end of RenderFrameImpl::CommitNavigation(). According to local benchmarks, it should improve the histogram mentionned above (see below). Links to collaboratory studies: * Without patch: https://goo.gl/isFY17 * With path: https://goo.gl/xWAjqB Bug: 705744, 820031 Change-Id: I4cac025f74865bf164d618d2afbd92bceeaede1e Reviewed-on: https://chromium-review.googlesource.com/951243 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541783}
-
Misha Efimov authored
Bug: 786559 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ife4a40e651a08827a0dfe5c500b80a685ff29359 Reviewed-on: https://chromium-review.googlesource.com/946408Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#541782}
-
Jamie Madill authored
This reverts commit d52a1146. Reason for revert: The Vulkan roll has landed in Chrome. Original change's description: > Temporarily disable angle_vulkan_deqp_tests. > > Unblocks the Vulkan roll (issues with http://crbug.com/643346). > > Bug: angleproject:2393 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Tbr: kbr@chromium.org > No-Try: True > Change-Id: Icd41d0ba9abbbdd5a8d52e9f391716dbef674a34 > Reviewed-on: https://chromium-review.googlesource.com/951648 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541458} TBR=jmadill@chromium.org,kbr@chromium.org Change-Id: Iadbb548ed09d8a19cf2f13302c3c790dcec911eb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:2393 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/955542Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#541781}
-
Fan Yang authored
R=rch@chromium.org Change-Id: Ia026d7497a2a901d231973a03effad0868f547d1 Reviewed-on: https://chromium-review.googlesource.com/953742Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#541780}
-
Yuki Shiino authored
Deletes |WrapPersistent| for wrapper-tracing version of callback interfaces after https://crrev.com/c/951163 . Bug: 778580 Change-Id: I16e8c19d1c01f74bc841aa3bcc1f6dacdc2563f8 Reviewed-on: https://chromium-review.googlesource.com/954864Reviewed-by:
-
Jochen Eisinger authored
Otherwise, we might crash flakily on windows, as we might tear down the Shell (WebContentsDelegate) before the callback to select a filename has returned. BUG=819739 R=battre@chromium.org Change-Id: I09348f556ee10a9efae738b0ee2721c23641590a Reviewed-on: https://chromium-review.googlesource.com/954944 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#541778}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Iae8c931231d6516cb64abe6386b4c3e343b9870c Reviewed-on: https://chromium-review.googlesource.com/952329Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#541777}
-
Nico Weber authored
Standard C++ doesn't allow implicit conversion between function pointers and void*. MSVC does allow that, so clang-cl also allows it but emits a -Wmicrosoft-cast warning. We want to enable this warning to make the compiler behave more similar on different platforms, so add an explicit cast to void*. (GetProcAddress() returns FARPROC, a function pointer type.) Merges one line from upstream 5d0574bf6473130d25dd296ad30206ccd148590b Bug: 550065 Change-Id: I54080e807e2106ff084adc6e0f7954a72bdf467f Reviewed-on: https://chromium-review.googlesource.com/953722Reviewed-by:
-
Ulan Degenbaev authored
This relands commit d690c638. This time the new test is marked as timeout in MSAN expectation. Original change's description: > [heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot. > > Each DOM node has a corresponding JS wrapper node. In heap snapshot > they appear as duplicates. > > Example retaining path with duplicates: > - [1] in InternalNode @2041178784 > - [1] in HTMLDivElement @2041079168 // DOM node > - [3] in HTMLDivElement @2231// JS wrapper > - retainer in Window / @2105 > > The heap snapshot generator now can merge an embedder node with a node > returned by EmbedderGraph::Node::WrapperNode() function. > > This patch implements the WrapperNode() function for each DOM node. > > Bug: chromium:811925 > Change-Id: I9ea6bc7e45f8ab3d54828b9ac61f7230d04d8019 > Reviewed-on: https://chromium-review.googlesource.com/928503 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539132} Change-Id: I0523477d562c68512a2a92902022826df8a32820 Reviewed-on: https://chromium-review.googlesource.com/955243Reviewed-by:
-
Chris Nardi authored
Remove already existing duplicate tests, and upstream a unified version of currently existing an + b selector parsing tests. Bug: 818475 Change-Id: Id889175e0d4df27037ee335d23020c213c148b44 Reviewed-on: https://chromium-review.googlesource.com/952078Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#541774}
-
Boris Sazonov authored
This CL fixes the string resource id used for the negative button in AccountSigninView. https://crrev.com/c/880861 introduced updateConsentText() that has been unconditionally using fre_skip_text for the negative button. In reality, the text for this button should change depending on the access point used to initiate sign-in. It was the last usage of IDS_FRE_SKIP_TEXT (Java method uses IDS_NO_THANKS instead), so this CL removes it. Bug: 818590 Change-Id: I00222b3648b82918b0bf262d28acece089604f91 Reviewed-on: https://chromium-review.googlesource.com/953423Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541773}
-
Chandan Padhi authored
InputDeviceInfo extends MediaDeviceInfo and represents audio and video input devices. These objects are the result of calling MediaDevices.enumerateDevices(). This interface gives access to the capabilities of the input device it represents via getCapabilities() method which will be implemented in asubsequent CL. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78 Bug: 817769 Change-Id: Ic9a016a05e622ee02b86d567f64c3ed84f0926c3 Reviewed-on: https://chromium-review.googlesource.com/942961 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#541772}
-
Fredrik Söderquist authored
This CL replaces the use of SVGElementProxy in ReferenceClipPathOperation with SVGResource. The main change between the two is when the element reference is resolved ("when used" versus "when computed".) This also, by extension, adds infrastructure for invalidation and other things required to make SVGResource work. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia43f76256a251a15c4dc100461cff9bf728eb188 Reviewed-on: https://chromium-review.googlesource.com/951613 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541771}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1666d944..16d3f07a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6343cb86d6cefa9339a456183da919f392a04bda Reviewed-on: https://chromium-review.googlesource.com/955042Reviewed-by:
-
Andy Paicu authored
PR: https://github.com/w3c/webappsec-csp/pull/290 Bug: 805886 Change-Id: I5bdda65c7e70e729b33a3647135fee6453e97e66 Reviewed-on: https://chromium-review.googlesource.com/934181 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#541769}
-
Christian Dullweber authored
When Chrome is restarted, tabs are initially in a frozen state and have no WebContents. History deletions need to clean up this frozen state to correctly remove navigation entries. Add integration tests for deletion of navigation entries from regular and frozen tabs. Bug: 407074 Change-Id: Id69ffcf05622f8e02eace0036e6787cea0b4dfab Reviewed-on: https://chromium-review.googlesource.com/949323 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Removed redundant parameter from CalculateBorderScrollbarPadding() and ConstrainColumnBlockSize(). Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If828121f1ab3582d2c97d9ea1d85ca0b51ed10c9 Reviewed-on: https://chromium-review.googlesource.com/946096Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
Also move bauerb@ to general owners for better coverage in EMEA R=dtrainor@chromium.org,tedchoc@chromium.org,twellington@chromium.org,yusufo@chromium.org,bauerb@chromium.org Change-Id: Id3b097ef8df4f76cc5abdcbfa69fecc610d68519 Reviewed-on: https://chromium-review.googlesource.com/940128Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541766}
-
Sylvain Defresne authored
Add GetToolbarVoiceSearchButtonImages(bool) to BrandedImageProvider to allow eventually remove GetToolbarVoiceSearchButtonImageId(int*) and to allow make provider use simpler (no need to check the return value). Bug: none Change-Id: Ibd25cb14018debe6b87fdc8a4c7af3c92a21a6c5 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/951691 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Use GetToolbarSearchButtonImage(SearchEngineIcon) overload and remove the deprecated old overload of the method (unused and downstream fixed to not override it already). Bug: none Change-Id: I5b115b5df55e7a81333903b0cc788c673e148053 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/951735 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4de0dd39. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" af1c15b1 "bluetooth: Use DeviceUUID in FakeBluetooth" 5dc0cbee "[css-typed-om] Clean up parsing tests." a9a7e883 "Move core CORB logic into //services/network." 5e638c8e "Upstream some CSSOM tests" 300cd0df "Moved XR getViewport, removed XRDevice.external" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13462 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bsittler@chromium.org, pwnall@chromium.org: external/wpt/cookie-store domenic@chromium.org, ricea@chromium.org: external/wpt/streams jrummell@chromium.org: external/wpt/encrypted-media jsbell@chromium.org: external/wpt/IndexedDB external/wpt/storage jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI kpaulhamus@chromium.org: external/wpt/webauthn yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: Iaf6b4b3ef0e660eeb63f85e60b03c0a2a9237be1 Reviewed-on: https://chromium-review.googlesource.com/954924 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541763}
-
Michael Lippautz authored
Reflects the change that there marking is actually implemented in the marking visitors and the adjust traits are only used for getting the proper descriptions. Bug: chromium:802273 Change-Id: Ib5df76a4689696b766c657fc7676780c694760f0 Reviewed-on: https://chromium-review.googlesource.com/948742 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
