- 03 Jan, 2020 40 commits
-
-
Andrew Xu authored
Layer::Clone(), which may be triggered by screen rotation, does not copy the mask layer. As a result, gradient zone for scrollable shelf may not show after screen rotation. This CL fixes the issue by checking the mask layer in ScrollableShelfView::Layout() and setting the mask layer if necessary. Bug: 1035715 Change-Id: I0f8adb1df9991066c2e6ff46a401a561fdb15204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986055 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728326}
-
Ben Joyce authored
BUG: 965286 Change-Id: I61c48daea3dba4b0a12e0dc0727981b80da30174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967877 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Conley Owens <cco3@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#728325}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e994380d00bb..a14d809391c8 git log e994380d00bb..a14d809391c8 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 nifong@google.com Support using an externally manage list of images in UrlDataManager for wasm debugger. 2020-01-03 mtklein@google.com remove FAAA/FSAA bots 2020-01-03 mtklein@google.com remove redundant Debug bots that have ASAN bots Created with: gclient setdep -r src/third_party/skia@a14d809391c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Iceb863f1f685635c8307e2b540123ddaf0296819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728324}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1577705382-benchmark-81.0.4011.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4012.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I276f4154a5d9df7a1f21107b4f78248478be6d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986277Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2257c087b11b..1f74351e20ca git log 2257c087b11b..1f74351e20ca --date=short --first-parent --format='%ad %ae %s' 2020-01-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9427b393..236f912c (728171:728281) Created with: gclient setdep -r src/third_party/webrtc@1f74351e20ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5861167faab84f15aee06540f159ce79416d33fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987105Reviewed-by:
-
Lukasz Anforowicz authored
This CL adds a DumpWithoutCrashing call when a destructor of content::BrowserContext gets called without an earlier call to BrowserContext::NotifyWillBeDestroyed. This CL will hopefully help 1) verify if there are scenarios in the wild, where a BrowserContext/Profile gets destroyed without calling BrowserContext::NotifyWillBeDestroyed first 2) find root cause of these scenarios Bug: 1038844 Change-Id: Ifb40daa27b7b4a4fc301df2ea6f09ffa499fe7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986262 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#728321}
-
Caleb Rouleau authored
In anticipation of turning down nexus5x perf bot, we are adding angle_perftests to the pixel2 bot. Since pixel2 shard map seems rather unbalanced right now, we also use this opportunity to reshard it. Bug: 1030840 Change-Id: Ifdaa2c22560a11e0d389d003a39a06903ede2017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987071 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728320}
-
Caleb Rouleau authored
Note that this change also reshards the win-10-perf builder, which may cause false positive regressions. In the event of perf regressions, this CL should not be reverted, since it is not causing the regression; it is just moving the test to run on a different device (of the same model and OS). See https://chromium-review.googlesource.com/c/chromium/src/+/1983326 for background. This moves all the gtest perf tests on win-10-perf into the performance_test_suite and onto the shard maps. This allows us to run them in parallel with the Telemetry benchmarks and account for their runtime within our system. Bug: 921353 Change-Id: Ibfd03a63256a884488c005e853527b4d9ac582b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986118 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Adam Langley authored
Currently, if credProtect is requested in a makeCredential call, an authenticator can return any credProtect level in the result. That's a bit slack because we're not checking that the level is what was requested. We expect some future authenticators to want to assert credProtect uniformly, so this change tightens the current check to require that the returned level is at least as strong as was requested, and relaxes it to allow credProtect to be returned even when not requested. Change-Id: I11b22dcc29b5551c6722a09d94b7c34cf0a48f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895381 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#728318}
-
Dan Beam authored
R=agrieve@chromium.org Fixed: 1038963 Change-Id: I0101e1ab7e2fe0159465d134c39971331d8b2340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985034 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#728317}
-
Sophie Chang authored
This adds a new HintsFetcher.NavigationHostCoveredByFetch.BeforeCommit one that is more in line with the other Optimization Guide metrics Bug: 1038766 Change-Id: I16309a56320913fc2457b00f7faa608a49271354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983264 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#728316}
-
Akihiro Ota authored
This change adds: 1. A search bar in the menus for users to type queries into. 2. A new menu which holds a list of results. 3. Functionality to dynamically populate the search menu with matched items. 4. Ability for users to simultaneously query and browse results. 5. Various clean up and modifications to accommodate the new behavior. Please see design sketch for this change for more details: https://docs.google.com/document/d/1eZ8HVKp47OPu8_vOJ9QE_v0nfXcSTSDSn5eqv1Rg8E0/edit# Bug: 684762 Change-Id: Iaa3c42ddd2a1e69a01aaee076a0b6799266fe98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975078 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#728315}
-
Avery Musbach authored
When a split view window is reinserted to overview, it shall go to the correct position to maintain the MRU ordering of the overview grid. Fixed: 1038396 Change-Id: I4cac7963610eb6a4b7022d2bc0e983e1f587a8cc Bug: 1038396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984723Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44134341fa8b..cf50f7748442 git log 44134341fa8b..cf50f7748442 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@cf50f7748442 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie550ddced3d740590fe68a23f3de394ea5d05040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986953Reviewed-by:
-
Nasko Oskov authored
ResourceDispatcherHost and its implementation are no longer present in the codebase, but are referenced in comments/docs. This CL cleans up those last few references. Bug: 472869 Change-Id: I4925617ff1d041f2d7328ac5b997fb07579900a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986920 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Chris Cunningham authored
The bulk of the change is to AudioRendererAlgorithm, which has historically been the decider of when the queue of decoded output is "full" such that we can begin playback. This CL adds a new method, IsAdequateForPlayback(), which may return true well before IsFull() when a latencyHint has been set that lowers latency from the default of 200ms. In such cases, we will still allow the decoded output to queue beyond the point of being "adequate" until we reach "full". When a latencyHint is set that increases latency vs the default, both the "adequate" and "full" thresholds will increase to accommodate the higher value. Bug: 1018908 Change-Id: I96fd19a7670630c23fb1e05076ac80c6486dba03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959326 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#728311}
-
David Grogan authored
Also organize virtual/layout_ng_flex_box entries, updating bug numbers etc. I have a local patch that only fixes mozilla tests, not ours or the usual wpt/css/css-flexbox. Bug: 845235 Change-Id: I5c2b4bd755fcc77867be43616042668ca1f01787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984819 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#728310}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/50ea92a176ba..1378a942692b $ git log 50ea92a17..1378a9426 --date=short --no-merges --format='%ad %ae %s' 2020-01-03 quiche-dev Adds SpdyStringPieceCaseHash and SpdyStringPieceCaseEq, for future use in SpdyHeaderBlock. 2020-01-03 quiche-dev This change plumbs an equality function object type through the quiche linked hash map type. This will enable future changes to the hashing behavior of SpdyHeaderBlock. 2020-01-02 renjietang gfe-relnote: deprecate gfe2_restart_flag_quic_coalesce_stream_frames_2 2020-01-02 renjietang gfe-relnote: deprecate gfe2_reloadable_flag_quic_use_connection_encryption_level 2019-12-30 ianswett Deprecate gfe2_reloadable_flag_quic_bbr_slower_startup4 Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Update flags R=rch@chromium.org Change-Id: Idf2aca1cd754ae82816a14e0ed0d9a69acb7b6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986053Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728309}
-
Stefan Zager authored
The default behavior of SetNeedsCompositingInputsUpdate is to do a PaintLayer ancestor walk, calling SetNeedsPaintPropertyUpdate along the way. However, none of the call sites in PaintLayerScrollableArea do anything that would actually invalidate ancestors' paint properties, so this CL skips the ancestor walk. Change-Id: I8e4134b40ccce5c9c90b9c723b4185d165d8bbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986276 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728308}
-
Lily Chen authored
This converts storage of ReportingReports in the ReportingCache into a flat_set. Also slightly refactors the interface exposed to the ReportingDeliveryAgent (in preparation for double-keying it). Bug: 1035660 Change-Id: I4f85283079ecf2e40e4840aac038078a646ec0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978218Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#728307}
-
Lan Wei authored
If we have a page hierarchy A(B(C)) and C tries to enter fullscreen by calling Fullscreen::RequestFullscreen(). This eventually calls the browser process at RenderFrameHostImpl::EnterFullscreen() for frame C. RenderFrameHostImpl::EnterFullscreen() for C hides the UI and puts the tab into fullscreen, and it also sends WillEnterFullscreen IPCs to A and B, so that they can modify their fullscreen state as well. In response to WillEnterFullscreen(), both A and B will call Fullscreen::RequestFullscreen(), but with for_cross_process_descendant being true, which skips a few things not needed for these ancestors (such as whether fullscreen can be entered). However, currently both A and B will each call RenderFrameHostImpl::EnterFullscreen() in the browser process *again*. The browser process notices that we're already in fullscreen mode (UI already hidden, etc.), so it doesn't do anything useful on these calls. We should not send the extra EnterFullscreen messages for A and B. This makes it so that we only hear RFHI::EnterFullscreen() from C, and it makes it possible to enforce fullscreen security checks on C in EnterFullscreen, without worrying whether it's C or its ancestors sending this message. Bug: 852645 Change-Id: I0d300ad2c88b46d379e2ecd0f3036a5fd486e123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967881 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728306}
-
Jia authored
Controller will only create the adaptive brightness system after a user session has started. The model will be personalized to the primary user profile, ie. the first signed-in user. Bug: 881215 Change-Id: Ib54fb5c8a05c2a47eec4ca1035d72e24e8183921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984794Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#728305}
-
Ian Vollick authored
With this change, the paint preview base service now can (optionally) be passed a policy object which can disallow paint previews for which it is not well suited. Bug: 1026349 Change-Id: I2dc9707fe17ca076c95f7ebdf0d064a710bb3b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986615 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#728304}
-
Andrew Xu authored
During the animation which is created to scroll ShelfView to the end when pinning an app icon under overflow mode, there is no gradient zone at the end. This CL fixes this issue. Bug: 1035420 Change-Id: Ifc0992c2191a1c56df9b99c44d0ac8d639617b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824128 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dfde190ab0ed..e994380d00bb git log dfde190ab0ed..e994380d00bb --date=short --first-parent --format='%ad %ae %s' 2020-01-03 bsalomon@google.com Some GrTypes cleanup. 2020-01-03 brianosman@google.com Remove SkRuntimeColorFilterFactory Created with: gclient setdep -r src/third_party/skia@e994380d00bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I6f58784aa76dec46f1867562001733fccf68163a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986201Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8bade6c45870..b8f36ec0ec7a Created with: gclient setdep -r src-internal@b8f36ec0ec7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9387977c7e1ebeff2048318eadf56a378f3b4a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985035Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728301}
-
Eric Karl authored
Previous CL added a SharedImageRepresentationTextureBase for other reasons, use this to simplify SharedImageRepresentationSkiaGL. Change-Id: Id0e027afc11c76b89664adc09b6ef3c85ac7a76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956255Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#728300}
-
Victor Fei authored
Refactored AxPlatformNodeTextChildProviderWinUnittest to make it more readable and compliant to existing tests and style guide. This change is introduced to prepare for a follow up change that fixes ITextChildProvider and ITextProvider. Bug: 928948 Change-Id: I2bb17fea9af9af1722ae121fea56745a4f9241f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985236Reviewed-by:
Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728299}
-
David Bokan authored
RootScrollBegin is a method used by WebView APIs to specifically target the viewport. It previously relied on passing the OuterViewportScrollNode through some internal ScrollBegin methods to skip parts (but not all) of the hit testing logic that determines which node to scroll. We now have a more explicit method of targeting specific nodes using the |current_native_scrolling_element_| field of the scroll data so this CL simply reuses that path. Bug: 1016229 Change-Id: I4762724b6af3d4004c80cdd51ce0d6eb7ff50885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981197 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728298}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d57274888541..2257c087b11b git log d57274888541..2257c087b11b --date=short --first-parent --format='%ad %ae %s' 2020-01-03 yvesg@webrtc.org [Cleanup/Optim] Pass IPAddress by const reference. Created with: gclient setdep -r src/third_party/webrtc@2257c087b11b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4781456ceb867496bb6cf6ba00eb2f8ba7a01cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986612Reviewed-by:
-
Michael Giuffrida authored
Add yilkal and michaelpg, and remove previous owners. Bug: None Change-Id: Ib06fab3d5992b6454f6f7ec49b89b08e040dd108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974757Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#728296}
-
Michael Giuffrida authored
One of these histograms lapsed, and the rest are up for expiry next milestone. Extend them, as they are still in use. Bug: 1009508 Change-Id: I40d648ed79bd35e60394d21b45401208e14233ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986191 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#728295}
-
Emily Stark authored
When a page runs active mixed content (or an active resource loaded with a certificate error), the origin's host is marked in SSLHostStateDelegate. The SSLHostStateDelegate is then queried to set mixed content flags on the NavigationEntry, which feeds into the SecurityLevel of the page. Before this CL, the host of the NavigationEntry's URL was being used to query SSLHostStateDelegate, but this means that mixed content flags weren't being set correctly for pages where the URL didn't match the actual origin (for example, about:blank). This CL changes SSLManager to query SSLHostStateDelegate with the committed origin of the root FrameNavigationEntry instead of the URL. As noted in the test in this CL, mixed content is still not being tracked properly for the initial about:blank navigation in a window or frame. That is tracked in https://crbug.com/1038765. This change creates a slightly weird UI; when an about:blank page is marked with active mixed content, the "about:" part is crossed-out (as seen in https://crbug.com/526218). A follow-up CL will fix that by only striking-through https:// schemes in the omnibox. Bug: 609527 Change-Id: Ia0f13290a5769006edea3719642a11faefe9ae8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986189 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#728294}
-
James Cook authored
The "desc" attribute is not sufficient to provide context to the translators because identical strings will be collapsed in the translation console. Add additional string constants, eliminate the shared "toggleOn" and "toggleOff" strings, and provide the "meaning" attribute in the GRD file to disambiguate. See bugs for details, or https://www.chromium.org/developers/design-documents/ui-localization Bug: 1031145 Bug: b/145301624 Change-Id: I3daf288f5a8a0dbf9ebd65575e7ff77144880ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986862Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#728293}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6e6c3a30e17..8bade6c45870 Created with: gclient setdep -r src-internal@8bade6c45870 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Icd18adbd3b13720a9d2ad7424d35c9f07a4f2cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986610Reviewed-by:
-
Bence Béky authored
This reduces duplicate code. The only side effect is that now packets built by MakeAckPacket() are saved in |saved_frames_|, but they are in fact never retransmitted. Change-Id: If6301deea0da015600f76b794478c21372f872c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982790 Auto-Submit: Bence Béky <bnc@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Eric Orth authored
DoH probes are run using a runner object, similar to the main DnsTransaction interface. This importantly allows creating multiple concurrent runs of the probes with different URLRequestContexts, and it allows independently cancelling those runs. Failure and available-DoH-server tracking are both still global, rather than tracked per-context, as until upcoming CLs spreading the new capabilities to more levels, probes are still only run for the primary context. Bug: 1022059 Change-Id: I1a20a31f9670da805652f1791fc4fbce0c27652d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984313 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#728290}
-
Regan Hsu authored
Currently, there is an extra "Learn More" in the browser language settings. This error was introduced when replacing "Learn More" links with settings-localized-link in os settings. Since browser settings is not using the settings-localized-link element, but shares the same strings used by os settings, a new string that does not contain "Learn More" in the sentence must be introduced. Fixed: 1038878 Change-Id: Ib450994561e9ea9908543c60377448120361a6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984377Reviewed-by:
-
Moe Ahmadi authored
before: https://screenshot.googleplex.com/M5ENgtHmDrF after: https://screenshot.googleplex.com/tgrmVBKYGjO Bug: 1030911 Change-Id: Ida41a52d1b2e305ae467a1f83452cfd084b26c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979148 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#728288}
-
Piotr Bialecki authored
Clean up and changes required to bring in WPT tests for hit test API. - minor clean up in webxr-test.js - store input_sources_ in a map, add 2 setter methods since the mojo properties were renamed but keep the old setters for back-compat - add webxr_test_constants_fake_world.js with logic to create a valid FakeXRWorld with given dimensions and a constant VALID_FAKE_WORLD - move transform-related asserts to webxr_test_asserts.js, change all variables storing the assert functions to `const`, add semicolons - add `DVLOG(3)`s in XRHitTestSource and XRSession Changes: Change-Id: I98ac5ed09cda877afb24e28df09ee4cd818d56f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986326 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728287}
-
