GitLab

This updates the NEL implementation to match the fields renames from
https://github.com/WICG/network-error-logging/pull/75.

Bug: 748549
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0545ce6f9bddb46c556e2ba15d16398ee9c3b1fa
Reviewed-on: https://chromium-review.googlesource.com/1104384Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568048}

They seem to pass.

Bug: 843511
Change-Id: I7e52d8cc7301d4d3bc87e03242124ce1b22c0000
Reviewed-on: https://chromium-review.googlesource.com/1104797
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568047}

Change-Id: Ica4288a6984f296958b7f9b812edb07663cec22e
Reviewed-on: https://chromium-review.googlesource.com/1104159Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#568046}

The feature has been running for a while on 50% canary and dev
with only one known issue which is already fixed on trunk.

Hence, let's enable it by default, which also requires updating
a few tests.

The switch exercises a more modern implementation of sessions
sync that should be identical from the users perspective, besides
the performance improvements (most notably, memory consumption
estimated to be reduced by a factor of 70% according to metric
Sync.ModelTypeMemoryKB.SESSION), or ~350 KB for the 95th
percentile.

Bug: 681921
Change-Id: Ida3e676a534d8c3ced174092d5498a793860020b
Reviewed-on: https://chromium-review.googlesource.com/1086945
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568045}

Do not force logout child accounts on Chrome OS if AccountReconcilor
encounters a retriable network error.

Bug: 851455
Change-Id: If7a79d7d634cd6b228158eceddb7e6c2729440e6
Reviewed-on: https://chromium-review.googlesource.com/1095110
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568044}

The gesture detector extrapolates scrolling events from previous real scrolling events.
The extrapolated event depends on the time difference between the events, favoring the
longest and more recent event. Here, we make the gesture detector receive the current
time instead of querying it from the system, and thus making the tests deterministic.

Bug: 853086
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2d46f5e5ebceb801aecccf5b2c0a2dbf6b858864
Reviewed-on: https://chromium-review.googlesource.com/1104583
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568043}

TBR=kenrb@chromium.org

Bug: 853761
Change-Id: I75eb2a580cc263a4dd4b6d3a0254fbadad8ec08e
Reviewed-on: https://chromium-review.googlesource.com/1104657
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568042}

https://chromium.googlesource.com/webm/libvpx.git/+log/37a0283b18a1..8648a64c83b5

$ git log 37a0283b1..8648a64c8 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 jianj VP9 HBD: Fix integer overflow problem in variance calc.
2018-06-15 tomfinegan Clean up avx512 compiler support test.
2018-05-23 jingning Prepare motion estimation process for temporal dependency model
2018-05-23 jingning Construct temporal dependency building system
2018-06-14 jianj vp9 svc: add tests for inter layer prediction.
2018-06-14 zoeliu Separate GF structure defining from bit allocation
2018-05-21 jingning Allocate tpl_dep_stats frame buffer
2018-06-14 jingning Add temporal model control as a speed feature
2018-05-21 jingning Add data structure for frame dependent mode decision
2018-06-13 luc [VSX] Optimize PROCESS16 macro
2018-06-13 zoeliu Unify frame_index in defining GF group structure
2018-06-13 jianj vp8: remove assertion in tree coder.
2018-06-13 luc VSX Version of SAD8xN
2018-06-13 luc Add Speed Tests for the SADTest test suite.
2018-06-13 tomfinegan Fix avx512 related MSVC build failure.
2018-06-12 jingning Remove duplicate vp9_twopass_postencode_update def

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Bug: 805277, webm:1534
Change-Id: I3fe5dc01690c4e2e43905663e5204b7e806e4b1c
Reviewed-on: https://chromium-review.googlesource.com/1103855Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#568041}

Tests in these classes have appeared frequently and near the end of the
test log in mac browser_tests tasks that either resulted in BOT_DIED or
exhibited a large number of failures due to crashpad (which itself
appears to be symptomatic of WindowServer death).

Bug: 828031
Change-Id: I37aeefe83a4ade9f69f5cb18ee5e13179fa24b89
Reviewed-on: https://chromium-review.googlesource.com/1104308Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568040}

Bug: b/78191741
Change-Id: I0bd7969e411adbace1f76eea8ba0d0d964312afe
Reviewed-on: https://chromium-review.googlesource.com/1099729
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568039}

This is a reland of e7652b9e

Original change's description:
> [Mac] Fix form control rendering on 10.14 Mojave.
> 
> The renderers need to talk to the CVMS server (OpenCL compiler), which
> then outputs codesigned blobs that can be loaded in to the process. This
> is required for drawing the form controls.
> 
> In addition, another Metal bundle location (in /Library) is permitted.
> 
> Bug: 850021, 847518
> Change-Id: I67106972baf5fc55fccd8f7deff3f47cbea076b5
> Reviewed-on: https://chromium-review.googlesource.com/1103127
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567877}

Bug: 850021, 847518
Change-Id: Ieb345079a0923d62b034425baacdfc604153c22b
Reviewed-on: https://chromium-review.googlesource.com/1104517Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568038}

Add expectation for virtual/user-activation-v2/fast/events/mouse-cursor-change-after-image-load.html

TBR=mustaq@chromium.org
NOTRY=true

Bug: 652536, 802291
Change-Id: I60a020661cc0027b1f0db7f9e1f232b1f1a20976
Reviewed-on: https://chromium-review.googlesource.com/1104693
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568037}

The new team now takes ownership of a few remaining directories.

Removing zea@ and pavely@ as owners from components/sync, after we've
been acting as owners for a while.

Bug: None
Change-Id: Ida9c8e7b22d40f16813aea0f521ab20ad170b49e
Reviewed-on: https://chromium-review.googlesource.com/1103572Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568036}

We need to ensure that we propogate the URI read permission
for subsequent intent triggers if the FRE was launched with
a content:// URI.

BUG=817717

Change-Id: Idc3089db222a423f66597f4f59102e42d4101e4c
Reviewed-on: https://chromium-review.googlesource.com/1103540
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568035}

These members of CodingSpecificInfo are unused since cl
https://webrtc-review.googlesource.com/61640,
and will be deleted in webrtc.

See also
https://chromium-review.googlesource.com/c/chromium/src/+/1102330,
with an analogous change to the remoting code.

Bug: webrtc:8830
Change-Id: I5cdf26058518109ea0b6cba965e6a4b5eddc9056
Reviewed-on: https://chromium-review.googlesource.com/1104340
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568034}

Freezing shouldn't be exposed to external components.

Bug: 775644
Change-Id: I60014f3a39ab241677d678d49ab1ffb2f99689c6
Reviewed-on: https://chromium-review.googlesource.com/1099650Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568033}

We need to analyze the bottlenecks in the upload to the dashboard.

Bug: 713357
Change-Id: If763ac8689798158c7e7bcc6587646737894fb81
Reviewed-on: https://chromium-review.googlesource.com/1104302Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568032}

This Cl makes InputData in input prediction to use
PointF instead of pos_x and pos_y.
And also adds two extra unit tests to lsq predictor

Bug: 836352
Change-Id: I3e551add7536e55be82f11ed2338b0bb9dfe8e07
Reviewed-on: https://chromium-review.googlesource.com/1093392
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568031}

This doesn't do anything yet (this component isn't yet published by
Omaha anyway), it's just all the boilerplate required to setup the
component installer, this will then be connected to c/b/rc and the
server side work will be done later (once the Chrome part is done).

Bug: 773383
Change-Id: I19802d63934b72ce812abe9d89d30d6f80a52258
Reviewed-on: https://chromium-review.googlesource.com/1100342Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568030}

Bug: b:74589757
Bug: 842718, 799739
Change-Id: I84f667ea521677928ef1b2c4f7f841ed2c0d11c2
Reviewed-on: https://chromium-review.googlesource.com/1042364
Commit-Queue: Luke Sorenson <lasoren@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568029}

The toolchain can be found using build/vs_toolchain.py instead.

Bug: none
Change-Id: Ia14c5334a9f33456da30862efe74c43af9162e6e
Reviewed-on: https://chromium-review.googlesource.com/1104163
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568028}

This CL adds the GBM_BO_USE_HW_VIDEO_DECODER flag to
gfx::BufferUsage::SCANOUT_VDA_WRITE buffers. It's a spinoff of a
comment [1] in crrev.com/c/1021675.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1021675/18/ui/ozone/platform/drm/gpu/drm_thread.cc#147

Bug: 822346
Test: simplechrome video playback on nautilus, vaapi engaged.
Change-Id: I795c6c3f74574ffab60c24d1ef746b22d214120a
Reviewed-on: https://chromium-review.googlesource.com/1104394Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568027}

Using wpt-import in Chromium c80bdd06.
With Chromium commits locally applied on WPT:
03ef65db "Update existing WebUSB WPT to be multi-global"
1db32e09 "OffscreenCanvas Text rendering tests"
89102421 "Reland "Multi-global WebUSB WPT for window and worker""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19912

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

TBR=robertma

No-Export: true
Change-Id: I4f196185becce5f6d486acbc4e929c9f64a8b47c
Reviewed-on: https://chromium-review.googlesource.com/1104298
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568026}

rendering benchmark is the new benchmark we are going to focus on, and
smoothness benchmark is going to be removed. So update cluster telemetry
to run the rendering benchmark instead.

BUG=760553

Change-Id: Ief60f9e12d2b0ad3776fe1d2beffd999e4784f51
Reviewed-on: https://chromium-review.googlesource.com/1103852Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568025}

AFBC for modeset buffers doesn't work correctly, as we can't fill them
with valid AFBC contents. For now, don't use AFBC for modeset buffers.
Remove this after we make ozone/drm capable of creating valid AFBC
modeset buffers (tracked by crbug.com/852675).

Bug: 852675, 853328, b/109782243
Test: External monitor works on Kevin

Change-Id: I902f2615aa78e34251381f87e25c5e76f39b94b5
Reviewed-on: https://chromium-review.googlesource.com/1100666
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568024}

This reverts commit cdd97e24.

After perf-bot reported a regression in timeToFirstMeaningfulPaint,
timeToFirstContentfulPaint, and timeToFirstPaint on android nexus5,
the original CL was reverted. However, the regression looks reasonable
because ReleaseMemory could be called before FCP and FMP came on low-end
devices if the website needs to use much memory. I guess that the regression
caused because the test website(edition.cnn.com) was consuming too much memory
on the mobile device.

Bug: 850977, 851868

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icc8e5f24c114947fe8d186f699d0457ea82b7416
Reviewed-on: https://chromium-review.googlesource.com/1096921Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#568023}

Previously, only the snooze setting hides the buttons and disables swipe.
This CL makes the inline setting do so. This is consistent with Android.

Bug: b/110329209
Test: manual (check the buttons are invisible and swipe is prohibited).

Change-Id: Ie177b445653eb74c9c01816fa0a09991875419dd
Reviewed-on: https://chromium-review.googlesource.com/1102437Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568022}

This enables the feature with the same name.

Bug: 830624, 826664
Change-Id: I156e197bc4a5f0a322747ad13def5ef361d3b173
Reviewed-on: https://chromium-review.googlesource.com/1014083
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568021}

This method was incorrectly invoking an EarlGrey method that scrolled to
the bottom of the view, not the top.

BUG=853330

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic5bfe4be02594828c4c12a45e3dab78a51641cac
Reviewed-on: https://chromium-review.googlesource.com/1104382Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568020}

Looks like the last caller was removed in
https://codereview.chromium.org/2287433003 .

Change-Id: I2664063bab31fe4983be65cb5c21039a90b73920
Reviewed-on: https://chromium-review.googlesource.com/1104342Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568019}

The framework depends on libfoo.dylib, and when we symbolize this dependency,
we use dirname(libfoo.dylib) -> '' as @loader_path, turning the rpath
@loader_path/. into the absolute path /.

Call realname() on the file before calling dirname to fix this, and to
fix a second (latent) bug where the rpaths should be relative to the
symlink targets, not to symlinks.

(I think this was always broken, but harmless before I made
GetSharedLibraryDependenciesMac() error out on resolving failures, and
harmless in practice since the framework itself symbolized itself and
its deps fine, just resolving the deps of the deps would silently fail
before I made it fail loudly.)

Bug: 853716
Change-Id: I519f786f785bcae8b5d64edc8ff1a883edba5c72
Reviewed-on: https://chromium-review.googlesource.com/1104393Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568018}

Adding coordinator and an empty view controller for the Google services
settings. This work is related Unity.

Screenshots:
https://drive.google.com/open?id=175ZmSyXJQsz_EJMezwu0WhnUuGJM-xxZ
https://drive.google.com/open?id=1kHqvfmCxoN6IsDfsj9TR0VxdqzoBff-M

Mock:
https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3b9ec33d4d_17_39

Test target added with: crrev.com/i/640917

Bug: 827072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7eb7ff3018a5bcef75e6c7ffddf79497a8a2fa38
Reviewed-on: https://chromium-review.googlesource.com/1096599Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568017}

NOTRY=true
TBR=charliea@chromium.org

Bug: 853763
Change-Id: I5e9b428c9f7b86160f391a8d0d74ed0434427af0
Reviewed-on: https://chromium-review.googlesource.com/1104316Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568016}

We missed a place where an inset needed to be tweaked for tab switch
suggestions. Also, it was choosing the wrong image for rich + tab
switch suggestion.

Bug: 780835
Change-Id: I2f74618584480d9857a5e5c5e7c82636735d7c6b
Reviewed-on: https://chromium-review.googlesource.com/1102913Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568015}

The related Skia change has landed, enable the fix and rebaseline.

BUG=skia:8042

Change-Id: Ia32cf8ec51e07202680388e3863e509979a76378
Reviewed-on: https://chromium-review.googlesource.com/1102484Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568014}

https://skia.googlesource.com/skia.git/+log/0242b59c0aaf..1bb47df4fc8e


git log 0242b59c0aaf..1bb47df4fc8e --date=short --no-merges --format='%ad %ae %s'
2018-06-18 caryclark@skia.org fast path for pathops
2018-06-18 caryclark@skia.org remove SK_MaxSizeT from docs


Created with:
  gclient setdep -r src/third_party/skia@1bb47df4fc8e

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@chromium.org

Change-Id: Ie4e22cb8df55fe7ef97317d781be660e5b756cf1
Reviewed-on: https://chromium-review.googlesource.com/1104437Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568013}

In [1] we found tests were being run with BlinkGenPropertyTrees enabled
but without use_layer_lists. This issue is difficult to debug and will
hit other developers. This patch adds a DCHECK that use_layer_lists is
enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1083012

Bug: 836902
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0c9cc1393100a66528abae84842e2164fb4ad107
Reviewed-on: https://chromium-review.googlesource.com/1102562Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568012}

This CL is part of a serie of CLs to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: I28d733a8f7fd7935b2cae8f7bea7d96be5370e00
Reviewed-on: https://chromium-review.googlesource.com/1102500
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568011}

It's mostly failing on "Win7 Tests (dbg)(1)"

TBR=rockot@chromium.org

Bug: 853733
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I667d434cc382d96a6e5ab37b9697f40e4506a690
Reviewed-on: https://chromium-review.googlesource.com/1104435Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568010}

CallExtraOrCrash is a function to call into V8 Extras and crash if it
fails. Unfortunately, calling into V8 Extras can fail under normal
conditions such as stack overflow and Worker destruction, causing a lot
of unnecessary crashes. Remove CallExtraOrCrash.

This is a stopgap change designed to be mergable to version 68. It
avoids major code restructuring but as a result lacks robust
encapsulation.

The general strategy is to pass a boolean pointer to functions in
ReadableStreamOperations that call into V8 Extras. If the internal call
fails, the boolean is set to true, and the call returns a default value.

BodyStreamBuffer keeps the boolean as member variable. Once a call to a
V8 extra function fails, the boolean is set and no more calls will be
made. This is to avoid us taking action based on information that is
incorrect.

For Tee() and the from-stream version of the BodyStreamBuffer
constructor, we use an ExceptionState object instead. In these cases, it
is straightforward to pass through ExceptionState object from the Blink
bindings. This allows the failure to be propagated safely back to
Javascript.

Conversely, DefaultReaderRead() has been switched from using
ExceptionState to using an error-signalling bool. This is because its
callers do not have access to a real ExceptionState object. Previously
callers used a NonThrowableExceptionState, but this was not suitable as
DefaultReaderRead() can throw.

BodyStreamBuffer mostly wraps access to ReadableStreamOperations, so
some degree of encapsulation has been retained.

7 new layout tests exercise each of the deterministically reachable
crashes, using stack overflows. Because they depend on stack layout and
whether DCHECKs are enabled, they only hit the crashes in particular
environments.

Bug: 829790, 849312
Change-Id: I47481b33a47b418dc6916e3b4311e60b5fd89e3d
Reviewed-on: https://chromium-review.googlesource.com/1097047
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568009}