- 07 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4d5651f6d0c..d8f7f3c91f72 Created with: gclient setdep -r src-internal@d8f7f3c91f72 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib4b88409e01b3be0384d38e9671e09029dbedbb5 Reviewed-on: https://chromium-review.googlesource.com/c/1322315Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606009}
-
Stuart Langley authored
Preparation for adding FolderFeatures as another parameter that can be set on a TestEntryInfo object. Bug: 884020 Change-Id: I1fec6cc38f024df83b5b3c065f1b6ec5e8462347 Reviewed-on: https://chromium-review.googlesource.com/c/1322341 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606008}
-
Marc Treib authored
This pref was only used for legacy supervised users, based on supervised_users::kRecordHistoryIncludesSessionSync. Legacy supervised users don't exist anymore, so no need to keep this around. Bug: none Change-Id: I34a3661bba4e9ebc4e89677749f4c0ee001d908d Reviewed-on: https://chromium-review.googlesource.com/c/1314492 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#606007}
-
Colin Blundell authored
This include causes complications when splitting //components/signin/core/browser:test_support into "internals" and "externals" targets: test_signin_client.h will go into the "internals" target, which should not depend on //components/signin/core/browser, which the included file is part of. Happily, this include isn't used and can be removed :). Bug: 901859 Change-Id: Ia9cd8381773801932af31856e45f9aa2a54b38c5 Reviewed-on: https://chromium-review.googlesource.com/c/1319590Reviewed-by:
-
Siddhartha authored
This data is useful to understand startup regressions from users. Storing of service name in base factory is not a lot of overhead considering that the strings are already part of binary. BUG=900688 TBR=blundell@chromium.org Change-Id: I240900515431fc56f005c7198ce0aea0645b3a62 Reviewed-on: https://chromium-review.googlesource.com/c/1311613Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606005}
-
Yoshifumi Inoue authored
This reverts commit f481306a and disables following tests on Windows: * RenderThreadImplBrowserTest.NonResourceDispatchIPCTasksDontGoThroughScheduler * UserScriptListenerTest.NavigationWaitsForContentScriptsToLoad Reason for revert: Causes BrowserMainLoopTest, CreateThreadsInSingleProcess to fail every time content_unittests is run, if DCHECKs are enabled. Original change's description: > Reland "Start ServiceManger before creating BrowserMainLoop." > > This relands commit aa60c219. The original CL > (https://crrev.com/c/1113802) got reverted becuase FeatureList and field > trials are not setup properly in early startup in Android WebView, but > ServiceMangerContext has checked features. See crbug.com/899376. The fix is > in a separate CL: https://crrev.com/c/1305876. Another related precursor CL > is: https://crrev.com/c/1308096. > > This CL is an exact copy of the original CL. > > The original cl description is: > This CL instantiates the ServiceManagerContext before creating > the BrowserMainRunner. It splits the startup path into two, > with/without starting the full browser. The changes are implemented > behind a flag "allow-start-service-manager-only". > > Bug: 846846,729596 > TBR: jam@chromium.org > Change-Id: I5214af850d4ef256c9d223db059ed009a42de714 > Reviewed-on: https://chromium-review.googlesource.com/c/1305822 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604969} TBR=gab@chromium.org,jam@chromium.org,hanxi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846846, 729596, 902311 Change-Id: I8b46711602a240023f4a03a69aa70f66d4eee726 Reviewed-on: https://chromium-review.googlesource.com/c/1322343Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606004}
-
Stephane Zermatten authored
BatchElementChecker:StopTrying was introduced as a work around when finding elements failed when run in parallel. On ScriptTracker, this required delaying re-checks and even executing scripts until a clean script end, which is complex to get right. Now that finding elements can safely be run in parallel, a BatchElementChecker can safely be deleted to interrupt any pending checks. This simplifies ScriptTracker. Bug: 806868 Change-Id: I87e61932a9dee178c5ad9337a315f9891c43bbf0 Reviewed-on: https://chromium-review.googlesource.com/c/1319670 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#606003}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit. That means that they also share the same anonymous namespace (which is per translation unit, not per file which would have been better). In https://chromium-review.googlesource.com/c/1316836 and https://chromium-review.googlesource.com/c/1315534 two peerconnection tests each added a kWriteBufferSize and a kDelegateReadBufferSize with different values which broke some jumbo build configurations (unluckily not the one in CQ but some in fyi builders). This renames the variables to have more unique names. TBR=shampson@chromium.org,hbos@chromium.org Bug: 874296 Change-Id: Ifc8af2be440f7a959b948c05e18deaf55aeefad2 Reviewed-on: https://chromium-review.googlesource.com/c/1322709Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#606002}
-
Mohamed Amir Yosef authored
This CL renames PasswordModelTypeController class. Currently it is used for the Pseudo USS implementation as an intermediate stage till releasing the full-blown USS implementation for passwords. We should reserve that name for the full-blown implementation. Bug: 902349 Change-Id: I01b9df1e9e4afcb0307f58a95172769a9f249f18 Reviewed-on: https://chromium-review.googlesource.com/c/1320170Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606001}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33b8d56d7282..e4d5651f6d0c Created with: gclient setdep -r src-internal@e4d5651f6d0c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia2455817e9288e74be2b2235802a10841d2882df Reviewed-on: https://chromium-review.googlesource.com/c/1322313Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b563adf6..2e9640bf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5162ec394e9d6da2164c4fa9c10daa35c31b31d6 Reviewed-on: https://chromium-review.googlesource.com/c/1322359Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605999}
-
Hitoshi Yoshida authored
We no longer use GYP, and it is confusing to keep having APIs or comments for it. Bug: None Change-Id: I0d2cd0f4c5b41edeab3ea65785a5eec9a4324b44 Reviewed-on: https://chromium-review.googlesource.com/c/1322344Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#605998}
-
Yi Su authored
Enable SearchEngineTabHelper to add new TemplateURL to TemplateURLService by following steps: 1. When a searchable URL is generated from <form> submission, save it to SearchEngineTabHelper; 2. If the navigation caused by <form> successfully finishes, create a new TemplateURL by recorded searchable URL and add it to TemplateURLService, then erase the recorded url. Failed navigation will be ignored because in that condition the generated searchable URL will probably lead user into an error page; Bug: 433824 Change-Id: I1835f2e12e9bc3a1d613011b5b7dd38206c019ad Reviewed-on: https://chromium-review.googlesource.com/c/1317909Reviewed-by:Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605997}
-
Koji Ishii authored
NGLineTruncator truncates lines by suppressing fragments to be clipped. However, when such fragments have SelfPaintingLayer, they are still painted by LayerPainter. This patch moves such fragments to the outside of the clipping area, the same way we used to use until r581177. Note that we used to move to line_width before r581177, but it's not enough when the block has padding. This patch moves to NearlyMax instead. Bug: 899902 Change-Id: I6192f230e2da3af11346acb5795483f9cc3a6a6a Reviewed-on: https://chromium-review.googlesource.com/c/1319889 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#605996}
-
Yoshifumi Inoue authored
This patch marks point-mapping/3d-point-mapping-{3,origins}.html flaky on Mac10.13 Retina. NOTRY=true TBR=yosin@chromium.org Bug: 902645 Change-Id: I9fc46621c034f932c791d4932907dcbcf88ebe4a Reviewed-on: https://chromium-review.googlesource.com/c/1322261Reviewed-by: -
Gauthier Ambard authored
This is a preliminary step to start using it for the "Switch to this tab" feature. Bug: 893121 Change-Id: I58f9095b689dbd0a59fffcb20bca7924dd239d7f Reviewed-on: https://chromium-review.googlesource.com/c/1319675Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#605994}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/52a091f41950..4b49707cb5ca git log 52a091f41950..4b49707cb5ca --date=short --no-merges --format='%ad %ae %s' 2018-11-07 yyanagisawa@chromium.org autoninja: use ninja in the autoninja.py directory Created with: gclient setdep -r src/third_party/depot_tools@4b49707cb5ca The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/77176746 TBR=agable@chromium.org Change-Id: I34b7cac49c620fda5354d08808403471f5651ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1322369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605993}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ecee6235c38..33b8d56d7282 Created with: gclient setdep -r src-internal@33b8d56d7282 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5f83c3eaca20e48cb6fdaa4d6dda20e1f3fac0de Reviewed-on: https://chromium-review.googlesource.com/c/1322371Reviewed-by:
-
Marc Treib authored
Less duplication == good. Most of the things in autofill::TestSyncService were already supported, a few missing ones are added in this CL. TBRing trivial change in payment_request_browsertest_base.h TBR=mathp Bug: 859874 Change-Id: I51c140c86efb95494f84eb38142d54fc32f74b14 Reviewed-on: https://chromium-review.googlesource.com/c/1319592 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#605991}
-
Marc Treib authored
This is a fix to the SyncService::ReadyForStartChanged code path: When stopping the data type, set an UNREADY_ERROR (instead of leaving the error unset). This causes the Sync engine to reconfigure, which properly marks the data type as no longer active. Before, the data type did stop syncing, but was still returned as part of SyncService::GetActiveDataTypes. It also adds integration tests that AUTOFILL_PROFILE gets disabled on autofill::prefs::SetProfileAutofillEnabled(.., false). Bug: 895824, 890737 Change-Id: I3736ef010ad09ecd79a101aeff400d597956569e Reviewed-on: https://chromium-review.googlesource.com/c/1319609 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
The crash is a renderer kill when the browser receives timing data that goes back in time. TimeTicks is supposed to be monotonically increasing. Bug: 881100 Change-Id: I3337b3e4102dfebfb3d2eeeb28cef85ecaf5e4ea Reviewed-on: https://chromium-review.googlesource.com/c/1322251Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605989}
-
Findit authored
This reverts commit ed0f2f84. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 605980 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2VkMGYyZjg0ZmExNzFhYjQzNDNjMmVjYTkzYjg2MDg1YjQ3MDM0OWUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/15725 Sample Failed Step: browser_tests Original change's description: > [VK] Automatically notify when test keyboard UI is loaded. > > Previously, test implementations of KeyboardUI did not call > KeyboardController::NotifyKeyboardWindowLoaded. KeyboardController > requires that function to be called in order to proceed to show the > virtual keyboard. Thus, individual test files had to manually call > NotifyKeyboardWindowLoaded. > > We change the test implementations to automatically call > NotifyKeyboardWindowLoaded (through a callback) and move the function > to be private. We use PostTask to simulate asynchronity. > > Bug: 849995 > Change-Id: I1eae9a94c785622ed645c2437a0457f5516fed47 > Reviewed-on: https://chromium-review.googlesource.com/c/1277129 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605980} Change-Id: I959fb6eede97135d784019240760184563de0b16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 849995 Reviewed-on: https://chromium-review.googlesource.com/c/1322609 Cr-Commit-Position: refs/heads/master@{#605988}
-
Sergei Datsenko authored
Now it requests ridiculously excessive number of results. Tune it down to just excessive. BUG=chromium:902600 Change-Id: I300c345284d06a15f3375286ae32cd1de1e30645 Reviewed-on: https://chromium-review.googlesource.com/c/1322329Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#605987}
-
Jun Choi authored
According to the CTAP spec, it is valid for external authenticators to return response to GetAssertion request with an empty credential when only one credential is listed in the allowed list section of the corresponding GetAssertion request. In this case, manually set credential id before returning the response to the relying party. Bug: 900577 Change-Id: I9ea65eea1c1dc83d6f5312839c0d5db81b0febed Reviewed-on: https://chromium-review.googlesource.com/c/1318973Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605986}
-
Anand K. Mistry authored
BUG=902227,901782 Change-Id: I130aedf1d2085089f7385ee13347894819f68e05 Reviewed-on: https://chromium-review.googlesource.com/c/1322181Reviewed-by:
-
Niels Möller authored
Needed to add constructor and make use of it in webrtc, see cl https://webrtc-review.googlesource.com/c/src/+/109500. Bug: webrtc:9962 Change-Id: I1437a25db26ed5fa5440f5aa22daa2bdd786b73d Reviewed-on: https://chromium-review.googlesource.com/c/1318892Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#605984}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=futhark@chromium.org Bug: 901709 Change-Id: I5adf66b516a0d07c9f58e195a1d0a2b7cb3e95ee Reviewed-on: https://chromium-review.googlesource.com/c/1322176Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605983}
-
Matt Falkenhagen authored
Since adding the long timeout in https://github.com/web-platform-tests/wpt/pull/13684, it doesn't timeout. However, it still has recently started timing out on Mac for oob-cors. Bug: 868225, 870173 Change-Id: I3b460ae75d0e25916ed2d836e0e5d75d29f2124b Reviewed-on: https://chromium-review.googlesource.com/c/1322335Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605982}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29c1a01acebc..0ecee6235c38 Created with: gclient setdep -r src-internal@0ecee6235c38 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9093f5ff34082d615dd94bfe2ec45a429900af9f Reviewed-on: https://chromium-review.googlesource.com/c/1322370Reviewed-by:
-
Darren Shen authored
Previously, test implementations of KeyboardUI did not call KeyboardController::NotifyKeyboardWindowLoaded. KeyboardController requires that function to be called in order to proceed to show the virtual keyboard. Thus, individual test files had to manually call NotifyKeyboardWindowLoaded. We change the test implementations to automatically call NotifyKeyboardWindowLoaded (through a callback) and move the function to be private. We use PostTask to simulate asynchronity. Bug: 849995 Change-Id: I1eae9a94c785622ed645c2437a0457f5516fed47 Reviewed-on: https://chromium-review.googlesource.com/c/1277129 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#605980}
-
Justin Cohen authored
When using the non-CRWNativeContent NTP the title may be incorrectly nilled out. Instead, don't update the navigation item title if there is a loading error page. BUG: 826369 Change-Id: I6d7d45982afbc94d13d73a26b1f8c9784a3ea7dc Reviewed-on: https://chromium-review.googlesource.com/c/1316752 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dc98b9b975fa..8770ce70746a git log dc98b9b975fa..8770ce70746a --date=short --no-merges --format='%ad %ae %s' 2018-11-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03cf97f6..38dcb5ed (605818:605924) 2018-11-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 793c8566..03cf97f6 (605715:605818) 2018-11-06 srte@webrtc.org Fixing bug in SimulatedNetwork where packets stop. 2018-11-06 srte@webrtc.org Removes deprecated GetSentPacket from PacketResult. Created with: gclient setdep -r src/third_party/webrtc@8770ce70746a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I90753b7885fcda76beab425300c99eddc0c7abf0 Reviewed-on: https://chromium-review.googlesource.com/c/1322210Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ef413aaa..b563adf6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2655d0aecb32b21bcf60ebab11a1c23d38e9bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1322349Reviewed-by:
-
Hayato Ito authored
TBR=tkent@chromium.org Change-Id: I7ac71397fab24f23ee8e860f8cf476a1ad4cd332 Reviewed-on: https://chromium-review.googlesource.com/c/1322179Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#605976}
-
Kush Sinha authored
Bug: 871690 Change-Id: I892c016bbcfcaaaba0e580b1b7783f916be2e469 Reviewed-on: https://chromium-review.googlesource.com/c/1276649 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605975}
-
Alexey Baskakov authored
For now we try to reuse as much USS code as possible. It has limitations and drawbacks (see the code). We will rethink our persistence code later when we start to design WebAppSyncBridge (an implementation for syncer::ModelTypeSyncBridge interface). Bug: 896150 Change-Id: Ia898b905f39869a6b1c3f79751358425449a617a Reviewed-on: https://chromium-review.googlesource.com/c/1295529Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#605974}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=tkent@chromium.org Bug: 901709 Change-Id: I21a5a8b9a53058ec6b777af846757c6b6377805a Reviewed-on: https://chromium-review.googlesource.com/c/1322253Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#605973}
-
Kent Tamura authored
Before this CL, an entry in event_interface_names.json5 looked like: "third_party/blink/renderer/core/dom/events/CustomEvent", This was confusing because this looked a path name, but its actual path name is "third_party/.../events/custom_event.{cc,h,idl}". generate_event_interfaces.py concatenated a directory information and an interface names, and make_event_factory.py split it. This CL changes it to: { name: "CustomEvent", interfaceHeaderDir: "third_party/blink/renderer/core/dom/events", }, 'interfaceHeaderDir' is same as one in json5 for tag names. * bindings/scripts/generate_event_interfaces.py: Don't concatenate directory information and an interface name. Produce interfaceHeaderDir field. * build/scripts/make_event_factory.py: - Build header paths with interfaceHeaderDir instead of os.path.dirname(entry['name']). - Don't use name_utilities.script_name(). entry['name'].original is enough because entry['name'] doesn't contain directory information. * build/scripts/templates/event_factory.cc.tmpl: Use 'name' filter to get the name as is. * build/scripts/make_names.py: Remove unnecessary os.path.basename(). Add template for interfaceHeaderDir. * build/scripts/name_utilities.py: Remove script_name(). This CL has no behavior changes. Change-Id: I960ad48d23c05e2b327864123a9ba3cb0caf9241 Reviewed-on: https://chromium-review.googlesource.com/c/1322012 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#605972}
-
Alexey Baskakov authored
Handle WebContents lifetime and errors properly (in the future). Bug: 901226 Change-Id: Ifc587e01a32362a89943a1a985a4893262a7154a Reviewed-on: https://chromium-review.googlesource.com/c/1322170 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605971}
-
Yoshifumi Inoue authored
This patch marks point-mapping/3d-point-mapping-{3,origins}.html flaky on Mac10.13 NOTRY=true TBR=yosin@chromium.org Bug: 902645 Change-Id: Ib23c6ddd21b0739317141cf78f26ea482bc920d5 Reviewed-on: https://chromium-review.googlesource.com/c/1322334Reviewed-by:
-
