GitLab

We're deprecating the default constructor of Supplement.

This CL also refactors PagePopupSupplement to make the implementation
closer to other supplement implementations.

BUG=610176

Review-Url: https://codereview.chromium.org/2617113003
Cr-Commit-Position: refs/heads/master@{#441949}

BUG=NONE

Review-Url: https://codereview.chromium.org/2610103003
Cr-Commit-Position: refs/heads/master@{#441948}

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary as long as we ensure that the database
handle does not get stuck in a closed Mojo pipe so the logic (and test
for it) have been removed.

BUG=627484

Review-Url: https://codereview.chromium.org/2601163002
Cr-Commit-Position: refs/heads/master@{#441947}

* Delete some one-line helper functions.
* Provide some more default method implementations in class Group.

BUG=659631

Review-Url: https://codereview.chromium.org/2616953002
Cr-Commit-Position: refs/heads/master@{#441946}

ExceptionState should not be ignored in production code unless you have
a strong reason to do so. However, people have abused IGNORE_EXCEPTION
and ignored ExceptionState that should not be ignored...

To discourage further mis-usage, this CL renames IGNORE_EXCEPTION to
IGNORE_EXCEPTION_FOR_TESTING.

BUG=670619

Review-Url: https://codereview.chromium.org/2615953003
Cr-Commit-Position: refs/heads/master@{#441945}

BUG=675561

Review-Url: https://codereview.chromium.org/2618703004
Cr-Commit-Position: refs/heads/master@{#441944}

This is one of the steps to deprecate the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2614143002
Cr-Commit-Position: refs/heads/master@{#441943}

BUG=674509

Review-Url: https://codereview.chromium.org/2610323003
Cr-Commit-Position: refs/heads/master@{#441942}

Continuation of cl/2615613005, updating module page_test to legacy_page_test.

BUG=678600
TBR=bustamante

Review-Url: https://codereview.chromium.org/2614123003
Cr-Commit-Position: refs/heads/master@{#441941}

No changes other than modifying includes and appropriately forward
declaring the class.

BUG=625684
TBR=girard@chromium.org, clamy@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2590273002
Cr-Commit-Position: refs/heads/master@{#441940}

This change adds the header and the Order Summary section to the
Payment Sheet in the Payment Request dialog. Both sheets still need
many tweaks and extra features but this is the first step towards the
dialog actually looking like the design specs.

Mocks here:

https://folio.googleplex.com/chrome-ux/mocks/329-future-web-pay/latest/desktop#

A screenshot of the Payment Sheet is here:

https://drive.google.com/file/d/0B-DVbqI3huZGREpIaE5yMDZjZzA/view?usp=sharing

A screenshot of the Order Summary shown when clicking the Order Summary
row is here:

https://drive.google.com/file/d/0B-DVbqI3huZGM0F0cC1sS2xLTWs/view?usp=sharing

BUG=676112

Review-Url: https://codereview.chromium.org/2592833002
Cr-Commit-Position: refs/heads/master@{#441939}

https://skia.googlesource.com/skia.git/+log/b38db9a48db0..f80f115dd5ae

$ git log b38db9a48..f80f115dd --date=short --no-merges --format='%ad %ae %s'
2017-01-06 kjlubick Be able to fuzz a directory of input

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2619553002
Cr-Commit-Position: refs/heads/master@{#441938}

This reverts commit c5f4d723.

Reason for revert:
Broke Mac trunk of official.desktop.continuous builder (https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/44193/steps/compile/logs/stdio)

TBR=pkasting@chromium.org,pastarmovj@chromium.org
BUG=678919

Review-Url: https://codereview.chromium.org/2618913002
Cr-Commit-Position: refs/heads/master@{#441937}

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for tupstream issue).

[1]: https://github.com/material-foundation/material-roboto-font-loader-ios/issues/6

BUG=673904

Review-Url: https://codereview.chromium.org/2618583004
Cr-Commit-Position: refs/heads/master@{#441936}

* Adds the first test for RecentTabsPage.
* Extracts RecentlyClosedTabManager interface from RecentlyClosedBridge to enable injection of a fake in tests.
* Deletes a bunch of one-line helper functions.
* Minor cleanups like using diamond operators and restricting visibility.

BUG=659631

Review-Url: https://codereview.chromium.org/2610143002
Cr-Commit-Position: refs/heads/master@{#441935}

The file was never added to the build and is now hopelessly out of date.
Other parts of the code exercise AutofillAddress sufficiently anyway.

BUG=672196

Review-Url: https://codereview.chromium.org/2563523002
Cr-Commit-Position: refs/heads/master@{#441934}

Chrome shouldn't be started for ARC++ Kiosk sessions.
However, if it's not started at all before "kSilentLaunch" check,
then bottom bar is shown.
Starting Chrome silently avoid it and shows only blank wallpaper until app is started.

As in future dedicated ARC++ Kiosk initialization flow with Splash Screen will be added,
the issue should pass away together with it, but we need temporary fix for M56 launch.

BUG=676185
TEST=Manual, Start ARC++ Kiosk sessions.

Review-Url: https://codereview.chromium.org/2604813002
Cr-Commit-Position: refs/heads/master@{#441933}

As ARC++ kiosk should always be running during the ARC++ kiosk session,
it make sense to restart it when there is notification that the task was closed.
However, it won't restart the app if some preconditions are not yet satisfied,
e.g. policy is not compliant, app is not ready.

BUG=676825
TEST=Manual, Run Kiosk on ARC++ device

Review-Url: https://codereview.chromium.org/2599333002
Cr-Commit-Position: refs/heads/master@{#441932}

The infrastructure of async_test LayoutTests was changed recently, and
one effect is that an assert inside an event listener will cause the
test to time out instead of returning the error. This makes the test
much more difficult to debug failures. Additionally, promise_test is just
nicer when it's easy to return a promise.

This CL updates the existing budget tests which run in service workers to
use promise_test. It also cleans up a bit of style.

BUG=617971

Review-Url: https://codereview.chromium.org/2600733002
Cr-Commit-Position: refs/heads/master@{#441931}

BUG=676820

Review-Url: https://codereview.chromium.org/2616933004
Cr-Commit-Position: refs/heads/master@{#441930}

If there is an untriggered idle task when the document is gone, it
introduces memory leak because IdleRequestCallbackWrapper keeps a
reference to the ScriptedIdleTaskController, making it live longer
than the document.

This patch fixes the issue by letting IdleRequestCallbackWrapper
store a WeakPersistent instead.

BUG=595155

Review-Url: https://codereview.chromium.org/2618893002
Cr-Commit-Position: refs/heads/master@{#441929}

The Reading List Collection View does not need to be reloaded for every change.
This CL reloads it only if some changes occurred.

BUG=677924

Review-Url: https://codereview.chromium.org/2609173002
Cr-Commit-Position: refs/heads/master@{#441928}

Sync Encryption screen now listens to sync changes and reloads itself
when necessary. This ensures modifications to the passphrase (done by
the Sync Encryption Passphrase screen) are reflected in the UI.

BUG=678609

Review-Url: https://codereview.chromium.org/2610403003
Cr-Commit-Position: refs/heads/master@{#441927}

Reload will delete Pending Item so altering it and reload will reload
the lastCommittedItem.
If there is a pending item, stop loading and trigger a new navigation.

BUG=678293

Review-Url: https://codereview.chromium.org/2610953002
Cr-Commit-Position: refs/heads/master@{#441926}

Browser actions will be reordered in a future change.

BUG=648558, 648563, 673362

Review-Url: https://codereview.chromium.org/2607533004
Cr-Commit-Position: refs/heads/master@{#441925}

It's not needed. ContextClient is used to detect if a frame is detached,
but we can check it with scriptState->contextIsValid().

BUG=610176

Review-Url: https://codereview.chromium.org/2614943003
Cr-Commit-Position: refs/heads/master@{#441924}

This class is only used for the RecentTabsPage.

BUG=659631

Review-Url: https://codereview.chromium.org/2612243002
Cr-Commit-Position: refs/heads/master@{#441923}

We're deprecating the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2619543002
Cr-Commit-Position: refs/heads/master@{#441922}

Moves the test code out of RangeCheck. Reorders range comparisons and
removes bitfields to avoid a GCC constexpr bug. Removes some custom
optimizations that are no longer necessary after the restructuring.

TBR=tsepez

Review-Url: https://codereview.chromium.org/2614073002
Cr-Commit-Position: refs/heads/master@{#441921}

We're deprecating the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2615713006
Cr-Commit-Position: refs/heads/master@{#441920}

There are crash reports that |m_resource| is broken in
ResourceLoader::didReceiveResponse. It is strange as ResourceLoader::m_resource
is constant after its construction. To investigate the issue, this CL adds some
CHECKs in ResourceLoader.

BUG=675947
R=tyoshino@chromium.org

Review-Url: https://codereview.chromium.org/2619513002
Cr-Commit-Position: refs/heads/master@{#441919}

If we pass in ScriptState to DOMWindowSpeechSynthesis::speechSynthesis,
DOMWindowSpeechSynthesis doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618613006
Cr-Commit-Position: refs/heads/master@{#441918}

When dismissing a suggestion through the context menu, it is possible
that by the time the animation ends, we navigated away from the NTP
and it got destroyed, resulting in an NPE. We now exit early when
that is the case.

This CL also reverts the ineffective tentative fix from
https://codereview.chromium.org/2553163002

BUG=668945

Review-Url: https://codereview.chromium.org/2614753002
Cr-Commit-Position: refs/heads/master@{#441917}

BUG=673904
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2610423002
Cr-Commit-Position: refs/heads/master@{#441916}

BUG=677908

Review-Url: https://codereview.chromium.org/2609403006
Cr-Commit-Position: refs/heads/master@{#441915}

This allows the compiler to compute the length of literal strings that
are compared and then we can early abort comparing if the length is
different.

This does introduce a strlen call for non-literal strings, which we
have very few of today.

This patch fixes the web idl enum checking loop to use WTF::equal to
avoid the strlen since that seemed like an easy way to remove lots of strlen
calls. We can make other callers use a similar approach in the future if
if we see strlen on profiles.

By code auditing (with code search method finding) I noticed a few other
places will now call strlen (ex. iframe sandbox and permissions attribute
parsing) but this patch opts not to convert all places we now call strlen and
instead go for the simple path of fixing those if we run into problems. This
is a similar trade off to code elsewhere in Chromium that uses
base::StringPiece which also puts a strlen call for non-literal strings.

I also took this as an opportunity to remove the operator== methods which aren't
used for things like LChar* (strangely UChar* was missing) and Vector<char>.

BUG=678266

Review-Url: https://codereview.chromium.org/2614123002
Cr-Commit-Position: refs/heads/master@{#441914}

BUG=678393

Review-Url: https://codereview.chromium.org/2611973003
Cr-Commit-Position: refs/heads/master@{#441913}

The Objective-C frameworks must be imported and not included.
Command to find Objective-C frameworks
dir="`xcode-select -p`/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/System/Library/Frameworks";
for f in `ls $dir`; do
  name=${f%%.framework};
  grep "^\s*#import " $dir/$f/Headers/$name.h > /dev/null 2>/dev/null;
  if [ "$?" = "0" ]; then
    echo $name;
  fi;
done

BUG=677965

Review-Url: https://codereview.chromium.org/2606753004
Cr-Commit-Position: refs/heads/master@{#441912}

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617103002
Cr-Commit-Position: refs/heads/master@{#441911}

BUG=none

Review-Url: https://codereview.chromium.org/2610923010
Cr-Commit-Position: refs/heads/master@{#441910}