- 29 Jan, 2018 40 commits
-
-
Mustaq Ahmed authored
Reasons for removal: - UserGestureIndicatorTest.Timeouts asserts the same check. - The removed test seems to have a sloppy time expectation. - This is blocking UserActivationV2 (with extended expiry). Bug: 804903 Change-Id: I8960e670772cb4a0bb306206e86a873e1c226f77 Reviewed-on: https://chromium-review.googlesource.com/881523Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#532480}
-
https://skia.googlesource.com/skia.git/+log/ba3ed69a4ee4..cca86f386cfd $ git log ba3ed69a4..cca86f386 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 fmalita [skottie] Hierarchical animators 2018-01-29 egdaniel Blacklist additional perf skp on win Intel Vulkan 2018-01-29 egdaniel Remove Ops whose lazy proxies fail to instantiate on flush 2018-01-29 kjlubick Disable flaky perf benchmark 2018-01-29 angle-skia-autoroll Roll skia/third_party/externals/angle2/ ffa4cbb6f..d1434c048 (6 commits) 2018-01-29 fmalita Revert "[skottie] Cache attached assets" 2018-01-29 bsalomon Allow printf style var args for messages in REPORTER_ASSERT. 2018-01-29 fmalita [skottie] Reduce parser verbosity 2018-01-29 egdaniel Add createTextureProxy function to ProxyProvider that takes an SkImage 2018-01-29 ethannicholas fixed creating a vector from another vector in SPIR-V output Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I36366d9be68d3c011f892a19dc65a8e8d13e3598 Reviewed-on: https://chromium-review.googlesource.com/890821Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532479}
-
Mirko Raus authored
With tablet style Bookmarks modified in: https://codereview.chromium.org/2837643002 Bookmarks tests need to be modified. Bug: 806217 Change-Id: I761e7fdade7a311d65b4411be2d98b3cffe071d0 Reviewed-on: https://chromium-review.googlesource.com/889338Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532478}
-
Sylvain Defresne authored
os.path.getmtime(path) returns a float value with non-zero fractional timestamp when using APFS+. Truncate the value when comparing to the saved timestamp in remap file. Bug: 324079 Change-Id: I92e100548d96d66df0da2d72258015763a5b6d5c Reviewed-on: https://chromium-review.googlesource.com/891358Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#532477}
-
Michael Wasserman authored
This reverts commit 751cc857. Reason for revert: Incorrect speculative revert. The actual change causing this failure was likely http://crrev.com/c/887282 for Issue 805937 That CL actually touched the failing test, and its revert caused the bot to pass: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25915 I'm reverting this seemingly incorrect speculative revert of my CL. Original change's description: > Revert "mus: Fix event processing for touch events in unified mode" > > This reverts commit 1423331f. > > Reason for revert: speculative attempt due to unhappy MSan ChromiumOS bot. > See also crbug.com/806638. > > Original change's description: > > mus: Fix event processing for touch events in unified mode > > > > This refines my earlier work done in: http://crrev.com/c/842467 > > > > Move event target nulling and root location use to WindowTreeClient, to ensure events reach MusUnifiedEventTargeter. > > Otherwise, WindowEventDispatcher::GetInitialEventTarget will use the touch gesture recognizer's target (returned by GetPriorityTargetInRootWindow) before performing the mirror display transformation on the event's location. > > > > Inline DispatchEventToTarget for additional clarity. > > > > Bug: 805714 > > Test: Mus touch events work in Chrome OS's unified desktop mode. > > Change-Id: Ic4844c85cc24a9f9885e7705ff27cb57b305d245 > > Reviewed-on: https://chromium-review.googlesource.com/887250 > > Commit-Queue: Michael Wasserman <msw@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#532030} > > TBR=sky@chromium.org,msw@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 805714 > Change-Id: I02333546f91d0d0f495153c8556aa9820612673d > Reviewed-on: https://chromium-review.googlesource.com/890841 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532328} TBR=sky@chromium.org,msw@chromium.org,shimazu@chromium.org Change-Id: I6c7b91429abdddb4f9db881c40c64f53141bc707 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 805714 Reviewed-on: https://chromium-review.googlesource.com/890822Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#532476}
-
Adithya Srinivasan authored
A variant of this was originally generated by clusterfuzz (https://crbug.com/803352), and caught a bug in https://crrev.com/c/829613. This test tests nameditem cache invalidation for form control collections, even after their form owner is disconnected from the document. Change-Id: I2b3389926e2bed9dd9173a9f26649c5aa55526c6 Reviewed-on: https://chromium-review.googlesource.com/878661 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532475}
-
Peter Beverloo authored
The serialization contains the p256dh and auth values of the push subscription encoded per base64url. Normally it's valid to keep the trailing equal-sign padding, but the Push API specifically forbids this. Bug: 801555 Change-Id: I370f01b6aa398ccd407502c967391ea573352381 Reviewed-on: https://chromium-review.googlesource.com/868295 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532474}
-
Jeremy Roman authored
For consistency between the methods, have all converters take v8::Isolate*, as all of the ones that presently take v8::Local<v8::Context> implicitly assume it to be the current context anyhow. Bug: None Change-Id: I565fb54bdc7a1d5ac1796ef5d7c1c69ca83290bb Reviewed-on: https://chromium-review.googlesource.com/876563 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532473}
-
Emily Hanley authored
Bug: 806257 Change-Id: Ia59da0cc8e3f5892aa1d250958bec6619ecc3ab2 Reviewed-on: https://chromium-review.googlesource.com/888097Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#532472}
-
Nico Weber authored
This CL was uploaded by git cl split. R=dmazzoni@chromium.org Bug: 177475 Change-Id: I4d9385c71c2cdb2202a768f547636bb8ecb3d298 Reviewed-on: https://chromium-review.googlesource.com/889949 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#532471}
-
Elly Fong-Jones authored
These source files produce object files with names that conflict with views object files when both are linked into the same product, so rename them to avoid those conflicts. This is a part of the broken-up CL 874730. Bug: 804950 Change-Id: Ic8967241efbe43a5a86bc76fd951296687c24e22 Reviewed-on: https://chromium-review.googlesource.com/889735Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#532470}
-
Takuto Ikuta authored
This is follow up of https://chromium-review.googlesource.com/612493 We want to use the config around L923. strip_debug_info is important to improve link time for buildbot having slow disk throughput. This fix improves link time of some large binaries on android_n5x_swarming_rel. With this fix: https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/349367 build stats are taken from https://chromium-build-stats.appspot.com/ninja_log/2018/01/29/slave613-c4/ninja_log.slave613-c4.chrome-bot.20180128-192032.27201.gz/table?dedup=true - link time of android_clang_arm/libwebviewchromium.so : 1m14.193s - link time of android_clang_arm/libmonochrome.so : 36.539s Without this fix: https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/349369 build stats are taken from https://chromium-build-stats.appspot.com/ninja_log/2018/01/29/slave153-c4/ninja_log.slave153-c4.chrome-bot.20180128-192916.30766.gz/table?dedup=true - link time of android_clang_arm/libwebviewchromium.so : 2m31.189s - link time of android_clang_arm/libmonochrome.so : 1m33.087s Change-Id: Ie180c37ff7924c7577ecbfe18da80a2bc4c20a98 Reviewed-on: https://chromium-review.googlesource.com/890687 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#532469}
-
Simeon Anfinrud authored
This permission is unneeded now that the system settings menu is using the leanback preference library. Bug: 72498412 Test: Install Cast apk on Android TV with OPR2 and access Cast settings menu. Change-Id: Ib9955bec23394c4ca232aced20e0798d7cbad261 Reviewed-on: https://chromium-review.googlesource.com/889987Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532468}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/6e8a3e62e171..dbac8ca4f5d7 $ git log 6e8a3e62e..dbac8ca4f --date=short --no-merges --format='%ad %ae %s' 2018-01-29 rharrison Fix typo introduced in cleanup of IsHyphen Created with: roll-dep src/third_party/pdfium BUG=805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I889d9a09816c347b29c300e25a372bae61acb5db Reviewed-on: https://chromium-review.googlesource.com/891299 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532467}
-
Jayson Adams authored
The recent change to separate TabWindowController from NSWindowController also removed it from the responder chain. As a result messages like swipeWithEvent: no longer reached the BrowserWindowController BWC. This cl reinserts the TabWindowController into the responder chain, before the window's NSWindowController. Bug: 805241 Change-Id: Ifa46d3e66ad306f26d860fe196f445e76fe293a4 Reviewed-on: https://chromium-review.googlesource.com/887326 Commit-Queue: Jayson Adams <shrike@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532466}
-
Julia Tuttle authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/853172 which was rolled back as part of https://chromium-review.googlesource.com/c/chromium/src/+/879041. Bug: 799616 Change-Id: I5dae7cd41b55dd2151a06e0f708743cd19b85b41 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/881401 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#532465}
-
Sahel Sharify authored
I wasn't able to reproduce the failures on my local windows official build and that's why I think this might be a timing issue with other machines. Bug: 800822 Change-Id: I46d4c58e8169897b613045553dfbaf131de46089 Reviewed-on: https://chromium-review.googlesource.com/880885 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532464}
-
Julia Tuttle authored
Apps should be able to use NEL, but they shouldn't share state with the main request context. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/875050 which was rolled back as part of https://chromium-review.googlesource.com/c/chromium/src/+/879041 Bug: 875050 Change-Id: Ibcdcf852cea1d8da16f812d175a15d4bdefd3e14 Reviewed-on: https://chromium-review.googlesource.com/881402 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#532463}
-
John Z Wu authored
One test that verifies fetching, filling, and clearing. Bug: 778764 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icc484e63fc0787bdfcedca95a15528111e4d7dcb Reviewed-on: https://chromium-review.googlesource.com/841342 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#532462}
-
sczs authored
Everytime a swipe to navigate gesture is started fullscreen will be disabled causing the Toolbar to show. This CL also updates the ToolbarModel state to reflect that the toolbar is being shown when the model is disabled, this includes updating y_contest_offset even when the model is disabled. ToolbarModelUnitTests have been updated accordingly. Bug: 799088 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icfe7f6caafcc6113b7c2909472fcbb1a0384cb79 Reviewed-on: https://chromium-review.googlesource.com/879126 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532461}
-
Raymond Toy authored
Move the mostly common test code into one method and use it for testing all of the valid and invalid attributes for the stereo panner. Bug: 717655 Change-Id: If6d6347d1fe303bc1c79acf141aa12ce3b04259c Reviewed-on: https://chromium-review.googlesource.com/879535Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#532460}
-
sangwoo.ko authored
When global FindPboard is updated, find result is cleared and next/prev buttons are disabled. But this makes users unabled to find the exact string without editing text. So enable buttons unless the text from pboard is empty. Bug: 739735 Change-Id: Iad72ae1e0a88165774fecd21fe26c3a2949c60c4 Reviewed-on: https://chromium-review.googlesource.com/888229Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#532459}
-
Peter Wen authored
This reverts commit 78988928. Reason for revert: Broke clank downstream unused resources Original change's description: > Android: Remove unused strings > > Update suppressions from android_tools upgrades resulting in unused > resources (mostly strings) being left behind after their feature is > removed. > > Also update some suppressions as expected. > > BUG=799070,806060 > TBR=nyquist@chromium.org > > Change-Id: I30d35320ad20b318a921972529f139b3b3e65453 > Reviewed-on: https://chromium-review.googlesource.com/886863 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532433} TBR=nyquist@chromium.org,wnwen@chromium.org,twellington@chromium.org Change-Id: I0681082ac3fdfe80d1ad6f3ba182e81f75678dce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799070, 806060 Reviewed-on: https://chromium-review.googlesource.com/890660Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532458}
-
proberge authored
This effectively makes user script extensions show up in the tab bar. Bug: 801861 Change-Id: I8fd4df034eee07403cda0a0eabef2d68ff5f272a Reviewed-on: https://chromium-review.googlesource.com/886651Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#532457}
-
Ovidio Henriquez authored
This change migrates the requestDevice tests to wpt/. BUG=509038 Change-Id: I0e7647be7525031aaedc76d3f0396305ae4070f0 Reviewed-on: https://chromium-review.googlesource.com/837581 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#532456}
-
Ovidio Henriquez authored
This change migrates the generated GATT service tests into wpt/. BUG=509038 Change-Id: I6b162df88bc8677dd8dfa1102bb7e23939e37ac3 Reviewed-on: https://chromium-review.googlesource.com/843416 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#532455}
-
Ian Kilpatrick authored
Introduces V8ObjectParser which contains the parsing utility functions. Change-Id: I812e87536e768f226cf76142c213d0c3e15ae259 Reviewed-on: https://chromium-review.googlesource.com/887749 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532454}
-
vasilii authored
The flag was responsible for viewing passwords in the settings on Android and iOS. The feature was launched and we don't need the flag anymore. Bug: 739404 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0ec8c0aaafa8b0520ee2d0f684893e022df5a0d8 Reviewed-on: https://chromium-review.googlesource.com/891235Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532453}
-
Robert Kroeger authored
When --mus mode is enabled, the window server thread (aka mus) serves as the ozone host. However, the DisplayCompositor continues to run on the Chrome UI compositor (pending OOP-D completion.) As a result, the DisplayCompositor's dependencies on ozone need to use a different message pipe to communicate with the DrmDevice service. This CL adds the creation and use of this additional mojo pipe when necessary. BUG=620927 Change-Id: I4ebd0b7fc060cfff60a75796d5431d0f919f113e Reviewed-on: https://chromium-review.googlesource.com/885261 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#532452}
-
vitaliii authored
Expect virtual/gpu/fast/canvas/canvas-strokePath-shadow.html to timeout on Linux, because it timeouts flakily. TBR=senorblanco@chromium.org Bug: 806017 Change-Id: Ic7a07258c6be31a257888f1ff298edb990bcd653 Reviewed-on: https://chromium-review.googlesource.com/890447 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532451}
-
Sigurdur Asgeirsson authored
The preference lossy, and so shouldn't cause extra writes. It is updated with the beacon value, and may optionally be autoupdated on a very slow schedule. Bug: 799526 Change-Id: I23382a3174f140ac9a137025988b4037493f1e8f Reviewed-on: https://chromium-review.googlesource.com/887347 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#532450}
-
Artur Khachatryan authored
Test testLoadsPage in class HeadlessInvalidCertificateTest fails on Android chromium build. Disabling all tests for that class. Change-Id: Ic56c16512025164bb0cd317642cced67ef018f00 Reviewed-on: https://chromium-review.googlesource.com/887946 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532449}
-
Anita Woodruff authored
- These so-called 'notification IDs' were *not* created by the NotificationIdGenerator and are therefore not notification IDs. Stop calling them this. Change-Id: I75b0a63cd8b3aa161814619be7fc1fc83cfe5392 Reviewed-on: https://chromium-review.googlesource.com/889458 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#532448}
-
vitaliii authored
Disable DumpAccessibilityTreeTest.AccessibilityIframePadding in Win, because it fails flakily on Win7 and Win10. TBR=dmazzoni@chromium.org Bug: 805998 Change-Id: I05e798cf1249cc8d568c4ed580f0041606cfba3f Reviewed-on: https://chromium-review.googlesource.com/891318 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532447}
-
jonross authored
We want to gain FYI coverage of Viz on Mac. So that we can identify any flakes before enabling on the CQ TBR=sky@chromium.org TEST=viz_browser_tests, viz_content_browsertests, viz_content_unittests Bug: 760181 Change-Id: Ic8abfafbd3bc66fbb9f5e5af45b9716301532e18 Reviewed-on: https://chromium-review.googlesource.com/886658Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#532446}
-
Aga Wronska authored
Add logic to hide shelf on secondary display to ShelfWidget. Add logic to hide system tray on secondary screen to LoginScreenController. Set hide state for shelf on secondary display in ShelfLayoutManager::UpdateVisibilityState(). Otherwise system tray will be displayed on secondary display despite calls from LoginScreenController. Bug: 796239 Change-Id: I941507860e2b4800a1f396ff3e8d6bdf09d95fda Reviewed-on: https://chromium-review.googlesource.com/885581Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#532445}
-
Aga Wronska authored
Update color of scroll bar and make the edges of scroll thumb rounded. Show scroll bar only upon hover. Bug: 792742 Change-Id: I80f88e9e0ffe16202401e385593bcc736840a2f2 Reviewed-on: https://chromium-review.googlesource.com/887249 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#532444}
-
David Benjamin authored
I noticed these scroll by: ../../components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java:203: warning: [NullablePrimitive] @Nullable should not be used for primitive types since they cannot be null @Nullable ^ (see http://errorprone.info/bugpattern/NullablePrimitive) Did you mean to remove this line? ../../components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java:848: warning: [ShortCircuitBoolean] Prefer the short-circuiting boolean operators && and || to & and |. return state == State.COMPLETE | state == State.ERROR | state == State.CANCELLED; ^ (see http://errorprone.info/bugpattern/ShortCircuitBoolean) Did you mean 'return state == State.COMPLETE || state == State.ERROR || state == State.CANCELLED;'? ../../components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java:215: warning: [NullablePrimitive] @Nullable should not be used for primitive types since they cannot be null @Nullable ^ (see http://errorprone.info/bugpattern/NullablePrimitive) Did you mean to remove this line? Bug: none Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ie3aa3a6004fa5ed094f45c259522d3282023eb99 Reviewed-on: https://chromium-review.googlesource.com/890361Reviewed-by:
Miriam Gershenson <mgersh@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#532443}
-
Helen Li authored
ProxyResolvingClientSocket creates a fresh HttpNetworkSession for each socket. This is very expensive. This CL creates a factory class which takes care of creating network session, so it can be shared across different socket instances. This will also make mojoifying this class easier because NetworkContext can be re-used. A follow-up CL will disable H2 and QUIC proxies on the HttpNetworkSession created for this purpose (more please see linked bug). Bug: 793066 Change-Id: I7b942db3246915abd0ce755ca1f9f29349b50776 Reviewed-on: https://chromium-review.googlesource.com/860198Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#532442}
-
Philipp Hancke authored
Removed all code in adapter.js that was not for Chrome, for very outdated versions of Chrome or not used anywhere. This file is a very old version of the project now residing on https://github.com/webrtc/adapter Bug: 690582 Change-Id: I21fa60fd86962dadbcec1650201fc13e932b736e Reviewed-on: https://chromium-review.googlesource.com/889755Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#532441}
-