- 15 Aug, 2019 40 commits
-
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLMapElement> and DynamicTo<HTMLMapElement> as new downcast helper. 2. Use IsA<HTMLMapElement>(element) in place of IsHTMLMapElement(element). Bug: 891908 Change-Id: I59c06892f8ea7fcac84c532f1f4f6eb8b87a24d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755431Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#687258}
-
Saman Sami authored
When we don't have a current context, g_current_gl_context is not null. Instead, it's an instance of NoContextGLApi. In ExternalVkImageBacking ::Destroy, don't check that g_current_gl_context is null. Always call MakeCurrent. Bug: 939442 Change-Id: Icc4cc15daec78f32697d56cc102718cf5b0a229b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754708Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#687257}
-
Mike Frysinger authored
Currently if a node parsing logic fails in an unexpected way, we just show the exception name. This isn't super useful by itself as it lacks specific context, so include the exception value too. In the case of missing files, this will be the filename that the code was unable to locate. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: Id9b9fd3370c648099ded6bafa816323bdf0de96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755392Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#687256}
-
Mike Frysinger authored
We're running an integer through oct() to get a string of the octal number, which we then pass to int() to parse as a decimal number so we can finally pass to %d to get a padded string. 195 -> '0303' -> 303 -> '303' This relies on the exact output format of oct() which breaks when using Python 3 -- it outputs '0o303' which int() rejects. We can simplify this greatly by just switching from %d to %o and letting Python do the translation for us. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I9c379d0962819e69eed2890bc2369784c0a95ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755384Reviewed-by:
-
Lily Chen authored
Bug: 990439 Change-Id: Ibf7f5a23486f3d55d728c02c5d03bc34b1a4cfa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753590Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#687254}
-
Tim van der Lippe authored
This is a reland of c7f781ee third_party/blink/web_tests/http/tests/devtools/extensions/extensions-panel.js has been fixed Original change's description: > Fix eslint and Closure compiler warnings > > Some functions that were globally scoped were not properly type-checked. > Adding these to the `externs.js` makes sure that these are now > type-checked (just like `ls` has been up to this point). > > This is in preparation of an upcoming change to run `eslint` and Closure > compiler in `module`-mode rather than script mode. > > Change-Id: Ic2d9dba24c7aae3c6024c3caeea2b042f401b3c5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748895 > Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> > Commit-Queue: Erik Luo <luoe@chromium.org> > Reviewed-by: Erik Luo <luoe@chromium.org> > Auto-Submit: Tim van der Lippe <tvanderlippe@google.com> > Cr-Commit-Position: refs/heads/master@{#686839} Change-Id: I26df62e5a315992d1b32e19671bee6f608550385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755904 Auto-Submit: Tim van der Lippe <tvanderlippe@google.com> Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#687253}
-
chrome://versionFrancois Doray authored
A BEST_EFFORT task can be preempted when resources are needed for higher priority tasks, for example during startup. That means that it is not an appropriate priority for a task that produces a user visible result. The appropriate priority when the result of a task is visible to the user is USER_VISIBLE. Bug: 990313 Change-Id: Id5de1feac5db052f5069480baf17576c68bd3f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752631 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#687252}
-
Miyoung Shin authored
This CL converts BackgroundFetchServiceRequest and BackgroundFetchRegistrationServicePtr in content to new Mojo types. Bug: 955171, 978694 Change-Id: Ieedb56f6b7db6f57145137655f4dd98cfb12dd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752571Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#687251}
-
Gabriel Charette authored
This reverts commit 1d132585. Reason for reland: build failure is because this CL landed at the same time as crrev.com/686824 which changed the semantics for HasTrait() Change-Id: I97c7cc0b41de444c31cd64017f0a3ab9e9be4093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754095 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#687250}
-
Fernando Serboncini authored
- Pass filter quality on CanvasResourceProvider creation. - CRDispatcher sets the frame to be nearest_neighbor if pixelated. - transferControlToOffscreen passes image rendering quality to Offscreen. This does not propagate changes from Canvas element to Offscreen yet, which will be addressed in a follow up CL. Bug: 645994 Change-Id: I9868f03120b0e345251366f27233804f9b41ad66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752122 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#687249}
-
Chris Hamilton authored
BUG=910288 Change-Id: I5832031effe223653d9c718b0a9044dd235994ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752942 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#687248}
-
Navid Zolghadr authored
Bug: 984417, 978289, 984417, 945676 Change-Id: I4e62da1b30cee1fe946a83af196e4e8f398234e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754510Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#687247}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0c036c43f7f8ac1a2eb4d0c409c91350f3fac3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755548Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687246}
-
Yuki Shiino authored
The new IDL compiler found out several issues in existing *.idl files. This patch fixes those *.idl files. Change-Id: Ib3a1f5695b345c3fef4a6571116b9f0a6af66090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755789Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#687245}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ie8da144b41120418426798f9299164da0d0b443a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756146Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687244}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8677b439ba31..75b6f212c853 git log 8677b439ba31..75b6f212c853 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 bclayton@google.com SpirvShader: Fix another edge case with phis and loops 2019-08-15 bclayton@google.com VkPipeline: Use vk::warn for spirv-opt warnings / errors Created with: gclient setdep -r src/third_party/swiftshader@75b6f212c853 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139424793,chromium:b/139424793 Change-Id: Ibc1cc6f48d8d3f515ef7a01264d39d7fcbc98047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755549Reviewed-by:
-
Nicolás Peña Moreno authored
This CL fixes the loadTime of background images for the LargestContentfulPaint web API. The StyleFetchedImage is now needed in the OnImageLoaded() method. Instead of computing the timestamp again, we query it from the ImageElementTiming class. This should be populated whenever ElementTiming is enabled. While it is still behind a flag, it is set to 'stable' so it should be on by default. A test is added to ensure that the loadTime is populated properly in a case where it wouldn't be previously. Bug: 965505, 986891 Change-Id: I7c3421006cec0dbd79c50a21ae055f11b7ce3ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752295Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#687242}
-
Yann Dago authored
Transfer the responsibility to set default policies into PolicyService. The decision is made using a EnterpriseUsersDefaultDelegate injected into the PolicyService. The ProfilePolicyConnector acts as EnterpriseUsersDefaultDelegate. For Chrome OS, the resulting behavior is not changed - enterprise user defaults are set if the profile is managed. For android and Desktop platforms enterprise user defaults are set if the profile managed. Bug: 980132 Change-Id: I134125ed0dbe22149eb36459b45268244afc5954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706575 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#687241}
-
Pavel Shmakov authored
TBR=tedchoc@chromium.org Bug: 994184 Change-Id: Iea2d5b84c5020d20fd5d7ad361c15f8d6e97493b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755747Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#687240}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c446588b7f8a..f714c29b97d0 git log c446588b7f8a..f714c29b97d0 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 khokhlov@google.com Merge "Trace processor: Use varint encoding for string size in StringPool" Created with: gclient setdep -r src/third_party/perfetto@f714c29b97d0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibcb67af5cd1ab971abb11552f11fcec1ed40913b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755366Reviewed-by:
-
Gabriel Charette authored
ScopedTaskEnvironment => TaskEnvironment SingleThreadTaskEnvironment == TaskEnvironment{ThreadingMode::MAIN_THREAD_ONLY} TestBrowserThreadBundle => BrowserTaskEnvironment Updated documentation. The filenames were left as-is in this file and will be renamed in a follow-up CL that mass renames users on top-of-tree. We could have moved the files and added back scoped_task_environment.h for the redeclaration but that would have clobbered git history. So this approach was preferred. Lastly, had to redeclare old names as subclasses instead of using using-decls because using-decls aren't compatible with fwd-decls used in a few tests throughout the codebase. R=dcheng@chromium.org Bug: 992483 Change-Id: Id408970df116ca66a1c2e150f7d2683aa93cac2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747171 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#687238}
-
Richard Knoll authored
To support loading apps on other platforms, the query for sharing apps needs to be async. This will delay opening the dialog until we got the list, which is the same behavior as for the context menu on ChromeOS. Bug: 993313 Change-Id: I6f3536ae51d75c0970f0fa3d570f773649cd9a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754031 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#687237}
-
Richard Knoll authored
Some more logic can be shared between implementations of the base controller. This makes its api a bit easier and removes some duplication. - Message sending is handled in the base class now - Removed obsolete includes and members - Loading state is automatically handled now - Moved internal state into private base class members Bug: 988461 Change-Id: If713788c8b54f09af27e2a14ddfed96a447184e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754014 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Richard Knoll authored
Native system apps have icons that are not available as vector icons. This adds support for using gfx::Image as an app icon to show in the sharing dialog app list. Bug: 993309 Change-Id: I5b131731e65db639486439932e28700c0d206fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752836Reviewed-by:
-
Eric Willigers authored
The CSS Box Model Module Level 3 spec was updated in August 2018 to allow percentages in padding-*. https://github.com/w3c/csswg-drafts/commit/5434e6a9752b6122cdd6f619431f1469af6aca7a Change-Id: I1cfcbf21e6ee8010cfcab500afffd22167f6187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755788Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#687234}
-
Joshua Pawlicki authored
--apps-gallery-url is set. Bug: 966017 Change-Id: Ibdd79784c4e2ed276cdaf78e1135665c7c6d0253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648743 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#687233}
-
Edvard Thörnros authored
In previous versions, the "repeat(n)" syntax was triggered via event even though it was a sync base. This has now been changed. There was also some minor inconsistencies with the naming of "sync bases" which now has been unified. This should result in more stable and faster animations since it doesn't have to rely on the asynchronous event system. Bug: 993702, 981522 Change-Id: I14a237e0d45a9b95550ebdd21afda5929d40a81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754023 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#687232}
-
Mike Frysinger authored
This doesn't exist in Python 3. The string form in all versions does what we need though, so normalize into that instead. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I4ac4ff210e7fce00130af588bdf7d5538e8d7f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755387 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#687231}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3f50099533d..201cdbb64614 git log f3f50099533d..201cdbb64614 --date=short --no-merges --format='%ad %ae %s' 2019-08-15 bsalomon@google.com Make GrSamplerState.h and GrRenderTarget.h private Created with: gclient setdep -r src/third_party/skia@201cdbb64614 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: I15cb9e87032d9bfaef97bcf8dc6c761c1f196386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755547Reviewed-by:
-
Mike Frysinger authored
These docstrings are shown directly to the user when an error is hit. That means the embedded newlines get passed along as-is and makes the output not nice. Clean them up in the few docstrings that get line wrapped. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I9a0a96fa871e9f31855b9f46dd16d273d53f7153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755383 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
henrika authored
We would really like to keep this histogram since it is used on a regular basis when tracking down audio issues in WebRTC-based real-time clients. Bug: 986520 Change-Id: Ia861c5c9806aa79d6e4f0d83b0c3e5f07c0eb258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753962Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#687228}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4208a66340bf..5a3cb6082190 Created with: gclient setdep -r src-internal@5a3cb6082190 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iea54848266a4aeaf0cf74afbf2d189ab1c902645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755365Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687227}
-
Leon Scroggins III authored
Bug: 993266 The fix already landed. Add a test. Change-Id: I07b4e9abc7b9a9d12334828b12546e9665b83751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754222 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#687226}
-
Dominik Röttsches authored
Move this from a reftest to our font matching harness, where it's easier to define the expectation and diagnose which fonts where selected. Tbr: eae Change-Id: If332b3d070df6a0bfc3bdaa22818e4e8cb9adfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755745Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#687225}
-
Dave Tapuska authored
Extensions and WebViews allow non same browsing instance frame lookups and things that require universal access won't necessarily have the same agent. BUG=970360 Change-Id: If9e7d450c9266a8f78568dac6f4d4fdac2df281f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707817Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yasmin authored
Bug: 992355 Change-Id: Ic258df6c77e77f7fe13d68e046e4ae0bce408aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755908 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Switch to timeseries reported under 'Speedometer2' test case, while we investigate why the summary metric (with no test case) is no longer reported. Bug: 994170 Change-Id: I9c11f9070406e9638bb9d433133a7016c31f97cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755982 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#687222}
-
Gabriel Charette authored
Now that TimeSource::MOCK_TIME fully mocks TimeTicks::Now(), there's no longer a need to inject fake clocks in ChromeOS components using a BootClock. Devirtualized BootClock (now always a "RealBootClock") and made it support time overrides natively. This cleans up test-only hooks that injected fake clocks and task runners (though the task runner hook was already unused, most likely because of prior improvements to main thread task runner mocking). Helps unblock https://chromium-review.googlesource.com/c/chromium/src/+/1747171 because implicitly casting TestBrowserThreadBundle* into ScopedTaskEnvironment* will break temporarily during the migration. Annotating with crbug.com/166153 too to remind us to remove BootClock in favor of whatever boot-time vs awake-time API we settle on for time.h. Bug: 992483, 166153, 993371 Change-Id: I85cd7d32d334773c74f08145f7758ef9c699ef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751503 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#687221}
-
Stephen Chenney authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1590415 When a document loads, there is a significant period between when the frame is created and when the user sees content. During this time, the document is not processing lifecycle updates but Javascript is scheduled and the RenderWidget exists to handle input. A major concern is that users might click on some place where there is something reactive laid-out and available for hit testing and processing (an ad, a link, start a video) before they have actually seen anything to click on. Think of something like a last ditch attempt to click on something on the page you're navigating away from only to hit something on the page you're navigating to. It seems safer to avoid this rather than have unexpected and potentially very nasty behavior. In theory this situation was possible before with deferred lifecycle updates though it apparently never warranted concern. But we're preparing to enable the flag that defers the first compositor commit until we have some content ready to raster (or a timeout), in which case document lifecycles are running and there is content there to hit-test against and send events to, but the user hasn't seen it yet (for half a second at most, right now). This patch suppresses all input from the time when RenderWidget navigates to a frame to the time we are notified of the first compositor commit and paint, which is the best estimate we have for the user seeing something. This patch may affect the FirstInputDelay (FID) web platform metric. FID may improve because dropped input won't be measured at all, and the delay for the first event we actually process will be smaller because it will come when the system is less stressed. i.e. after initial layout and paint. Regardless, the impact on FID will be monitored when this patch lands. A command line switch is added to allow early input for tests. Many tests are flaky with this patch because they do not reliably wait for input, and in some cases we cannot easily modify the tests to wait (for example, web_tests and Android java-based tests). The open issue crbug.com/987626 exists to burn down the set of tests needing the flag, and possibly remove it. Sheriffs, please to not revert this for flakiness. Flakiness can be addressed by modifying individual flaky tests with the "allow-pre-commit-input" command line flag. Bug: 958424 Change-Id: Iea30f5b3bb2b1505a7ab7bfe749d0700f6db1027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729803 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL converts implementations of gamepad.mojom and related classes in the renderer process. Major changes are as below, - Change mojo::Binding with mojo::Receiver - Change GamepadMonitorPtr with mojo::Remote<GamepadMonitor> - Apply mojo::PendingReceiver into GamepadMonitorRequest Bug: 955171 Change-Id: I8c305818f0c52d9b9e81dfa562ecf642150d29cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752280 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
