GitLab

New extension button should slide out from the right, instead of the left.
Adjust the button's initial frame accordingly.

BUG=429810

Review URL: https://codereview.chromium.org/738223002

Cr-Commit-Position: refs/heads/master@{#305062}

BUG=none

Review URL: https://codereview.chromium.org/741943003

Cr-Commit-Position: refs/heads/master@{#305061}

Unused.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/740863003

Cr-Commit-Position: refs/heads/master@{#305060}

SuggestionsServiceFactory::GetForProfile() returns nullptr if
Profile::IsOffTheRecord() is true. So when another factory or
client code use the helper method to get the service, it gets
a nullptr.

The SuggestionsServiceFactory::GetBrowserContextToUse() test
happens only in the GetServiceForBrowserContext() call, and
thus does not happens when client code use this helper method.

The only situation where GetBrowserContextToUse() could be
called is if code directly call GetServiceForBrowserContext
or if ServiceIsCreatedWithBrowserContext() were overridden
to returns true.

Since none of those two conditions are true, then the method
is never called with an off-the-record Profile and the default
implementation inherited from BrowserContextKeyedServiceFactory
does the right thing (i.e. returns nullptr, which in turn cause
GetServiceForBrowserContext to return nullptr).

BUG=None

Review URL: https://codereview.chromium.org/744033002

Cr-Commit-Position: refs/heads/master@{#305059}

Revert of Add chrome sync tests to the GN build. (patchset #3 id:40001 of https://codereview.chromium.org/717923006/)

Reason for revert:
This seems the most likely culprit behind sync_integration_test build and test errors that started in the patch that included this change.

Original issue's description:
> Add chrome sync tests to the GN build.
>
> This adds sync_integration_tests, sync_performance_tests, and the sync test support targets.
>
> I removed some files that were duplicated between the sync integration tests and the test support. In GYP the fact that test support was a static library hid the duplicate symbols.
>
> Add a dependency on sessions_core from sessions test support since it's required to link. Made test support target be a source set (linking source sets into static libraries will often duplicate symbols).
>
> Committed: https://crrev.com/d60468061789084ebd98458b9743726cc1541786
> Cr-Commit-Position: refs/heads/master@{#304904}

TBR=scottmg@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/746563002

Cr-Commit-Position: refs/heads/master@{#305058}

Gyp variable mips_fpu_mode is currenty used and needed by v8.

BUG=
TEST=call build/gyp_chromium with GYP_DEFINES="target_arch=mipsel mips_arch_variant=r2"

Review URL: https://codereview.chromium.org/742133002

Cr-Commit-Position: refs/heads/master@{#305057}

This is a small webview-specific workaround that affects all drivers.
Will need a better driver/version specific workaround later.

BUG=434570

Review URL: https://codereview.chromium.org/722683004

Cr-Commit-Position: refs/heads/master@{#305056}

This CL makes the WeakPtrFactory check allow more than 1 WeakPtrFactory at
the end of the class, but still ensures that no other data members appear after the WeakPtrFactory(s).

BUG=303818

Review URL: https://codereview.chromium.org/740083002

Cr-Commit-Position: refs/heads/master@{#305055}

The data reduction proxy retries a bypassed request by creating
a new URLRequestHttpJob for the request and starting it. This
change uses URLRequestJobManager::CreateJob() to create that job.
Previously, the URLRequestJobFactory chain was called to create
the job, an it only would for main frame requests.

BUG=434830

Review URL: https://codereview.chromium.org/740643003

Cr-Commit-Position: refs/heads/master@{#305054}

For guest sessions (profile->IsGuestSession), we do not use
profile->GetOriginalProfile() for browser windows, we use the off the
record profile instead.

This was triggering an assert at the top of Browser::Browser().

BUG=434491

Review URL: https://codereview.chromium.org/741883002

Cr-Commit-Position: refs/heads/master@{#305053}

Specifically, this adds tests for:
  TruncatedMean
  Variance
  StandardDeviation
  StandardError

which were not covered before. I also added a couple notes about things
we may want to change in the behavior of the math_utils functions.

Still not covered is PooledStandardError, unit test coverage can be added
for that function in separate CL.

BUG=

Review URL: https://codereview.chromium.org/736573002

Cr-Commit-Position: refs/heads/master@{#305052}

Add some syscall wrappers instead of calling syscall() inline.
This adds some type safety and will make it easier to switch the
underlying syscall implementation.

This fixes a few issues with SYS_CLONE being called with the wrong number of
parameters.

BUG=435194

Review URL: https://codereview.chromium.org/684993005

Cr-Commit-Position: refs/heads/master@{#305051}

BUG=435174

Review URL: https://codereview.chromium.org/745683002

Cr-Commit-Position: refs/heads/master@{#305050}

Prior instrumentations showed that most of the jank for this bug comes from these lines in AboutSigninInternals::NotifyObservers
  scoped_ptr<base::DictionaryValue> signin_status_value =
      signin_status_.ToValue(client_->GetProductVersion());

Note that at least in Windows Canary, there are always 0 observers, and the value that we are calculating using a janky call is not used.

I'm almost certain that the cause of jank is in VersionInfo::GetVersionStringModifier, but I'm adding this last instrumentation to be 100% sure.

Reviewers, please feel free to stop me and start fixing the jank if you already know what's happening.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.

BUG=422460

Review URL: https://codereview.chromium.org/740783004

Cr-Commit-Position: refs/heads/master@{#305049}

BUG=427057

TBR=gab,isherman

Review URL: https://codereview.chromium.org/731663002

Cr-Commit-Position: refs/heads/master@{#305048}

BUG=318404
TBR=samuong@chromium.org

Review URL: https://codereview.chromium.org/744453002

Cr-Commit-Position: refs/heads/master@{#305047}

After the fix, jankiness disappeared from the task tracked by this bug.
Before the fix, jankiness of URLRequestSimpleJob::StartAsync was 18.1jph.

However, jankiness of URLRequest::Delegate::OnResponseStarted went up from 23.7 to 42 jph.
That task is tracked by another bug 423948.

This could mean the page fault exception that moved to another place.
I'm instrumenting the suspicious place mentioned in earlier conversations.

BUG=422489

Review URL: https://codereview.chromium.org/746483002

Cr-Commit-Position: refs/heads/master@{#305046}

This was removed in https://codereview.chromium.org/689463003 and then
accidentally reintroduced in https://codereview.chromium.org/668123003.

R=reveman@chromium.org

Review URL: https://codereview.chromium.org/737903003

Cr-Commit-Position: refs/heads/master@{#305045}

 * Add JSDoc.
 * Add EventType enum.
 * Create completeInit class to wait for initialization completion.
 * Add FileSelectionHandler#isAvailable.

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/736663002

Cr-Commit-Position: refs/heads/master@{#305044}

As of M39, Chrome is a 64-bit only binary. This changes the default build
configuration to 64-bit globally. After this CL, the 32-bit Mac build is no
longer supported.

BUG=405542,18323
R=mark@chromium.org

Review URL: https://codereview.chromium.org/730173002

Cr-Commit-Position: refs/heads/master@{#305043}

Requests for tabs permission for VirtualKeyboard. The URL of the current tab page is needed, and this permission grants it.

BUG=

Review URL: https://codereview.chromium.org/739323002

Cr-Commit-Position: refs/heads/master@{#305042}

Focus of this CL is on the PNaCl records that can appear in bitcode files.
A subsequent CL will add how the records are converted to bitcode sequences.

Replaces CL: https://codereview.chromium.org/364463002

BUG=None
NOTRY=True
(documentation only change).

Review URL: https://codereview.chromium.org/725333002

Cr-Commit-Position: refs/heads/master@{#305041}

This is a reland of https://codereview.chromium.org/715853002/

There are no changes, but the last attempt triggered some silent exit code
errors which have now been fixed by https://codereview.chromium.org/732473003/

This CL provides a more robust and efficient implementation of WriteFile,
also integrating the functionality of the (now removed) WriteTextFile.

BUG=267773

Review URL: https://codereview.chromium.org/744753002

Cr-Commit-Position: refs/heads/master@{#305040}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f84325cc..2c80aa8

TBR=timvolodine@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/740413002

Cr-Commit-Position: refs/heads/master@{#305039}

BUG=400619

Review URL: https://codereview.chromium.org/722703002

Cr-Commit-Position: refs/heads/master@{#305038}

After the fix, jankiness disappeared from this task.

BUG=422489
TBR=tony@chromium.org, danakj@chromium.org, thestig@chromium.org, finnur@chromium.org, michaeln@chromium.org, avi@chromium.org

Review URL: https://codereview.chromium.org/747443002

Cr-Commit-Position: refs/heads/master@{#305037}

BUG=435109
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/744863003

Cr-Commit-Position: refs/heads/master@{#305036}

BUG=384341

Review URL: https://codereview.chromium.org/726373006

Cr-Commit-Position: refs/heads/master@{#305035}

TBR=eroman@chromium.org, kalman@chromium.org, jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/744723002

Cr-Commit-Position: refs/heads/master@{#305034}

BUG=397107

Review URL: https://codereview.chromium.org/716053003

Cr-Commit-Position: refs/heads/master@{#305033}

This benchmark was broken when command line args got removed from
measurements.

NOTRY=True
TBR=tonyg@chromium.org
BUG=435108

Review URL: https://codereview.chromium.org/744103002

Cr-Commit-Position: refs/heads/master@{#305032}

media::VideoFrame may be scaled lazily by having natural_size < visible_rect.size. PepperVideoSourceHost currently ignores this and sends the full resolution to the effects plugin anyway. This CL makes PepperVideoSourceHost respect natural_size by downscaling the frame if necessary before sending it to the effects plugin.

TEST=Open the camera in 1080p with e.g. https://apprtc.appspot.com/?debug=loopback&video=minWidth=1920,minHeight=1080. Join a Hangouts. Natural size will be set to 720p and trigger a rescaling.

Review URL: https://codereview.chromium.org/736033002

Cr-Commit-Position: refs/heads/master@{#305031}

This will count the number of dropped frames and the number of decoded
frames. This provides a reasonable guarantee that the video pipeline is
working.

The next step would be to look at the actual pixels in the video.

BUG=434701

Review URL: https://codereview.chromium.org/738973005

Cr-Commit-Position: refs/heads/master@{#305030}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e097be5..9176e2c

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=humper@google.com

Review URL: https://codereview.chromium.org/743173002

Cr-Commit-Position: refs/heads/master@{#305029}

This code was used when Android native controls were
used for fullscreen video instead of html5 controls.

Review URL: https://codereview.chromium.org/739613003

Cr-Commit-Position: refs/heads/master@{#305028}

BUG=405566

Review URL: https://codereview.chromium.org/744683002

Cr-Commit-Position: refs/heads/master@{#305027}

Make the OverscrollRefresh effect take the target drag threshold as a
parameter. This isolates it from direct dependencies on the device scale
factor, making associated unit tests determnistics across all devices.

BUG=435125

Review URL: https://codereview.chromium.org/748433002

Cr-Commit-Position: refs/heads/master@{#305026}

BUG=378799
TBR=aboxhall
NOTRY=true

Review URL: https://codereview.chromium.org/725463004

Cr-Commit-Position: refs/heads/master@{#305025}

Future generations may grep for my userid, and the edited line is
vital to their research.

R=mmenke@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/741083002

Cr-Commit-Position: refs/heads/master@{#305024}

Revert of Enable loading V8's initial snapshot from external files on Linux. (patchset #2 id:20001 of https://codereview.chromium.org/735043002/)

Also partial revert of cl r304601 (https://codereview.chromium.org/734163007/) to remove snapshot files form Files.cfg.

Reason for revert:
Breaking PrintPreviewWebUITest on linux bots.

BUG=435167,421063,434985

Original issue's description:
> Enable loading V8's initial snapshot from external files on Linux.
>
> BUG=421063, 434985
>
> Committed: https://crrev.com/85e17b910590a0da3ed71b5f44e55cba79ea990d
> Cr-Commit-Position: refs/heads/master@{#305007}

TBR=baixo@google.com,baixo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=421063, 434985

Review URL: https://codereview.chromium.org/740403002

Cr-Commit-Position: refs/heads/master@{#305023}