- 30 Jun, 2020 40 commits
-
-
Lingqi Chi authored
Codes outside /service/network/ are using |CrossOriginReadBlocking::ResponseAnalyzer|, so this CL moves cross_origin_read_blocking.* to the public/cpp folder to meet the public rules. |AddExceptionForPlugin|, |ShouldAllowForPlugin| and |RemoveExceptionForPlugin| are not shareable for the security reason, they will remain in their original locations. Note: Ideally, we should use mojo but just moving shareable code to avoid performance regression. Bug: 1049894 Change-Id: I255d45bb0b3fd40b378b588d7dbe24f5e2c27c9a Tbr: karandeepb@chromium.org Change-Id: I255d45bb0b3fd40b378b588d7dbe24f5e2c27c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186830 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#783825}
-
Koji Ishii authored
|NGInkOverflow| was a simple struct of one or two |PhysicalRect|s, allocated as |std::unique_ptr|. This patch: 1. Changes it to a class of the size of a pointer, hidng details such as the number of rectangles it has, or the memory allocations. 2. When overflow is small, this class can store values without allocating memory. Overflows less than 4px (32 bits, 1024px on 64 bits) are "small". For example, all text at https://en.wikipedia.org/wiki/Google_Chrome are "small". When r2266052 crrev.com/c/782445 changed to copy |NGFragmentItem| instead of move, it involves memory allocation for ink overflow if the item to copy has overflow. This patch mitigates it in most cases. In this patch, the memory saving is only for text fragments. When leaves have overflows, their containers have overflows too. We can save memory for them too, but doing so involves slight behavior changes that it's not included in this patch. The performance is slightly positive, blink_perf.layout: https://pinpoint-dot-chromeperf.appspot.com/job/140794f7120000 This change has additional cost to check whether the overflow is small or not, and saves time and memory if small. In common cases, most overflows are small and results in net-positive. This change also improves sipmlified layout and reusing line cache by avoiding additional memory allocations. Bug: 982194 Change-Id: Id5d0d4492e0536e9fc363e7b9b1190d9e87453b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269451Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#783824}
-
Kent Tamura authored
Layout with 'Yu Gothic', 'Meiryo', and 'Noto Sans CJK JP' on Windows look fine. Bug: 1082087 Change-Id: If8da6fac1f13deb97776b6a3a9ecaf7637c859fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273039 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#783823}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9391fdb176d..d912aa91339c 2020-06-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I77a5be6eeafb0faf0b9e4b9a0be7e3e423c922b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275259Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783822}
-
David Black authored
Features enabled for teamfooding in this CL: - AssistantBetterOnboarding - AssistantTimersV2 Bug: b:157510970, b:149570650 Change-Id: I21b8c823afd4b8b5e030ff8ca7a78ed60a739ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252610 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#783821}
-
Artem Iglikov authored
The original way of tagging the traffic with uid or tag is through TrafficStats methods which modify a ThreadLocal variable. This makes the migration from HttpURLConnection to CronetHttpURLConnection easier as one wouldn't need to worry about the traffic becoming untagged. Setting uid is only supported on Android P+, as the required API is not available in the earlier versions. Change-Id: I82eeeb2d2ae7f3068260714cc7b36e02ff009a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265832 Commit-Queue: Artem Iglikov <artikz@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#783820}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593453566-5a3b62176029046ef3c78ea8aa3bef37e9aa6907.profdata to chrome-mac-master-1593475028-63728bbaf9d72e013a403087ba2956d3e5f5a26b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I02e460a18bcb3c1e9fc1a33cb97848b09167aca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274789 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Maggie Cai authored
There are mime type that only contain the main type or single *. They are treated as wildcard matching as well, e.g. image, *. This CL supports this. BUG=1092784 Change-Id: I0f3bdd81eb1f3bbc29f94e0b22206e3886dd5abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269443 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#783818}
-
Giovanni Ortuño Urquidi authored
js_data_deps were missing a dependency on one of the generator targets. This caused only one type of bindings to be generated when depending on the data deps. This was not the case when depending on the js library. Bug: 1002798 Change-Id: Ice6f16238eced9722a5c63c039f9e0f34705d4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269831Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#783817}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1c9e0450240d..b231c7fb717d 2020-06-29 cwallez@chromium.org Null: Make Increment/DecrementMemoryUsage use uint64_t. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1099621 Tbr: cwallez@google.com Change-Id: I3050e3ea52dff1211e7737b3aa58db883433875d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274651Reviewed-by:
-
Daniel Classon authored
Change-Id: Iea90d0d0e33a68a27c375f4a92ba35042e8f6b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274241 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#783815}
-
Sergey Ulanov authored
AEMU was enabled on main waterfall, but not on FYI bots. Enable AEMU on FYI x64 for consistency. Bug: 1096611 Change-Id: I337440d94b485af5a8506dc721f0085ed4b6c117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268583Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783814}
-
Mustafa Emre Acer authored
We currently treat an IDN label as safe if all its characters are same script. However, the characters might still be digit lookalikes. This CL adds an additional digit lookalike checks for these cases. This change doesn't impact any real world domains with more than 10 monthly users. Bug: 1100485 Change-Id: Ief3e136dbfd58ccc247fb94b2fab874189a095f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274617 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#783813}
-
Joon Ahn authored
If the first char of a full chunk happens to be '\0' it assumes the file is less than max_size and just returns chunk which is incomplete. Bug: chromium:1099000 Change-Id: Iaebbc1d908c9c6386cbacf151f3bb8c19000fb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271245Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#783812}
-
Eugene Zemtsov authored
Bug: 1042111 Change-Id: Ia6cd4a8c6fac17ad1245b1526aa1f76e294d3164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198535 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#783811}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/de622ae397a7..9e96ce180331 2020-06-30 dberris@chromium.org sched: Support per-configuration job concurrency If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:981429 Tbr: wenbinzhang@google.com Change-Id: Ib14c4fb780027884318cc8621699a531a9ee6a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275143Reviewed-by:
-
danielng authored
Adding UI features required for static microphone and camera permissions. When permissions are shifted to a dynamic model, much of this code will be changed/removed. Screenshots: https://drive.google.com/drive/folders/1m66pUVmnhGa1BRc1JABzYpgsvJk8OCKj?usp=sharing Testing: Implemented and ran browser-tests, tested UI locally Bug: 1071872 Change-Id: Ib882acc57896a3c273e5484d5ce242e08667febc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264175 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#783809}
-
Kunihiko Sakamoto authored
This moves the WebBundle parser from services/data_decoder/ to components/web_package/, a new directory under components/. This component will be used from blink (in addition to data_decoder), for Subresource loading with Web Bundles. Bug: 1082020 Change-Id: Idda32bff3ec2cf485149dd8d84d8169417d61a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255934 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#783808}
-
Owen Rodley authored
Bug: 1094768 Change-Id: I8040777617c66483d4611e8791b018a3fdf3bee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275358 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#783807}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Idb71c527a8c538ba12c4c68f87fddb31da717912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274819Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783806}
-
David Munro authored
Sometimes (when the system is under sufficient load, tests are running slow enough, the system is tickled the right way by swarming, and other things I haven't figured out yet), there is a chance that the Crostini Settings Subpage will be attached to the DOM (or at least, the attached method gets fired) *before* the SubPageDetails suite runs its setup to navigate to the page. When this happens the request for crostini installer status (fired by the subpage details attached event) happens before we attach a listener in the suite setup, so our listener hangs forever for a message that will never arrive. That behaviour isn't actually required for the tests to run so move the check from the suite setup into its own test, and check in a way that if it fails it fails, instead of hanging forever. Bug: chromium:1082575 Test: Browser tests Change-Id: I590a0aab8b6e4e0bfba2497a1706667201dfa3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274404Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/77e0c895b247..82ed9d9bb1f0 2020-06-30 xidachen@chromium.org [devtool] Change "FPS meter" to "Frame Rendering Stats" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5ed247077b85cbeba96687b92770f148135e5d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274790Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42bac92a0600..0f437404b0ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: peria@google.com Change-Id: Ia54f5eeb07778d045fcc33dc3e9d555a399393b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274472Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783803}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3a54b68cb436..10b7541a1edc 2020-06-29 brianosman@google.com Add proj() intrinsic (XY / Z), fix bug with perspective matrix sampling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I43bc3a39ced50bec3bd897d4f99a5d04d318a2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275140Reviewed-by:
-
Abhijeet Singh authored
When a Quick-Answer widget is showing above a context-menu within the browser, pressing the Up key will transfer the focus to this widget if the first menu-item is selected at the time. While it visually looks like the selected-item was cleared, pressing the Down key again selects the second menu item instead of selecting the first item again. This CL fixes that by adding an API to select the parent menu-item to update the menu's pending state as well, instead of only unselecting the current menu-item which would not affect the menu's state. Bug: 152057976 Test: Tested on Chrome OS VM. Change-Id: Id73682254a9503c0a458e7525204138859f6bb1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267454 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#783801}
-
Noel Gordon authored
The splitter button contains a 6-dot icon that has G Grey 300 color in files-ng design. Increase that to G Grey 400 to improve color contrast against the files-ng files app white background color. Bug: 1059691 Change-Id: I950f88856032150f2eab26414ec1bf1e90c903c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274124Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#783800}
-
Christopher Cameron authored
This function failed to update the image state. TBR=geofflang (previously landed as r783187) Bug: 1092155 Change-Id: Iac5ec5e7850e61e8f3c79c32713d9c7a9f435698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274586 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#783799}
-
Hiroki Sato authored
AX-Relnotes: n/a. Bug: b:159952661 Test: manual. The number appears in chrome://histograms. Change-Id: Ia25ed2a0eb428958e3675100f0b653fb5536370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269612 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#783798}
-
Peter Kasting authored
These will replace the versions in ui/gfx/geometry/safe_integer_conversions.h. Bug: 1088346 Change-Id: Ied8b5cbeff02fa870923976bb3ceb6fc8f98c340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274161 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#783797}
-
Maggie Cai authored
Currently intent only carry parts of the url and this causes lost of information of the query and ref parts. Change to carry url so that we don't miss these information when launch the app. BUG=1096848,853604 Change-Id: Id4226c2ac4e1c0e84ce78b6d19f41b238db9983a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265693Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
Most DwoC reports for https://crbug.com/1056949 seem to indicate that the request_initiator_site_lock has been set to an opaque, unique origin. This CL tweaks two code paths that can lead to such an opaque origin: 1. mhtml subframes 2. committing a browser-initiated navigation to an about:blank URL After this CL, the origins above will be derived from an artificial origin that should show up in crash keys of DwoC reports. This CL supplements r779447 which so far has come back empty handed. Bug: 1056949 Change-Id: I0b6eeb266ebe4d625b2a9a949f6fec0710872c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273486 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#783795}
-
Ella Ge authored
The field is never been used. Bug: 1007641 Change-Id: Ic3622502e98fc012c414d0fd0d0b0cf80f0a24ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273817Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#783794}
-
Kuo Jen Wei authored
Expose GetScreenState() method from ash::ScreenBacklight API. Let CameraAppHelper associated with each CCA app window monitor system screen state through API and report AUTO_OFF screen state changes to CCA Javascript side to open/close camera accordingly. Bug: b/158010019 Test: CCA camera preview is closed/open when close/open lid. Test: CCA camera preview is closed/open when click on power button. Test: CCA camera preview remain active when backlight brightness down to zero. Test: Verify all related behavior when external display is plugged in. Change-Id: I8daff03beae4f15a331af509e00c65588603ceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251599 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783793}
-
Joshua Bell authored
When iterating a forwards, comparisons are done between each record found and the range's bound to know when to stop. There's an special case for reverse cursors where a starting key is needed at the upper end of the range, so the uppermost key in the range is looked up as the starting cursor position. The code to do this for indexes was not guarded by a check for the cursor direction, though. This was harmless for most forward iterations as the uppermost actual key would match the upper bound anyway. But when iterating a cursor over a range in an index, records can change their index keys and thus appear again in the iteration. This would lead to the cursor stopping at what was no longer the actual uppermost key in the range, missing records in the iteration. Add the missing check, and a WPT to verify this behavior. (The code dates back to before 2013, so this is not a recent regression.) Bug: 1091731 Change-Id: I23336ba03d31607607d496fc7e18c28bcf644cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274085 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#783792}
-
Xiaocheng Hu authored
Bug: 1065508 Change-Id: If27098661c2edfc6f20f8ae2dff0f261599e308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270673Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#783791}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f64be08132ec..d9391fdb176d 2020-06-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If1b66ffa97f7f83a5ffa4c52a348cdfead538506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274175Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/58ff77a83502..e2de2c1c5473 2020-06-29 jonahr@google.com Fix disable_native_parallel_compile workaround condition. 2020-06-29 nguyenmh@google.com Refactor frame_capture_utils.h to frame_capture_test_utils.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1094869 Tbr: ianelliott@google.com Change-Id: Ibdc59cecf62662dc42a7e57e22ba476947674b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274468Reviewed-by:
-
Xida Chen authored
This Cl converts base::Bind to base::BindRepeating in banners/ This is a code health CL, no behavior change. Bug: 1007635 Change-Id: I52576f02d18bd51171c6b0d43a38f73ba0ada95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273485 Auto-Submit: Xida Chen <xidachen@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
dpapad authored
There is no benefit by using cr-input, as the UI of this element is heavily customized anyway, and none other features of cr-input are needed. Bug: 1100432 Change-Id: I9831a981dc790b83570a9d6645ffab1af2e290cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271105Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#783787}
-
Sammie Quon authored
These are continued to be use for performance measurement. Test: none Fixed: 1089982 Change-Id: I95aa09b5587b1171bd374520ba904dde3b3358cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274587Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#783786}
-
