- 01 Apr, 2020 40 commits
-
-
Xianzhu Wang authored
Previously kBackgroundPaintInScrollingContents from LayoutBoxModelObject::GetBackgroundPaintLocation() meant we should paint background in the scrolling contents layer only if the scroller was composited. It would be changed to kBackgroundPaintInGraphicsLayer if we found the scroller was not composited at multiple places. However, that didn't work for CompositeAfterPaint. Now save the the real BackgroundPaintLocation in LayoutObject bitfields (in place of previous PreviousBackgroundPaintLocation), and invalidate background when it changes. This fixes CompositeAfterPaint issue that background was painted in scrolling contents when the scroller was not composited. This also improves raster invalidation in some cases. Change-Id: Ide87d31f63eb14de909edd65aff1e88f1b44d984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127991Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755478}
-
Yicheng Li authored
In MakeCredential, if the authenticator has user verification "supported and configured" and the request is not u2f only, user verification requirement is forced to be "required". This change exempts platform authenticators from this enforcement. Change-Id: I7120e1a5c2ffd6064d29d47da64142918767a60d Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124236Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#755477}
-
danakj authored
The test changed with --enable-gpu-rasterization instead of --force-gpu-rasterization but the trybots didn't pick up the right expectations somehow on Mac 10.14? R=vmpstr@chromium.org Bug: 1066392, 866140, 1065893 Change-Id: I861106133411158802e10cc13fea3ddf609572da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129783 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#755476}
-
Sam Bowen authored
Change-Id: I4419da39a18a97bf764852ce87d7003f3813217b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131167Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#755475}
-
Philip Rogers authored
It is deadcode. Change-Id: Ia7db200d18526b457751148b0163025ce66f85f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132639 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755474}
-
Eric Roman authored
This reverts commit e315c666. Reason for revert: This allegedly increased the binary size on mac perf builder by 940 KiB (http://crbug.com/1066342) Original change's description: > Add quick check parameter to ConfiguredProxyResolutionService ctor > > Doing this cleans up an undesirable ConfiguredProxyResolutionService > usage pattern where code that primarily works with a > ProxyResolutionService must currently cast to the specialized class > before setting the right PAC quick check value. > > Bug: 1032820 > Change-Id: I777eb1c6097a604bf522e7d87f8806f4df0324b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113802 > Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> > Reviewed-by: Eric Roman <eroman@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753426} TBR=eroman@chromium.org,jam@chromium.org,mmenke@chromium.org,niarci@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032820 Change-Id: I1ad89c7ee4da76f34d8bf363cc824a2d5aea655a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132628Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#755473}
-
Hailey Wang authored
Add usage of MaxSimultaneousLoad threshold in BackgroundTabLoadingPolicy's loading logic. Bug: 1059341 Change-Id: I20f167142a32df59fbd2126c22a15936a5b744da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122479 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#755472}
-
Viktor Semeniuk authored
In this CL next bugs are fixed: - Passwords and username not aligned, - Missing divider after header section in password check, - Layout issues with RTL languages. Fixed: 1066779, 1066782, 1066788 Change-Id: I17eaacd576b22816390d4d2852fd783c9c9f0853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130853 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755471}
-
Caitlin Fischer authored
The tests in ukm_egtest.mm should be kept in sync with those in //chrome/browser/metrics/ukm_browsertest.cc. The test in ukm_browsertest.cc for which EG are being added is AddSyncedUserBirthYearAndGenderToProtoData. (A second CL will be sent for tests corresponding to those in metrics_service_user_demographics_browsertest.cc.) Bug: 1065870 Change-Id: I5ad386a0b96cbb1feea51676a908374d13863819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127247 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#755470}
-
Finnur Thorarinsson authored
Bug: 1006823, 656015 Change-Id: I47875b25a542ba6040eda7147449c7fb61d89024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132218 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#755469}
-
Nicolás Peña Moreno authored
This CL adds support for performance.eventCounts, gated behind the EventTiming flag. EventCounts is maplike and enables computing the number of input events that have occurred for any of the supported event types. It is populated on WindowPerformance::RegisterEventTiming so that it matches when timing with when the PerformanceEventTiming entry is created for slow events. The spec for this is here: https://wicg.github.io/event-timing/#sec-event-counts Bug: 543598 Change-Id: I95bd8b977556557811a1eff8d9fc5d106af0d2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125019 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#755468}
-
Etienne Pierre-doray authored
Bug: 1059767 Change-Id: I69880f5bb32cb6400138f1af0b2cf9da56a08c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129013Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#755467}
-
Sadrul Habib Chowdhury authored
In the previous change, the latency metrics from the UI were still being reported in the common CompositorLatency bucket. This was unintentional. Fix this to stop reporting the latency metrics for the UI compositor altogether. BUG=1005226 Change-Id: I42f21c0200723d9b72b17c9dd3027c379e890174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132626 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#755466}
-
Fan Yang authored
Change-Id: Ie8f1d0f26bb7e40176401a3520625aba500ff90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132527Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755465}
-
Mikhail Khokhlov authored
Isolate file generation fails with current setup (see crbug.com/1066246), because the uploader script is not a gtest test. Switch target type to 'generated_script' instead. Bug: 1050517, 1066246 Change-Id: I59b136a155e60751f69e343878906d4350dfe1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128114Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#755464}
-
Xida Chen authored
Currently we report throughput to UKM at: 1. 5 seconds after a sequence starts. 2. Every 500 seconds after that as long as the sequence lasts. The problem is that in many cases users stays on a page less than 500 seconds, and then we would only get the report for the first 5 seconds, which can be heavily biased by the page loading time. This CL is a temp solution to ignore the first 5 seconds, so instead we will report throughput at: 1. The second 5 seconds after a sequence starts. 2. Every 500 seconds after that as long as the sequence lasts. Bug: 1040634 Change-Id: I808b3ff56acce12c3a81e8fca5b7d472f4fcf4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129014 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755463}
-
George Steel authored
Make the implementations of CSSValueFromComputedStyle for background-position-x/y return correct values when three/four-value syntax is used with background-position. Since these properties only support single-value syntax, positions from the right or bottom will use calc() values if they result in mixed lengths and percentages when converted to be from the left/top. This is not the canonical form in the css-backgrounds-4 spec proposal, but does not require changes to the parser. Add a reftest (passes without patch) for three/four-value background-position syntax (there is currently only a manual test). Add another version of the reftest (fails without patch) which takes the above and attempts to write back the computed values of background-position-x/y. This is done in preparation to make transitions use normal keyframes which require round-trip serialization of all transition properties. Change-Id: I50e714746cc15fd0591bcd0a41cf9ecd56f55c44 Bug: 610627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121415Reviewed-by:
-
Renjie Tang authored
Change-Id: I99d8d77190b66eda62a5116a224ae23d94845d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128470Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f30cf017965..994bed549663 git log 4f30cf017965..994bed549663 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 ehmaldonado@google.com Fix Python3 integer division issue in roll-dep. Created with: gclient setdep -r src/third_party/depot_tools@994bed549663 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idb0505efd9fcd2d9a2ab61d736a99dfbe05db8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755460}
-
Dan Harrington authored
- Updated code so content fetch time is saved - If content is stale, load from the network. Bug: 1044139 Change-Id: I676ac6dab77133815286b14d93b94b5b778b3386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131012Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#755459}
-
Danyao Wang authored
This patch contains two preparatory changes for exposing the C++ PaymentAppService via JNI: 1. Replace the output parameter of PaymentAppService::Create() with a separate method that callers can use to get the number of payment factories. This will make it easier for the upcoming JNI code to first query the number of factories, cache it in a delegate, and call Create() with the delegate. 2. Added two new utility helpers to deserialize Mojo objects from Java ByteBuffers. Bug: 1063118 Change-Id: Ibb7ff2fcb09e18cc30abe06f410392852bbe7307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129066 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#755458}
-
Devlin Cronin authored
The ErrorConsole has been launched for several milestones. Remove the corresponding feature switch. Bug: None Change-Id: I403d6dedb51227433a75b99cc6de244eaf06d851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131360Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755457}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //device/bluetooth/bluez. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=sonnysasaka@chromium.org Bug: 714018 Change-Id: I294a17baa39c390c53928676b4c3cefd09f67e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132135 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#755456}
-
Kyle Horimoto authored
This removes jhawkins@, who is no longer working on EasyUnlock. Change-Id: I05adf467fd5ba570b24e0accc24a6d25915351ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132588 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#755455}
-
Hesen Zhang authored
- Will continue to implement CreateFromFinch once the flag change is done, include the unittest. Bug: 1066550 Change-Id: Ie63e4b037eeb8ffc5d100d3fff7cc168f46eb406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130182Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755454}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e283d1ca64c6..486232025b0b git log e283d1ca64c6..486232025b0b --date=short --first-parent --format='%ad %ae %s' 2020-04-01 marinaciocea@webrtc.org Transform received audio frames in ChannelReceive. 2020-04-01 mbonadei@webrtc.org Replace std::string::find() == 0 with absl::StartsWith. Created with: gclient setdep -r src/third_party/webrtc@486232025b0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I69b0ac541b1076f9ed558459218ecab3e63939ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132576Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //remoting. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 714018 Change-Id: I34f580a97431487d7b438a9cc4bf4640611b311a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132152 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#755452}
-
Livvie Lin authored
Interstitial code that relies on dynamic_type_util is getting moved to //ios/components so that it can be used by iGA, so the common util methods should also be moved to a shared directory. Bug: 1064382 Change-Id: I6719ddefd0ac76a9a5b2b3727221bd1f0207aa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128086 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#755451}
-
Kevin Marshall authored
This is a reland of 4898ea48 Adds a missing export directive which was breaking component builds. Original change's description: > [Fuchsia] Add support for selectively enabling input types. > > * Implements the FIDL ConfigureInputTypes() API, for embedder control > over whether input events should be routed to web content or ignored. > * Transitions CastRunner to use ConfigureInputTypes(). > * Removes the deprecated SetInputEnabled() method. > > Bug: 1031776 > Change-Id: I54e0b5c3b5a92935e6860e037edc6bc5a92eaa42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956154 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755219} TBR=ddorwin@chromium.org Bug: 1031776 Change-Id: Ia0047b56ce7ac8b28b25d0853f4d772d94cec68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132854Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#755450}
-
Marc Treib authored
The model type was added in crrev.com/c/1455965, which failed to add this suffix entry. While we're here, also mark the EXPERIMENTS suffix as obsolete. The corresponding data type has been deprecated and unused since March 2019 (crrev.com/c/1515537). Bug: 919489 Change-Id: I1941e1fc34d21ea33e2fd0ac7a87807222894d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131328Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#755449}
-
Becca Hughes authored
Add a field that stores whether the item has been checked by Safe Search or not and the result. Adds that to the Media Feeds WebUI. BUG=1066643 Change-Id: I65587885d177b45f95237a22bd08a3e1488f407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130784Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#755448}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6fd42ad9ae2..77cb6e24f164 git log b6fd42ad9ae2..77cb6e24f164 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 fmayer@google.com Merge "Try to connect to central heapprofd on user." Created with: gclient setdep -r src/third_party/perfetto@77cb6e24f164 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3bc81ea787fd83c5477c46f31e75b56fd4f23b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132510Reviewed-by:
-
Anastasiia Nikolaienko authored
Add inline margin to the label, fix repeated ids. Screenshot: http://screen/UO3c4g6HR17 Bug: 1043108 Change-Id: I169b11823efb6981d80574eda181bd4a7b7b4150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130350Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#755446}
-
Mohit Hotwani authored
Also remove the timestamp since logd adds the timestamp. This makes the logs similar to cast. Bug: internal b/152558058 Change-Id: Ifda50ed1115e2192aaa7887440aba7a02341ef09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123507Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mohit Hotwani <hmohit@chromium.org> Cr-Commit-Position: refs/heads/master@{#755445}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //ash. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 714018 Change-Id: I1bad1acf6e94610fe36679f925772aa0968b9cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132131 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: -
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //chromeos/services. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=khorimoto@chromium.org Bug: 714018 Change-Id: I13f5ea4b51764c8108cf630aa6913384f0657d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132392 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#755443}
-
Jan Wilken Dörrie authored
This change extends the histograms related to HTTP Password Migration and performs some small clean-ups of the logging code. Fixed: 1053097 Change-Id: If1950c16bc168ee6595c2cdf3755b9336a9fc06b Bug: 1053097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132264 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Stephen Chenney authored
Add tests for the following: - Images in <embed> - Images in <object> - Background repeat, position and size properties Chromium fails the background repeat tests. Also removed border properties from the existing tests as they influence the compositing behavior of Chromium and are not necessary for the test. All the tests are marked as failing for Chromium due to a lack of fuzzy matching support. Bug: 1034283 Change-Id: Ib8dfc0c47ba7d9d1e33c38b541caf169e07c786d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130648 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#755441}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8d2080a34ed..587b091d03bc git log e8d2080a34ed..587b091d03bc --date=short --first-parent --format='%ad %ae %s' 2020-04-01 brianosman@google.com Stop including SkVertices.h from SkCanvas.h Created with: gclient setdep -r src/third_party/skia@587b091d03bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I21579ad6f5af9b93109d7292f501a7659ab8f531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132509Reviewed-by:
-
Sergey Poromov authored
Original CL: https://crrev.com/c/2127707 Bug: 1062788 Change-Id: Ife67de34bd4b214a6832bd9889ac050fc056f2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132129Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#755439}
-
