- 05 Oct, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7659b7123080..30f82e022cc4 Created with: gclient setdep -r src-internal@30f82e022cc4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib9b4a4c7b952f1261802cf74ed0f19ea4f116d92 Reviewed-on: https://chromium-review.googlesource.com/c/1263866Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597021}
-
Findit authored
This reverts commit 24c77b16. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596999 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjRjNzdiMTZlYTg2ZmEwMmRmOGI4YjBlYjQ1YTEyMGNmMDJkYzg3OQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14262 Sample Failed Step: single_process_mash_content_browsertests Sample Flaky Test: NetworkServiceRestartBrowserTest.SharedWorker Original change's description: > shared worker: Self-terminate when network service crashes. > > This treats the network service crashing like the worker's process > crashing, and prevents clients getting stuck with a broken worker. > > Bug: 848256 > Change-Id: Iab8864d673da04cea062f65644e2ee10f74de4da > Reviewed-on: https://chromium-review.googlesource.com/c/1260903 > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596999} Change-Id: I2bf5229056da67f539f4f89ed7fc92578edac567 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848256, 892535 Reviewed-on: https://chromium-review.googlesource.com/c/1263885 Cr-Commit-Position: refs/heads/master@{#597020}
-
Renee Wright authored
This change fixes a bug where the value for Settings > Device > Storage Management > Linux (Beta) storage shows as 0 when the Termina container is not running. Bug: 888795 Change-Id: I6ab468bc6cca5cdf786e226517ecc25c971061ec Reviewed-on: https://chromium-review.googlesource.com/c/1260608 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597019}
-
Kunihiko Sakamoto authored
Bug: 849935 Change-Id: Ifc480bba69fa9b15aa0b0adb9b0c6a6cb28441b0 Reviewed-on: https://chromium-review.googlesource.com/c/1264136Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#597018}
-
Trent Apted authored
Adds - FileManagerJsTest.ImporterCommonTest - FileManagerJsTest.LRUCacheTest - FileManagerJsTest.AsyncUtilTest - FileManagerJsTest.FilesAppEntryTypes - FileManagerJsTest.UtilTest Also adds test_importer_common.js to be typechecked, which isn't itself a unit test. This exposed a weird dependency group on ui/file_manager/exerns/volume_info.js - encapsulate those dependencies as well as we can. Remove the dependency on cr.EventListenerType: it's a @typedef {...|*} so adds no type safety and requires a dependency on "//ui/webui/resources/js/cr:event_target" which is not an extern. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I479f8e7b22b56ea315c27fabc5e7ccdeb6277728 Reviewed-on: https://chromium-review.googlesource.com/c/1250762 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597017}
-
Trent Apted authored
This allows the html files generated under out/foo/gen/.... to be opened in Chrome as a file:/// URL. It doesn't affect how the files are served by the embedded test server (leading ../..'s are ignored). Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6a7a8838c6158f9f5cdeb9fa8e0745c23d88f602 Reviewed-on: https://chromium-review.googlesource.com/c/1264095Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#597016}
-
Asami Doi authored
to record a script type 'classic' or 'module'. The goal is to import and evaluate as a module script at ServiceWorker. Users can use it by adding type 'module' when register a service worker script. This CL allows to store script type into ServiceWorkerDatabase and use it when starting an installed service worker. Bug: 824647 Change-Id: I4d26b774fa662a6e6587bf10137fd8b1dae2e42a Reviewed-on: https://chromium-review.googlesource.com/c/1226488Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Asami Doi <asamidoi@google.com> Cr-Commit-Position: refs/heads/master@{#597015}
-
Lei Zhang authored
IWYU for GN. Change-Id: I88f2a9c1b7c115aefeca36208d21ea4b1db89687 Reviewed-on: https://chromium-review.googlesource.com/c/1263570Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#597014}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1d4dc8eb878..f98905e8f03c git log d1d4dc8eb878..f98905e8f03c --date=short --no-merges --format='%ad %ae %s' 2018-10-05 hinoka@google.com [led] Roll led to fix broken Milo annotation stream. Created with: gclient setdep -r src/third_party/depot_tools@f98905e8f03c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891925 TBR=agable@chromium.org Change-Id: Ic4783663bfe1bf6803e828cfc68c734f11956d46 Reviewed-on: https://chromium-review.googlesource.com/c/1263864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597013}
-
Noel Gordon authored
Add a tall PDF file (derived from tall.txt). No change in behavior, so no new tests, just adding a resource. Bug: 891150 Change-Id: Ib5b7f2faec713c8cae23183cc3c55a3f77188a4b Reviewed-on: https://chromium-review.googlesource.com/c/1263680 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#597012}
-
Takashi Sakamoto authored
This reverts commit e275f44c. Reason for revert: network_service_browser_tests and browser_tests failures on Mac10.* An example of failed builders: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15650 An example of failures: [ RUN ] PPAPINaClNewlibTest.MessageHandler [20331:4611:1004/172559.081686:WARNING:notification_platform_bridge_mac.mm(512)] AlertNotificationService: XPC connection invalidated. [20331:775:1004/172559.238456:ERROR:delegated_frame_host.cc(174)] Not implemented reached in void content::DelegatedFrameHost::SetNeedsBeginFrames(bool) [20331:775:1004/172559.246528:ERROR:web_contents_view_mac.mm(487)] Failed to look up NSViewBridgeFactoryHost! [20331:87555:1004/172600.232802:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico [20331:41475:1004/172600.253102:FATAL:child_process_launcher_helper_mac.cc(111)] Check failed: false. 0 browser_tests 0x000000010880e56f base::debug::StackTrace::StackTrace(unsigned long) + 31 1 browser_tests 0x0000000108749e0f logging::LogMessage::~LogMessage() + 223 2 browser_tests 0x0000000106daeea8 content::internal::ChildProcessLauncherHelper::BeforeLaunchOnLauncherThread(content::PosixFileDescriptorInfo const&, base::LaunchOptions*) + 584 3 browser_tests 0x0000000106dae42a content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread() + 90 4 browser_tests 0x0000000108737492 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 242 5 browser_tests 0x00000001087cc726 base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) + 918 6 browser_tests 0x0000000108819974 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) + 100 7 browser_tests 0x00000001087cbd81 base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) + 305 8 browser_tests 0x00000001087c2b57 base::internal::SchedulerWorker::RunWorker() + 391 9 browser_tests 0x00000001087c29b4 base::internal::SchedulerWorker::RunDedicatedWorker() + 20 10 browser_tests 0x0000000108819e47 base::(anonymous namespace)::ThreadFunc(void*) + 87 11 libsystem_pthread.dylib 0x00007fffbcc2f93b _pthread_body + 180 12 libsystem_pthread.dylib 0x00007fffbcc2f887 _pthread_body + 0 13 libsystem_pthread.dylib 0x00007fffbcc2f08d thread_start + 13 Original change's description: > macOS V2 Sandbox: Remove the feature flags. > > The V2 sandbox is now default for all but the network and GPU processes > on macOS. This CL deletes the feature flag. A new experiment will be > introduced for the GPU process. > > Bug: 749839 > Change-Id: Idb65a83f25f48db5aaf8d8d2400992640673d0e8 > Reviewed-on: https://chromium-review.googlesource.com/c/1258214 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596910} TBR=avi@chromium.org,asvitkine@chromium.org,kerrnel@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I318db92c92f7d03b1a67fd2734e27b50169bd4e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749839 Reviewed-on: https://chromium-review.googlesource.com/c/1263737Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#597011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b0f761dc3cd..7659b7123080 Created with: gclient setdep -r src-internal@7659b7123080 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6f5b6c87a3e36c36006203858befe06cf1d1f8df Reviewed-on: https://chromium-review.googlesource.com/c/1263863Reviewed-by:
-
Andrew Luo authored
Uninstall webview before running cts test and don't run shell instrumentation test on swarming for now. Bug: 814405 Change-Id: Icdd9f5f68679d3483d2b329f18a7b820ae500d0e Reviewed-on: https://chromium-review.googlesource.com/c/1264155Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#597009}
-
Kouhei Ueno authored
Bug: None Change-Id: Ifea1dad183590cdb258264f4158473fbcebea35d Reviewed-on: https://chromium-review.googlesource.com/c/1263683 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
Jun Choi authored
Currently relying party ID is injected to the title of AuthenticatorBlePinEntrySheetModel. This should be fixed to device display name. Bug: 877344 Change-Id: Ia2126c401881df9b70a4867711886f50ae53fdf6 Reviewed-on: https://chromium-review.googlesource.com/c/1260013 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#597007}
-
Giovanni Ortuño Urquidi authored
This is a reland of 837b3c20 The original patch attempted to init the alternate dbus client on Linux where there is no alternate bus connection. The latest patchset fixes this by returning early if there is no alternate bus connection. Additionally, BluetoothAdapterClientImpl assumed it was always initialized. This caused a crash on Linux during shutdown. This latest patchset fixes this by only cleaning up if the client has been initialized. TBR'ing since it's a small change from the original CL. Original change's description: > bluetooth: Add a new BluetoothAdapterClient instance and use it for GetState > > There are two parts to this change: > > 1. Create a new BluetoothAdapterClient instance. For this we add > "alternate_bluetooth_adapter_client()" to the bundle of DBus clients. > This new instance uses a separate DBus Connection through > BluezDBusThreadManager. This ensures actions on one client won't > affect the other client. > > 2. Implement BluetoothSystem::GetState using the new client. > > Bug: 870192, 882771 > Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201 > Reviewed-on: https://chromium-review.googlesource.com/c/1215427 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596520} TBR=derat@chromium.org,stevenjb@chromium.org,reillyg@chromium.org,sammc@chromium.org Bug: 870192, 882771 Change-Id: Ie089e30d297e8afd9ceb70c0e9a4af7600e633de Reviewed-on: https://chromium-review.googlesource.com/c/1263640Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#597006}
-
Tetsui Ohkubo authored
This CL adds Clear All button to NewUnifiedMessageCenterView. NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: Ibadc6e5a3d799fcbeb6c94199d68656d169295d4 Reviewed-on: https://chromium-review.googlesource.com/c/1260530Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#597005}
-
Yoshifumi Inoue authored
This patch makes Element#innerText to collapse white space after <br> to avoid emitting extra space for improving interop. Bug: 892491 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8dd429a8af6ecd2e6d5195d6a6ec7b0214c6345c Reviewed-on: https://chromium-review.googlesource.com/c/1263638Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597004}
-
Ryan Sturm authored
This allows a future CL to add PreviewsState to this object without violating DEPS. Change-Id: Ibfb1def6224f208147d2cb37e340a4cebf23c6ca TBR=mmenke,jianli Change-Id: Ibfb1def6224f208147d2cb37e340a4cebf23c6ca Reviewed-on: https://chromium-review.googlesource.com/c/1263395 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#597003}
-
Xiaoqian Dai authored
After the drag ends, the dragged tab window might need to merge back into the source window if 1) the dragged window or the source window is not added to overview and 2) the dragged window has dragged farther than half of the screen height and 3) the dragged window is not in snap preview area and 4) the dragged window is not dragged to other side of the splitscreen if source window is showing in splitscreen. Bug: 887739 Change-Id: I21bab4ef5fbfc4c9c4294a6028798be3793b8b5c Reviewed-on: https://chromium-review.googlesource.com/c/1259468 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#597002}
-
Yuta Kitamura authored
This CL moves web_thread.h to blink/renderer/platform/scheduler/public and renames WebThread to Thread, so this class can only be referred from Blink. All the existing #include lines are rewritten, but references to WebThread in Blink are not renamed yet. The rename will happen in later CLs. To make the migration easier, temporary aliases of old names are added. Bug: 826203 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3cc9d209fd0c53c8a6362321661a361602f12dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1257473 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597001}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7a24422d086..56216d7832a4 git log a7a24422d086..56216d7832a4 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chiniforooshan@chromium.org Telemetry: pixel approximated/checkerboarded Created with: gclient setdep -r src/third_party/catapult@56216d7832a4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890757 TBR=sullivan@chromium.org Change-Id: I00fdd306c02a5ff45b9706d9664e45bed98bec4f Reviewed-on: https://chromium-review.googlesource.com/c/1263862Reviewed-by:
-
Matt Falkenhagen authored
This treats the network service crashing like the worker's process crashing, and prevents clients getting stuck with a broken worker. Bug: 848256 Change-Id: Iab8864d673da04cea062f65644e2ee10f74de4da Reviewed-on: https://chromium-review.googlesource.com/c/1260903Reviewed-by:
-
Darren Shen authored
For the inline handwriting feature, we introduced a private onFocus event to pass along stylus information. However, third party IMEs cannot listen to this, so we have to dispatch the public onFocus events to them. In our original patch, we did consider this issue and made sure that we only dispatch the private onFocus if "HasListener" is true. However, it turns out that "HasListener" returns true if *any* extension is listening to the event, so as long as the XKB extension is active, no third party IMEs will receive the public onFocus event. We change it so that we check whether each particular extension is listening to the private onFocus event before dispatching, so that the XKB extension receives the private onFocus event and third party IMEs receive the public one. We think that the other usages of HasListener are technicaly incorrect as well, but we will fix them in a follow up patch to limit the scope of this one. TBR=shuchen@chromium.org Bug: 835699 Change-Id: I7895d8503eb3677de8d248475f2856d1dfd397ca Reviewed-on: https://chromium-review.googlesource.com/c/1258702 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596998}
-
Ilya Sherman authored
* Hide more internal logic within PendingProfiles * Ensure that the functions that collect profiles cannot be called without verifying that collection is enabled. * Move profile serialization out from being under a lock. There's an important implementation detail: Profiles stored in the two vectors might end up interleaved, in terms of timestamps. However, it is still guaranteed that profiles from a single process are ordered consistently in the uploaded data, which is sufficient for later efficient processing. BUG=888716,851163 R=chengx@chromium.org Change-Id: I94c4ab165753e8a09a53490494f8161b197f1428 Reviewed-on: https://chromium-review.googlesource.com/c/1258514Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596997}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/84583f618399..0a74e09b39c1 git log 84583f618399..0a74e09b39c1 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0af97cea..618ddbcb (596847:596951) Created with: gclient setdep -r src/third_party/webrtc@0a74e09b39c1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie39b01f2cdf1f4e3cb6506f6227ea9c6162e7da7 Reviewed-on: https://chromium-review.googlesource.com/c/1263860Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56f1cb670eca..3b0f761dc3cd Created with: gclient setdep -r src-internal@3b0f761dc3cd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic362e27c3b92777804bd669671483dcbc099ccdb Reviewed-on: https://chromium-review.googlesource.com/c/1263856Reviewed-by:
-
Naoki Fukino authored
When the current directory is hidden by filter setting (incl. disabling "Show all Play folders" option), the current directory should be changed to visible one. This CL change the current directory to the volume's root directory for such cases to be consistent with the case when the current directory is deleted. . Bug: 877405 Test: manual test on a arc-enabled device, and browser_tests --gtest_filter=*hideCurrentDirectoryByTogglingHiddenAndroidFolders Change-Id: Ie2db1f297df0cf6ee1dcf2719f204763985a1c80 Reviewed-on: https://chromium-review.googlesource.com/c/1258807 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b4ad765627f..4f87e2255b8a git log 1b4ad765627f..4f87e2255b8a --date=short --no-merges --format='%ad %ae %s' 2018-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 76dd2d6f9f5e..14246813a110 (4 commits) Created with: gclient setdep -r src/third_party/skia@4f87e2255b8a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I5e3b8cbb44c9dd15bc0b78813e2dcb6c339aa97a Reviewed-on: https://chromium-review.googlesource.com/c/1263857Reviewed-by:
-
Lei Zhang authored
Change-Id: If2ff3976bae6216853ba9a70a189ba0932f16c6b Reviewed-on: https://chromium-review.googlesource.com/c/1257245 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#596992}
-
Fergal Daly authored
This creates a blinkpy/preusbmit directory, so that we run also run audit_non_blink_usage_test.py Change-Id: I7ce7832a90bc4a02e3f886fad216a4eb82188064 Reviewed-on: https://chromium-review.googlesource.com/c/1261103 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#596991}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f7d74f7cd02..a7a24422d086 git log 3f7d74f7cd02..a7a24422d086 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 chiniforooshan@chromium.org Telemetry: fix thread_other_cpu_time_per_frame_tbmv2 Created with: gclient setdep -r src/third_party/catapult@a7a24422d086 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:891546 TBR=sullivan@chromium.org Change-Id: I4b92e40272ff65e082998a2ca6379ae661e43d1a Reviewed-on: https://chromium-review.googlesource.com/c/1263858Reviewed-by:
-
Noel Gordon authored
Now we have the QuickView <webview> infra to detect the 'loaded' state of thew <webview> content, add a <file-safe-media> image test and also check the <webview> renders its content on a transparent black body. Bug: 891150 Change-Id: I8e6aac85ce09e0fcbe0cbba660630d1427e2962b Reviewed-on: https://chromium-review.googlesource.com/c/1263678Reviewed-by:
-
Ian Clelland authored
This queues a report through the Reporting API whenever requestPictureInPicture is called in a frame in which the 'picture-in-picture' feature is not allowed according to feature policy. Bug: 867471 Change-Id: I1cede10385f6a5110fd0ddd5bf124ff5d3737dd9 Reviewed-on: https://chromium-review.googlesource.com/c/1262432 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#596988}
-
Sergei Datsenko authored
BUG=chromium:854481 Change-Id: I3f6fe2429d9bc762b3f6552811c3d58326b18bac Reviewed-on: https://chromium-review.googlesource.com/c/1263641Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#596987}
-
Jinsuk Kim authored
SwipeRefreshHandler is used for the active WebContents to handle swipe-to-refresh gesture. It's now managed as TabWebContentsUserData - created on the first initialization of WebContents, and destroyed at the end of the life of the Tab it belongs to. Accompanied changes: - TabGestureStateListener should also have the same lifetime i.e. created on the first WebContents of a Tab becomes active, then have its associated WebContents init/destroyed as active one changes over time, and finally destroyed together with Tab. Previously it was created repeatedly for new WebContents. This CL changes it. - All TabWebContentsUserData (so far) need to call |cleanupWebContents| upon |destroy|. This CL factors the common pattern out to their base class. Bug: 877878 Change-Id: I6f6264866338e763be7737716b93dab86ea1414b Reviewed-on: https://chromium-review.googlesource.com/c/1253525 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596986}
-
Darren Shen authored
KeyboardUI::GetKeyboardWindow lazily creates a keyboard window and loads web contents. Because the KeyboardController lifecycle is quite complicated, it's not clear from reading the code whether a call to GetKeyboardWindow creates a window or not. In fact, only one particular call to GetKeyboardWindow creates the keyboard window. All the other calls are guaranteed to occur after that call. Thus, we keep that one call to GetKeyboardWindow to create the keyboard window and replace the other calls with KeyboardController ::GetKeyboardWindow, which, by contrast, has no side effects. Bug: 845780 Change-Id: I56e86932e82ced8b25a6f9eb034c60034e3a3548 Reviewed-on: https://chromium-review.googlesource.com/c/1235353 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596985}
-
siyua authored
The feature is already existing, and previously we just by default disabled it. This CL ensures we can config this feature from Chrome://flags Bug: 852904 Change-Id: I9c5e37070eed995e03b5bfddcb7fd05c744a9091 Reviewed-on: https://chromium-review.googlesource.com/c/1262929 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#596984}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 71098fe5. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." 65d72632 "Make DTMF tone change more deterministic" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25850 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: Ia0cff643cfe95b7fa0aea7460abb60051238234f Reviewed-on: https://chromium-review.googlesource.com/c/1263591 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596983}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e9443f5b7f8..d1d4dc8eb878 git log 8e9443f5b7f8..d1d4dc8eb878 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d1d4dc8eb878 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6ad82b1795c42dc41426f292ea03023f36a52770 Reviewed-on: https://chromium-review.googlesource.com/c/1263855Reviewed-by:
-
