- 04 Oct, 2016 40 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/32eebb8c482d73dbc453dfdce62e46d4c8ee19a1 Disable local fallback in goma staging environment (tikuta@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2396453002 Cr-Commit-Position: refs/heads/master@{#422736}
-
guidou authored
Revert of Send a TrackedPreference incident when registry pref validation fails. (patchset #3 id:40001 of https://codereview.chromium.org/2384213002/ ) Reason for revert: Parent CL https://codereview.chromium.org/2204943002 is suspect of breaking WebRTC Win Tester bots. See https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/28938 Original issue's description: > Send a TrackedPreference incident when registry pref validation fails. > > Note that the new incident types (BYPASS_CLEARED and BYPASS_CHANGED) are only > used when external (registry) validation fails and existing > (secure_preferences-based) validation succeeds. > > BUG=624858 > > Committed: https://crrev.com/1ba5bcd1a74380bb398eeab3787ede5620b5130c > Cr-Commit-Position: refs/heads/master@{#422545} TBR=jialiul@chromium.org,caitkp@chromium.org,gab@chromium.org,proberge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624858 Review-Url: https://codereview.chromium.org/2390213002 Cr-Commit-Position: refs/heads/master@{#422735}
-
hidehiko authored
Currently, the responsibility of the ARC auth code control flow was distributed across ArcAuthService ArcSupportHost and background.js etc. This CL removes it from background.js, as a preparation to move all of them into a manageable form. Now, background.js has two types of messages. 1) Action, which is sent from the native code, to do something in extension, and 2) Event to notify to the native code that something (e.g., user clieck etc.) is happend in the extension BUG=b/31079732 TEST=Ran on test device. Ran tests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2388763002 Cr-Commit-Position: refs/heads/master@{#422734}
-
suzyh authored
This DCHECK was commented out in Apr 2014 (https://chromium.googlesource.com/chromium/src/+/8a343ad96e4ca48eb665a77a6db8beb4357fe67c) because it was causing Chrome OS test failures. Since this assertion has been ignored for 2.5 years and the logic in this part of the code has since changed, it is not clear that this assertion would be useful if it were ever re-enabled. BUG=365507 Review-Url: https://codereview.chromium.org/2390803004 Cr-Commit-Position: refs/heads/master@{#422733}
-
arthursonzogni authored
This CL prevents redirect timing to be set to zero when there is no redirection. BUG=576261 Review-Url: https://codereview.chromium.org/2368883003 Cr-Commit-Position: refs/heads/master@{#422732}
-
alancutter authored
This patch avoids using raw pointers to AtomicString contents for animation PropertyHandles. By making the AtomicString class a member all the necessary reference counting occurs. BUG=652127 Review-Url: https://codereview.chromium.org/2390203002 Cr-Commit-Position: refs/heads/master@{#422731}
-
steel authored
The BluetoothAudioSink code does not seem to be used from anywhere. The code is currently just bloat. If we decide in the future to use this code, we can always re-add it back again by reverting this CL. Reviews requested, ortuno@ or scheib@ - OWNERs mcchou@ - original author of the code, hence general review. R=mcchou@chromium.org, ortuno@chromium.org, scheib@chromium.org BUG=None Review-Url: https://codereview.chromium.org/2389753003 Cr-Commit-Position: refs/heads/master@{#422730}
-
xianglu authored
This CL implements mojom client on blink side. - FaceDetector::detect() sends an image to the browser through shared_buffer; - FaceDetector::onDetectFace() receives a list of boundingBoxes from Chrome. A mock mojom server is added to test the connection. This CL also reduces the API surface by removing Detector and DetectedObject interface, so that the hierarchy is simpler and cleaner. BUG=646083 TEST=Pass LayoutTest detectface.html Review-Url: https://codereview.chromium.org/2369693002 Cr-Commit-Position: refs/heads/master@{#422729}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#422728}
-
yyanagisawa authored
BUG=314403 Review-Url: https://codereview.chromium.org/2374943002 Cr-Commit-Position: refs/heads/master@{#422727}
-
dcheng authored
Generated with https://codereview.chromium.org/2056153003/. BUG=581865 R=sky@chromium.org,xiyuan@chromium.org TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2392693002 Cr-Commit-Position: refs/heads/master@{#422726}
-
hiroshige authored
This CL adds a check of synchronousPolicy to ResourceLoaderOptions::canReuseRequest() to avoid Resources to be reused between sync and async requests. This CL also removes a condition from ResourceFetcher::determineRevalidationPolicy() that is covered by the newly added check. CachingCorrectnessTest is updated so that it doesn't use synchronous RawResource requests. BUG=652172 Review-Url: https://codereview.chromium.org/2391523002 Cr-Commit-Position: refs/heads/master@{#422725}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#422724}
-
nya authored
Currently ArcDownloadsWatcherService requests Android media provider to scan every new/modified files under the Downloads directory. It causes heavy load when many files are created/deleted there. This change excludes files not supported by Android media scanner. BUG=chromium:651731 TEST=touch a.txt # Not scanned TEST=touch a.png # Scanned TEST=unit_tests --gtest_filter='ArcDownloadsWatcherServiceTest.*' Review-Url: https://codereview.chromium.org/2379323002 Cr-Commit-Position: refs/heads/master@{#422723}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/714e94ae..eb2b7fdc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2390163002 Cr-Commit-Position: refs/heads/master@{#422722}
-
nhiroki authored
This CL removes an unused |origin_filter| param from DidGetRegistrationsInfo() on ServiceWorkerStorage. Before this CL, the param was always an empty GURL. In addition, this makes DidGetRegistrations() always take a non-empty GURL as |origin_filter| and renames the function to DidGetRegistrationsForOrigin() to clarify its functionality. BUG=n/a Review-Url: https://codereview.chromium.org/2390953002 Cr-Commit-Position: refs/heads/master@{#422721}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/b71fd26f0 BUG=497522 TBR=trchen@chromium.org Review URL: https://codereview.chromium.org/2390183002 . Cr-Commit-Position: refs/heads/master@{#422720}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/76383db4906c..b73c99335bfb $ git log 76383db49..b73c99335 --date=short --no-merges --format='%ad %ae %s' 2016-10-03 thestig Revert of Assert that only 0-numbered objects are Released() (patchset #7 id:120001 of https://codereview.chromium.org/2375343004/ ) 2016-10-03 weili Sync pdfium_test version to include updated test file 2016-10-03 tsepez Assert that only 0-numbered objects are Released() 2016-10-03 tsepez Add ptr_util.h from base until std::make_unique<> available TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2384273003 Cr-Commit-Position: refs/heads/master@{#422719}
-
pkasting authored
This also makes some minor modifications (add trailing periods, eliminate unneeded comment, etc.). BUG=563793 TEST=none Review-Url: https://codereview.chromium.org/2389703004 Cr-Commit-Position: refs/heads/master@{#422718}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/8d329a8b3 BUG=651940 TBR=malaykeshav@chromium.org Review URL: https://codereview.chromium.org/2389113002 . Cr-Commit-Position: refs/heads/master@{#422717}
-
mgiuca authored
These settings no longer hook up to actual data; they just return 'allow' always, and setting them has no effect. Updated documentation. This is because Chrome now (and has for awhile) ignores these settings and always permits these actions without asking the user. BUG=591896 Review-Url: https://codereview.chromium.org/2358893004 Cr-Commit-Position: refs/heads/master@{#422716}
-
horo authored
BUG=652535 TBR=ikilpatrick@chromium.org Review-Url: https://codereview.chromium.org/2384393002 Cr-Commit-Position: refs/heads/master@{#422715}
-
loyso authored
We add/remove/etc animations to AnimationPlayer now. ElementAnimations is a light helper class. BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2377223002 Cr-Commit-Position: refs/heads/master@{#422714}
-
yoichio authored
In following CL, I accidentally skipped null check for |innerNode|: https://chromium.googlesource.com/chromium/src/+/66f8f14f5560949660ad6efc0b00484d8342a 15e%5E%21/#F4 This has caused null-ref error. BUG=633073 Review-Url: https://codereview.chromium.org/2390613002 Cr-Commit-Position: refs/heads/master@{#422713}
-
steel authored
This CL rolls the DEPS to pull in the latest cros_system_api, which adds the constant for the SetAdvertisingIntervals method. It also fixes a few nits from the CL that added the setAdvertisingIntervals code, https://codereview.chromium.org/2353133005/ R=ortuno@chromium.org BUG=637231 Review-Url: https://codereview.chromium.org/2390063002 Cr-Commit-Position: refs/heads/master@{#422712}
-
loyso authored
We don't need to preserve the state of cc::ElementAnimations between detach/attach. All state lives in cc::AnimationPlayer now. BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2363733004 Cr-Commit-Position: refs/heads/master@{#422711}
-
wangxianzhu authored
Use enclosingLayoutRect instead of enclosingIntRect in SVGLayoutSupport::transformPaintInvalidationRect() https://bugs.chromium.org/p/chromium/issues/detail?id=651521#c2: The purpose of the original enclosingIntRect() might be to avoid unwanted inward-snapping due to FloatRect -> LayoutRect conversion. Change it to enclosingLayoutRect. Also changed PaintInvalidator to use enclosingLayoutRect when converting from FloatRect to LayoutRect. BUG=651521 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2380403002 Cr-Commit-Position: refs/heads/master@{#422710}
-
loyso authored
BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2357533002 Cr-Commit-Position: refs/heads/master@{#422709}
-
trchen authored
As spec'd by https://drafts.fxtf.org/filters-2/#BackdropFilterProperty BUG=497522 Review-Url: https://codereview.chromium.org/2379803003 Cr-Commit-Position: refs/heads/master@{#422708}
-
xzhou authored
Android apps can use the broadcast to start automatically. This Change disable ACTION_BOOT_COMPLETED broadcast for 3rd party applications. BUG=650313 TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*" Review-Url: https://codereview.chromium.org/2359003004 Cr-Commit-Position: refs/heads/master@{#422707}
-
malaykeshav authored
BUG=651940 COMPONENT=Paint, ScrollableArea, Scrollbar CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2382103006 Cr-Commit-Position: refs/heads/master@{#422706}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/234079c8f BUG=627588 TBR=chrishtr@chromium.org Review URL: https://codereview.chromium.org/2391813003 . Cr-Commit-Position: refs/heads/master@{#422705}
-
loyso authored
Next step: Rework UpdateClientAnimationState to deal with a bitset instead of single property (batch, batch, batch) BUG=592873 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2349643003 Cr-Commit-Position: refs/heads/master@{#422704}
-
dominickn authored
This CL refactors WebappRegistry and WebappDataStorage to make most of the methods synchronous. WebappRegistry is now a singleton instance that is instantiated at browser startup. This allows all SharedPreferences files to be pre-warmed before the class is used; new web apps open new SharedPreferences on a background thread when registered, after which the preferences are cached automatically. Most static methods on WebappRegistry and WebappDataStorage have been converted to instance methods or removed. This makes the code much cleaner and more efficient; each static method had to independently open their SharedPreferences, which minimally performs a stat() on the underlying XML file to see if it has changed. Now the singleton WebappRegistry caches all WebappDataStorage objects on startup and whenever new ones are added. This reduces disk IO overhead. This CL allows all calls to SharedPreferences.Editor.apply() in WebappRegistry and WebappDataStorage to occur on the main thread, mostly removing the need for unwieldy callback interfaces and bare pointer passing across the JNI. BUG=633791 Review-Url: https://codereview.chromium.org/2351113005 Cr-Commit-Position: refs/heads/master@{#422703}
-
Ian Clelland authored
WTF::Strings are not null-terminated, so this error would cause a single character to be read past the end of the string, if the string ends in an unfinished escape sequence. (This parser is not currently used by any code in blink) This also adds a test that would have caught this error, if run on an MSAN bot, and fixes the same code in the DevTools parser. The DevTools parser would not trigger an out-of-bounds read in the same situation, since it operates on null-terminated string data. Also added is the fuzzer which caught the issue in the first place. BUG=651166 R=dgozman@chromium.org, mmoroz@chromium.org, pfeldman@chromium.org, pfeldman Review URL: https://codereview.chromium.org/2380823002 . Cr-Commit-Position: refs/heads/master@{#422702}
-
lhchavez authored
ARC standalone project was cancelled. Let's remove that code. BUG=None TEST=trybots Review-Url: https://codereview.chromium.org/2384173004 Cr-Commit-Position: refs/heads/master@{#422701}
-
bashi authored
OnMemoryStateChange() callback is invoked on the UI thread but we can't call GetDefaultMemoryLimit() from the UI thread. Store the default limit on construction. BUG=652557 Review-Url: https://codereview.chromium.org/2388403002 Cr-Commit-Position: refs/heads/master@{#422700}
-
tzik authored
TestSimpleTaskRunner::GetPendingTasks copies whole set of the pending task for each invocation. That prevents a migration to the non-copyable Callback. This CL replaces it with newly added TakePendingTasks and others. BUG=554299 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2331423002 Cr-Commit-Position: refs/heads/master@{#422699}
-
hajimehoshi authored
When the memory coordinator is enabled, SdchOwner becomes a client of the memory coordinator instead of installing MemoryPressureListener. In the implmentation of this CL, both MemoryPressureListener and MemoryCoordinatorClient are installed regardless of the flag, but as default MemoryCoordinator is not enabled and when MemoryCoordinator is enabled by a flag, it is planed to suppress MemoryPressureMonitor features. Design Doc: https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8Uo/edit?ts=57d7968b# BUG=639700 Review-Url: https://codereview.chromium.org/2390603002 Cr-Commit-Position: refs/heads/master@{#422698}
-
hajimehoshi authored
When the memory coordinator is enabled, SSLClientSessionCache becomes a client of the memory coordinator instead of installing MemoryPressureListener. In the implmentation of this CL, both MemoryPressureListener and MemoryCoordinatorClient are installed regardless of the flag, but as default MemoryCoordinator is not enabled and when MemoryCoordinator is enabled by a flag, it is planed to suppress MemoryPressureMonitor features. Design Doc: https://docs.google.com/document/d/1a69mMr7jI7qK0OfKNlrZ350xiXizVMCCe8orGX7K8Uo/edit?ts=57d7968b# BUG=639700 Review-Url: https://codereview.chromium.org/2384703002 Cr-Commit-Position: refs/heads/master@{#422697}
-