- 08 Aug, 2014 40 commits
-
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288431} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288431 0039d316-1c4b-4281-b951-d872f2087c98
-
rockot@chromium.org authored
This just moves update_manifest.h/cc into the extensions_common target. Precursor to moving manifest parsing code and ultimately the rest of the download/install/update code. BUG=398671 TBR=dcheng@chromium.org for IPC messages (header move only) Review URL: https://codereview.chromium.org/454873005 Cr-Commit-Position: refs/heads/master@{#288430} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288430 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/b511042bb07a6a289b0d1146cb57f6e8b80580d6..be129b26f13d575fd6b396c6ae759838ecc9bd1a CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel TBR=bungeman@google.com BUG= Review URL: https://codereview.chromium.org/453653004 Cr-Commit-Position: refs/heads/master@{#288429} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288429 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
Add support for configs with domains *.foo.bar. Given a domain foo.bar, it will first look for a config with domain foo.bar, then *.foo.bar, then *.bar. BUG=396139 Review URL: https://codereview.chromium.org/404363003 Cr-Commit-Position: refs/heads/master@{#288428} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288428 0039d316-1c4b-4281-b951-d872f2087c98
-
hanxi@chromium.org authored
Use ExtensionsAPIClient to register guests. BUG=352290 Review URL: https://codereview.chromium.org/444113003 Cr-Commit-Position: refs/heads/master@{#288427} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288427 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
r284961 broke PNaCl on-demand by loading resources retrieved by component_uploader before sending a request to download a user pexe. This change fixes the breakage by only loading resources after we've determined that that there is no cached translated nexe. BUG=401755 R=dmichael@chromium.org, dschuff@chromium.org Review URL: https://codereview.chromium.org/453073002 Cr-Commit-Position: refs/heads/master@{#288426} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288426 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
linux_chromium_rel_swarming seems find, so I'm trying on windows next. BUG=109173 TEST=none R=jam@chromium.org TBR=jam@chromium.org Review URL: https://codereview.chromium.org/454083003 Cr-Commit-Position: refs/heads/master@{#288425} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288425 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
This is shorter, and it allows us to remove two trampoline files on Android (which still weren't updated to trampoline to the 4.8 toolchain and still referred to the 4.6 toolchain instead). No intended visible behavior change. BUG=none Review URL: https://codereview.chromium.org/450843002 Cr-Commit-Position: refs/heads/master@{#288424} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288424 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
Still seeing log spam because we set oem_manifest_loaded_ to true even if the file doesn't exist. Follow-up to r239700 BUG=314793 TEST=remove oem manifest.json - should not see spam in log file. Review URL: https://codereview.chromium.org/448403002 Cr-Commit-Position: refs/heads/master@{#288423} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288423 0039d316-1c4b-4281-b951-d872f2087c98
-
luken@chromium.org authored
> Extend contextMenus API to support browser/page actions > > Screenshot: > http://i.imgur.com/RILqQqe.png > > BUG=234425 > > Review URL: https://codereview.chromium.org/359493005 TBR=gpdavis.chromium@gmail.com Review URL: https://codereview.chromium.org/455023002 Cr-Commit-Position: refs/heads/master@{#288422} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288422 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
R=estade@chromium.org BUG=393489 Review URL: https://codereview.chromium.org/444093003 Cr-Commit-Position: refs/heads/master@{#288421} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288421 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
If the web-page specifies a color using the 'theme-color' meta-tag, then use that color to paint the background of the window-title. Fix the height of the title to be 25px. BUG=401569 R=oshima@chromium.org Review URL: https://codereview.chromium.org/455773003 Cr-Commit-Position: refs/heads/master@{#288420} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288420 0039d316-1c4b-4281-b951-d872f2087c98
-
gpdavis.chromium@gmail.com authored
Screenshot: http://i.imgur.com/RILqQqe.png BUG=234425 Review URL: https://codereview.chromium.org/359493005 Cr-Commit-Position: refs/heads/master@{#288418} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288418 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/406043003/krstnmnlsn@chromium.org authored
(originally reverted because the buildbots weren't pointed to verifier_test_dll.dll by unit_tests.isolate) ========================================================= Adding the VerifyModule function (and helpers) to safe browsing. This function allows us to compare a module in memory with its original on disk, and identify any differences (after accounting for relocations). The state of the module (MODULE_UNKNOWN, MODULE_UNMODIFIED or MODULE_MODIFIED) is returned along with a list of the possibly modified exported functions of the module. BUG=401854 TBR= noelutz@google.com, robertshield@chromium.org, csharp@chromium.org, asvitkine@chromium.org, grt@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/451893003 Cr-Commit-Position: refs/heads/master@{#288417} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288417 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
- Static field names start with s. - static final fields (constants) are ALL_CAPS_WITH_UNDERSCORES. http://source.android.com/source/code-style.html#follow-field-naming-conventions BUG=318404 TBR=qinmin Review URL: https://codereview.chromium.org/455523002 Cr-Commit-Position: refs/heads/master@{#288416} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288416 0039d316-1c4b-4281-b951-d872f2087c98
-
felt@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/456503003 Cr-Commit-Position: refs/heads/master@{#288414} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288414 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
This new object is implemented in content in both the renderer and browser side. The CacheStorage API methods now pass in to the browser process in the UI thread, where all API calls are failed as not implemented. R=jkarlin@chromium.org,falken@chromium.org,jochen@chromium.org,jschuh@chromium.org BUG=392621 Review URL: https://codereview.chromium.org/379303002 Cr-Commit-Position: refs/heads/master@{#288413} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288413 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
Users can specify the device scale factor for some external displays. Now, it remembers the configured device scale factor to the local storage, and recovers to the specified value when reconnected. This also fixes the bug when the user specifies the resolution and the device scale factor at the same time (DSF was ignored beforehand). BUG=396704 R=oshima@chromium.org TEST=manually, unit_tests Review URL: https://codereview.chromium.org/455443002 Cr-Commit-Position: refs/heads/master@{#288412} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288412 0039d316-1c4b-4281-b951-d872f2087c98
-
andresp@chromium.org authored
BUG=367114 Review URL: https://codereview.chromium.org/453013002 Cr-Commit-Position: refs/heads/master@{#288411} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288411 0039d316-1c4b-4281-b951-d872f2087c98
-
mathp@chromium.org authored
This will only affect the Local NTP (offline). Also, in Local NTP use the @2x version and let Chrome downscale it (recommended way, done on the online NTP). BUG=363519 R=oshima@chromium.org Review URL: https://codereview.chromium.org/450313002 Cr-Commit-Position: refs/heads/master@{#288409} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288409 0039d316-1c4b-4281-b951-d872f2087c98
-
noyau@chromium.org authored
These utility functions are used on iOS and Android. BUG=None Review URL: https://codereview.chromium.org/452913002 Cr-Commit-Position: refs/heads/master@{#288408} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288408 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
This is a step towards allowing WebUI to directly embed guest views. BUG=386838 R=fsamuel@chromium.org Review URL: https://codereview.chromium.org/426593007 Cr-Commit-Position: refs/heads/master@{#288407} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288407 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
This could happen in cases where we initiate a transfer but end up navigating in the original SiteInstance. BUG=402018 TEST=No proxy host for the current RFH after navigating an about:blank tab. Review URL: https://codereview.chromium.org/452673002 Cr-Commit-Position: refs/heads/master@{#288406} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288406 0039d316-1c4b-4281-b951-d872f2087c98
-
ajith.v@samsung.com authored
Normally, the paste popup is hidden when its position changes. However, there are legitimate cases outside of scrolling where the position may change, e.g., due to a resize, where the popup should remain visible. Handle this case by only hiding the popup if its position changes while scrolling. BUG=380084 Review URL: https://codereview.chromium.org/312293002 Cr-Commit-Position: refs/heads/master@{#288404} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288404 0039d316-1c4b-4281-b951-d872f2087c98
-
hartmanng@chromium.org authored
We can miss applying a transform if we have a transformed, partially occluded DelegatedRendererLayerImpl with a contributing RenderPass. This causes the wrong transform to be sent into the occlusion tracker, so occlusion gets applied incorrectly, which hides desired content. BUG=379072,390873 Review URL: https://codereview.chromium.org/447193005 Cr-Commit-Position: refs/heads/master@{#288403} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288403 0039d316-1c4b-4281-b951-d872f2087c98
-
alekseys@chromium.org authored
BUG=401344 Review URL: https://codereview.chromium.org/447963005 Cr-Commit-Position: refs/heads/master@{#288402} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288402 0039d316-1c4b-4281-b951-d872f2087c98
-
felt@chromium.org authored
According to Alan, the shadow on the SSL warning illustration was 1px off. This updates the pngs. BUG=401289 R=bauerb@chromium.org Review URL: https://codereview.chromium.org/457433002 Cr-Commit-Position: refs/heads/master@{#288401} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288401 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Reason: blink_glue.* is too generic for this. It just contains a single function to convert from base::File::Info to blink::WebFileInfo. Similar to web_url_request_util.h and pepper_file_util.h. BUG=345892 TEST=None R=avi@chromium.org Review URL: https://codereview.chromium.org/455623002 Cr-Commit-Position: refs/heads/master@{#288399} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288399 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288398} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288398 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179817:179832&mode=html TBR=jbroman@chromium.org,zerny@chromium.org BUG= Review URL: https://codereview.chromium.org/458493002 Cr-Commit-Position: refs/heads/master@{#288397} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288397 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This eliminates some dependencies from NetworkingPrivateServiceClient that will allow it to be moved to src/extensions. It also changes NetworkingPrivatCrypto from a class to a namespace since that is how we use it. BUG=363776 Review URL: https://codereview.chromium.org/442073003 Cr-Commit-Position: refs/heads/master@{#288396} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288396 0039d316-1c4b-4281-b951-d872f2087c98
-
morrita@chromium.org authored
Don't bother IPC owners with mojo changes. TEST=none BUG=none R=darin@chromium.org,jam@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/451073002 Cr-Commit-Position: refs/heads/master@{#288395} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288395 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://settings/overlayNamechrome://help/channel-change-pagemichaelpg@chromium.org authored
uber.onContentFrameLoaded is mistakenly called *after* the overlay is opened. This function always brings the navigation frame to the foreground, so it should be called before any overlay might be opened. The overlay being opened will then cause the navigation frame to recede into the background. This was inadvertently broken in r287989 (issue 423533003). BUG=401903 TBR=dbeam@chromium.org Review URL: https://codereview.chromium.org/452113002 Cr-Commit-Position: refs/heads/master@{#288394} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288394 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
Quick Launch shortcut. InstallShortcutTest.CreateAllShortcutsSystemLevel has been broken since http://crrev.com/164849 ... The test expectations had not been adjusted in this CL as setup_unittests.exe doesn't run on the waterfall yet (issue #153829) and the breakage had gone unnoticed. Expectations have now been adjusted such that we no longer expect a system-level (Default-user) Quick Launch shortcut, but a per-user Quick Launch shortcut for the admin running the install as the product code's logic has been doing for over a year... Also remove the code cleaning up the legacy Default-user Quick Launch shortcut as this cleanup code has been running for 21 months now and leaving this shortcut behind for a few users is a no-op (i.e. the Default-user shortcut will get copied to new Windows profiles and Active Setup will kick in a few seconds later to try to install the same shortcut which will already exist... the UX result will be the same: a single Chrome Quick Launch shortcut will be installed). BUG=329239, 153829 Review URL: https://codereview.chromium.org/432273005 Cr-Commit-Position: refs/heads/master@{#288393} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288393 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
Revert of Revert of [Android] Use UIResource for overscroll glow (https://codereview.chromium.org/454863003/) Reason for revert: The ToT builder failures appear to be unrelated to this change, and the upstream instrumentation already exercise these code paths. Tentatively reverting the revert and will keep an eye on downstream rolls. Original issue's description: > Revert of [Android] Use UIResource for overscroll glow (https://codereview.chromium.org/422013003/) > > Reason for revert: > This is breaking chrome ToT downstream and the change quie complex so > I don't feel qualified to try to fix it in place. > > The failure we hit is > F/chromium( 2961): [FATAL:system_ui_resource_manager_impl.cc(35)] Check failed: !bitmap.empty(). > > See an example of a failed run in > https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/32007 > > (but just trying to boot clank with this patch will trigger it) > > > Original issue's description: > > [Android] Use UIResource for overscroll glow > > > > Introduce a SystemUIResourceManager class for loading and providing access to > > shared UIResourceId's. Wire this class to the existing OverscrollGlow effect, > > using the shared id's with a UIResourceLayer for both glow and edge layers. > > > > This patch is a subset of powei@'s original SystemUIResource patch found at > > https://codereview.chromium.org/377013002/. > > > > BUG=326326 > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288095 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288330 TBR=aelias@chromium.org,powei@chromium.org,yfriedman@chromium.org,sky@chromium.org,miguelg@chromium.org NOTREECHECKS=true NOTRY=true BUG=326326 Review URL: https://codereview.chromium.org/454113002 Cr-Commit-Position: refs/heads/master@{#288392} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288392 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288391} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288391 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288390} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288390 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/447353002/abarth@chromium.org authored
Reason for revert: I misunderstood the outcome of the discussion surrounding this topic. We need to keep this code in order to not break google.com while gathering data about this feature. Original issue's description: > Enable HTMLMediaElement@autoplay on Android > > This CL sets user_gesture_required_for_media_playback to false in Chrome for > Android. Previously, we removed this requirement as a special case for the > Google Search Results page. Now that this setting matches Chrome's behavior on > other platforms, we don't need the special case for google.com and can remove > the entire VoiceSearchTabHelper. > > This CL leaves the user_gesture_required_for_media_playback WebPreference > because that's used by android_webview. > > R=klobag@chromium.org, darin@chromium.org > BUG=178297 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288308 TBR=darin@chromium.org,klobag@chromium.org NOTREECHECKS=true NOTRY=true BUG=178297 Review URL: https://codereview.chromium.org/453023002 Cr-Commit-Position: refs/heads/master@{#288389} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288389 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
This way I don't have to duplicate it across bots. I'll remove from the other files once the recipe side has been updated. BUG=109173 TEST=none R=thakis@chromium.org Review URL: https://codereview.chromium.org/450403002 Cr-Commit-Position: refs/heads/master@{#288388} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288388 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
BUG=383635 Review URL: https://codereview.chromium.org/445353003 Cr-Commit-Position: refs/heads/master@{#288387} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288387 0039d316-1c4b-4281-b951-d872f2087c98
-