GitLab

GDataEntry::FromProtoString() fails if incompatible proto is detected
We should return an error rather than DCHECK it.
See crbug.com/142912 for how incompatible proto is rejected.

BUG=127856
TEST=out/Release/unit_tests --gtest_filter=GDataDBTest.*

Review URL: https://chromiumcodereview.appspot.com/10701118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133432
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10702038

TBR=junov@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10690120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145949 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145948 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10698132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145947 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of browser::FindTabbedBrowser call in pyauto's OpenProfileWindow. The tests that use it all use it to create a new window.

BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10695121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145946 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=check_perms

Review URL: https://chromiumcodereview.appspot.com/10700147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145945 0039d316-1c4b-4281-b951-d872f2087c98

Ensure static BrowserContext methods only get called on the UI thread. Also ensure ResourceContext methods only get called on the IO thread.
Review URL: https://chromiumcodereview.appspot.com/10764015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145944 0039d316-1c4b-4281-b951-d872f2087c98

Having this member was awkward, as it's inconsistent
with other states, which are all stored in |cache_state|.

BUG=136390
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10698124

TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10704129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145936 0039d316-1c4b-4281-b951-d872f2087c98

Having this member was awkward, as it's inconsistent
with other states, which are all stored in |cache_state|.

BUG=136390
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10698124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145933 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/133576
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10696148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145932 0039d316-1c4b-4281-b951-d872f2087c98

"Paste and go" state was being calculated wrong on views (at least).  Fix by making this calculation stateless.

BUG=135202
TEST=Start Chrome, navigate to a URL, copy some non-URL text, right-click the omnibox, and verify "paste and search" is shown.  Copy a URL and right-click and verify "paste and go" is shown.
Review URL: https://chromiumcodereview.appspot.com/10704074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136548
TBR=yzshen@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10695127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10703120

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145929 0039d316-1c4b-4281-b951-d872f2087c98

Small patch to set correctly endianness for MIPS arch.

BUG=https://code.google.com/p/chromium/issues/detail?id=130022
TEST=make chrome

Review URL: https://chromiumcodereview.appspot.com/10752020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145928 0039d316-1c4b-4281-b951-d872f2087c98

On Android, renderer sandboxing prevents us from opening files and so
ResourceBundle is initialized with file descriptors passed in at process
creation. This change adds methods to DataPack and ResourceBundle to
support loading/initializing from PlatformFile in addition to the
current FilePath.

Also, the current methods are renamed so that the naming is consistent
between these two files.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10686005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136562
TBR=mtytel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10696156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145926 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133432
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10702038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145925 0039d316-1c4b-4281-b951-d872f2087c98

This is the Chromium side of http://webk.it/87399.

BUG=130425
TEST=None yet. Confirmed plugin is instantiated when GetClient()->createHelperPlugin(frame_); is added to WebMediaPlayerImpl::play().


Review URL: https://chromiumcodereview.appspot.com/10442102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145924 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145923 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10695123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145922 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153115
TEST=self

Review URL: https://chromiumcodereview.appspot.com/10701124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145920 0039d316-1c4b-4281-b951-d872f2087c98

Ran in on Windows. It worked here. Not sure why it failed on bots a week ago.

BUG=135229
TEST=it IS a test


Review URL: https://chromiumcodereview.appspot.com/10748014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145916 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136548
TBR=yzshen@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10736012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145915 0039d316-1c4b-4281-b951-d872f2087c98

TBR=benrg@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10689136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145913 0039d316-1c4b-4281-b951-d872f2087c98

This code hasn't been used since M19 - as of M20 canvas_skia.cc is used instead.

BUG=105550
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10735009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145911 0039d316-1c4b-4281-b951-d872f2087c98

This causes a compile warning.

Review URL: https://chromiumcodereview.appspot.com/10702124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145910 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that some of the version shear crashes happen to users with non-local profiles. In this case, it's easy to imagine that the version info in the registry is out of sync with that on the filesystem.

Copied from http://codereview.chromium.org/10740003/.  Try jobs on the first pass missed a compile break in chrome_nacl_win64.

BUG=78585
TEST=none
TBR=siggi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10698129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145908 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none
TEST= none

Review URL: https://chromiumcodereview.appspot.com/10762009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145907 0039d316-1c4b-4281-b951-d872f2087c98

A crash can happen when the token is received after the
NavigationController is destroyed. This change prevents this by listening
to WebContents being destroyed.

BUG=None
TEST=None
R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10692074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145903 0039d316-1c4b-4281-b951-d872f2087c98

CID=104368

R=miket@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10765014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145902 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10765008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145901 0039d316-1c4b-4281-b951-d872f2087c98

Some FFmpeg SIMD functions overread/write slightly to have
more efficient buffer access code. Not adding padding thus
can lead to overreads/bytes (and crashes) when the buffer
pointer points near the end of the frame boundaries.

BUG=136231

Review URL: https://chromiumcodereview.appspot.com/10765015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145900 0039d316-1c4b-4281-b951-d872f2087c98

This is speculative, since we don't have the underlying support in NaClIPCAdapter. But I verified locally that it works as well as it did before (i.e., sending data works).

BUG=116317
TEST=


Review URL: https://chromiumcodereview.appspot.com/10750005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145899 0039d316-1c4b-4281-b951-d872f2087c98

Moved ExtensionPrefs, ExtensionPrefsScope, and TestExtensionPrefs into
extensions namespace.

BUG=135024, 117261


Review URL: https://chromiumcodereview.appspot.com/10704023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145898 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10700127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145897 0039d316-1c4b-4281-b951-d872f2087c98

 The owner of an infobar delegate might be NULL if the infobar is
already in the process of being deleted. Checking for this before asking
it to dismiss in the auto-login infobar.

TEST=None
BUG=None


Review URL: https://chromiumcodereview.appspot.com/10701080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=fischman

Review URL: https://chromiumcodereview.appspot.com/10704130

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145895 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that some of the version shear crashes happen to users with non-local profiles.  In this case, it's easy to imagine that the version info in the registry is out of sync with that on the filesystem.

BUG=78585
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10740003

TBR=grt@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10704132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145894 0039d316-1c4b-4281-b951-d872f2087c98