- 18 Nov, 2020 40 commits
-
-
Sebastien Marchand authored
This is not needed anymore. Change-Id: I610d2d8f195ab7fea15d6ac0eeec9bfe1c18275f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542363Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#828611}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a388aa297c47..2981f64209b4 2020-11-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I67433c6bbf27b2416bea5de002fa4c044ec9b16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545438Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828610}
-
Lingqi Chi authored
Some new features, such as prerendering, need to defer some binding interface requests or stop the renderer when an unexpected mojo pipe is requested to set up. This CL introduces MojoBinderPolicyApplier that manages binding requests and integrates it with BrowserInterfaceBroker. Regarding the MojoBinderPolicyApplier, it should be initialized with a predefined policy map. It decide the actions the applier takes when handling incoming requests. Based on the predefined policies and the current state, a MojoBinderPolicyApplier instance may take the following actions: 1. Bind the given interface immediately. (kGrant or `ResolveDeferredBinders` has been invoked) 2. Delay binding the interface until `ResolveDeferredBinders` is called. (kDefer) 3. Call the cancelling closure. (kCancel) 4. Stop the renderer and collect some metrics for analysis. (kUnexpected) Bug: 1132752 Change-Id: Ifdc2f0b27d2f4613274fe5c6e44ddb056a199509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513960 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Yuly Novikov authored
Change downscaled video trace_test expectations to no zero_copy, because zero_copy is only used for fullsize or upscaled video. Bug: 1079393 Change-Id: If3bc6283621ce7d566a78f685549b138b71cb17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545260Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828608}
-
Eric Lin authored
A previous CL collaps transfer status on the C++ side. Only a limit number of transfer status updates are passed through to JS. This is blocking some testing automation: https://crbug.com/1136365#c19 For example, kComplete is mapped to kInProgress. This CL map 1:1 for all statuses. Manually verified using: Nearby Share tile for receiving a file. Nearby Share sheet to send a file. As a sender from Nearby Share sheet, select the receiver at sender side then reject the connection at receiver side. Run a JS script to register the onTransferUpdate event and check kComplete can be received when transmission done. Bug: 1149598 Change-Id: Ic5bfef95b4e51b16fbc895a42aad578840efa2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543528Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Eric Lin <ericth@google.com> Cr-Commit-Position: refs/heads/master@{#828607}
-
Weiliang Chen authored
Add an about:flag entry for using HUD to show the performance metrics. This is a debug usage flag so it should not expire. Bug: 1149385 Change-Id: Ia6b658d973c6b56ed501f9b0fcba5cc24395f9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538128 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#828606}
-
Yu-Hsuan Hsu authored
Support GetAssociatedOutputDeviceID on lacros-chrome, which returns the output device ID having the same device name as the given input ID. BUG=b:173113548 Change-Id: I8530e4d80a40010cd38e7183ed95ea5c06e55e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536664 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#828605}
-
Patrick Monette authored
Bug: 971272 Change-Id: I8beac0e036d84884e4c13a2b7d84c4d8b2d1ce6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533535 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#828604}
-
Dave Tapuska authored
Along with moving SetAutoResizeMode and DidAutoResize into base, move a few things that are necessary to move auto resize handling into base, the size and synchronous resize mode setting. BUG=1097816 Change-Id: I41890ab7586cfdbc9df04d4b08b1d3701e98f1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540846 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828603}
-
Ahmed Fakhry authored
In this CL, we handle: - Imminent suspends. - User switches in multi-profile sessions. BUG=1142994 TEST=Added new tests Change-Id: I31da5c8cfb4f2648b2a34b206673eb59cce69f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538590 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828602}
-
Jiewei Qian authored
This reverts commit 706526c7. Reason for revert: Speculative reverting this for failures in external/wpt/html/semantics/tabular-data/processing-model-1/span-limits.html on Mac10.13 Tests (dbg) bot. Since this file touches things related to span before the first failure. Original change's description: > Move OutlineRectsShouldIncludeBlockVisualOverflow to ComputedStyle > > Moving to |ComputedStyle| has following benefits: > * Reduces the usage of |LayoutObject| in NG code. > * Uses first-line style correctly when we have > |NGPhysicalFragment|. > > This patch has no behavior changes. > > Bug: 1145048 > Change-Id: If1298087754286e7a5ec1935fc1ba52d1298770f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536585 > Reviewed-by: Aleks Totic <atotic@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827948} TBR=kojii@chromium.org,atotic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145048 Change-Id: I7473ebbce84f5a8496674de250eee9f306bca815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545852Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828601}
-
Jimmy Gong authored
Add aria-labels to buttons for improved a11y experience with NearbyShare onboarding page. Bug: 1148456 Test: Local Change-Id: I706d9c28c0947ff40432f4c932846a1748224193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545194Reviewed-by:
-
Evan Stade authored
AppBannerManager is the only callsite, and it has platform-specific implementations. IsWebAppInstalledForUrl has platform-specific implementations as well. Thus it fits nicely into AppBannerManager{Desktop,Android}. The rest of installable_utils is not needed by WebLayer, so this crosses one more file off the componentization TODO list. Bug: 1147268 Change-Id: I783942d31c993d67bc57ed08b4f2f2541ce911ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537925 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30e311332350..262a64839ac8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: qjw@google.com Change-Id: I1a88a1b2ff6c6ca925c1cdeaa034924dbfa91b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828598}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/698385d4e2b4..a0758a1aef12 2020-11-18 jiawei.shao@intel.com D3D12: Only enable toggle 'use_dxc' when Dawn can load DXC DLLs 2020-11-17 cwallez@chromium.org Use hermetic XCode on Dawn standalone builders. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I379ed9c792eb197a14fb8fd6f41b5f37263c38a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545989Reviewed-by:
-
tby authored
We're still experimenting with this feature, so let's push the flag expiry out. Change-Id: I27ac6b4e7051795c8d886506071c614313ce94ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543863 Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#828596}
-
Eric Orth authored
Go beyond the capabilities of the current address result handling by allowing results in any order, as long as it creates a complete chain from query name to the result name(s). The ordering requirement used in the current-but-quickly-becoming-legacy address result handling is generally followed by the DNS ecosystem, but as far as I can tell, not officially required by any spec. Plus, we will soon start allowing similar HTTPS aliasing, which will not require any specific response ordering. Bug: 1147247,640596 Change-Id: Id10767d34a2c638b142123145cd41dfe0dee0fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532514Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#828595}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0b81ac61..3644d1fc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4ed02222e85b6c98f7c5881838c4af6fe49a3c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546166Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828594}
-
Fergus Dall authored
Bug: none Change-Id: I0c151d1ad7a1823bb1520aae952f11d6fd23b32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546383 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#828593}
-
Anupam Snigdha authored
When the hyperlink is entirely selected, currently we do not remove the hyperlink, but rather do a replaceData operation in |SetCharacterDataCommand::DoApply| to insert the character that the user has typed into the hyperlink and the subsequent characters are inserted outside the hyperlink. This change deletes the hyperlink when user selects the entire hyperlink and types a single character. However, we do not replace the hyperlink if insertText operation inserts a text (more than one character) into the hyperlink when the entire link's content is selected. Test: web_tests/editing/execCommand/insert_text_hyperlink_replace.html Bug: 848506 Change-Id: Ied50697792f8d496ce59792129f5947f782da5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545686Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#828592}
-
Evan Stade authored
The functionality made it to the stable branch of 87. Bug: 1146058 Change-Id: Ib52dfccd62f2874237a6464b414130aebbc77887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545868 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828591}
-
Shakti Sahu authored
This CL fixes a string for read later introduction IPH. Bug: 1150005 Change-Id: I32289ebe281619e12d27e0011727d4639d24a600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543839 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#828590}
-
tby authored
This implements the ProvideIndependentMetrics API within the structured metrics provider, ready to upload independent metrics. We can't actually enable this yet, because of issues described in the TODO. Unit tests to come once a related CL is also landed. Bug: 1148168 Change-Id: I4fb739c7cbb2ecea54da82fe8382140cdf562946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543882Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed87c16ad00e..2ffff6d024c7 2020-11-17 syoussefi@chromium.org Vulkan: Support image buffers 2020-11-17 cclao@google.com Vulkan: Experimental: forcing highp to mediump in fragment shader. 2020-11-17 syoussefi@chromium.org Default deqp to Vulkan on !Apple 2020-11-17 kainino@chromium.org Add TODOs for Apple DTK skips; update bug urls 2020-11-17 m.maiya@samsung.com Vulkan: Add EXT_external_buffer support 2020-11-17 kainino@chromium.org Disable more tests for Apple DTK (macOS ARM) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132295 Tbr: cnorthrop@google.com Test: Test: ExternalBufferTestES31.*Vulkan Change-Id: I8c92db1567a6d8a991a714bc03203676c4d2c706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545703Reviewed-by:
-
Dirk Pranke authored
https://crrev.com/c/2229335 added a dependency on `six` from test_env.py in order to try and make it compatible with both Python 2 and Python 3. However, it got the path to the //third_party version of six wrong, and so it actually only worked if six was available otherwise in the Python install (which it is, most of the time, these days). The script didn't actually benefit much from six, though, so rather than fix the import path, this CL just makes the code 2- and 3-compatible without needing six, and removes the dependency instead. Bug: 942720 Change-Id: I44e44772cea8d92eff10a5c59879ce4d05de8fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545924 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#828587}
-
Josip Sokcevic authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //content. R=falken@chromium.org Bug: 1113033 Change-Id: Ie85022f566d7017f3d1950f93e2192ce62f4f000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544850 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
-
Johann authored
Bind the battery monitor to the RenderFrameHostImpl BIB instead of the RenderProcessHostImpl BIB. This allows freezing/managing the interface with more granularity. Remove multiple-windows tests. These were necessary when multiple windows could share the same mojo connection. Since each page has its own connection these tests are no longer necessary. Bug: 1126758 Change-Id: Iba5a928105d19a9e86f9100fa6fdcf356b847c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500968Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#828585}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605625046-b998d997d9684c194050542ad9b812298a5a0da2.profdata to chrome-win64-master-1605646753-b6e30e01e5beed347db34dbd1e74ff9cda422393.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7f93d12b40173b7713746a0edfdc9384c677f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545985Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for MenuPart::Type. enum class is more type safety. Bug: 940736 Change-Id: I7b412d7b61584b80a9f9b20c22ecf69533288203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543535 Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828583}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I1963a9fac223da898fa8ffa33368d88bcc226844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545048Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828582}
-
Findit authored
This reverts commit 8ad25003. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 828478 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGFkMjUwMDNkZTgwODIxMjhjM2IzNDU2NWVhMjg4ZGM3OGZhODhkYgw Sample Failed Build: https://ci.chromium.org/b/8863329295603494640 Sample Failed Step: mojo_unittests on (none) GPU on Mac on Mac-10.14.6 Sample Flaky Test: NodeChannelTest.MessagesCannotBeSmallerThanOldestVersion Original change's description: > Mojo: NodeChannel should require a minimum size when using multiple versions > > When we added support for versioned message we accidentally introduced a > behavior where messages can be shorter than expected. This is what the > behavior should be to allow older messages to be received. However, > we know the minimum size is the oldest message version. We should > never be allowed to go smaller than that. > > BUG=chromium:1149805 > > Change-Id: I3a24dd62b6fafd742cd7ac155f863d33bb5c6de8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545207 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Brian Geffon <bgeffon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828478} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:1149805 Change-Id: I0bb4a4605a1f705c4388769fae4559e0835d1980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546460 Cr-Commit-Position: refs/heads/master@{#828581}
-
Mike Wasserman authored
Restore before moving across displays, re-maximize on exit. Add a simple interactive ui test. Bug: 1149666 Change-Id: I57caa7f8f5c7351e4489ef7aad6387111bf4c7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542763Reviewed-by:
-
Weiliang Chen authored
Set up a feature flag and corresponding state inside cc to enable using HUD for displaying performance metrics. Currently when we enable the show performance metrics flag we only add WebVitals metrics, which comes from Blink. We might want to add other metrics in the future. TBR=sadrul, bokan@chromium.org Bug: 1149385 Change-Id: I718ef95d782ee2f1bb3ac13dd296e48b0c3e25bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540570 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#828221} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545088Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828579}
-
Anton Bikineev authored
This improves scanning time by... 36x (from 116ms to 3ms) on cnn:2020. As a bonus, it fixes some of the test failures. Bug: 11297512 Change-Id: I826c338ca19bec5815c0c16aedb7f9222f110a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544942 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#828578}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28de54004087..a388aa297c47 2020-11-18 andoli@chromium.org Adds localization to legacy view extensions 2020-11-18 andoli@chromium.org Includes extra runtime look up into the new view extension infrastructure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5432a2beb19c8f9123f1483086a3bbd97ac971ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545609Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/80f68fb067c7..309eb9b67205 2020-11-18 bsheedy@chromium.org Reland "[typ] Use requests for ResultSink" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1147992 Tbr: rmhasan@google.com Change-Id: Ia340a3e3b9d54cbf1d4cf992d6393b6d52ecb0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545988Reviewed-by:
-
Sammie Quon authored
This is a reland of 536b412d Original patch crashed with ASAN bots because it was trying to access variable that was part of destroyed object. Original change's description: > desks: Speculative fix for crash. > > The previous attempt [1] added checks for whether the starting or ending > screenshot was taken. In the case of the starting screenshot missing, it > would signal the animation to remove some RootWindowDeskSwitchAnimators, > leading to a vector out of bounds. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2506356 > > Bug: 1148607 > Test: added regression test > Change-Id: I7f14df877cb93619a0ca8a85f5d0ad434dda3ad2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536934 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828034} Bug: 1148607 Change-Id: Iec8fa6e68c182e2447399e74b42c742423a0c48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542598 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#828575}
-
Ahmed Fakhry authored
This is a follow-up CL to handle requests made on the recording service CL (https://crrev.com/c/2404145): - The Record*() APIs of the service should provide the needed client, video capturer, and audio stream factory, instead of exposing APIs in the client so that anyone can bind to those capturers. - The service is launched to handle video recording, and terminated once recording ends, and all the chunks have been sent. - A GPU crash is handled by ending the recording. BUG=1126586, 1147989, 1143411 TEST=Manually, existing tests. Change-Id: I235cb1f9ee81dbbc42e21d0a222d32bcafa7a0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536030Reviewed-by:
-
Dale Curtis authored
Now that we're building with the official SDK these aren't needed anymore. Bug: 1105187, 1115294 Test: Bots are okay, manually confirmed VP9 hardware decoding on Big Sur. Change-Id: I9d190989a23266a5615cb149b4a958ad46d39611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545880 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828573}
-
Darren Shen authored
Use ScopedObservation and fix up some style. Bug: 1148157 Change-Id: I56ec7fe2db2ab768c7af37c85fff76670db03c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537254 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#828572}
-
