- 18 Sep, 2020 40 commits
-
-
Michael Thiessen authored
Introduces JUnitTestGURLs, which returns GURLs generated from serialized GURLs for use in junit tests where the native library cannot be loaded. This allows junit tests to do simple operations with GURLs and allow unit testing of classes that use GURL without caring too much about more complex things like formatting or comparing origins, etc. The alternative to this is migrating the junit tests to instrumentation tests, but this isn't always feasible. For example, QualityEnforcerUnitTest is really difficult to re-write as an instrumentation test because of how it mocks out Activity behaviour and tests toasts. Bug: 783819 Change-Id: I37cf3a869958bd30e7ae86d2b212fd19961c1d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417063Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#808347}
-
Jesse Schettler authored
When scanning is disabled, the scan SWA is disabled and chrome://scanning is forwarded to chrome://app-disabled. Bug: b:167569193 Change-Id: Ib9b3eb83f501470f6711a954abb68f12b479cead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406180 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#808346}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9eaa69c21c45..4dcc12d1a441 2020-09-18 rex.xu@amd.com SPIRV: Add more utility functions to build some opcodes (#2398) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: If6d867a6904166d92a14b06aea3b50dfab8d682b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808345}
-
Clark DuVall authored
I forgot to fix this earlier, this makes it so manifest paths don't need to be fully qualified. Bug: 1126301 Change-Id: I586e9830d61b0a1c76f5f357657b1d6e78e1b742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417541Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#808344}
-
Benoit Lize authored
PartitionAlloc's main lock is the per-PartitionRoot lock. It has to be fast on the common uncontended path, and better than a simple spinlock when it's contended. Past attempts to replace it with base::Lock regressed low and high-level benchmarks. This commit introduces SpinningFutex, a futex()-based lock which spins in userspace like SpinLock before calling into the kernel, like base::Lock does. It is intended to be as fast as SpinLock, but better for contended cases. Since it relies on the linux-specific futex() system call, this is only available on Linux-based kernels, for now. Bug: 1125866, 1125999, 1061437 Change-Id: I1e0cf23beb48c32518d0ffc293d1a9326bc2d7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409902 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#808343}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/076fddf19f32..913c13b2757b 2020-09-18 petermarshall@chromium.org [typescript] TypeScript-ify accessibility/AccessibilityAttributesView.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I462987aa0d7567fdc3ca74b9d28270ccb3ee9eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418365Reviewed-by:
-
Titouan Rigoudy authored
The is_web_secure_context bit for a document should take into account the bit set on its parent, if any. This is not the case for now, so this test demonstrates the bug. Bug: chromium:1126856 Change-Id: I45ebe97f0eb50034f933048b37f3c68eb778dfa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414248 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808341}
-
Francois Doray authored
crbug.com/1121339 indicates that there can be a null-pointer access in ContentToVisibleTimeReporter::RecordHistogramsAndTraceEvents() on Mac since 87.0.4241.0. The accessed variable is likely |tab_switch_start_state_|. Since |tab_switch_start_state_| is set before issuing RecordHistogramsAndTraceEvents() callback and reset at the end of that callback, a null-pointer access suggests that TabWasShown() was invoked twice, without a call to RecordHistogramsAndTraceEvents() or TabWasHidden() in-between. To mitigate the crash, this CL invalidates previously issued callbacks when TabWasShown() is invoked. This mitigation is useful to avoid crashes in branch M87. In a separate CL, we will add a DumpWithoutCrashing() to diagnose cases where TabWasShown() is invoked twice, without a call to RecordHistogramsAndTraceEvents() or TabWasHidden() in-between. Bug: 1121339 Change-Id: I6526cf3a001e9647c5f8ec1081f4747f94a160f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414408 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#808340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec598d5b00eb..feb4d10f7b2d 2020-09-18 mtklein@google.com tweak gathers in skvm interpreter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I7a91fb3ece1337c5c5cdf859e6086b11d465d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418364Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8cf89f57dc90..236701a9c910 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andruud@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andruud@google.com Change-Id: I13b28e3ed35bd7c02d74ecf473b4acbd3b379dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808338}
-
Benoit Lize authored
ThreadCache::Purge() is called from PartitionRoot::PurgeMemory(), which holds the lock, whereas freeing the thread cache memory in ThreadCache::Purge() calls PartitionRoot::RawFreeStatic(), which also acquires the lock. This deadlocks the allocator. Bug: 998048 Change-Id: Ifd61b3c463ed2372adf6a1b479ace1c9eab86da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418311 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
Dave Tapuska authored
In order to use this definition in blink we need to move it outside of content. Since the definition of the header file is in cc, it makes sense to move this into cc as well. BUG=1097816 Change-Id: Ifce47e0cc3f4ff4d2460cc274cadc1377fd24252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411941Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#808336}
-
Charlie Hu authored
This CL updates comments and fuzzer seeds content according to current document policy syntax and document policy feature names. Bug: 1113375 Change-Id: Ia751abcaeb970436b73e0af8dd1f7031a96dfe84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416876Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#808335}
-
Morten Stenshorne authored
And vice versa: Treat legacy objects as monolithic inside NG block fragmentation. The two block fragmentation implementations (NG and legacy) cannot cooperate, so once we switch engine somewhere inside a fragmentation context, we need to treat that subtree as monolithic. This requires us to specify which fragmentation engine is being in use when calling GetPaginationBreakability(), at least when possible at all. This required some work in LayoutFlowThread and LayoutMultiColumnFlowThread. Bug: 1127112 Change-Id: I8e0c4d17fd8985c488614e01db23a0c63e899679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416069 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#808334}
-
Luke Zielinski authored
results-viewer For any test that is run we attempt to lookup its associated metadata ini files in the source tree. If it exists, it gets copied to the results viewer directory and renamed to <test>-expected.txt Bug: 1127360 Change-Id: Ie2f68e9f07c468918b69be041d247a1033ce500c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412622Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#808333}
-
Victor Vasiliev authored
This switches all QUICHE container aliases to the appropriate type of hash map, switches optional to absl::optional, and also changes some of the macros. Bug: 1128392 Change-Id: I47384d899c509170cd8d46208ee6a7eeac78d59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416945Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#808332}
-
Takashi Sakamoto authored
Change-Id: Ibbc7228faedc039a679864e11dd17763ebed97c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415754 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#808331}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2cf9523..1d480934 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a79cdd31561ded4b07a3e49edd75f966548530b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418611Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808330}
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves content::UniqueNameHelper to blink, and a unit test file will be moved with a followup CL for moving {page_state_serialization.cc, h} by the dependency. Bug: 1110246 Change-Id: Iaae877403e27eeda2146191854e1a6f2b29f2e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415912Reviewed-by: -
Henrique Ferreiro authored
This allows to remove explicit typedefs from cursor.h. Bug: 796644 Change-Id: I91a8faf3a2a478a2d834795a4701114d17f9ea64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416592Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#808328}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d6498a41ab4e..c01b26490a54 2020-09-18 cwallez@chromium.org Remove wgpu::BindingType::StorageTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I93cb2d8f17a088f3446e6a69e698dd417a62c8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418360Reviewed-by:
-
Tim Volodine authored
As per code inclusion practices (go/avoid-whitelist), replace "IsUrlWhitelisted" with "IsUrlAllowlisted" in UrlCheckerDelegate, its subclasses and method calls for all relevant platforms. BUG=1124420 Change-Id: Ia0eed45e8357b10a7887ecdcb63ef2a48a687c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404933 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#808326}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600408803-cf78b7068fa61ec1aacbec5ee17841a8e2bbd57a.profdata to chrome-linux-master-1600430187-d29b7adeb10d561801760f89eec79cec9539af2e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I1ddb0cd33076e93c91fbd25c79acc9a4a4ae1d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418366Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1eb3e4c9ba5c..8d875587d515 2020-09-18 kwiberg@webrtc.org Cancer Stick Castle: Clarify copyability and movability If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id8ed63b106c125f7df13e19eb89b1df99cd8e4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418358Reviewed-by:
-
arthursonzogni authored
A regression has been introduced by [1]: ``` [COOP] access reporting: Clear old CoopAccessMonitor. https://chromium-review.googlesource.com/c/chromium/src/+/2408752 ``` Instead of accumulating the CoopAccessMonitor for the same pair of (accessing, accessed) window, it limited it to one and kept only the most recent one. This is an issue, because both the accessing and the accessed window might have a reporter defined. We must keep both for supporting sending reports toward both. This patch adds regressions tests. Bug: 1090273 Change-Id: I2a3aa7f26458db820d3383245c60c5f3f917acd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414308Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#808323}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600300188-843ccc7f4981299b9d59bff076f7994d3bf42fe8.profdata to chrome-win32-master-1600387025-c38924cc9d65da7bb095e05e5b8c2168202d7a81.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id7207f49f2b08514eb93b8b21cfe1fb6db0d7bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417754Reviewed-by:
-
Ehimare Okoyomon authored
Create two page info static helpers to determine if we are on an internal page and if a permission is factory default. Change references. Bug: 1077766 Change-Id: Ica6e13b5438b0d18a5fe9e424cd3017bb4ce1b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395756 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808321}
-
Ulan Degenbaev authored
Now V8DetailedMemoryReporterImpl::GetV8MemoryUsage measures the memory usage of the main V8 isolate and all workers in the renderer process. Bug:1085129 Change-Id: I9522e73ba8e88abc5e2679702ac87ca19c3abb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409914 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#808320}
-
Nicolas Ouellet-Payeur authored
Bug: 1124758 Change-Id: Ic95808d3c56f8461437f6dd5281fb332dd968955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416744 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#808319}
-
Sebastien Lalancette authored
Concurrent model-mutating actions (e.g. deleting a Bookmark via two-windows with context menus then trying to edit it in the second window) would crash the app. This can also happen via sync (where the delete action would be coming from another syncing device). Added guarding logic to prevent the new context menus (whose actions hold closure over models) actions from causing crashes. Bug: 1126030 Change-Id: Ice1d4f5e7b94bebd490938949304f411af8f0364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417210Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#808318}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/855c5cdcd364..076fddf19f32 2020-09-18 mlippautz@chromium.org HeapSnapshot: Process detached'ness state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110816 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iffcafc4714a91f4e3285fc0cc5de79d4c717db42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418354Reviewed-by:
-
Hiroshige Hayashizaki authored
The comment introduced at https://chromium-review.googlesource.com/c/chromium/src/+/1181430/25..30 should be about ScriptStreamer, not ScriptResource. Bug: None Change-Id: Ib29742e0c09b14f3e1f301cd9c079e6db10d8641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417680 Auto-Submit: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#808316}
-
John Palmer authored
Bug: b/168670584 Change-Id: Ifd45b0ccf4484cc9040ff30eded589122a8e53d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417671 Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#808315}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/837fe726e639..7257a3f99111 2020-09-17 thestig@chromium.org Move parts of PDFFuzzerPublic to a separate target. 2020-09-17 thestig@chromium.org Change pdf_fm2js_fuzzer to be a "public" fuzzer. 2020-09-17 tsepez@chromium.org Nest CXFA_TextParseContext as CXFA_TextParser::Context 2020-09-17 tsepez@chromium.org Make CJX_Object and its subclasses be garbage collected. 2020-09-17 tsepez@chromium.org Make CXFA_FMExpression and its subclasses be garbage collected. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I39e0b26b9470f31c251b0744ce4ad441206cd37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418018Reviewed-by:
-
Clemens Arbesser authored
Before this CL, Prompts had two competing ways to break on navigation. The first was in the controller, the second in the WaitForDom of the prompt action. It was likely a matter of timing which of the two would fire, which exlains why this did sometimes work, but not always. With this CL, the controller will not break the flow on navigation for jitt scripts, which resolves the problem. An example video of the result is attached to the bug below. Bug: b/168280710 Change-Id: I276bc0b343693013932ed1fddf0099f0fd44dbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414252 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#808313}
-
Mario Sanchez Prada authored
During the migration of FrameMsg_Stop from the legacy IPC to mojom, in crrev.com/c/2170232, we slightly altered the logic that would be run in the case where WebLocalFrameImpl::StopLoading() would be run not because of an IPC message from the browser process, but as a direct method call from PepperURLLoaderHost or PepperPluginInstanceImpl. In the original code, WebLocalFrameImpl::StopLoading() would be called from those Pepper-related classes, calling FrameLoader::StopAllLoaders() and nothing else after that. However, after crrev.com/c/2170232 calling that method would now rely on LocalFrame::StopLoading() instead, which will not only call FrameLoader::StopAllLoaders(), but also will end up notifying all the observers of RenderFrameImpl, that is, calling the RenderFrameObserver::OnStop() method for all of them (unless the frame is no longer in an attached state). While this implementation of LocalFrame::StopLoading() is equivalent to the former implementation of RenderFrameImpl::StopLoading() before that CL from the POV of handling a mojo message coming from the browser process, it is true that the code is not a 1:1 match for those cases where such method is called directly, as it's the case for calls from PepperURLLoaderHost and PepperPluginInstanceImpl. Thus, in order to preserve the original behaviour, let's restore the original code from WebLocalFrameImpl::StopLoading() and make it even more clear that such method is only used by those Pepper* classes by adding a "Deprecated" prefix to its name. This way, no observers will be notified and only FrameLoader::StopAllLoaders() will be run in that particular (and deprecated) case. Bug: 1120266 Change-Id: Ic876f5ba80245f2de999a964f4931f0d40cd94f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416691Reviewed-by:
-
Morten Stenshorne authored
Just like for MathML, custom layout (display:layout()) has no legacy layout engine implementation, so we need to force NG layout, even when contained by something that requires legacy fallback. Rewrote the mechanism somewhat; calling ComputedStyle() on an element isn't the right thing to do within Element::ShouldForceLegacyLayout() (it called ShouldForceNGLayout(), which did that), since ShouldForceLegacyLayout() is involved when style is about to change, or when it has just been changed. ShouldForceLegacyLayout() will now return true even if the display type requires LayoutNG. Cope with this by just not setting ForceLegacyLayout on any NG LayoutObjects at all. And remove a couple of DCHECKs in NG LayoutObject classes that expected legacy fallback not to be in use on the Element side. This is rather convoluted. :( Also update HTMLSlotElement::AttachLayoutTree(), which recently got modified to support legacy fallback properly. This fixes one of three DCHECK failures that occur in the fuzzer test in bug 1127112. Bug: 1127112 Change-Id: I16b5f5297cb04192056f6c5137c2cefa1bc33298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414289Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 470edb3e. With Chromium commits locally applied on WPT: c2ab413e "CSS: Retire expansion-based implementation of :is and :where" aaab8ee4 "CSS: Rename new WPTs for uniqueness" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I2ee844ca48c968127ee32edfdb6a8be3d985b955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418111Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808310}
-
Alice Wang authored
This CL adds a unit test for updateCredentials in AccountPickerDelegate. Bug: 1122942 Change-Id: I584e66de268adef59bcbfb6a4ee8b261e3fcfbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416504Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#808309}
-
Andrei-Laurențiu Olteanu authored
Remove previous registration of untrusted tests. Add registerUntrustedTest which runs a test in untrusted with a custom or default test class. Add an array of test names and classes. Reorder UntrustedRequestTelemetryInfoUnknownCategory in untrusted_browserttest.js to ensure the same order as from array. Bug: b:168444371 Change-Id: I5bcde404acfb9db528f0273051866a25551029ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410254 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#808308}
-
