- 21 Jan, 2021 40 commits
-
-
Mike Dougherty authored
This reverts commit 8904382c. Reason for revert: This CL breaks AppStateTest.resumeSessionWithStartupParameters for iOS 12 devices. See https://ci.chromium.org/ui/p/chrome/builders/ci/iphone-device/15349/blamelist. Original change's description: > [iOS] Fix Session.TotalDuration metric with multiwindow. > > Track the session as open while there is at least one foreground window. > Log this in a dedicated app agent to avoid polluting AppState. > The same is done to IOSProfileSessionDurationsService's session > start/end events. > > Bug: 1156586 > Change-Id: I37586f989039206fbaa90f7ec4046fbf9582e70a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599870 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845653} TBR=mpearson@chromium.org,marq@chromium.org,msarda@chromium.org,stkhapugin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Icd927a3252658933c02c8101067657f3ac7365b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643264Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845730}
-
Maksim Sisov authored
This test suite was disabled by accident in https://crrev.com/c/2476731 Enable it back. PS also added shards as in other places in test_suites.pyl file. Change-Id: I7a07fd729c09141859e8e6129d384f847345a87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642778 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845729}
-
Stephen Roe authored
Add SDK arch directory to test data to allow discovery of SDK libraries. Adjust test size limits. Bug: 1126177 Change-Id: I807539c53153af6b804b7bad60c96a8e60fe515b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638075Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#845728}
-
Alan Screen authored
There were no preexisting unit tests for LocalPrinterHandlerDefault, even though some tests did exist for the ChromeOS-specific counterpart of LocalPrinterHandlerChromeos. Start to introduce some support for getting capabilities which will benefit testing coverage of new paths to support printer handling performed out of the browser process. This is basically just a slightly modified version of the StartGetCapability() tests which already exist for ChromeOS. Bug: 809738 Change-Id: Icee1fc72eddb4bd1f3721eb0e848ab14cd85f28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628025 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845727}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e41b3bb941a6..ea17cd60ebc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164189,chromium:1166926 Tbr: lgrey@google.com Change-Id: I0abc4bed9977ab6a3c9ed08ad73c8c3b92d9579f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845726}
-
Takuto Ikuta authored
This is to prevent failure causing revert like https://crrev.com/c/2639349 Bug: 1127205 Change-Id: I6d6fac6a900caa3c64fc80f3b33cf4be5b7713c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642838 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845725}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a7e34d33fe70..6031b74664d0 2021-01-21 ivoc@webrtc.org Implement a Neon optimized function to find the argmax element in an array. 2021-01-21 sprang@webrtc.org Fixes issue triggered by WebRTC-VP9-PerformanceFlags trial. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1167353,chromium:12355 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1db0278740ff3e8346c4dc293edd633f6efd2982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845724}
-
Jiewei Qian authored
This is a reland of 38aeef20 The first reland adds a test for behaviors during browser shutdown, and doesn't yield consistent result. The second reland removes that test. The shutdown test was intended to fix https://crbug.com/1121894, where we hit CHECK in Browser constructor. The bug was fixed by checking browser isn't shutting down in LaunchSWAImpl.] It's okay to not test shutdown in LaunchSWAAsync (the added test in first reland), because LaunchSWAAsync doesn't attempt to create browser windows, and calls methods on objects (Profile, AppService) that are still valid during Browser shutdown sequence. So the LaunchSWAAsync API shuoldn't experience similar crashes observed in https://crbug.com/1121894. Original change's description: > Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API" > > This is a reland of 62cb2352 > > The original CL fails when AppBrowserControllerBrowserTest.Shutdown > passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK > because the use of GetCreationStatusForProfile already makes sure the > DCHECK is always successful. > > Original change's description: > > system-web-apps: implements a new LaunchSystemWebAppAsync API > > > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > > chrome components to launch a SWA safely. This new API should be used > > for SWA launches. > > > > The new API uses AppService to record metrics, handle disabled apps, > > etc. > > > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > > > LaunchSWAImpl is publicly declared because certain browser tests need to > > know the browser that hosts the SWA. It shouldn't be used to launch the > > App (other than LaunchSWA and Web app implementations). Subsequent CLs > > will attempt to migrate these browsertests to work with the new API. > > > > Bug: 1154540 > > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > > Reviewed-by: James Cook <jamescook@chromium.org> > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Jiewei Qian <qjw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#843939} > > Bug: 1154540 > Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845049} Bug: 1154540 Change-Id: I823b43be08c4fb6aefd53a92442359eee296bab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641605 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
The Assistant failed to restart, as we consumed the bootup config the first time it started, and we were sending an empty config the second time (which violated the signature of the |ServiceController::Initialize| mojom method). Steps to reproduce: - Go in ChromeOS settings. - Enable assistant. - Disable assistant. - Enable assistant. This CL also fixes a potential race condition I spotted in |ServiceControllerProxy|, where we told the mojom service to start before setting the initialize callback that is required. Bug: b/178097002 Test: new chromeos_unittest "AssistantManagerServiceImplTest.ShouldAllowRestartingAfterStopping" and manually reproduced. Change-Id: Iefbe8bcee02f17305baa8d4bee7f13a22fe5c10c Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642752 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845722}
-
Takuto Ikuta authored
This is not used anymore. https://source.chromium.org/search?q=%22--auth-service-account-json%22%20f:recipe Bug: 1127205 Change-Id: Ia6cb9dc263a238073ac988210c99079c173f0f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642656 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611230296-c6265b318ac69ceb3057c4103fbc67710d80a9da.profdata to chrome-win32-master-1611241154-e1663486a23de2e3bc4e3496ca3a854ed6ee6faf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I486d93b21aff5dafe9ac2c0864adc3b7ae0d986e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642814Reviewed-by:
-
Evan Stade authored
This reverts commits d4449153 and 79cee575 which are no longer necessary after f6658bc4 Bug: 1161143 Change-Id: I0893d147bb4a6384204198738df7a46cd855a932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640378Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845719}
-
Sigurdur Asgeirsson authored
This is a reland of 5fce665c Original change's description: > PM: Enable service worker relationships in graph. > > Bug: 1143281 > Change-Id: Ibc54e560a2a2a5f38c6ef48c7352c40c1b82109c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636273 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844550} Bug: 1143281 Change-Id: I6bfd41ce7826d14fbeb6aaabf80129d8af9816ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642982Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845718}
-
Jon Mann authored
The order of destruction for members of WifiConfigurationSyncService was incorrect, possibly causing a crash on shutdown. Bug: 1145366 Change-Id: I227c805c3eba2d7aed21114de7a3318f0e7decd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641475Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#845717}
-
Takuto Ikuta authored
It seems --shard-index is always specified now. This is partial re-land of https://crrev.com/c/2639441 Bug: 1127205 Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Change-Id: If26fc49d61581635ae9260805d982768e285823a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640526 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611230296-6b85df13abed72480b96a917e46b214e59288b63.profdata to chrome-win64-master-1611241154-5f537a5e634f10cbf823c07501b1298a461fb817.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4eafdebe7923a87505b7b15c8c51fc05137f2cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643176Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/477bd92472cc..3b349f3ea9c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9707b6ebd1ea87d6996a87026e63bdbd5b6ed851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643022Reviewed-by:
-
Joe Mason authored
Moves the code that statefully updates the aggregation result into an AggregationPointVisitor helper class. This will make it easier to implement new algorithms that gather different information from each aggregation point (eg. finding the set of processes spanned by all aggregation points) by subclassing AggregationPointVisitor. R=siggi Bug: 1168573 Change-Id: I0b674fdc4282e164e9541ed17ca6b53483bb525e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640675 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845713}
-
Eugene But authored
Bug: None Change-Id: Ibce50e2c29c55108f356f9af8e78c740e84f4c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633197 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845712}
-
Eugene But authored
Bug: None Change-Id: I17ffab718b09776455fe8a0220df49803e36755c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633976 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Eugene But authored
Bug: None Change-Id: Iea7445481f361b59e847fc66f9be457174a0daff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638513Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845710}
-
Owen Min authored
The original CL crrev.com/c/2611675 is landed on M90 instead of M89. Update the supported_on version range based on that. Bug: 1163293 Change-Id: I5b641a8ab0639d3b450c9079a39735490dc64c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642879 Commit-Queue: Owen Min <zmin@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#845709}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ef869c2d01d5..001b499275e1 2021-01-21 rharrison@chromium.org Adding stage input/output reflection to inspector path 2021-01-21 dsinclair@chromium.org Update vertex index decoration names. 2021-01-21 cwallez@chromium.org Vulkan: Enable barrier validation using VK_EXT_validation_features. 2021-01-21 bclayton@google.com TextureFormatUtils: Remove unused functions 2021-01-21 bclayton@google.com Convert StorageTextureValidationTests to WGSL 2021-01-21 cwallez@chromium.org Vulkan: Add support for layer extensions. 2021-01-21 cwallez@chromium.org Vulkan: Fix layout of Sampled+ROStorage texture. 2021-01-21 cwallez@chromium.org Vulkan: Use ityp::bitset for Instance/DeviceExtSet If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: Icaa67fc910f4e3b80f542bd330fa996c97f82576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642983Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611187144-41a088ce50b040cc139b89be9e9a13dad4a09053.profdata to chrome-linux-master-1611230296-a0d70aa7451b9c0a65b3b69ada45b93ac77ab251.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I99a7a654f5903e874ecb9853b9636c1323744501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642804Reviewed-by:
-
arthursonzogni authored
The test was timing out. This is likely caused by not running as "slow" and having many promise_test running in sequence. This patch: - Make them run in parallel. - Fix an error "is-disallowed" vs "is-not-allowed" - Fix an error HTTP vs HTTPS. The "same-origin" case is now useful. - For injecting a script, prefer document.write over javascript-url. The Javascript-url might be canceled by Document::CancelPendingJavaScriptUrls() and this might be another reason to explain the flakes. Bug: chromium:1163751 Change-Id: Id0fe915c551cc464df23fa4235090216b8f701ad Fixed: chromium:1163751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640615 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#845706}
-
Ramin Halavati authored
"Profile.EphemeralGuest.Signin" metric is recorded when user signs in to or signs out from a GAIA account in an ephemeral Guest profile. Bug: 1167474, 1148695 Change-Id: Ib0aa6660c2663083b740a6c393243a0058be78c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632694 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845705}
-
manukh authored
Drive responses have noticeable latency. To avoid matches switching styling between drive-like (e.g. 'Title - Date - Owner - Google Docs') and non-drive-like (e.g. 'Title - URL'), the provider caches previous matches and returns them synchronously before the async matches from the backend are ready. Cached docs that no longer match the input, should not be displayed; e.g. the match 'doc x' should not be displayed for input 'doc y' even though it may be cached from the previous input 'doc '. Therefore, cached matches previously had their scores set to 0; if still relevant, they will inherit a non-0 score from a duplicate history or bookmark match; otherwise, they'll keep a score of 0 and be hidden. This had 2 problems that resulted in matches either appearing & disappearing or swapping places during the sync (on keystroke) and async (on backend response) phases: 1) There isn't always a duplicate match to inherit a score from. 2) Ranking per history/bookmark scoring could differ from the ranking per the max of the history/bookmark & document scoring. To address the above 2 issues, cached matches no longer have their scores set to 0 during the async phase. To preserve the original intent, cached matches will continue to have their scores set to 0 during the sync phase. Also groups the code controlling whether to run the document provider into |IsDocumentProviderAllowed()|, should have no effect. Also updates doc |stripped_destination_url| to use |AutocompleteMatch::GURLToStrippedGURL()| (which invokes |DocumentProvider::GetURLForDeduping()|) instead of calling the latter directly. The former resorts to a generic striped URL computation if the latter doc-specific computation doesn't succeed. This ensures a non-empty |stripped_destination_url| which avoids overriding cache entries. Change-Id: I7f8b5c4935df40c0c8a937725f4fb99d93bdd637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634131 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
Per https://bugs.chromium.org/p/chromium/issues/detail?id=1166192#c10, the product decision was to always show the profile picker on start-up instead of restoring the session. This CL shows the profile picker even instead of restoring the session. Note: The user has a choice to never show the profile picker on start-up (and restore their session) - they just have to select "Don't show on start-up" on the profile picker UI. Bug: 1166192 Change-Id: I853a227abfff7f7fe7f24c07c4166ef553d4b75c Fixed: 1166192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629268Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#845703}
-
Collin Baker authored
Both TabRestoreService and SessionService support tab groups, but restoring a window after a browser restart did not restore groups. This was because the code translating SessionService entries to TabRestoreService entries did not copy over group data. Adds the necessary code to restore groups correctly. This allows, for example, restoring a recent window with groups after a browser crash. Fixed: 1168751 Change-Id: I6510ab036caa1450f904ea7e1209885acf08682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641334Reviewed-by:
-
Nick Diego Yamane authored
The drag-and-drop origin surface may get suddenly destroyed, when it is a xdg-popup, eg. dragging bookmarks bar's menu item in Chrome, which currently leads to crashes in WaylandDataDragController. This CL fixes it as well as adds unit tests to prevent future similar regressions. R=msisov@igalia.com, tonikitoo@igalia.com Bug: 1143707 Test: Covered by ozone_unittests --ozone-platform=wayland Change-Id: I1bac3032c428d3456bf644b35f869ec6ff5122e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635449 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#845701}
-
Michael Savigny authored
This change ( https://chromium-review.googlesource.com/c/chromium/src/+/2633051) requires the libstc++ library under third_party/llvm-build/Release+Asserts to be uploaded, and explicitly set to be included in remote action uploads. Bug: 1169195 Change-Id: Ib7f8427d7bbb42db96d6cb907d0518d2696f2859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642860Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#845700}
-
Dave Tapuska authored
Use gfx::Size/gfx::Rect respectively. BUG=738465 Change-Id: Iaa3ac722f8477f49c5f9bdae678f617d04ba06ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639312Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#845699}
-
Aaron Leventhal authored
Anonymous layout objects do not need their own AXObject. Creating them causes parent computation errors. For example, the layout hierarchy used for ruby, and for table CSS, can contain additional layout objects that are not reached during the normal AXObject tree building process, which uses the DOM. The cleanest fix is to simply no longer create these objects. Note: although these were previously being created, in GetOrCreate(LayoutObject*). they were not part of the AX hierarchy. Bug: 1138028 Change-Id: Ibb5b99907ad8c45e0a0bd9aa7f44df0ac74f9224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633425 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#845698}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee9fbcba..4e306939 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7ed08aeb5581470024bfbaecdbf808fa987e5cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643020Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845697}
-
Ben Mason authored
Change-Id: I712a3fe59be4f72d6033d745931f99d0c2ea32ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642878 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845696}
-
Ehsan Kia authored
This CL cleans up and submits a script originally written by engedy@chromium.org with a few speed and convenience improvements: - use multi-threading to reduce runtime from ~45m to ~8m - add flags for controlling a few options - automatically run the config formatter - reduce the number of false positives - make the script py2 (since chromium is still on py2) Bug: 1053702 Change-Id: Ie5d211d0374f5db6352677821e27defa415c7d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637405Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ehsan Kia <ehsankia@google.com> Cr-Commit-Position: refs/heads/master@{#845695}
-
Garrett Beaty authored
Change-Id: Iec3d74ae1c0e78de49df7a89b3f12402d40ecc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641335 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845694}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30152edff696..1890f38f2471 2021-01-21 leese@chromium.org Deduplicate memory tabs by backing store 2021-01-21 andoli@chromium.org [module.json extensions] settings views 2021-01-21 petermarshall@chromium.org [surveys] Move SurveyLink component into ui/components If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738,chromium:1134103,chromium:1163802,chromium:1169143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie909efd2a11e7730319e1704a25a63e9fd79e9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642811Reviewed-by:
-
Reilly Grant authored
This directory has been fully converted to choose between Once and Repeating for all callback types and calls to base::Bind(). Bug: 1007654 Change-Id: I9fd5a20aea036e0e5f6e93a7eed325b8c2a7cc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641159 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845692}
-
Nick Burris authored
* Records SecurePaymentConfirmation.Funnel.AuthenticationDialog metric based on the user action performed on the dialog. * Adds test coverage of the metric to the existing dialog view test. Bug: 1163574 Change-Id: If1fac8ec81225c3227fff1f84f1f97eefe1914fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639140Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#845691}
-
