GitLab

A frame is considered focused if its associated RenderWidgetHost is
focused and it is the focused frame inside its frame tree.

BUG=450634

Review URL: https://codereview.chromium.org/860393004

Cr-Commit-Position: refs/heads/master@{#313085}

BUG=

Review URL: https://codereview.chromium.org/864943002

Cr-Commit-Position: refs/heads/master@{#313084}

Using this we will be able to write:

  with logging_utils.SuppressLogging():
    # all but CRITICAL logging messages are suppressed
    logging.info('just doing some thing') # not shown
    logging.critical('something really bad happened') # still shown

BUG=

Review URL: https://codereview.chromium.org/875083002

Cr-Commit-Position: refs/heads/master@{#313083}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dc0f408..1d124c3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/877763002

Cr-Commit-Position: refs/heads/master@{#313082}

Remove unused QuicDecrypter::Decrypt method and implementations.

Merge internal change: 84548556
https://codereview.chromium.org/868953002/

Changed verify_details_ check to verify_details_.get() to keep code in
sync with internal source.

Merge internal change: 84442484
https://codereview.chromium.org/872483002/

Removing an obselete TOOD. It is obselte becasue FrameOverlapsBufferedData
does this.

Merge internal change: 84372263
https://codereview.chromium.org/871733002/

Replace the map in QuicAckNotifier with a counter.
No functionality change.

This reduces memory and CPU usage of the ack notifier.

Merge internal change: 84345868
https://codereview.chromium.org/867033002/

Change some of QUIC's AckNotifier datastructures from maps to hashmaps
and sets to lists.  No behavior change.

This should reduce CPU consumption substantially, particularly on
internal servers.

Merge internal change: 84156430
https://codereview.chromium.org/870733002/

Add a new RTO connection option to QUIC.  Flag protected behind the
existing flag FLAGS_quic_use_new_rto.

This new RTO connection option uses loss detection to reduce the
congestion window after an RTO, instead of always reducing the
CWND to 2.

Merge internal change: 84036848
https://codereview.chromium.org/824693007/

QUIC - sync'ing with internal source tree changes.

Minor change to keep the code similar to chromium and internal tree.

Merge internal change: 83993217
https://codereview.chromium.org/870723002/

Fix a bug in QUIC's RTO.  Flag protected by FLAGS_quic_use_new_rto.

Ensures a beta based loss reduction is not triggered directly before
OnRetransmissionTimeout when recovering from RTO.

Merge internal change: 83986840
https://codereview.chromium.org/868813003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/868993002

Cr-Commit-Position: refs/heads/master@{#313081}

After discussion with Annie/Dave/Fadi/Kari and myself, seems like we settled on not exposing an arbitrary # of new command lines. Rather, there'd be an optional param to rerun with extra tracing categories enabled. The benchmark would specify that there's a debug option available, and has a way of customizing the exact categories it needs.

Example of v8 benchmark modified:

class V8GarbageCollectionCases(benchmark.Benchmark):
  """Measure V8 metrics on the garbage collection cases."""
  def CreateTimelineBasedMeasurementOptions(self):
    # TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become
    # available in the 'benchmark' category.
    # This can theoretically be handled now by the "default" override
    return timeline_based_measurement.Options()

  @classmethod
  def HasBenchmarkTraceRerunDebugOption(cls):
    return True

  def SetupBenchmarkDefaultTraceRerunOptions(self, tbm_options):
    tbm_options.ExtendTraceCategoryFilters(['v8'])

  def SetupBenchmarkDebugTraceRerunOptions(self, tbm_options):
    tbm_options.ExtendTraceCategoryFilters(['*'])

BUG=

Review URL: https://codereview.chromium.org/840043004

Cr-Commit-Position: refs/heads/master@{#313080}

The Finch experiments ReplaceAECMWithAEC and UseDelayAgnosticAEC make appropriate changes to webrtc::AudioProcessing at create time. If any of these experiments are enabled by default using a different experiment name (which it should have) the desired config change is not made.

BUG=368175,450193

Review URL: https://codereview.chromium.org/879523003

Cr-Commit-Position: refs/heads/master@{#313079}

Change OK to NO_ERROR in enum ParserError for convergence with server code.

BUG=345769

Review URL: https://codereview.chromium.org/867273002

Cr-Commit-Position: refs/heads/master@{#313078}

BUG=None
TEST=components_unittests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/873083002

Cr-Commit-Position: refs/heads/master@{#313077}

Revert of Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (patchset #1 id:1 of https://codereview.chromium.org/821233003/)

Reason for revert:
The regression is fixed in the extension code. It should be safe to land this again.

Original issue's description:
> Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (patchset #1 id:1 of https://codereview.chromium.org/851333002/)
>
> Reason for revert:
> This cl caused regression that the backspace-to-decommit feature for both VK and physical keyboard autocorrect.
>
> Original issue's description:
> > Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText
> >
> > Previously, only text before cursor will be removed regardless the value of
> > offset. This CL adds support for deleting text after cursor. We want to this
> > feature in order to implement "set existing word to composition mode" feature
> > when cursor is moved inside an existing word. We want to be able to remove the
> > parts of the existing word before cursor and after cursor first and then call
> > setComposition to set the word to composition mode.
> >
> > Note: this API tries to comform the API spec of ibus delete_surrounding_text
> > here: ibus.googlecode.com/svn/docs/ibus-1.5/IBusInputContext.html#IBusInputContext-delete-surrounding-text
> > A noticible difference is a positive offset value in this API does not take effect.
> >
> > BUG=446249
> >
> > Committed: https://crrev.com/756820cb2c42a7b302a16d24909d820ee18dad0e
> > Cr-Commit-Position: refs/heads/master@{#312113}
>
> TBR=nona@chromium.org,bshe@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=446249
>
> Committed: https://crrev.com/7f17a7758881aa33e8790494b170962bc37e05d8
> Cr-Commit-Position: refs/heads/master@{#312304}

TBR=nona@chromium.org,shuchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446249

Review URL: https://codereview.chromium.org/868663005

Cr-Commit-Position: refs/heads/master@{#313076}

Cr-Commit-Position: refs/heads/master@{#313075}

This fixes the GN build on Android after https://codereview.chromium.org/846063002.

(The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099)

TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/879543002

Cr-Commit-Position: refs/heads/master@{#313074}

BUG=450828

Review URL: https://codereview.chromium.org/866763002

Cr-Commit-Position: refs/heads/master@{#313073}

BUG=450589
R=mkwst@chromium.org,jkarlin@chromium.org

Review URL: https://codereview.chromium.org/862053002

Cr-Commit-Position: refs/heads/master@{#313072}

This CL updates content_shell to a recent move to the RenderTreeAsText
to be LayoutTreeAsText.

BUG=450612

Review URL: https://codereview.chromium.org/872173002

Cr-Commit-Position: refs/heads/master@{#313071}

BUG=452002, 451999
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/878603002

Cr-Commit-Position: refs/heads/master@{#313070}

This patch adds two variants for postTask and postDelayedTask which
take the original posting location as a parameter. This mirrors the
similar task posting interface of base::TaskRunner and makes it
possible to trace where tasks are being posted from.

BUG=450977

Review URL: https://codereview.chromium.org/869573005

Cr-Commit-Position: refs/heads/master@{#313069}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/872263003

Cr-Commit-Position: refs/heads/master@{#313068}

Revert of Send Windows accessibility events based on tree updates. (patchset #9 id:160001 of https://codereview.chromium.org/848653002/)

Reason for revert:
DumpAccessibilityEventsTest.AccessibilityEventsTextChanged failing frequently on Windows bots.  Fails most of the time on Win8 Aura.

Original issue's description:
> Send Windows accessibility events based on tree updates.
>
> The idea of this change is to fire Win AX events
> based on the AX tree changing, rather than based
> on Blink firing the right event and mapping it to a
> Win event.
>
> Store the Win-specific AX attributes (ia role,
> ia state, name, value, etc.) in a struct, and when a
> node is updated, compare the old value of each attribute
> to the new value and fire an appropriate event for each
> one (name changed, state changed, etc.).
>
> Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText.
>
> This enables all of the "event" tests that were
> previously added to pass now, and it makes live regions
> work correctly in NVDA and JAWS.
>
> BUG=447962
>
> Committed: https://crrev.com/eb691a960bef3c2aefa38627baa7cbdde480b81e
> Cr-Commit-Position: refs/heads/master@{#313052}

TBR=dtseng@chromium.org,aboxhall@chromium.org,dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447962

Review URL: https://codereview.chromium.org/880523002

Cr-Commit-Position: refs/heads/master@{#313067}

BUG=450795

Review URL: https://codereview.chromium.org/869543005

Cr-Commit-Position: refs/heads/master@{#313066}

with exponential backoff!

BUG=372381,450828

Review URL: https://codereview.chromium.org/880483002

Cr-Commit-Position: refs/heads/master@{#313065}

BUG=446256, 451991, 451992, 451988, 293125, 451983
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/875923002

Cr-Commit-Position: refs/heads/master@{#313064}

BUG=447575

Review URL: https://codereview.chromium.org/880433002

Cr-Commit-Position: refs/heads/master@{#313063}

Revert of Isolate extensions_browsertests (patchset #7 id:120001 of https://codereview.chromium.org/869783004/)

Reason for revert:
This CL seem to cause the failure in extension browser test in Windows Vista SP2

Original issue's description:
> Isolate extensions_browsertests
>
> R=maruel@chromium.org, yoz@chromium.org
> TBR=jam@chromium.org
> BUG=98637
>
> Committed: https://crrev.com/d1caf97fe8db47e5c76043bccbf4dd4a42265831
> Cr-Commit-Position: refs/heads/master@{#312993}

TBR=maruel@chromium.org,yoz@chromium.org,scottmg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637

Review URL: https://codereview.chromium.org/876633002

Cr-Commit-Position: refs/heads/master@{#313062}

Re-baseline after the Blink(crbug.com/451047) change goes in.

BUG=451047

Review URL: https://codereview.chromium.org/873593003

Cr-Commit-Position: refs/heads/master@{#313061}

BUG=451024

Review URL: https://codereview.chromium.org/870573002

Cr-Commit-Position: refs/heads/master@{#313060}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5c1dad7..dc0f408

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/871403002

Cr-Commit-Position: refs/heads/master@{#313059}

BUG=446599,443203

Review URL: https://codereview.chromium.org/830743003

Cr-Commit-Position: refs/heads/master@{#313058}

BUG=448399
TBR=petrcercmak@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/867263002

Cr-Commit-Position: refs/heads/master@{#313057}

Adds code which attempts to exit by closing all browser instances and gracefully shuts down the test.

BUG=450651

Review URL: https://codereview.chromium.org/874933002

Cr-Commit-Position: refs/heads/master@{#313056}

Original description:

The implementation is based on a simple 'cat' run by shell on the
device (with optional as_root).

Interface changes:
- The return value is a string (instead of a list of lines).
- An exception is raised if the file cannot be read
  (instead of returning an empty list).

Previous CLs:
- https://codereview.chromium.org/794583004/
- https://codereview.chromium.org/775333002/

BUG=267773

Review URL: https://codereview.chromium.org/806843002

Cr-Commit-Position: refs/heads/master@{#313055}

Increasing timeout (again) to see if it helps with the DrMemory test
failures.

NOTRY=true
TBR=finnur

BUG=451299

Review URL: https://codereview.chromium.org/878533002

Cr-Commit-Position: refs/heads/master@{#313054}

Showing both local and federated logins and passing information about
type of credentials choosing by user back to blink.

BUG=400674
R=mkwst@chromium.org,vasilii@chromium.org

Review URL: https://codereview.chromium.org/848723002

Cr-Commit-Position: refs/heads/master@{#313053}

The idea of this change is to fire Win AX events
based on the AX tree changing, rather than based
on Blink firing the right event and mapping it to a
Win event.

Store the Win-specific AX attributes (ia role,
ia state, name, value, etc.) in a struct, and when a
node is updated, compare the old value of each attribute
to the new value and fire an appropriate event for each
one (name changed, state changed, etc.).

Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText.

This enables all of the "event" tests that were
previously added to pass now, and it makes live regions
work correctly in NVDA and JAWS.

BUG=447962

Review URL: https://codereview.chromium.org/848653002

Cr-Commit-Position: refs/heads/master@{#313052}

BUG=449075
TEST=content_unittests --gtest_filter=NavigationControllerTest.IsInPageNavigation

Review URL: https://codereview.chromium.org/855883002

Cr-Commit-Position: refs/heads/master@{#313051}

The UMA stat WebRTC.AecDelayBasedQuality was not logged due to a misspelling.

Correct name https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/histograms/histograms.xml&q=AecDelay&sq=package:chromium&type=cs&l=41307

BUG=N/A
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/867233002

Cr-Commit-Position: refs/heads/master@{#313050}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/96a857e..5c1dad7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/868453003

Cr-Commit-Position: refs/heads/master@{#313049}

BUG=330607
TEST=browser_tests:ProxyAuthOnUserBoardScreenTest.*

Review URL: https://codereview.chromium.org/869993003

Cr-Commit-Position: refs/heads/master@{#313048}

BUG=293125

Review URL: https://codereview.chromium.org/877433002

Cr-Commit-Position: refs/heads/master@{#313047}

Cr-Commit-Position: refs/heads/master@{#313046}