- 30 Aug, 2016 40 commits
-
-
eakuefner authored
This directory has not been touched since 2008, appears to be from the very early history of tracing, and contains only some very primitive trace examples. The frontend tracing code lives in Catapult, so let's remove this dir. Review-Url: https://codereview.chromium.org/2290393002 Cr-Commit-Position: refs/heads/master@{#415360}
-
sdy authored
BUG=636093 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2271653006 Cr-Commit-Position: refs/heads/master@{#415359}
-
sfiera authored
A partial list of things done here: * Move tests that verified NTPSnippet::best_source() behavior into ntp_snippet_test.cc; they don't belong here. * Switch it to use the chromecontentsuggestions-pa. Testing new features like server-provided categories is not possible without this. * Replace MockContentSuggestionsProviderObserver with a fake. It shouldn't have been a mock, since we weren't using it to test behavior, only state. * In one case, test using what the observer sees, instead of peeking in through debugging hooks. * Get rid of special test base class and Mock::VerifyAndClear calls; I consider these anti-patterns. * Initialize the service better; give it an empty list of snippets for its first fetch, and wait for it to complete the fetch before returning (I think this is what was most strongly implicated by the failures with the other CL). * Create the service and expect the scheduling directly from each case, so they are more readable individually. Review-Url: https://codereview.chromium.org/2285133004 Cr-Commit-Position: refs/heads/master@{#415358}
-
malaykeshav authored
BUG=642078 COMPONENT=HaTS, Chrome OS Review-Url: https://codereview.chromium.org/2294473003 Cr-Commit-Position: refs/heads/master@{#415357}
-
brettw authored
Inline sources into GN files. Review-Url: https://codereview.chromium.org/2291223002 Cr-Commit-Position: refs/heads/master@{#415356}
-
jonross authored
Update toolkit_delegate_views to launch the menu as async TEST=manually testing the various ways of calling the context menu. Normal views, guest_views BUG=557136 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2255923002 Cr-Commit-Position: refs/heads/master@{#415355}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/bb5de0678735599d572dad88f9a15e54e509f874 Add support for running WebView tests with new cts test runner. (mikecase@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2297773002 Cr-Commit-Position: refs/heads/master@{#415354}
-
paulmeyer authored
I've noticed some problematic edge cases with the reporting of find-in-page results from FindRequestManager. While trying to write some new tests in find_request_manager_browsertest.cc, I noticed that the new tests sometimes fail because of these edge cases. The existing tests in there could definitely fail from this as well, though much less likely. I have seen them fail very rarely before though and this is probably why. The details of the issue, edge cases, and my solution are explained in this design doc: https://docs.google.com/a/google.com/document/d/1BCvuSW9XSBH7GMx5VC0TgBh6XmJJDOzz_XZKItjF6oM/edit?usp=sharing UPDATE: Anther find-in-page CL I landed recently (https://codereview.chromium.org/2186113002/) was reverted because of a test that began timing out. I believe that failure is caused by the problems fixed here, so that bugfix is now blocked on this CL. Review-Url: https://codereview.chromium.org/2249133002 Cr-Commit-Position: refs/heads/master@{#415353}
-
isandrk authored
In some cases the certificates_ array would be empty thus selecting the first row (which is non-existing) would crash Chrome. BUG=630319 Review-Url: https://codereview.chromium.org/2277133003 Cr-Commit-Position: refs/heads/master@{#415352}
-
jdonnelly authored
This includes: - Moving the mapping between autofill credit card types and types defined in the spec to components/autofill. - Adding the basic credit card response type from the spec. BUG=602666 Review-Url: https://codereview.chromium.org/2285523002 Cr-Commit-Position: refs/heads/master@{#415351}
-
zmo authored
BUG=635081 TEST=mac bots NOTRY=true R=kbr@chromium.org,erikchen@chromium.org Review-Url: https://codereview.chromium.org/2251263002 Cr-Commit-Position: refs/heads/master@{#415350}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/fc6cb7366493..9a44565e9946 $ git log fc6cb7366..9a44565e9 --date=short --no-merges --format='%ad %ae %s' 2016-08-30 bsalomon Remove custom data from GrGpuResource CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=bsalomon@google.com Review-Url: https://codereview.chromium.org/2290383002 Cr-Commit-Position: refs/heads/master@{#415349}
-
bokan authored
This is occurring because we try to get the RootScrollerController from the top level Document by calling topDocument(). Since we're in a remote Frame though, topDocument returns the current RootScrollerController's Document and so we infinitely recurse into isViewportScrollCallback. This is a quick fix to the problem while I come up with a better long term solution for OOPIFs. BUG=641775 Review-Url: https://codereview.chromium.org/2290353002 Cr-Commit-Position: refs/heads/master@{#415348}
-
avi authored
This is done by making SPDY's stream info map own the StreamInfos, and by making sync's MetahandlesMap own the EntryKernels. BUG=555865 Review-Url: https://codereview.chromium.org/2287783002 Cr-Commit-Position: refs/heads/master@{#415347}
-
fs authored
m_useCurrentView being true implies that m_viewSpec is non-null. Perhaps defensively, most code that checks it is written in a way such that it expects that m_viewSpec can be null if m_useCurrentView is true - which is not the case, and adds unnecessary code. Instead change the code to adhere to the rule above, and assert that in the various places instead. Also add some checks of the invariant in methods that set the flag and m_viewSpec. Refactor SVGSVGElement::setupInitialView to avoid the need to sprinkle invariant checks "all over" it. BUG=110195 Review-Url: https://codereview.chromium.org/2290293003 Cr-Commit-Position: refs/heads/master@{#415346}
-
estark authored
I added this flag with the new plumbing for subresources with cert errors in https://crbug.com/634171, but neglected to clear it on navigation. BUG=641180 Review-Url: https://codereview.chromium.org/2280753003 Cr-Commit-Position: refs/heads/master@{#415345}
-
eroman authored
HKDF was added to the spec trunk: https://github.com/w3c/webcrypto/commit/36bc6686c4cc630a91df3d9e9f38bfc9b8f0ce47 BUG=642045 Review-Url: https://codereview.chromium.org/2295613002 Cr-Commit-Position: refs/heads/master@{#415344}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/89be526f6da4..bf2b35a6b699 $ git log 89be526f6..bf2b35a6b --date=short --no-merges --format='%ad %ae %s' 2016-08-30 benjhayden Migrate clockSyncLatencyMetric from ScalarNumeric to Histogram TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2296683003 Cr-Commit-Position: refs/heads/master@{#415343}
-
hanxi authored
The icon and icon murmur2 hash are sent to the WebApk Minting Server when creating/updating a WebAPK. For updating, these two values are fetched and computed by ManifestUpdateDetector, so WebApkInstaller doesn't need to download the icon and compute icon hash again. BUG=639000 Review-Url: https://codereview.chromium.org/2263673003 Cr-Commit-Position: refs/heads/master@{#415342}
-
oshima authored
I think this is safer to merge than https://codereview.chromium.org/2291923002/. I'll remove the check once the bug 64223 is fixed. BUG=642222 Review-Url: https://codereview.chromium.org/2291933002 Cr-Commit-Position: refs/heads/master@{#415341}
-
bradnelson authored
Pulling in a new v8 fuzzer. Adding a download step for the wasm and wasm->asm.js module fuzzers. BUG=None TEST=None R=kcc@chromium.org,ahaas@chromium.org,mmoroz@chromium.org Review-Url: https://codereview.chromium.org/2284393003 Cr-Commit-Position: refs/heads/master@{#415340}
-
tommycli authored
Breakage introduced by prior patch here: https://codereview.chromium.org/2208463002 We had split off GetPluginContentSetting into a utils file, but forgot to add the widevine header file include. This means that WIDEVINE_CDM_AVAILABLE is never defined, and the Widevine-treated-as-JavaScript for content settings clause is never activated, breaking Widevine on Corp machines. BUG=641706 Review-Url: https://codereview.chromium.org/2295563002 Cr-Commit-Position: refs/heads/master@{#415339}
-
anthonyvd authored
Discussed with bettes@ to decide that the profile badge on RTL layouts should be on the LHS instead. Also fixed the position of the circular mask for profile icon on RTL layouts (see first bug) - the circular mask needs to be bumped to the right on RTL layouts so that it's right-aligned. See comparative screenshots: https://drive.google.com/drive/folders/0B7Fvv7JszRyGN1FKakw4RXE2Vkk?usp=sharing BUG=640907 BUG=615893 Review-Url: https://codereview.chromium.org/2285413002 Cr-Commit-Position: refs/heads/master@{#415338}
-
robhogan authored
When merging two ruby bases ensure that the new base has a complete float list. BUG=619380,624028 Review-Url: https://codereview.chromium.org/2283413003 Cr-Commit-Position: refs/heads/master@{#415337}
-
cfroussios authored
The current name of these tests did not reflect the component actually tested. It was also inconsistent with how the tests for the the other implementations of KeyStorage were named. Review-Url: https://codereview.chromium.org/2292933002 Cr-Commit-Position: refs/heads/master@{#415336}
-
msw authored
Move and rename ash/desktop_background/* Move and rename ash/wm/system_background_controller* Rename identifiers; update comments. Remove unused src_container for Reparent* functions. BUG=629605 TEST=No functional changes; just renaming. R=jamescook@chromium.org TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2290473004 Cr-Commit-Position: refs/heads/master@{#415335}
-
qinmin authored
If browser is killed when a download is just created, the download is forever lost. User can no longer resume the download. And a temporary file is left forever on the disk. On desktop platforms, this may not be a big issue as users can easily go to the download dir to delete that file. However, it is not very straight forward to access the file maanger. This change commits the CreateDownload() to history db immediately on Android, rather than waiting for the scheduled time interval. This will greatly reduce the chance of the above problem, though very unlikely possible. BUG=636101 Review-Url: https://codereview.chromium.org/2292733002 Cr-Commit-Position: refs/heads/master@{#415334}
-
thestig authored
Review-Url: https://codereview.chromium.org/2293853002 Cr-Commit-Position: refs/heads/master@{#415333}
-
penghuang authored
On minnie, the Display initializing is slow, so the display is ready after GpuService. So only notifying initialized displays when the GPU channel is established is not sufficient. We need also set the GPU channel to every display when it is ready. BUG=None Review-Url: https://codereview.chromium.org/2290363002 Cr-Commit-Position: refs/heads/master@{#415332}
-
mikecase authored
Review-Url: https://codereview.chromium.org/2277033002 Cr-Commit-Position: refs/heads/master@{#415331}
-
robert.bradford authored
TEST=Using local md_browser.py check documentation formatting is correct. BUG=none Review-Url: https://codereview.chromium.org/2290223003 Cr-Commit-Position: refs/heads/master@{#415330}
-
sky authored
This does roughly the same thing as we do for chrome --mash. In particular it bundles the all the mash apps so that we aren't dll opening them as that causes problems. BUG=594674 TEST=covered by tests. TBR=erg@chromium.org Review-Url: https://codereview.chromium.org/2295433003 Cr-Commit-Position: refs/heads/master@{#415329}
-
tommycli authored
BUG=640199 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2287593002 Cr-Commit-Position: refs/heads/master@{#415328}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2287443003 Cr-Commit-Position: refs/heads/master@{#415327}
-
denniskempin authored
Exosphere renders its own cursor which does not get hidden by the global logic to hide a cursor when using direct input mouse events. This CL will make sure the cursor widget gets hidden or restored depending whether direct input is used or not. BUG=636458 TEST=use direct input in exo app. Cursor should be hidden. Review-Url: https://codereview.chromium.org/2295513002 Cr-Commit-Position: refs/heads/master@{#415326}
-
dpranke authored
Win goma builds do not support PDB files, so trying to build with full symbols is very painful. Previously we would default to "full symbols" but silently turn off symbols if using goma; this CL restructures things so that we default to "minimal symbols" if using goma (and visual studio's compiler). R=brucedawson@chromium.org, brettw@chromium.org, thakis@chromium.org BUG=634184 Review-Url: https://codereview.chromium.org/2215433002 Cr-Commit-Position: refs/heads/master@{#415325}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/48701b2a..26642c66 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2294793002 Cr-Commit-Position: refs/heads/master@{#415324}
-
boliu authored
Make it a general feature of CleanupReference. Review-Url: https://codereview.chromium.org/2281313002 Cr-Commit-Position: refs/heads/master@{#415323}
-
liaoyuke authored
Add functionality to http server utility so that it can include Set-Coockie in the header. Some tests need cookies to be set, sets cookie through http response can better simulate real world user behavior than through javascript. BUG= Review-Url: https://codereview.chromium.org/2283203003 Cr-Commit-Position: refs/heads/master@{#415322}
-
jamescook authored
Remove the chrome D-Bus bindings code and web UI test code. We can revive them from git history if we need them again. BUG=641996 TEST=compiles CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2292703002 Cr-Commit-Position: refs/heads/master@{#415321}
-