GitLab

Bug: 832054
Change-Id: I9f6c6131f4406348fe0cfbf40a876ae3724c3c6d
Reviewed-on: https://chromium-review.googlesource.com/1166907Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Tove Petersson <tovep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581821}

NVML provides a more reliable way to query for the NVIDIA driver
version. It also provides a query for NVIDIA CUDA compute capability
which corresponds to the GPU generation. This is a good value to use
for filtering GPUs based on hardware properties.

We now query NVML for driver version and CUDA compute capability in
case an NVIDIA GPU is encountered on Windows. NVML is loaded
dynamically from %ProgramW6432%/NVIDIA Corporation/NVSMI/nvml.dll.
In recent drivers the library is only shipped as a 64-bit binary, so
it won't load in case the 32-bit build of Chromium is used.

As a fallback, the actual NVIDIA driver version is parsed from the
driver version in the Windows registry. This best-effort parsing
should work for most versions, though every single version may not
conform to the expected format.

NVML has been present in NVIDIA drivers since version 270 published in
2011. Some functionality in NVML is exclusive to professional Quadro
or Tesla GPUs, but basic functionality like the queries used here are
available across NVIDIA GPU brands.

BUG=693090

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I31b44021e00426fcfb2b850fea5d63c114c4569c
Reviewed-on: https://chromium-review.googlesource.com/1108199Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Cr-Commit-Position: refs/heads/master@{#581820}

Replace old API with new API. This CL is a refactor
and has no intended behavior change.

Bug: 842194
Change-Id: Ie1a6a3972d7df9bcaee4dbc68592997c5d65bd87
Reviewed-on: https://chromium-review.googlesource.com/1160837
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581819}

When S13nServiceWorker is on and NetworkService is off, we should
use content::URLLoaderFactoryImpl as the default network factory
of SharedWorkerScriptLoader because AppCacheRequestHandler wouldn't
work when NetworkService is off. It needs to use non-network
service path when a request is fallback to network to make sure
that an appcache is associated, if any.

SharedWorkerScriptLoader may ask the network factory to create
loaders more than once with the same |request_id| when there are
redirects. However, ResourceDispatcherHostImpl, which is used by
URLLoaderFactoryImpl, doesn't allow using the same |request_id|
multiple times. To work around this restriction we call
ResourceDispatcherHostImpl::CancellRequest() when a redirect happens
while loading a shared worker script.

This CL fixes following test when S13nServiceWorker is enabled:
- external/wpt/html/browsers/offline/appcache/workers/appcache-worker.https.html

Bug: 869302
Change-Id: I5fae74439f82b3314f87a06bf9842db9df75a351
Reviewed-on: https://chromium-review.googlesource.com/1164741
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581818}

When tapping an input field, the keyboard will always come up.
Because this cannot be suppressed easily, the accessory sheet will close
to not clutter the screen.

Bug: 871244
Change-Id: I823225a05601ae4a1eb92a08767729fdfd94dac7
Reviewed-on: https://chromium-review.googlesource.com/1167512Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581817}

Fixes 2 recent regressions
- Object popover properties had extra scrollbars; now they have
  standard line-height and show overflow
- Dark theme forced SoftContextMenus, which appear behind the
  inspected page in DeviceMode; now they are not enforced by theme

Screenshots:
https://imgur.com/a/JOXwaGI
https://imgur.com/a/NmXVtyx

Bug: none
Change-Id: Ia79e2a23ea987f4ed9e2cd29ba02537bdd4db076
Reviewed-on: https://chromium-review.googlesource.com/1167887Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581816}

Previously, we would lose any CrostiniManager state set in UserSessionManager
because it quits and restarts the browser, killing the old CrostiniManager with
it.

Also fixed a bug where newly installing Termina didn't set the CrostiniManager
state variable correctly.

Bug: 871651
Change-Id: I2cfa3288069fccd86280e4301cd4757eb656e02d
Reviewed-on: https://chromium-review.googlesource.com/1166271Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581815}

Bug: 816369
Test: None
Change-Id: Ide3fe8d28b0e2bc9ada51f78595e0c9271ab260b
Reviewed-on: https://chromium-review.googlesource.com/1160838Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#581814}

The code for first-letter was recently reworked, but this was overlooked.

Fixes DCHECK failures for LayoutNG.

R=futhark@chromium.org, yosin@chromium.org

Bug: 872207
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I03e7aa3216c3e6c9e8576ff2d76cdb20730a9aae
Reviewed-on: https://chromium-review.googlesource.com/1166921Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581813}

This reverts commit 76c395e0.

Reason for revert: Initial position of sliders are broken

Original change's description:
> Fix UnifiedVolumeView asan failure during closing.
> 
> This CL fixes UnifiedVolumeView asan failure when
> 1. the slider is in unified system tray main bubble
> 2. volume key is pressed during bubble fade out animation
> 
> This is because controllers are deleted before views are deleted. This
> is intented because usually controllers are called only when a user
> makes mouse event in the bubble. Slider is an exception because
> it also notifies controller that value is changed by API although
> it's ignored on controller side. Other possible fixes are:
> 
> * Make controller ptr in the view WeakPtr.
> * UnifiedSliderView implement Slider listener and not forward changes
>   caused by API.
> 
> The CL is the least verbose fix.
> 
> TEST=manual
> BUG=871005
> 
> Change-Id: Ifb40b4107e1a04936bf6cd6e0649139498e15746
> Reviewed-on: https://chromium-review.googlesource.com/1164962
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581759}

TBR=yoshiki@chromium.org,tetsui@chromium.org

Change-Id: Ib02ac9cc17a77bc7c7fafe437f3d289e2033ce2b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871005
Reviewed-on: https://chromium-review.googlesource.com/1168862Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581812}

https://pdfium.googlesource.com/pdfium.git/+log/4b17aea63fed..f765805983d1


git log 4b17aea63fed..f765805983d1 --date=short --no-merges --format='%ad %ae %s'
2018-08-08 tsepez@chromium.org Remove unused codepage from WideString::GetWideString().


Created with:
  gclient setdep -r src/third_party/pdfium@f765805983d1

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1f28c231fc8e23dc9c3a92bc622b6be2c56ccf5f
Reviewed-on: https://chromium-review.googlesource.com/1168542Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#581811}

BUG=chromium:871600
TEST=bots

TBR=nednguyen@google.com

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I5746a02cea032ce44f77dae6b47958f31d8c16f0
Reviewed-on: https://chromium-review.googlesource.com/1168477Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581810}

This CL adds a flag to control if the renderer with media streams should
have strong or moderate binding.

BUG=868611

Change-Id: I3263ffcca6076f9d38452c3e60df8fdd90634ea8
Reviewed-on: https://chromium-review.googlesource.com/1162927Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581809}

As UX spec is now ready, this CL updates the style of slider bubbles
e.g. volume slider and brightness slider.

TEST=manual
BUG=870473

Change-Id: I8c3ca92e6fd2f8d834c494144578bf06d78276b2
Reviewed-on: https://chromium-review.googlesource.com/1166779
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581808}

- Make OnCompositeToPdfCallback() a static method.
- Do not use std::move(map) when methods take the map by const-ref.
- Use C++11 map initialization syntax.

Change-Id: Ia6e9e1c5dd1074e8dd37a7d8c096a51aedf84161
Reviewed-on: https://chromium-review.googlesource.com/1167786Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581807}

The opacities based on colors and contrast ratios need to be
recalculated when window active state or colors change, and
doing this for all tabs is not efficient, so the stored
opacities are moved to TabStrip for use by all its tabs.
The motivation for this CL was to fix a bug where some tabs
had different hover opacities than others because they
were not updating with change in window active state.

Bug: 872310
Change-Id: Ia7367227df005470364da10b43df429f9e4e8e47
Reviewed-on: https://chromium-review.googlesource.com/1168140
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581806}

The same change was made to the MR extension to hide audio-only devices
for desktop mirroring proper support is implemented. (bug 849335)

Bug: 849335
Change-Id: I969000c50ba6c07068298e2149f393e8737461f7
Reviewed-on: https://chromium-review.googlesource.com/1167657
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581805}

The Budget API began shipping in M60. It can be used to retrieve the
amount of budget an origin has available for resource consuming
background operations, as well as the cost associated with doing such
an operation.
https://codereview.chromium.org/2891953002
https://www.chromestatus.com/feature/5691190548627456

BUG=704725

Change-Id: Ieae4c7a1f1883e974ea9c9902d71acf528200d5f
Reviewed-on: https://chromium-review.googlesource.com/1166267Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581804}

This reverts commit d8fb3e8f.

Reason for revert: No evidence of flake on flakiness dashboard for
these tests in DEBUG, yet find.it said there was. Who's right?

Well, reverting this CL to find.it out (the cause was a bad v8 roll
by the looks).

Original change's description:
> Disabled tests in chromeos dbg due to flakiness.
>
> Only one of the subtests reported flaky, but didn't know how to disable
> them separately.
>
> TBR=noel@chromium.org
>
> Bug: 871684
> Change-Id: Ie4f27cc5681ba3c6174853dbbfd16d1ba665c451
> Reviewed-on: https://chromium-review.googlesource.com/1164958
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581194}

TBR=futhark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 871684
No-try: true
No-presubmit: true
Change-Id: Ibf9f9ee10ac3e1d37fb13c6b69ddac56071747a9
Reviewed-on: https://chromium-review.googlesource.com/1168842
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581803}

Previously it was checking active user profile to be in line with
other power-related prefs. Now that other power-related prefs are
changing to primary user profile, this cl changes to check primary
user profile too.

Bug: 862461
Change-Id: Iad053ba29c3295828bf8ab83ad522c41f24d1f42
Reviewed-on: https://chromium-review.googlesource.com/1168265Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581802}

Bug: 516866
Change-Id: Ib91eb840c937e0aa6a7056a1d68555a02bbdac4c
Reviewed-on: https://chromium-review.googlesource.com/1167509
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581801}

This is part of the work of refactoring the iOS audio playback logic.

This CL implements the AudioPlaybackSink for iOS using the AudioQueue
API. The implementation is following Apple's guide for the playback
process:
https://developer.apple.com/library/archive/documentation/MusicAudio/Conceptual/AudioQueueProgrammingGuide/AboutAudioQueues/AboutAudioQueues.html#//apple_ref/doc/uid/TP40005343-CH5-SW22

In the next CL there will be an AudioPlaybackStream class that
connects the AudioJitterBuffer with AudioPlaybackSinkIos.

Bug: 868088
Change-Id: Ifbaa08bfcf5f983587bfb71418c681001ab7cdca
Reviewed-on: https://chromium-review.googlesource.com/1166246
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581800}

Use the menu #share-menu:not([hidden]) prefix in the share button/menu
dialog test case flow to avoid CSS matching hidden menus that have the
same command |id|.

None do at the moment, but the |id| "#share" is too generic, so a more
precise CSS selector prevents future bugs (when we have something else
to "#share" in future, which seems plausible).

Minor: remove old TODO and its associated test step: the mocked shared
dialog is 300 x 100px, no need to measure/worry about its size.

Minor: use !!result when checking remote call return results.

Bug: 872119
No-try: true
Change-Id: I504421ebd4c2e9a6d0cece351b9f2bed8defde35
Reviewed-on: https://chromium-review.googlesource.com/1167924Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581799}

This reverts commit 93a3a4b3.

Reason for revert: msan issue was fixed and landed (and wasn't triggered by this patch). Reverting the revert to reland.

Original change's description:
> Revert "window-service: makes objects using Env take Env (or get from WindowService)"
> 
> This reverts commit 04308f3d.
> 
> Reason for revert: Patch earlier in the chain caused failures on msan bot.
> 
> Original change's description:
> > window-service: makes objects using Env take Env (or get from WindowService)
> > 
> > This allows for multiple Envs at the same time.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: I20dda0f7e3fde50027c9c867562718e49152d238
> > Reviewed-on: https://chromium-review.googlesource.com/1167654
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581701}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: If149ac9dc90f0ef6cec5e59f744cd0c3189d01e6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168402
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581715}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: Id10e4d33b7cf619b4e14f1ed4c8f604cd2c96591
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168326Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581798}

This reverts commit 07aab203.

Reason for revert: msan issue was fixed and landed (and wasn't triggered by this patch). Reverting the revert to reland.

Original change's description:
> Revert "wm/views: makes objects using Env take Env"
> 
> This reverts commit 9feb99aa.
> 
> Reason for revert: a patch earlier in the chain caused msan failures.
> 
> Original change's description:
> > wm/views: makes objects using Env take Env
> > 
> > This allows for multiple Envs at the same time. Additionally:
> > . NativeWidgetPrivate::CreateNativeWidget: now takes InitParams
> > . NativeWidgetPrivate::IsMouseButtonDown() is now an member function.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: Ic35b274c0a927a7c602809a7e611383b5d3dd3e2
> > Reviewed-on: https://chromium-review.googlesource.com/1166148
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581621}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: I9410bf471a71d07b32f49a139b7afa9ced0f3fea
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168403
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581716}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I1fcd75fb66d00693dfc2e0b78e871848a335319a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168566Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581797}

This reverts commit c179496f.

Reason for revert: The test failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a lingering issue and not caused by patch (but triggered by my patch), so reverting the revert.

Original change's description:
> Revert "aura: makes each Window be associated with an Env"
> 
> This reverts commit 99df3b26.
> 
> Reason for revert: Caused failures on msan bot.
> 
> Original change's description:
> > aura: makes each Window be associated with an Env
> > 
> > This is to avoid using Env::GetInstance(), so that there can be multiple
> > Envs created at once.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: I2e2604c8f8a356ca9cc6771ed050ef8431e7b840
> > Reviewed-on: https://chromium-review.googlesource.com/1165861
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581568}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: I50fb5f0d27011219ed2569b1035a78e01b9b3de9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168323
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581718}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I83e61d6ca9de8dcd023757f03bb18f0abf09790e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168565Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581796}

JS files don't name their `#includes`, but for closure compilation we
must effectively list each .js file's #includes in build dependencies.
We can use this to generate the list of .js files, in the correct
order, that we use for js unittests. Manually creating the
foo_unittest.html files is fiddly, error-prone, and is not robust to
files being moved around. However, it does require the unittest js
file to be properly closure-compiled.

Start by obsoleting the 3 foo_unittest.html files in
gallery/image_editor, which are the only ones currently closure-
compiled.

Note that the dependency files are created _regardless_ of the
`closure_compilation = true` gn flag. i.e. this does not introduce a
dependency on the closure _compiler_: dependency information comes from
the GN build files alone. The closure_compilation flag only affects the
js_type_check(..) targets, but the approach here uses js_library(..)
targets.

Bug: 867700
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I91b3a726b999a9f7db721fefc23b3f6512fd3c0c
Reviewed-on: https://chromium-review.googlesource.com/1161720Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581795}

Change-Id: Ic9f5deeb77213bf58e3706983e2291955b84f519
Reviewed-on: https://chromium-review.googlesource.com/1167544Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581794}

ARC apps are added to the context menu to allow the user to handle
certain urls via an installed app.

However these apps shoudln't be added to such UI while in incognito
mode, this CL enforces that.

Bug: b/112107069
Test: Try.
Change-Id: I200e38403f07301fb5d90fd6a381c57a0d150872
Reviewed-on: https://chromium-review.googlesource.com/1168146Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581793}

This reverts commit 3882e0ff.

Reason for revert: *SIGH* reverted wrong revert, relanding.

Original change's description:
> Revert "views: changes test to not use equality"
> 
> This reverts commit 72a83a6c.
> 
> Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert.
> 
> Original change's description:
> > views: changes test to not use equality
> > 
> > This test was assuming a newly created Window got a pointer value different
> > than one recently destroyed. For whatever reason my recent patch made it more
> > likely (on the msan bot) that the newly created pointer got the same value as
> > the one destroyed, leading to failure.
> > 
> > I'm converting the test to verify the window is destroyed using a WindowTracker.
> > 
> > BUG=847992
> > TEST=covered by tests
> > 
> > Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
> > Reviewed-on: https://chromium-review.googlesource.com/1168466
> > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581788}
> 
> TBR=sky@chromium.org,msw@chromium.org
> 
> Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 847992
> Reviewed-on: https://chromium-review.googlesource.com/1168762
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581791}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I3f26795a5a5959ad38949cc451591f34539f2141
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168763Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581792}

This reverts commit 72a83a6c.

Reason for revert: The text failure was fixed at https://chromium-review.googlesource.com/c/chromium/src/+/1168466 . The failure was a side effect of my change and a lingering issue, so reverting the revert.

Original change's description:
> views: changes test to not use equality
> 
> This test was assuming a newly created Window got a pointer value different
> than one recently destroyed. For whatever reason my recent patch made it more
> likely (on the msan bot) that the newly created pointer got the same value as
> the one destroyed, leading to failure.
> 
> I'm converting the test to verify the window is destroyed using a WindowTracker.
> 
> BUG=847992
> TEST=covered by tests
> 
> Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
> Reviewed-on: https://chromium-review.googlesource.com/1168466
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581788}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I902ae7e85e8a40e5d682a332b2a7171eb233c300
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847992
Reviewed-on: https://chromium-review.googlesource.com/1168762Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581791}

Not perfect, since this really should be going through the mojo interface
for dealing with blobs, but a lot better than going through blob URLs.

Tbr: reillyg@chromium.org
Bug: 859594, 868462, 804546
Change-Id: Ifd7cd11b7bf4432eff41bdef00edd079d31e49c6
Reviewed-on: https://chromium-review.googlesource.com/1164523
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581790}

Bug: 864871
Change-Id: I8e7b6f33685625b831ea326737d605ffc813288b
Reviewed-on: https://chromium-review.googlesource.com/1153477
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581789}

This test was assuming a newly created Window got a pointer value different
than one recently destroyed. For whatever reason my recent patch made it more
likely (on the msan bot) that the newly created pointer got the same value as
the one destroyed, leading to failure.

I'm converting the test to verify the window is destroyed using a WindowTracker.

BUG=847992
TEST=covered by tests

Change-Id: I4f9f64ad59ae15b0314619a93935d7e85bb6d8e7
Reviewed-on: https://chromium-review.googlesource.com/1168466Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581788}

Use the menu #file-context-menu prefix in file menu command queries to
avoids CSS matching hidden menus that have identical command |id|, for
example cut/copy/paste.

Minor: zip_files.js's #zip-selection menu case is specific enough that
we don't need the :not([hidden]) if we add remote call result checking
to the zip test code to verify #zip-selection command clicks.

Remove old TODO(), reviewers advised the issue was fixed with the meta
data mambo jambo cleanup/changes/fixes (see issue 867974).

Bug: 872119
No-try: true
Change-Id: I611f3a5403cbe724fa0687204c046ed2e6fffd89
Reviewed-on: https://chromium-review.googlesource.com/1167344
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581787}

In a previous patch [1], we changed the anchor insets for tray bubbles
so that when the keyboard is shown, bubbles show above the keyboard.

However, this causes a subtle bug with the accessibility virtual
keyboard. When we open the accessibility VK, the status area / shelf
moves downwards. We then show a bubble, which is positioned correctly
relative to the VK due to [1]. However, when we hide the VK, the status
area / shelf moves upwards. Because the bubble is anchored to the status
area / shelf and still has the same insets, it will move up as well.

To fix this, we change the bubble anchor bounds to return either the
status area bounds or the virtual keyboard bounds depending on whether
the keyboard is visible.

[1] https://crrev.com/3e3220d49f21fc41dcc51e21c3680d7853fb3d38

Bug: 871718
Change-Id: I8f24e2ff26f8912f579c386755de8af512c6ed1d
Reviewed-on: https://chromium-review.googlesource.com/1166766Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581786}

Use the menu #tasks-menu:not([hidden]) prefix to ensure that the menu
is visually displayed.

Bug: 872119
Change-Id: Ia601f3e601b7a243d7613f798696da09763fc308
Reviewed-on: https://chromium-review.googlesource.com/1167346Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581785}

Preferences related to ChromeOS Drive are removed from the persistent
storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ic2be139b20c90b7a372560c682d34dad527c9e62
Reviewed-on: https://chromium-review.googlesource.com/1166824Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581784}

Preferences related to ChromeOS language remap are removed from the
persistent storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: I86da7605639c1d7f8bc0baf5bfbcd4aac573f020
Reviewed-on: https://chromium-review.googlesource.com/1166822Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581783}

Added frame metrics analysis to LayerTreeHostImpl. The frame presentation
callback times are sent to frame metrics for every nth scrolling.

Bug:851088

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I32aee9b5401c056ed3be64e17a45cc1958188199
Reviewed-on: https://chromium-review.googlesource.com/1147921
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581782}