GitLab

BUG=481955

Review URL: https://codereview.chromium.org/1114503003

Cr-Commit-Position: refs/heads/master@{#327353}

BUG=477690
R=skyostil@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/1112573003

Cr-Commit-Position: refs/heads/master@{#327352}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e68c882..b9db944

TBR=pdr@chromium.org,caseq@chromium.org

Review URL: https://codereview.chromium.org/1108823005

Cr-Commit-Position: refs/heads/master@{#327351}

BUG=456354

Review URL: https://codereview.chromium.org/1113463003

Cr-Commit-Position: refs/heads/master@{#327350}

BUG=480762

Review URL: https://codereview.chromium.org/1105743003

Cr-Commit-Position: refs/heads/master@{#327349}

We seem to have gathered enough data to find out debug further cause/reason for calling CloseHandle on already closed/invalid handle.
There are couple of theories which need to be investigated further like policy ownership of TargetProcess and thread watching for JOB_OBJECT_MSG_ACTIVE_PROCESS_ZERO.
CHECK seem to have introduced with CL https://codereview.chromium.org/1045513004

BUG=480639
R=cpu@chromium.org,grt@chromium.org

Review URL: https://codereview.chromium.org/1108953003

Cr-Commit-Position: refs/heads/master@{#327348}

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1112603003

Cr-Commit-Position: refs/heads/master@{#327347}

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045

Review URL: https://codereview.chromium.org/1111673003

Cr-Commit-Position: refs/heads/master@{#327346}

This would make the widget container code independent of the
chrome APIs
available/used by the extension embedding the widget.

TEST=Verified installing file handlers and file system providers works
BUG=477106

Review URL: https://codereview.chromium.org/1091943002

Cr-Commit-Position: refs/heads/master@{#327345}

ERROR Dependency cycle:
  //gpu/command_buffer/service:service_sources ->
  //gpu/config:config_sources ->
  //gpu/command_buffer/service:service_sources

The problem was that gpu/command_buffer/service already include from
gpu/config, but gpu/config were also including from
gpu/command_buffer/service for gpu_switches.h, creating the above
dependency cycle.

By moving the required switch down to gpu/config, we broke this
dependency cycle.

With that 'gn check' passes for gpu/config with the following command
lines:

$ gn gen out-gn/Debug
$ gn check out-gn/Debug //gpu/config/*

gpu/command_buffer/service needs more work to pass 'gn check' though.

BUG=367595,376000
TEST=see above
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/1103403002

Cr-Commit-Position: refs/heads/master@{#327344}

GCD App needs to query devices for basic information.

BUG=brillo:839

Review URL: https://codereview.chromium.org/1106183006

Cr-Commit-Position: refs/heads/master@{#327343}

This histogram tracks the time-weighted memory use incurred by SDCH
dictionaries. This histogram is measured in units of byte-seconds per
second.

BUG=465873

Review URL: https://codereview.chromium.org/1051353003

Cr-Commit-Position: refs/heads/master@{#327342}

Now ScopedPtrHashMap expect the 2nd parameter is scoped_ptr<T>. For example, old usage
ScopedPtrHashMap<int, Value>
new usage
ScopedPtrHashMap<int, scoped_ptr<Value>>

With this change, ScopedPtrHashMap support scoped_ptr's custom deleter.

R=danakj@chromium.org, tzik@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1099383002

Cr-Commit-Position: refs/heads/master@{#327341}

patch from issue 1051323006 at patchset 40001 (http://crrev.com/1051323006#ps40001)

BUG=475714

Review URL: https://codereview.chromium.org/1103553002

Cr-Commit-Position: refs/heads/master@{#327340}

This CL prevents FaviconHandler from stopping iteration over a page's icon URLs
if a download for one of the icon URLs previously returned a 404. In particular,
this CL makes FaviconHandler::ScheduleDownload() call the download callback
when FaviconDriver::StartDownload() does not start a download. This is important
because the download callback is responsible for initiating the fetch for the
data for the next favicon candidate.

Sample scenario:
  Page HTML snippet:
  <link rel="icon" href="www.google.com/nothingtoseehere.png" />
  <link rel="icon" href="www.google.com/favicon.ico" />

  A previous download for "www.google.com/nothingtoseehere.png" returned a 404
  (e.g. the user previously visited a different page which also makes use of
  www.google.com/nothingtoseehere.png)

  This CL makes FaviconHandler fetch data for "www.google.com/favicon.ico"
  despite the download for the first favicon candidate
  ("www.google.com/nothingtoseehere.png") having previously failed.

BUG=474429
TEST=FaviconHandlerTest.MultipleFavicons404,
     FaviconHandlerTest.MultipleFaviconsAll404

Review URL: https://codereview.chromium.org/1079523005

Cr-Commit-Position: refs/heads/master@{#327339}

BUG=b/19609728

Review URL: https://codereview.chromium.org/1066003007

Cr-Commit-Position: refs/heads/master@{#327338}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2d6802a..e68c882

TBR=pdr@chromium.org,caseq@chromium.org

Review URL: https://codereview.chromium.org/1113623002

Cr-Commit-Position: refs/heads/master@{#327337}

We discovered an audio playing site that often triggers
the starvation condition during the playback. This introduces
a race between Pause , starvation detecton and the MediaDecoderCallback.
If starvation detection happens between Pause and the callback,
we will do Prefetch and then stop the flow of packets,
and won't update the audible status properly.

This fix sets the audible status to false in OnPrefetchDone()
if we realize that the flow will stop.

BUG=474761

Review URL: https://codereview.chromium.org/1067153002

Cr-Commit-Position: refs/heads/master@{#327336}

properties are accessed.

R=rch@chromium.org, asvitkine@chromium.org
BUG=481618

Review URL: https://codereview.chromium.org/1096783005

Cr-Commit-Position: refs/heads/master@{#327335}

Previously onSucceeded() had to synchronize and turn around and
request total bytes received.  By passing it we avoid the
synchronization.

Review URL: https://codereview.chromium.org/1100923002

Cr-Commit-Position: refs/heads/master@{#327334}

in the same way as AshWTHX11/Ozone

Fixed minor error introduced when cleaning up CL

BUG=365662
TEST=UnifiedDesktopBasic will pass with real offscreen output surface

Review URL: https://codereview.chromium.org/1113493002

Cr-Commit-Position: refs/heads/master@{#327333}

This custom polymer element shows some information from media that is currently cast to a device. It is styled after the current cast extension's route details view.

BUG=464222

Review URL: https://codereview.chromium.org/1027253004

Cr-Commit-Position: refs/heads/master@{#327332}

This is needed because the RenderThread in the renderer process owns a reference to the RenderWidget, and that reference is only released when the RenderWidgetHost sends ViewMsg_Close, which happens on RenderWidgetHost::Shutdown.

BUG=464764

Review URL: https://codereview.chromium.org/1052223008

Cr-Commit-Position: refs/heads/master@{#327331}

Instead of using the wrench menu as an anchor for an overflowed
action's popup, slide the action out onto the main toolbar
for the duration of the popup, and then slide it back in
when the popup closes.
On Mac, do the same for context menus (since we can't open a
menu-in-menu on mac).

Known issue:
- On Mac, if you right click on an action that has slid out
to show its popup, it will slide back in (but the context
menu still appears). This is fixable, but requires a bit
of a refactor.

BUG=479387

Review URL: https://codereview.chromium.org/1105713002

Cr-Commit-Position: refs/heads/master@{#327330}

This will be used by the next portion of ios/web/ code being upstreamed;
separating into another CL since it contains a binary file.

BUG=464810
R=eugenebut@chromium.org

Review URL: https://codereview.chromium.org/1108373003

Cr-Commit-Position: refs/heads/master@{#327329}

This CL gives appropriate permissions to the RenderFrameHost on
NavigationCommit. This allows to run browser tests backed by javascript files
on disk with PlzNavigate enabled.

BUG=475027

Review URL: https://codereview.chromium.org/1103253003

Cr-Commit-Position: refs/heads/master@{#327328}

This pulls in the following Native Client changes:

4699f0e: (sbc@chromium.org) Always honor NACL_TMPFS_PREFIX in the environement
0178d59: (sbc@chromium.org) Add runtime test for availability of PROT_EXEC with shm_open
772dc1f: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
7408e00: (petarj@mips.com) PNaCl: Update binutils revision in pnacl/COMPONENT_REVISIONS
6937d61: (dschuff@chromium.org) Update revision for PNaCl

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/87d5dd90911a0657c27574f78e86b7dfc4ad8b29..6937d61627c025d697f70b5a09d02f192a71e157

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4155
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1109153003

Cr-Commit-Position: refs/heads/master@{#327327}

Revert of Pass -Oz flag to Clang when targeting Android. (patchset #2 id:20001 of https://codereview.chromium.org/1103393002/)

Reason for revert:
Causes a build failure with -Dcomponent=shared_library

Original issue's description:
> Pass -Oz flag to Clang when targeting Android.
>
> The -Oz flag enables more aggressive size optimizations. Shrinks the
> libchromeshell.so DSO by around 2.5MB.
>
> BUG=481675
> R=thakis@chromium.org
>
> Committed: https://crrev.com/2433e6ab2206fad3bc5954fd61e9d4785ccab108
> Cr-Commit-Position: refs/heads/master@{#327183}

TBR=thakis@chromium.org,pcc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481675

Review URL: https://codereview.chromium.org/1109203002

Cr-Commit-Position: refs/heads/master@{#327326}

For a full list of changes, see
https://github.com/chromium/web-page-replay/compare/4e4d540...0e5c45a

BUG=478178

Review URL: https://codereview.chromium.org/1104233007

Cr-Commit-Position: refs/heads/master@{#327325}

The new UI is exposed behind a flag, --enable-autofill-keyboard-accessory-view. The intent is that there should be no behavior change when the flag is not passed, but eventually the flag will become the default and AutofillPopup[Bridge] and related code will be removed.

This maintains the same appearance for the list items, and matching the mocks (switching to white on blue, etc.) is a TODO. See go/wzhwq for goal state.

There are also TODOs surrounding behavior:
- we likely want to hide the keyboard accessory if the keyboard hide
- add animations
- somehow deal with very small amounts of available space (comes up in landscape mode)

BUG=428087
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/1082183002

Cr-Commit-Position: refs/heads/master@{#327324}

tools/grit/grit.py does not recognize "preprend" as a valid emit_type but
instead understand "prepend" which avoid the inclusion of atlres.h in the
generated file.

BUG=475514

Review URL: https://codereview.chromium.org/1113603003

Cr-Commit-Position: refs/heads/master@{#327323}

Review URL: https://codereview.chromium.org/897053003

Cr-Commit-Position: refs/heads/master@{#327322}

If add,remove or add,add (scanning for devices) events are delivered
fast enough, the remove/add event would be processed before the first
add event. In the first case the state would be incorrect while in the
second case it would cause the device to be opened multiple times
(causing permission errors in one of the events). To avoid this, use a
sequenced worker pool to properly order events. The device path is used
to group events for the same device.

This CL also keeps track of the active devices such that we can ignore
duplicate events (possible due to device scanning) and reduce the number
of display configurations performed.

BUG=477792,476728

Review URL: https://codereview.chromium.org/1072193008

Cr-Commit-Position: refs/heads/master@{#327321}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/438de49..50cb76b

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1110823003

Cr-Commit-Position: refs/heads/master@{#327320}

R=brianderson

Review URL: https://codereview.chromium.org/1108193003

Cr-Commit-Position: refs/heads/master@{#327319}

Revert of Add a slimming paint version of the r&r key silk case benchmark (patchset #1 id:1 of https://codereview.chromium.org/1106823003/)

Reason for revert:
Turns out, we really only care about the smoothness version of this benchmark. I'm going to revert this change and put up a new patch to enable the key silk cases smoothness benchmark with slimming paint enabled.

Original issue's description:
> Add a slimming paint version of the r&r key silk case benchmark
>
> This patch adds a version of rasterize and record on key silk cases with
> --enable-slimming-paint.
>
> BUG=464910
>
> Committed: https://crrev.com/da8b63007bd79a03f9d5429d75511db8b723a2ea
> Cr-Commit-Position: refs/heads/master@{#327162}

TBR=chrishtr@chromium.org,sullivan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464910

Review URL: https://codereview.chromium.org/1110203002

Cr-Commit-Position: refs/heads/master@{#327318}

Properly ignore component extensions in InstalledLoader.

Review URL: https://codereview.chromium.org/1114583002

Cr-Commit-Position: refs/heads/master@{#327317}

Revert of Revert of Add CPP API for BLE advertisments. (patchset #1 id:1 of https://codereview.chromium.org/1111563002/)

Reason for revert:
Can't seem to find any bots this was failing on. Trybots on the original CL that had component=shared_library are working fine and locally it builds fine too.

Original issue's description:
> Revert of Add CPP API for BLE advertisments. (patchset #12 id:220001 of https://codereview.chromium.org/1054743003/)
>
> Reason for revert:
> Breaks component=shared_library build (missing export?)
>
> ../../device/bluetooth/bluetooth_adapter_chromeos.cc:321: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::BluetoothAdvertisementChromeOS(scoped_ptr<device::BluetoothAdvertisement::Data, base::DefaultDeleter<device::BluetoothAdvertisement::Data> >, scoped_refptr<chromeos::BluetoothAdapterChromeOS>)'
> ../../base/memory/scoped_ptr.h:128: error: undefined reference to 'device::BluetoothAdvertisement::Data::~Data()'
> ../../device/bluetooth/bluetooth_adapter_chromeos.cc:322: error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'
> obj/device/bluetooth/device_bluetooth.bluetooth_adapter_chromeos.o(.debug_addr+0x6f20): error: undefined reference to 'chromeos::BluetoothAdvertisementChromeOS::Register(base::Callback<void ()> const&, base::Callback<void (device::BluetoothAdvertisement::ErrorCode)> const&)'
>
> Original issue's description:
> > Add CPP API for BLE advertisments.
> >
> > This CL adds the new classes, changes to existing classes and tests for adding
> > the CPP API for LE advertisements. The design for this is available at
> > http://go/chrome-ble-advertising.
> >
> > R=armansito@chromium.org, jamuraa@chromium.org
> > BUG=466375
> >
> > Committed: https://crrev.com/c96da18077ef4b5ab28cb8b2684cd84386075e5a
> > Cr-Commit-Position: refs/heads/master@{#327128}
>
> TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,rkc@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=466375
>
> Committed: https://crrev.com/28bc6bec94e67f23a6a9a16490e6bdf721cf6b27
> Cr-Commit-Position: refs/heads/master@{#327155}

TBR=armansito@chromium.org,jamuraa@chromium.org,scheib@chromium.org,spang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466375

Review URL: https://codereview.chromium.org/1108403002

Cr-Commit-Position: refs/heads/master@{#327316}

This allows us to select which ANGLE back-end to use more flexibly,
and controls the selection process entirely in Chrome.

The logic for when to try a backup renderer is a bit more complex
because we query the display extensions in the static binding
init code.

BUG=457325

Review URL: https://codereview.chromium.org/1051253008

Cr-Commit-Position: refs/heads/master@{#327315}

The hack is no longer needed.

BUG=310172

Review URL: https://codereview.chromium.org/1113643002

Cr-Commit-Position: refs/heads/master@{#327314}