- 29 Mar, 2018 40 commits
-
-
Xiaohui Chen authored
The callbacks are called on a different thread than the main thread. Need to post them to main thread instead of directly handling it. Bug: None Test: locally build and run, no DCHECK crash Change-Id: Ib08e5363348959e0702d80cac96c20f28975cd56 Reviewed-on: https://chromium-review.googlesource.com/985898 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#546931}
-
Stephen Martinis authored
They're broken pretty badly on windows. Bug: 826735 No-Try: True Change-Id: I65320b55b66d3780b542b8a0b521f72cee0f30f0 Reviewed-on: https://chromium-review.googlesource.com/986650Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#546930}
-
W. James MacLean authored
Record whether DevTools is currently active in CrashKeys. Bug: 824774 Change-Id: I697bf892037c63216890d9d5f7ccc67e037f3b19 Reviewed-on: https://chromium-review.googlesource.com/986453 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546929}
-
Mostyn Bramley-Moore authored
This reverts commit 07b2231e. Reason for revert: We need to be more conservative with plugin behaviour changes. TODO: document the process, then attempt to re-land this change via that process. Original change's description: > drop unnecessary realpath usage in the FindBadConstructs plugin > > All we need to do is ensure that there's a leading '/' in the path, we > don't expect the path to exist necessarily, and we don't need to resolve > symlinks. We just want to be able to search for directories by doing a > string search of the form "/foo/". And since we don't use realpath > anymore, this should work with distributed compilation systems like icecc. > > This will also avoid mis-classification of files in chromium checkouts > that are inside a directory with the same name as one of the so-called > "banned" directories, eg a checkout in /home/gen/chromium/. > > BUG=583454 Change-Id: Ic840387bb2244d967e66fd078684c56435fe940a Reviewed-on: https://chromium-review.googlesource.com/986435Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#546928}
-
Eric Noyau authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9952338f4a2faeaaec02d15a4917f9542ee57926 Reviewed-on: https://chromium-review.googlesource.com/985980 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546927}
-
sebsg authored
Attempts to refill a form that was modified after an initial fill if it respects these conditions: - Only if the form is modified after a fill - Only if the form is modified less than 1 second after the fill - Only once per page - Only refill group types that were filled initially - Only if the form has the same "NameForAutofill" Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaad7a49f8d0237fadacde590d473a9fcb3ae6323 Reviewed-on: https://chromium-review.googlesource.com/943251 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#546926}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/85a5ac7c6177..f3f1110ffae1 $ git log 85a5ac7c6..f3f1110ff --date=short --no-merges --format='%ad %ae %s' 2018-03-29 hidehiko Fix android-package name for P. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I358dcec3db289470779d49b492718015d1526736 Reviewed-on: https://chromium-review.googlesource.com/986643Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546925}
-
https://pdfium.googlesource.com/pdfium.git/+log/3b76ebd56054..8f4f0ede809a $ git log 3b76ebd56..8f4f0ede8 --date=short --no-merges --format='%ad %ae %s' 2018-03-29 thomasanderson Fix use_custom_libcxx=false build on Linux Created with: roll-dep src/third_party/pdfium BUG=chromium:None The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0b406a22a21807ba0c4b921eb9cb2b2d9b992357 Reviewed-on: https://chromium-review.googlesource.com/985903 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546924}
-
Tommy C. Li authored
To implement the Material Refresh UI, we need to draw this elevation-based shadow on all platforms, not just ones that we use the Window manager on. Therefore we are moving this Shadow class from ui/wm to ui/compositor. Forked off of: https://chromium-review.googlesource.com/c/chromium/src/+/869699. Bug: 823535 Change-Id: Ib12ca299ab15512022228283d946c8403751525a Reviewed-on: https://chromium-review.googlesource.com/978590Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#546923}
-
Vlad Tsyrklevich authored
BUG=701919 Change-Id: If2880073f9e927534fb24295fc6a375d78b80f2c Reviewed-on: https://chromium-review.googlesource.com/985155Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#546922}
-
Anthony Vallee-Dubois authored
Bug: 823338 Change-Id: I24be14c162c2098c1c797bf8720d455005487770 Reviewed-on: https://chromium-review.googlesource.com/982363Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#546921}
-
Findit authored
This reverts commit 338eaef9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 546901 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMzOGVhZWY5Yzc1ODU3Zjg3ZTM3YmZlYTM2Yjg3ZDdiYmM2NGM0OWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Win/65521 Sample Failed Step: compile Original change's description: > Use ReentrantObserverList for aura::Window::observers_ > > BUG=812109 > TEST=aura_unittests pass with "allow_reentrancy=false", which will > be default in the future. > > Change-Id: Ic1ab64cbf4021f4495933bb4803130c1715b203f > Reviewed-on: https://chromium-review.googlesource.com/984831 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546901} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=812109 Change-Id: I42ac5f5dc01e24f392984c3f77a0a3f4aae636e3 Reviewed-on: https://chromium-review.googlesource.com/986892 Cr-Commit-Position: refs/heads/master@{#546920}
-
Evan Stade authored
Don't try to be smart about no-oping when the size hasn't changed since SetBoundsRect() already does that (but also checks if layout is valid). Bug: none Change-Id: Ie4826005187777c9d6952fd9583865cb74b67d65 Reviewed-on: https://chromium-review.googlesource.com/986471Reviewed-by:
-
Shimi Zhang authored
This reverts commit a1f4e6cb. Reason for revert: This is causing all cronet build failing on cronet_test_instrumentation_apk Original change's description: > Android: Upgrade ProGuard 5.2.0 -> 6.0.1 > > Shrinks ChromePublic.apk's classes.dex uncompressed by 110kb > > Release notes: > https://www.guardsquare.com/en/blog/proguard-60-released > > Change-Id: I237dfb7fb35c33671766c217f838ff559d0a4baf > Reviewed-on: https://chromium-review.googlesource.com/982011 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546711} TBR=agrieve@chromium.org,jbudorick@chromium.org Change-Id: Icf9e21a9c91f6e6de56ec9590514edec2d6c4758 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/986616Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#546918}
-
Klaus Weidner authored
We should never get any frames arriving on the Surface before the corresponding SubmitFrame which calls SwapBuffers. This was left over from the old compositor transport path. Change-Id: I5180921404a3697f26bd7e6b8c8e09c1580c171f Reviewed-on: https://chromium-review.googlesource.com/985636 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#546917}
-
Klaus Weidner authored
Rename frame_index_ to next_frame_index_ to make it more visually distinct from the "frame_index" parameter. It's not supposed to be used outside SendVSync related logic. Rename webvr_delayed_frame_submit_ to webvr_delayed_gvr_submit_. I'll be adding a saved closure to defer an incoming mojo SubmitFrame, and it's confusing if the names are too similar. Update the SendVSync DVLOG to distinguish skipped frames from animated frames. Remove the unused last_frame_index_ member. Change-Id: If937f936f6ba8e6029b21d72d4211f63aecc6da5 Reviewed-on: https://chromium-review.googlesource.com/984714 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Mikel Astiz authored
As part of a larger effort to avoid direct use of SessionID::id_type, and instead use SessionID, this patch migrates one of the main provider and consumer of session IDs: components/sessions (including session and tab restore). Besides the API changes, the internal implementation components/sessions also migrates away from deprecated APIs, such as using the default constructor of SessionID. Bug: 823798 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8e10aadc7ee12a63e73c13290b66a5febbcfeeed Reviewed-on: https://chromium-review.googlesource.com/982626Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#546915}
-
Bernhard Bauer authored
The feature still requires a whitelisted client package name and will only work on a trusted CDN that sends the right header. It can also be disabled via a kill switch. Bug: 814365 Change-Id: Ic57e01357c61f73eabb0bf90813e77664b61fc6a Reviewed-on: https://chromium-review.googlesource.com/983963Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546914}
-
Scott Violet authored
If ResourceRequestAllowedNotifier::Init() is called before the NetworkChangeNotifier has been created, then no observer is added and ResourceRequestAllowedNotifier's Observer is never notified. I'm moving the call from VariationService's constructor to PreMainMessageLoopRun(), at which point the NetworkChangeNotifier has been created (and adding a DCHECK in VariationService for good measure). BUG=826930 TEST=none Change-Id: Id2d4e2a541738fb9451ae3b1fd36cd72db445d92 Reviewed-on: https://chromium-review.googlesource.com/985769 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#546913}
-
chrome://device-logReilly Grant authored
This log contains events which are indirectly related to user activity and so should be cleared when the user requests that the browser delete this data. Bug: 826490 Change-Id: Ief8bdf0985ade4fe47084991e599aef5322003c4 Reviewed-on: https://chromium-review.googlesource.com/984718Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#546912}
-
Jialiu Lin authored
Gaia reuse ClientSafeBrowsingReportRequests are dropped by SB backend because of missing page_url field. This is because in UnsafeResource::IsMainPageLoadBlocked() function, this threat type is not marked as not blocking main page. And consequently, UnsafeResource::GetNavigationEntryForResource() returns null, thus prevent ThreatDetails to fill the page_url field. Bug: 826508 Change-Id: I27f6ee4974c2956acbd135d733bf43a4da3159d1 Reviewed-on: https://chromium-review.googlesource.com/982600Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#546911}
-
Karan Bhatia authored
This CL adds "last_committed_main_frame_url" and "pending_main_frame_url" to the extension FrameData. "last_committed_main_frame_url" is used to track the the last committed url of the frames's web contents and "pending_main_frame_url" is used to track an active main frame navigation. "pending_main_frame_url" will be required for main frame subresource loads which cannot be reliably mapped to a single main frame url currently. In a subsequent CL, a page whitelisting API will be introduced for the Declarative Net Request API and this information related to the main frame url will be used to check whether a network request has been whitelisted as per the API. BUG=811460, 696822 Doc=https://docs.google.com/document/d/1Fhm-t0JCc3dcmwyBX_i7TGyuJ2QjqDechv1-VCRBo5o/edit?usp=sharing Change-Id: Ie6588955ca5105af0bca4ed4408a141b0d586e44 Reviewed-on: https://chromium-review.googlesource.com/936325Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#546910}
-
Eugene But authored
New images match with the current palette from Open Source MDC. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ied128f319a5bfadc818cb86a3aa4389a1d4ae948 Reviewed-on: https://chromium-review.googlesource.com/982542 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#546909}
-
Eugene But authored
Drive icon x center is anchored to status icon center x. Drive label leading is anchored to status label leading. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0ba004c83d59f34c80fcbc6c11757e313a7c3945 Reviewed-on: https://chromium-review.googlesource.com/985233 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
bsheedy authored
Returns early in onLargeIconAvailable if mNotificationInfoBuilder is null. Bug: 826928 Change-Id: I339650af36f24674c5db7781625811f8755319fc Reviewed-on: https://chromium-review.googlesource.com/985455Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#546907}
-
David Reveman authored
This is needed to allow wayland server support in guest mode. Bug: 827253 Change-Id: I3196e0298369ca092638f2bdad1adc130117850b Reviewed-on: https://chromium-review.googlesource.com/986573Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f126268a..95f3837e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I8eb0ddd6007bdefff31f6ec36d1986c7ab88fa64 Reviewed-on: https://chromium-review.googlesource.com/986474Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#546905}
-
Bruce Dawson authored
While analyzing crash dumps from crbug.com/754677 I wanted to know the timeout value passed to MsgWaitForMultipleObjectsEx and other functions. I attempted to retrieve that value from r8 but it appears that the user-mode registers saved when a thread is waiting on the kernel are not trustworthy. So, this uses the simpler and more reliable technique of base::debug::Alias. Bug: 754677 Change-Id: Ib9b7c294c6fff8566121c33edb04a25abec9df81 Reviewed-on: https://chromium-review.googlesource.com/985107Reviewed-by:
-
Tom Anderson authored
Change-Id: Iaa5a1548901498e8d38b6e92bda8c301af2fd631 Bug: None Reviewed-on: https://chromium-review.googlesource.com/985416Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
This also breaks down the existing 'begin scanning/advertising -> connection' foreground advertising metric into two additional metrics: 'begin scanning/advertising -> receive advertisement' and 'receive advertisement -> connection'. Local testing with these new metrics gives initial insight into the likely performance improvement of the background advertising model (Foreground='FG', Background='BG'): FG, begin scanning/advert -> receive advert: 3062ms FG, receive advert -> connection: 5190ms FG, begin scanning/advert -> connection: *8253ms* BG, begin scanning -> receive advert: 1099ms BG, receive advert -> connection: 5604ms BG, begin scanning -> connection: *6703ms* Bug: 819279 Change-Id: Iffe5b9e53f1a6bc5ef69e37e1e3d150826c5fe7b Reviewed-on: https://chromium-review.googlesource.com/978441 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#546902}
-
Mitsuru Oshima authored
BUG=812109 TEST=aura_unittests pass with "allow_reentrancy=false", which will be default in the future. Change-Id: Ic1ab64cbf4021f4495933bb4803130c1715b203f Reviewed-on: https://chromium-review.googlesource.com/984831Reviewed-by:
-
Bailey Berro authored
This change adds an SMB Shares subpage to the Downloads settings. If the NativeSmb feature flag is enabled, an SMB Share can be mounted by providing the url. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic0b52eeda2247edff8d61b330ecc8a2c755b1bab Reviewed-on: https://chromium-review.googlesource.com/967160 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Koji Ishii authored
110 rebaselines from manual review of 1074 IMAGE and IMAGE+TEXT failures in: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_layout_ng/4444 Rebaselined differences are: 1. 1px glyph inline positioning differences. 2. List bullets differences (crbug.com/826267, may fix) Following look possible to rebaseline but are not included: 1. Round borders are slightly different. Not distinguishable for me, but left as failures for now. 2. Rotate-transformed lines are slightly different. Not distinguishable for me, but left as failures for now. TBR=eae@chromium.org, mstensho@chromium.org, atotic@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I584ac19103a90e329e72752002f05fd39a50f451 Reviewed-on: https://chromium-review.googlesource.com/986036 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#546899}
-
https://chromium.googlesource.com/angle/angle.git/+log/96310cdad317..a43994c9dd3a $ git log 96310cdad..a43994c9d --date=short --no-merges --format='%ad %ae %s' 2018-03-29 lfy GLES1: glColor4(f|ub|x) 2018-03-28 lucferron Vulkan: Add support for ivec* for uniforms 2018-03-27 lucferron Vulkan: Support for uniform arrays 2018-02-12 xinghua.cao ES31_GLSL: support invocation and memory control functions Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: Ice3ce72b48bcf9a7856e3eecb31ea089fac505ff Reviewed-on: https://chromium-review.googlesource.com/986640Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#546898}
-
Matt Mueller authored
CertDatabase does not actually use NSS. Also remove inaccurate & obsolete comment from NSSCertDatabase (NSS must already be initialized if the constructor is getting PK11Slot arguments passed in!) Bug: 59847 Change-Id: I3995834dabdc385bb28e493d864c50934770b95d Reviewed-on: https://chromium-review.googlesource.com/964623Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#546897}
-
Amirhossein Simjour authored
A flag is added to NativeUiModel that shows if the UI should be floating. A floating UI is rendered on a quad that is close to the main content. This CL is the break down of https://chromium-review.googlesource.com/961456 to make the review and clean up process easier. Bug: 819881 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3a0baf6d82766f72e314b217081343d7a9335862 Reviewed-on: https://chromium-review.googlesource.com/969113 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Reviewed-by:
-
Matthew Jones authored
This patch changes the behavior of EoC. When suggestions become available, the content is not shown until the user scrolls down the page and reverse scrolls back up. This means that it is possible the user never sees the bottom sheet even when suggestions are available. Bug: 822948 Change-Id: I2f9f16b41469347163295d3d79e5a322d3666cfe Reviewed-on: https://chromium-review.googlesource.com/982494 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#546895}
-
Julia Tuttle authored
Change-Id: If7751d0316ac54e8c2e961c5b4e0385f1c6107a6 Reviewed-on: https://chromium-review.googlesource.com/978301 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
On CL https://chromium-review.googlesource.com/860138 FormParser was implemented. This CL makes use of FormParser in Password Manager. It contains: 1.Minor fixes in FormParser 2.Moving JSON->FormData functions from autofill_agent.mm to autofill_util (since they will be used in PasswordManager). 3.Calling Autofill convert utils for converting DOM->JSON from PasswordController.js 4.Calling Autofill JSON->FormData convert utils from PassswordController.mm. 5.Removing all old password form parsing code. 6.Unittests update. More details in go/ios-password-form-parsing. Bug: 807623 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I256301ae09f9bdad06522847022d155fa0d78ba7 Reviewed-on: https://chromium-review.googlesource.com/901664 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#546893}
-
Dave Schuyler authored
This Cl renames (and groups) some member variables to be more clear about what is for the suggestion view and what is for the keyword view. This helps highlight that the keyword view is using the separator from the suggestion view. That's something I intend to address in a follow-up CL. Long term, I'd like to create a new view that each of the suggestion view and keyword views are instances of. This this CL is making no logic changes, I'm sending it TBR. TBR=jdonnelly@chromium.org Bug: None Change-Id: I505dbb4d69bfc7be5acc5cde1a4353bea0b1e2dd Reviewed-on: https://chromium-review.googlesource.com/985456Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#546892}
-
