- 26 Sep, 2014 40 commits
-
-
qsr authored
Due to the following bug: https://code.google.com/p/android/issues/detail?id=76644, it is not possible in art to create an empty buffer for address NULL. This solve the issue by creating an empty buffer on a random address. This is not an issue as the memory will never be accessed. BUG=406848 R=ppi@chromium.org,yfriedman@chromium.org Review URL: https://codereview.chromium.org/601163002 Cr-Commit-Position: refs/heads/master@{#296964}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/2a007a0..e48d3d4 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/608463005 Cr-Commit-Position: refs/heads/master@{#296963}
-
jrummell authored
BUG= Review URL: https://codereview.chromium.org/607693002 Cr-Commit-Position: refs/heads/master@{#296962}
-
earthdok authored
A recent security update changed the file, so the patch had to be rebased. BUG=313751 TBR=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/610643002 Cr-Commit-Position: refs/heads/master@{#296961}
-
dmazzoni authored
BUG=408809 Review URL: https://codereview.chromium.org/541903002 Cr-Commit-Position: refs/heads/master@{#296960}
-
noms authored
Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMc28yXzJuRFRZbWs&authuser=1 TL; DR: - never show a drop down arrow in the button. This means we can do s/MenuButton/LabelButton - if there is one local, non-signed in profile, show a tiny button with a generic avatar - in all other cases, show the avatar button with the profile name - updated the button insets so that the icons are centered correctly in the button - the new tab button should completely slide under the avatar button - because of this, I made public the new tab button width (and height, to be consistent) BUG=410946 Review URL: https://codereview.chromium.org/598163002 Cr-Commit-Position: refs/heads/master@{#296959}
-
qsr authored
This is a reland of https://codereview.chromium.org/607513003 with the fix for the failing test. BUG=417707 TBR=sdefresne@chromium.org Review URL: https://codereview.chromium.org/612443002 Cr-Commit-Position: refs/heads/master@{#296958}
-
timvolodine authored
Fix the number of buckets in Tabs.ScrubDistance. Currently the value 19 falls in the bucket with value 18 which is confusing. Results can be checked on uma.googleplex.com. BUG= Review URL: https://codereview.chromium.org/551893002 Cr-Commit-Position: refs/heads/master@{#296957}
-
damienv authored
BUG=376450 Review URL: https://codereview.chromium.org/599123002 Cr-Commit-Position: refs/heads/master@{#296956}
-
plundblad authored
BUG=394284 Review URL: https://codereview.chromium.org/598003002 Cr-Commit-Position: refs/heads/master@{#296955}
-
treib authored
Update the AvatarMenu (and the ProfileChooserView, which listens for changes to the AvatarMenu) when a supervised user's custodian info changes. BUG=372381 Review URL: https://codereview.chromium.org/597783003 Cr-Commit-Position: refs/heads/master@{#296954}
-
rmcilroy authored
BUG=418029 Review URL: https://codereview.chromium.org/605073003 Cr-Commit-Position: refs/heads/master@{#296953}
-
penghuang authored
BUG=417408 Review URL: https://codereview.chromium.org/601293003 Cr-Commit-Position: refs/heads/master@{#296952}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/0f037ba..2a007a0 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/602043005 Cr-Commit-Position: refs/heads/master@{#296951}
-
timvolodine authored
Fix number of buckets in AsyncDNS.ServerCount and SyncDNS.ServerFailureIndex UMA histograms. Currently the value 9 falls in the bucket with value 8 which is confusing. Results can be checked on uma.googleplex.com. BUG= Review URL: https://codereview.chromium.org/551873002 Cr-Commit-Position: refs/heads/master@{#296950}
-
asanka authored
If the cause of a rename failure is suspected of being transient (sharing violations, suspected race conditions in the file system), then retry the rename with an exponential backoff. BUG=368455 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278483 Reverted (Win XP issues): https://chromium.googlesource.com/chromium/src.git/+/d31e3689a5f5a0ae6eba1f15ea299bf84fd6d381 Review URL: https://codereview.chromium.org/319603003 Cr-Commit-Position: refs/heads/master@{#296949}
-
aurimas authored
BUG=416041 Review URL: https://codereview.chromium.org/609663002 Cr-Commit-Position: refs/heads/master@{#296948}
-
ttuttle authored
Add a "domain" field that returns the hostname of the original request. This lets sites with wildcard contexts tell which subdomain triggered the beacons they receive. BUG= Review URL: https://codereview.chromium.org/605473002 Cr-Commit-Position: refs/heads/master@{#296947}
-
qsr authored
Revert of mojo: Add router for python bindings. (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/607513003/) Reason for revert: Test are failing. Original issue's description: > mojo: Add router for python bindings. > > BUG=417707 > R=sdefresne@chromium.org,cmasone@chromium.org > > Committed: https://crrev.com/5d07d365694ba3e516a861a1018d31e055bfdf39 > Cr-Commit-Position: refs/heads/master@{#296941} TBR=cmasone@chromium.org,sdefresne@chromium.org NOTREECHECKS=true NOTRY=true BUG=417707 Review URL: https://codereview.chromium.org/609783004 Cr-Commit-Position: refs/heads/master@{#296946}
-
vadimt authored
Adding tracking to verify the theory that jankiness of ExtensionMessageFilter::OnExtensionAddListener is because of rebuilding matchers. BUG=417106 Review URL: https://codereview.chromium.org/597413004 Cr-Commit-Position: refs/heads/master@{#296945}
-
dgozman authored
Revert of [DevTools] Implement DevToolsManager::Observer which notifies about target updates. (patchset #5 id:80001 of https://codereview.chromium.org/577923002/) Reason for revert: Breaks asan bot. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7924 Original issue's description: > [DevTools] Implement DevToolsManager::Observer which notifies about target updates. > > BUG=398049 > > Committed: https://crrev.com/509c17cf55a12b49b017245f6d0cff558f312637 > Cr-Commit-Position: refs/heads/master@{#296921} TBR=pfeldman@chromium.org,vkuzkokov@chromium.org,jam@chromium.org NOTREECHECKS=true NOTRY=true BUG=398049 Review URL: https://codereview.chromium.org/591313006 Cr-Commit-Position: refs/heads/master@{#296944}
-
pritam.nikam authored
With current implementation forms lacking user-name fields are treated as invalid password forms and browser does not save passwords in such cases. With this patch password manager saves passwords on forms without user-name fields as well. BUG=406343 TBR=gcasto@chromium.org,vabr@chromium.org Review URL: https://codereview.chromium.org/548953002 Cr-Commit-Position: refs/heads/master@{#296943}
-
bengr authored
When the data reduction proxy responds with a bypass message, chromium constructs a redirect response and feeds that through the network stack. This results in the request being retried directly to the origin. If the original request had an Origin header, then the manufactured redirect should have the appropriate CORS headers. BUG=415644 Review URL: https://codereview.chromium.org/603323002 Cr-Commit-Position: refs/heads/master@{#296942}
-
qsr authored
BUG=417707 R=sdefresne@chromium.org,cmasone@chromium.org Review URL: https://codereview.chromium.org/607513003 Cr-Commit-Position: refs/heads/master@{#296941}
-
John Abd-El-Malek authored
BUG=327719 TBR=hirono@chromium.org Review URL: https://codereview.chromium.org/608803002 Cr-Commit-Position: refs/heads/master@{#296940}
-
glevin authored
Images over 32M pixels exceed IPC message limit size. In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message. BUG=366825 TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug Committed: https://crrev.com/d9d0e601c4c45ec8f2fb1d148e68458d9baa4e24 Cr-Commit-Position: refs/heads/master@{#296407} Review URL: https://codereview.chromium.org/482163002 Cr-Commit-Position: refs/heads/master@{#296939}
-
paulmeyer authored
Fix for how webview.executeScript and webivew.insertCSS check for page navigtation when loading data URLs via NavigationController::LoadURLWithParams. Tests will follow shortly in the patch that adds webview.loadDataWithBaseURL. BUG=417816 TBR=rockot@chromium.org Review URL: https://codereview.chromium.org/602193002 Cr-Commit-Position: refs/heads/master@{#296938}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/5ce3b1a..0f037ba TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/607883003 Cr-Commit-Position: refs/heads/master@{#296937}
-
jkarlin authored
This will prevent tests that utilize a SimpleCache from running into teardown leaks. BUG=413688 Review URL: https://codereview.chromium.org/562203002 Cr-Commit-Position: refs/heads/master@{#296936}
-
igsolla authored
Remove the legacy fullscreen video path that was used before html5 video controls were introduced. The last user was the WebView, but this has been migrated to html5 controls now. Review URL: https://codereview.chromium.org/597523003 Cr-Commit-Position: refs/heads/master@{#296935}
-
fdegans authored
BUG=397118 Review URL: https://codereview.chromium.org/605773002 Cr-Commit-Position: refs/heads/master@{#296934}
-
xians authored
Revert of Reland 588523002: Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #5 id:80001 of https://codereview.chromium.org/597923002/) Reason for revert: It fails some aec dump content browser tests on windows, and likely it also breaks the aec dump production code, it is safer to revert it since cut happens today. http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester/builds/9752/steps/content_browsertests/logs/stdio Original issue's description: > The original review thread is in https://codereview.chromium.org/588523002/ > > Fix the way how we create webrtc::AudioProcessing in Chrome. > > TBR=tommi@chromium.org > > BUG=415935 > TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist. > > Committed: https://chromium.googlesource.com/chromium/src/+/5ac9f35c3e5d9781a01769f3f0d0433026c57de7 TBR=tommi@chromium.org,jochen@chromium.org,maruel@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=415935 Review URL: https://codereview.chromium.org/611493002 Cr-Commit-Position: refs/heads/master@{#296933}
-
mlerman authored
Fixes an issue where chrome://signin-internals page is opened multiple times, and the scoped_ptr was getting de-allocated by the first object. Moving to a linked_ptr for more robust reference counting. BUG=416802 Review URL: https://codereview.chromium.org/602773002 Cr-Commit-Position: refs/heads/master@{#296932}
-
sammc authored
BUG=406487,416665 Review URL: https://codereview.chromium.org/603243004 Cr-Commit-Position: refs/heads/master@{#296931}
-
hjd authored
To pick up the asset fix at https://android-review.googlesource.com/#/c/108196/. BUG=391488 Review URL: https://codereview.chromium.org/603683008 Cr-Commit-Position: refs/heads/master@{#296930}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b71ff8c..5ce3b1a TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/608743002 Cr-Commit-Position: refs/heads/master@{#296929}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#296928}
-
vkuzkokov authored
Issue 387067 can be resolved by having port forwarding socket dependent on all other references to AndroidDeviceManager::Device. This requires for lifetime of AWS to be manageable in the first place. BUG=387067 Review URL: https://codereview.chromium.org/449883002 Cr-Commit-Position: refs/heads/master@{#296927}
-
mek authored
TBR=erikwright Review URL: https://codereview.chromium.org/607683002 Cr-Commit-Position: refs/heads/master@{#296926}
-
wuchengli authored
BUG=350197,402182 TEST=Run vainfo and VEA unittest on various Intel platforms. Review URL: https://codereview.chromium.org/603153002 Cr-Commit-Position: refs/heads/master@{#296925}
-