- 15 Jan, 2020 40 commits
-
-
David Munro authored
Bug: None Test: CQ Change-Id: I0b1ef13b013673712abfe69f25fe2ef1dc22d3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000438 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#731850}
-
Kunihiko Sakamoto authored
After this patch, Web Bundles response from network without "X-Content-Type-Options: nosniff" header will cause net::ERR_INVALID_WEB_BUNDLE error. Spec: https://wicg.github.io/webpackage/draft-yasskin-wpack-bundled-exchanges.html#name-serving-constraints Bug: 1018640 Change-Id: I32632ee547ab32ea6646d0150dcc9493c374c263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992944Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#731849}
-
Donn Denman authored
This enables the OverlayNewLayout feature for all builds. We've pushed this to 1% Stable on M79 and the metrics look good, so default-enabling for M81 (will revert if the experiment has snags). BUG=929870 Change-Id: Iaa9ba3d0b3712d66db936b8991b5635c3f11aa4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993876 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#731848}
-
Hiroshi Ichikawa authored
Change-Id: I3bbe59acc8e2ac8dc4a1e9d6cfc8d97d184cb026 BUG: 1023250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961285 Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#731847}
-
Kent Tamura authored
* Add HTMLInputElement::UploadButton() to return a shadow element * Update its active state for CanReceiveDroppedFiles() immediately. Remove LayoutFileUploadControl::can_receive_dropped_files_. * Remove LayoutFileUploadControl::ButtonValue(), which was not used. * Remove LayoutFileUploadControl::UploadButtonWidth(), which was not defined. This CL has no behavior changes. Bug: 1040828 Change-Id: Id2a598dacd9f60451614d38fba3785cea1ec4d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000280Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#731846}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 10b09986. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I24b2e99cf86196375d3dfb88bc287b41630fcbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001163Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731845}
-
John Lee authored
Bug: 1027373 Change-Id: Ie4acd431ce85b62fc0ff961e81e1f6a64dad5500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000969 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#731844}
-
Gil Dekel authored
Certain chromebooks now come with panels that have integrated privacy screens on them. This CL exposes the existence of this property, or lack thereof, by propagating this information from ozone/drm via DisplaySnapshot. Bug: b/147451539 Test: display_unittests Change-Id: I8b531de0d1c8089a606913104d409a453a3034a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994435 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#731843}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/118df7cf62ab..9d91492203f0 git log 118df7cf62ab..9d91492203f0 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 bsalomon@google.com Revert "Make SkGpuBlurUtils take SkTileMode" 2020-01-15 mtklein@google.com make sure each sample() call uses the same uniforms 2020-01-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-14 robertphillips@google.com Update compressed texturing GM 2020-01-14 mtklein@google.com add dumpJIT() to disassemble 2020-01-14 mtklein@google.com Revert "Pass in a SkColorType into SkImage_Gpu ctor." 2020-01-14 bsalomon@google.com Make SkGpuBlurUtils take SkTileMode 2020-01-14 mtklein@google.com add --skvm to nanobench and fm 2020-01-14 egdaniel@google.com Pass in a SkColorType into SkImage_Gpu ctor. 2020-01-14 robertphillips@google.com Expand SkImage::MakeFromCompressed to support mipMapping 2020-01-14 jvanverth@google.com Revert "Add new method for storing DrawOpAtlas texture index." 2020-01-14 halcanary@google.com [minor] tools/skottie_ios_app/Skia*Context: remember to cast 2020-01-14 jvanverth@google.com Add new method for storing DrawOpAtlas texture index. 2020-01-14 halcanary@google.com add more docs/examples from named fiddles. 2020-01-14 mtklein@google.com improve scalar gather32 2020-01-14 mtklein@google.com impl gather32 for x86 Created with: gclient setdep -r src/third_party/skia@9d91492203f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: Ibc368040d194b67a70d0562c8400aa3b9318e3b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731842}
-
David Munro authored
ResultCallback is used in more places than the comment says e.g. it's also used for PortForwarding. Remove the list of what it's used for. Bug: None Test: None Change-Id: I7967253035a0d983593e20c9746f320575323c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002039 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#731841}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cd170a5c7216..7f078e7ebe3f git log cd170a5c7216..7f078e7ebe3f --date=short --first-parent --format='%ad %ae %s' 2020-01-15 jiawei.shao@intel.com Add checks to TextureUsage::Storage Created with: gclient setdep -r src/third_party/dawn@7f078e7ebe3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id270105030404a3398009131f0a465063199f9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001859Reviewed-by:
-
Hayato Ito authored
ServiceWorkerOfflineCapabilityCheckBrowserTest is flaky. The failure happens when we assert SW's status is ACTIVATED after we await navigator.serviceWorker.ready. This is, however, is not always true. Its status can be ACTIVATING. See https://crbug.com/1041778#c4 for details. Bug: 1041778 Change-Id: I62ff0ee1a99d05ef693bbf4585a25b6c8831cedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000400Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#731839}
-
Xianzhu Wang authored
This is a follow-up of the rebaseline of the base tests. TBR=wangxianzhu@chromium.org Change-Id: I5091e1b9798918ab4ec6389d282f9b30f2580088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001944Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#731838}
-
Sammie Quon authored
Jesse said these will be useful indefintely, but the histogram rules states we should set expires for a year out. Bug: 975485 Change-Id: I24f9b5d8f539069b9d54ce96d2c289299dc2519c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673573Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#731837}
-
Sadrul Habib Chowdhury authored
It is not necessary to report the various latency metrics for the Universal sequence, since the un-prefixed metric is equivalent. BUG=none Change-Id: I82caf09752288e6dbfe3c2781be1668e0d2a10af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996154 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#731836}
-
Koji Ishii authored
Before this patch, |NGFragmentItem| used its own function to paint inline children of |LayoutBlockFlow|. This patch changes it to use |PaintBlockFlowContents| by making the function support |NGFragmentItem|. Fixes ~45 failiures. Bug: 982194 Change-Id: I9f4de6c71f85cf14722fcb8b1721719445dd1f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994556Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c58babd220a9..a7d8cc39254e git log c58babd220a9..a7d8cc39254e --date=short --first-parent --format='%ad %ae %s' 2020-01-14 thestig@chromium.org Merge CFX_FilteredDIB into CPDF_DIBTransferFunc. 2020-01-14 thestig@chromium.org Consistently use helper functions to read from FXDIB_Format. 2020-01-14 thestig@chromium.org Make CFX_DIBBase::IsAlphaMask() consistent with related functions. Created with: gclient setdep -r src/third_party/pdfium@a7d8cc39254e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Icb8556800acfe69001e7bef8cd4fae5de03e0fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001687Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7431e17d79d0..b9bb682ff61f git log 7431e17d79d0..b9bb682ff61f --date=short --first-parent --format='%ad %ae %s' 2020-01-15 fancl@chromium.org Fix the read-only view of sheriff Created with: gclient setdep -r src/third_party/catapult@b9bb682ff61f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: wenbinzhang@google.com Change-Id: I137f83359467d416cb51cf24848cca1d17ad4826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001861Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/676a4d7d6cca..0c469d4541c3 Created with: gclient setdep -r src-internal@0c469d4541c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034829 Tbr: jbudorick@google.com Change-Id: Ie74c3c82d575417c94a82b1f0c8263149d2a7ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731832}
-
Rachel Carpenter authored
Bug: 1034629 Change-Id: Ic7a90406c044a6fae9871cd5f1ebf1d5b79622de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999884Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#731831}
-
Wei Li authored
Change-Id: I06f1eff192d85a69365069e4e337d45a4e638b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001084Reviewed-by:
-
Mario Bianucci authored
This DCHECK is causing a small number of crashes, but I can't find a reason for it to exist. As far as I can tell, it shouldn't hurt anything if a ScrollBegan event comes through with 0 deltas. After removing it, I tried scrolling via mouse wheel, touchpad, and touch screen and all still worked fine. I also tried removing it and changing both scroll_update.data.scroll_update.delta_x and scroll_update.data.scroll_update.delta_y to 0 every time it entered that block, and scrolling appeared just fine to my eye. I moved the needs_update requirement to the if statement to avoid extra work being done if kPhaseBegan mouse wheel events come through with 0 deltas because I'm not sure how commonly that occurs. Bug: 1039911 Change-Id: I8e9590ef95dedd94830e6181322cd111e72b5b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995702 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#731829}
-
Lin Sun authored
Remove some flaky issues on Intel graphics card including a comprehensive suppression that marks all d3d11 tests as flaky. Remove fixed failures and reorder some common vulkan failures. Bug: 602688, 620379, 628395, 854100, 945942 Bug: 1014429, 1025652, 1021428 Bug: angleproject:1179, angleproject:2722 Bug: angleproject:2914, angleproject:3469 Change-Id: I50c14fb96f55c4cf2e1098c6b0b98c4f2d160048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973712Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#731828}
-
Makoto Shimazu authored
This metric is used for the health check of InstallEvent dispatched to service workers. Let's extend the expiration date for one more year. Bug: 1037267 Change-Id: Ida1213ebb002cea5d30b074b799d605b7270c208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997437Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#731827}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=miu@chromium.org Bug: 1041419 Change-Id: Ibdcde4d07f7c038ab1559bdafd86a09d6d3a8574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995797 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#731826}
-
Joshua Bell authored
Chrome's AppCache implementation supported specifying namespaces as regular expressions that match URLs. This extension was invoked by adding the `isPattern` keyword after the namespace in the manifest. Parser support was removed in a previous CL. This CL finishes the cleanup, although the database schema is left untouched. Bug: 1039869 Change-Id: Id4f1c13e1bef5b0282d2383e166559b4431a1dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999623 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#731825}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=miu@chromium.org Bug: 1041419 Change-Id: I286d8d48c666171a21289b458825eae8fd61a482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997790 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
shrekshao authored
Expose to WebGL 2 only as first stage. Implementation includes hooking up ANGLE implementation and that in cmd decoder. Bug: 1000354 Change-Id: I0f856d5ce693cb8da8275eda5179a582068880ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907195 Auto-Submit: Shrek Shao <shrekshao@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#731823}
-
Tim Song authored
The quick settings bubble currently intercepts all key events when it is not activated, but this behaviour breaks text input for notifications in the new message center bubble. TEST=manually verified BUG=1040738 Change-Id: Ib465fe7dee85ddd8a018c39197953de0ba79b844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001758Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#731822}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I84c3bfab7c42accaf198ee1a84a62602ca173b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997655Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#731821}
-
Victor Fei authored
Currently, when a label is referenced by a control of type radio or checkbox, we set the label as ignored in the AXTree thereby excluding it from being perceived by ATs. However, for the case when the control (radio/checkbox) is a descendant of the label and label is focusable (tabindex="0") but control is to be omitted from focus (tabindex="-1"), ATs perceive neither the label nor the control when tabbing through the content: <label style="display:block" tabindex="0"> radio button 1 <input type="radio" id="radio1" tabindex="-1"> </label> <label style="display:block" for="radio2" tabindex="0"> radio button 2 <input type="radio" id="radio2" tabindex="-1"> </label> <label style="display:block" for="checkbox1" tabindex="0"> checkbox 1 <input type="checkbox" id="checkbox1" tabindex="-1"> </label> <label style="display:block" for="checkbox2" tabindex="0"> checkbox 2 <input type="checkbox" id="checkbox2" tabindex="-1"> </label> This change fixes the above scenario by exposing labels (referenced by radio or checkbox) when they are focusable. For all other cases when labels are referenced by radio or checkbox, we keep the existing behavior of ignoring the label. Note: Neither Firefox nor Edge legacy hides a label from AT when the label is referenced by a control. On Firefox and Edge legacy, label content will be read twice (focus on label and focus on control respectively). WAI-ARIA spec does not specify label should be ignored when associated with a radio/checkbox control. Bug: 1040210 Change-Id: Ie7df5144dd2f0d285d97e6556adb46dcf2338f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992017 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#731820}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I74aeffaeb62dfaf0fc9d57f5349e3f4f7700492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001022Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731819}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/feb3b6cc6f2b..86f730971751 git log feb3b6cc6f2b..86f730971751 --date=short --first-parent --format='%ad %ae %s' 2020-01-14 kbr@chromium.org Upstream support for iOS Simulator. 2020-01-14 syoussefi@chromium.org Add a test to expose translator bug w.r.t short circuiting Created with: gclient setdep -r src/third_party/angle@86f730971751 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I840cb84a7f4c65db49c624e6f52c2d912d434208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001639Reviewed-by:
-
Xianzhu Wang authored
The tests were disabled because of crbug.com/696842 which has been fixed in crrev.com/c/1816578. TBR=wangxianzhu@chromium.org Bug: 696842 Change-Id: I483ed2e4312148f9a2bc918744f1f8e4214742a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001851Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df902743..fab248d2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia80ce01ed47db7189ff1f7e365e1610b7d2f6745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001160Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731816}
-
Roman Sorokin authored
Fixed: 1036851, 1036857, 1036858 Change-Id: I8db8db8915804f536ac78d72a430ea6347be3f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997104Reviewed-by:
-
Alexander Hendrich authored
Actively purging non-ephemeral user sessions will only start in 2020/2021 (still in discussion), since we only started recording last activities since 2019-01-29. Bug: 870616 Change-Id: I8ec9cd05a77ec7e4068fa380afeb64931535c31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985010 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This allows OverlayRequestMediator subclasses to dispatch multiple responses before dismissal for a single UI interaction event. Bug: none Change-Id: I6248d6d5a369dc9b25c3a5f88a1f8962241505b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996160 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#731813}
-
Adam Rice authored
This reverts commit 6c9388f9. Reason for revert: Broke compile on ios-device-xcode-clang bot: https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/120239 Original change's description: > Allow FROM_HERE to be backed by base::Location::Current(). > > This allows the functionality of base::Location::Current() to be > verified in releases while still allowing a simple revert. > > One minor difference from before is that the helper macro > FROM_HERE_WITH_EXPLICIT_FUNCTION is no longer supported. Since > cc::BeginFrameTracker is the only user of this macro and doesn't > appear to need it, just revert it to use FROM_HERE directly. > > Bug: 974061 > Change-Id: Iae09bc02caf9f095a3ace9ea3ac70ded3dd493e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990262 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Auto-Submit: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731804} TBR=danakj@chromium.org,dcheng@chromium.org,jbroman@chromium.org,altimin@chromium.org Change-Id: I4d545b08f3e784cb9302ad1fb1541741296af726 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 974061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000439Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#731812}
-
Brian Geffon authored
BUG=chromium:1014871 Change-Id: I25e48d51150e9d4291a98fb7e68fa7319e5de734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001722Reviewed-by:
-
