GitLab

BUG=397107

Review URL: https://codereview.chromium.org/722173002

git-svn-id: svn://svn.chromium.org/blink/trunk@185445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=397107

Review URL: https://codereview.chromium.org/722173003

git-svn-id: svn://svn.chromium.org/blink/trunk@185444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185431

BUG=427868
TBR=aandrey@chromium.org

Review URL: https://codereview.chromium.org/726313005

git-svn-id: svn://svn.chromium.org/blink/trunk@185443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431697

Review URL: https://codereview.chromium.org/727773002

git-svn-id: svn://svn.chromium.org/blink/trunk@185442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Animation timelines now expose a protocol method to change the playback
rate. This change adds controls on the animations pane to allow all
animations to be paused and for the playback rate to be changed. This
aids debugging of non-trivial web pages with many animations running
simultaneously.

BUG=432368

Review URL: https://codereview.chromium.org/724693003

git-svn-id: svn://svn.chromium.org/blink/trunk@185441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The progress is estimated as event count divided by total buffer size.

BUG=426117

Review URL: https://codereview.chromium.org/722693002

git-svn-id: svn://svn.chromium.org/blink/trunk@185440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/727823002

git-svn-id: svn://svn.chromium.org/blink/trunk@185438 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We can calculate the pointer to EventTarget from a pointer to
ScriptWrappableBase because EventTarget inherits from ScriptWrappableBase.
So we don't need V8T::toEventTarget function for each V8T.

This CL also reduces the binary size (static data size) of libblink_web.so
packing several flags into bitfields.  The reduced size is about 60kbytes,
which covers http://crbug.com/409852

BUG=409852,235436

Review URL: https://codereview.chromium.org/725163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185437 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185405

BUG=391288
TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/733783006

git-svn-id: svn://svn.chromium.org/blink/trunk@185436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185367

BUG=429536
TBR=philipj@opera.com

Review URL: https://codereview.chromium.org/731113002

git-svn-id: svn://svn.chromium.org/blink/trunk@185435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To fix crbug.com/126766, we stopped to create snapshot files for non-natvie
files at the beginning of drag operations. It causes files having empty paths
are reaches to input tag, and thus renderer process crashes.

BUG=407568
TEST=FileInputTypeTest.ignoreDroppedNonNativeFiles

Review URL: https://codereview.chromium.org/720403002

git-svn-id: svn://svn.chromium.org/blink/trunk@185434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185402

BUG=423071
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/726373002

git-svn-id: svn://svn.chromium.org/blink/trunk@185433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are the reviews in which the enum values became unused:

CSSStyleDeclarationGetPropertyCSSValue:
https://codereview.chromium.org/717933002

ContentSecurityPolicyReportOnlyInMeta:
https://codereview.chromium.org/554303002

HTMLAppletElementLegacyCall:
https://codereview.chromium.org/719013002

MixedContentImage/MixedContentMedia/MixedContentRaw:
https://codereview.chromium.org/561153002

SVGFontElement/SVGFontInCSS:
https://codereview.chromium.org/656913006

Review URL: https://codereview.chromium.org/732013003

git-svn-id: svn://svn.chromium.org/blink/trunk@185432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=427868
TBR=vsevik

Review URL: https://codereview.chromium.org/732043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=431335
R=mkwst@chromium.org
TEST=content_shell doesn't do tabs, so no tests

Review URL: https://codereview.chromium.org/730013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=eustas

Review URL: https://codereview.chromium.org/732013002

git-svn-id: svn://svn.chromium.org/blink/trunk@185429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Contributed by Denis Pravdin <denis.pravdin@intel.com>

Review URL: https://codereview.chromium.org/719853003

git-svn-id: svn://svn.chromium.org/blink/trunk@185428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Animations: Disable compositor when timeline playback rate is set (patchset #2 id:20001 of https://codereview.chromium.org/722203004/)

Reason for revert:
Compilation failed on Mac and Linux:

FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/core/animation/webcore_remaining.AnimationTimeline.o.d -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=218707 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DWebCoreTextFieldCell=ChromiumWebCoreObjCWebCoreTextFieldCell -DWebCoreRenderThemeNotificationObserver=ChromiumWebCoreObjCWebCoreRenderThemeNotificationObserver -DENABLE_OPENTYPE_VERTICAL=1 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_WEB_AUDIO=1 -DENABLE_OILPAN=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING -DSK_USE_POSIX_THREADS -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../../third_party/WebKit/Source -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/blink -I../../third_party/angle/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/libwebp -I../../third_party/libxml/mac/include -I../../third_party/libxml/src/include -I../../third_party/libxslt -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/sqlite -I../../third_party/zlib -I../../v8/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wglobal-constructors -Wexit-time-destructors -std=c++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/WebKit_Mac_Oilpan/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /Volumes/data/b/build/slave/WebKit_Mac_Oilpan/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin_12.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -include ../../third_party/WebKit/Source/build/mac/Prefix.h -c ../../third_party/WebKit/Source/core/animation/AnimationTimeline.cpp -o obj/third_party/WebKit/Source/core/animation/webcore_remaining.AnimationTimeline.o
../../third_party/WebKit/Source/core/animation/AnimationTimeline.cpp:242:16: error: non-const lvalue reference to type 'blink::AnimationPlayer *' cannot bind to a temporary of type 'blink::AnimationPlayer *'
    for (auto& player : m_players) {
               ^      ~
../../third_party/WebKit/Source/wtf/HashSet.h:73:18: note: selected 'begin' function with iterator type 'iterator' (aka 'HashTableConstIteratorAdapter<HashTableType, ValueTraits>')
        iterator begin() const;
                 ^
1 error generated.


Original issue's description:
> Animations: Disable compositor when timeline playback rate is set
> 
> This change invalidates all compositor animations when the animation
> timeline playback rate is modified. If the timeline playback rate is not
> 1, then animations are no longer composited.
> 
> BUG=432368
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185424

TBR=dstockwell@chromium.org,samli@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432368

Review URL: https://codereview.chromium.org/734003002

git-svn-id: svn://svn.chromium.org/blink/trunk@185427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=433324
R=yurys, dslomov

Review URL: https://codereview.chromium.org/729513002

git-svn-id: svn://svn.chromium.org/blink/trunk@185426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For unconditionally garbage collected types, use of RawPtr<> is
unnecessary.

Review URL: https://codereview.chromium.org/727523002

git-svn-id: svn://svn.chromium.org/blink/trunk@185425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change invalidates all compositor animations when the animation
timeline playback rate is modified. If the timeline playback rate is not
1, then animations are no longer composited.

BUG=432368

Review URL: https://codereview.chromium.org/722203004

git-svn-id: svn://svn.chromium.org/blink/trunk@185424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Multiple RecalcStyle events can occur in a single frame and we didn't
have a good test for associating invalidation events in this case. This
patch also does some minor cleanup of the style recalc test.

BUG=410701

Review URL: https://codereview.chromium.org/727253002

git-svn-id: svn://svn.chromium.org/blink/trunk@185423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=405921

Review URL: https://codereview.chromium.org/721133003

git-svn-id: svn://svn.chromium.org/blink/trunk@185422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an element's renderer is being reattached, previously we reattach
whitespace siblings, causing full paint invalidation of the parent.

If the whitespace sibling needed renderer and still needs renderer,
don't reattach.

- Renamed Node::reattachWhitespaceSiblings() to
  Node::reattachWhitespaceSlibingsIfNeeded();
- In the function, test if rendererIsNeeded changed before reattaching;
- Modified Text::textRendererIsNeeded() so that it can return correct
  value when the Text has already renderer.

BUG=428997
TEST=fast/repaint/absolute-display-block-to-none.html
TEST=fast/forms/select-listbox-focus-displaynone.html (Existing test
covering the change in Text.cpp).

Review URL: https://codereview.chromium.org/684633006

git-svn-id: svn://svn.chromium.org/blink/trunk@185421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a SuppressLog argument to MixedContentChecker::shouldBlockFetch to suppress logging for preload requests.
This makes it consistent with content security policy checks which also do not warn on preload requests.

BUG=432771

Review URL: https://codereview.chromium.org/726563004

git-svn-id: svn://svn.chromium.org/blink/trunk@185420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

StyleResolver::m_keyFrameRulesMap is never used and can be deleted.

BUG=none
TEST=compile

Review URL: https://codereview.chromium.org/716403002

git-svn-id: svn://svn.chromium.org/blink/trunk@185419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=429060
TEST=http/tests/serviceworker/

Review URL: https://codereview.chromium.org/728713003

git-svn-id: svn://svn.chromium.org/blink/trunk@185418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The problem is that the mouse events aren't fired when there is the element culled inline
like label element that doesn't has any background color or border or self-layer.
We already handle area-based hit-tests for culled inline.
This patch makes hit-test include not only area-based hit-tests but also point-based ones at the place handling culled inline.

BUG=312199
R=rbyers@chromium.org, pdr@chromium.org, leviw@chromium.org
TEST=LayoutTests/fast/events/hit-test-culled_inline.html

Review URL: https://codereview.chromium.org/685963002

git-svn-id: svn://svn.chromium.org/blink/trunk@185417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec of ServiceWorker was changed.
https://github.com/slightlyoff/ServiceWorker/issues/559
https://github.com/slightlyoff/ServiceWorker/commit/fe2cd64e9d84c316fc02b7c29648b0c712402746

BUG=N/A
TEST=http/tests/serviceworker/

Review URL: https://codereview.chromium.org/723963003

git-svn-id: svn://svn.chromium.org/blink/trunk@185416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It timeouts on not only Mac and Win, but also on Linux.
Flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-composite-image.html

NOTRY=true
BUG=433711
TBR=yosin@chromium.org

Review URL: https://codereview.chromium.org/733043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a refactoring and does not change behavior.

BUG=None

Review URL: https://codereview.chromium.org/728453002

git-svn-id: svn://svn.chromium.org/blink/trunk@185413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=back-send-referrer.html%2C%20canvas-composite-image.html%C2%A0

BUG=433710, 433711
TBR=dongseong.hwang@intel.com
NOTRY=true

Review URL: https://codereview.chromium.org/729313002

git-svn-id: svn://svn.chromium.org/blink/trunk@185412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Disable AcceptEx on Win32 Apache (patchset #1 id:1 of https://codereview.chromium.org/695193006/)

Reason for revert:
It was not the culprit of the serviceworker test flakiness.

Original issue's description:
> Disable AcceptEx on Win32 Apache
> 
> Some layout tests time out since the switch to apache server, with
> AcceptEx failures logged on error log. This may fix the issue.
> 
> BUG=30536, 431172
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185174

TBR=dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=30536, 431172

Review URL: https://codereview.chromium.org/734553002

git-svn-id: svn://svn.chromium.org/blink/trunk@185411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The problem is that Selection is not getting cleared 
after tapping of gesture. This was affected by 
https://codereview.chromium.org/507533002, 
because initialization for m_selectionInitiationState was 
skipped in case of gesture. 
This patch makes m_selectionInitiationState be initialized
after dispatching mousedown event for gesture tapping.

BUG=429967
R=rbyers@chromium.org
TEST=LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html

Review URL: https://codereview.chromium.org/705733002

git-svn-id: svn://svn.chromium.org/blink/trunk@185410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=420515

Review URL: https://codereview.chromium.org/725293002

git-svn-id: svn://svn.chromium.org/blink/trunk@185409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously RenderTreeBuilder::createRendererForTextIfNeeded()
and RenderTreeBuilder::createRendererForElementIfNeeded() are called
from Element and Text, respectively.

This refactoring separates logics needed for creating renderer
for Element and for Text, reducing isElement and isText checks.

More importantly, this refactoring exposes 
RenderTreeBuilderForText::createRenderer()
so that we can test Text::textRendererIsNeeded() only once when
we reattach whitespace siblings
(for https://codereview.chromium.org/684633006/).

BUG=482997

Review URL: https://codereview.chromium.org/699213003

git-svn-id: svn://svn.chromium.org/blink/trunk@185407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/727093002

git-svn-id: svn://svn.chromium.org/blink/trunk@185406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a reland of first letter as a psuedo element after the revert
in r184113.

Currently, first letter renderers are created and destroyed through the
updateFirstLetters() call in RenderBlock. This has, historically, been
problematic as we may miss places where the call was required, leading to
accessing invalid memory.

This CL converts the first letter code to use a PseudoElement for the
first-letter instead of creating classes during layout.

With the PseudoElement implementation the two tests which are currently in
LayoutTests/fast/css/first-letter-removed-added.html work as expected.

BUG=391288

Review URL: https://codereview.chromium.org/672953002

git-svn-id: svn://svn.chromium.org/blink/trunk@185405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore. After
this patch, Source/core has no unneeded forward references
any more.

Review URL: https://codereview.chromium.org/732803003

git-svn-id: svn://svn.chromium.org/blink/trunk@185404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This has been moved into the infra repo at:
https://chromium.googlesource.com/infra/infra/+/master/appengine/sheriff_o_matic/

NOTRY=true
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/728023004

git-svn-id: svn://svn.chromium.org/blink/trunk@185403 bbb929c8-8fbe-4397-9dbb-9b2b20218538