GitLab

The ibus-gtk layer was using XPutBackEvent which pushes an event to the
top of the X event queue. The problem with this is that if the gtk event
loop processes more than one event before the X event loop executes the
message pump will see the events in reverse order.

Fix this by processing the mapped X11 event immediately. Since the gtk
event loop and the X11 event loop are on the same thread this makes
sense as the events stay in the proper order.

BUG=524084

Review-Url: https://codereview.chromium.org/1324913002
Cr-Commit-Position: refs/heads/master@{#412607}

setTabSwitcherMode will set the state of the tab switcher for the
toolbar before the animations have started causing the progress
bar to be momentarily visible. This change tracks when the tab
switcher mode is set and when the animations finish to show the
progress bar correctly.

BUG=633972

Review-Url: https://codereview.chromium.org/2220063002
Cr-Commit-Position: refs/heads/master@{#412606}

Goal is: A site details subpage that's accessible both from /siteSettings/all, /siteSettings/bluetooth, /siteSettings/plugins, etc. (all the categories).

Previous way it was done was: Separate route for each category, so there was /siteSettings/all/details, /siteSettings/bluetooth/details, /siteSettings/plugins/details.

And it relied on a quirk of how settings-animated-pages used to work to coalesce all those routes to a single card.

New way I'm proposing: One single /siteSettings/siteDetails route.

But here are some extra needed changes:
 - settings-animated-pages must slide right / left based on route depth instead of based on .contains()
 - subpage-back button needs to call window.history.back() whenever there is a previous route, even if the previous route doesn't strictly contain the current route.

I think the above two changes are harmless and the new version is overall an improvement.

BUG=637865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2249873003
Cr-Commit-Position: refs/heads/master@{#412605}

Some extra bluettoth polish:
* Fixed height for the bluetooth dialog
* Correctly center dialog contents
* Blue spinners for all chrome WebUI
* Focus dialog inputs

BUG=602538
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2218713002
Cr-Commit-Position: refs/heads/master@{#412604}

Added integration test to Chrome Proxy to verify fallback to HTTP after bad HTTPS response from proxy.

This checks that when the proxy responds with an error, in this case using the chromeproxy-test server which will give a 404 error on the request, the client will fallback to using a HTTP proxy instead.

BUG=430206

Review-Url: https://codereview.chromium.org/2227163002
Cr-Commit-Position: refs/heads/master@{#412603}

Revert of Reset the focus after windows are restored, and grids are shutdown. (patchset #4 id:60001 of https://codereview.chromium.org/2244173006/ )

Reason for revert:
Reverting because this can cause crash with arc++ windows.

Original issue's description:
> ResetFocusRestoreWindow may change activation, which can resize the window, which then results in reposition. This prevents it by updating the focus after grids are shutdown.
>
> BUG=634572
>
> Committed: https://crrev.com/e26c7e4886eec4d2c58a5810b6440f7faa4293ea
> Cr-Commit-Position: refs/heads/master@{#412384}

TBR=varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634572

Review-Url: https://codereview.chromium.org/2251053003
Cr-Commit-Position: refs/heads/master@{#412602}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a33f1674..1b38caa9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2250853003
Cr-Commit-Position: refs/heads/master@{#412601}

- Show "Scan card" prompt in card holder name field as well as in the
  card number field.

- When scanning the card, use the new card holder name data to populate
  the credit card form.

BUG=637896

Review-Url: https://codereview.chromium.org/2249773002
Cr-Commit-Position: refs/heads/master@{#412600}

https://chromium.googlesource.com/angle/angle.git/+log/3416ff3..d2f59bb

BUG=637037,635433
TBR=kbr@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2245373005
Cr-Commit-Position: refs/heads/master@{#412599}

Fix libfuzz builds on Mac.

There's only one change in this roll.
https://chromium.googlesource.com/chromium/deps/icu/+/2341038b

BUG=636127
TEST=Libfuzzer Upload Mac ASan builds
TBR=mmoroz@chromium.org

Review-Url: https://codereview.chromium.org/2254543005
Cr-Commit-Position: refs/heads/master@{#412598}

The bezier icon should use an image asset like our other icons.

Review-Url: https://codereview.chromium.org/2237663002
Cr-Commit-Position: refs/heads/master@{#412597}

This prevents exposing the server outside of the local machine (given a sane firewall).

BUG=none

Review-Url: https://codereview.chromium.org/2257523002
Cr-Commit-Position: refs/heads/master@{#412596}

This helps when printing FormDigest objects to logs during debugging.

autofill::PasswordForm has a similar operator but implemented through JSON
stringification for better flexibility. FormDigest does not need this, because
it only has 3 members and is unlikely to grow.

R=dvadym@chromium.org
BUG=621355

Review-Url: https://codereview.chromium.org/2252053002
Cr-Commit-Position: refs/heads/master@{#412595}

This adds functionality to insert filtering predicates in-between calls to add trace events, and the actual trace buffer. These predicates can be used to implement custom logic for whether or not events should actually be added or not, in addition to the normal category checks. Events can also be modified, if need be.

The initial added usecase for this is to be able to add an additional level of filtering to reduce sizes of traces to the bare minimum, for use with perf waterfall TBMv2 metrics, and Slow Reports.

Review-Url: https://codereview.chromium.org/1923533004
Cr-Commit-Position: refs/heads/master@{#412594}

NSObject.description is not nullable and may return nil. In which case
gesture recognizer should not be matched.

BUG=None

Review-Url: https://codereview.chromium.org/2252833003
Cr-Commit-Position: refs/heads/master@{#412593}

https://chromium.googlesource.com/skia.git/+log/8d3f92a92be7..e4f246111380

$ git log 8d3f92a92..e4f246111 --date=short --no-merges --format='%ad %ae %s'
2016-08-17 bsalomon Detemplatize GrGLSLGeometryProcessor::setTransformDataHelper()
2016-08-17 mtklein SkLiteDL: inline empty()
2016-08-17 jvanverth Add alternative spot shadow to Android shadow sample
2016-08-17 csmartdalton Implement difference clip rects with window rectangles

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2254903002
Cr-Commit-Position: refs/heads/master@{#412592}

Add a histogram for measuring the impact of a new StrictMode violation. This histogram is for a pending downstream change.

BUG=638252

Review-Url: https://codereview.chromium.org/2256553002
Cr-Commit-Position: refs/heads/master@{#412591}

BUG=635861
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2249933002
Cr-Commit-Position: refs/heads/master@{#412590}

Currently, w3c-test-autoroller:
 1. Uploads a CL.
 2. Triggers try jobs on Blink try bots.
 3. Waits for try job results (which are failing).
 4. Modifies TestExpectations and commits.
 5. Uploads another patch.
 6. Calls `git cl land -f --auth-refresh-token-json ...`.

I think that when landing CLs, w3c-test-autoroller commits
should go through the CQ, and if the CQ fails even after
updating TestExpectations etc., then the CL should be closed.

BUG=629275

Review-Url: https://codereview.chromium.org/2248913003
Cr-Commit-Position: refs/heads/master@{#412589}

The main advantage of this is that it makes the main method shorter and more abstract, and provides a convenient place to put a comment about why we're copying over files from outside the imported repo into the new imported directory before committing.

Review-Url: https://codereview.chromium.org/2247923002
Cr-Commit-Position: refs/heads/master@{#412588}

TBR=foolip@chromium.org
BUG=638621

Review-Url: https://codereview.chromium.org/2253953002
Cr-Commit-Position: refs/heads/master@{#412587}

This CL makes WebApkInstaller take the Murmur2 hash of the bitmap at the icon
URL prior to any transformations being applied to the bitmap (such as
encoding/decoding the bitmap). The icon hash is used to determine whether the
icon that the user sees matches the icon of a WebAPK that the server generated
for another user.

The icon could be dynamically generated and:
- use the same icon URL for all users
- be visually different for each user

If the hashes match the server can vend the WebAPK that it
previously generated to other users. Vending previously generated WebAPKs is
faster than creating a new WebAPK for each "create WebAPK" request.

BUG=624059
TEST=WebApkIconHasherTest

Review-Url: https://codereview.chromium.org/2231843003
Cr-Commit-Position: refs/heads/master@{#412586}

Indexed DB was passing net::URLRequestContext as it was needed for Blob
writing in WriteBlobToFileOnIOThread. This switches to passing the
*Getter which facilitates the move to Mojo where initialization is done
on the Indexed DB thread.

BUG=627484

Review-Url: https://codereview.chromium.org/2172863002
Cr-Commit-Position: refs/heads/master@{#412585}

Removes an assert that was triggered when scanner_ was nil,
which is expected whenever the scanner is in the "stopped"
state. Instead, we explicitly check if scanner_ is nil and
return an empty metadata list.

BUG=630769

Review-Url: https://codereview.chromium.org/2248983003
Cr-Commit-Position: refs/heads/master@{#412584}

The test result looks worse than it used to, but not bad
enough to fix. It's a super marginally situation, so not
too important.

There may still be failures on Mac Debug after this. The
test previously showed Release/Debug differences. The
expectation may need to be re-added with narrowed conditions.

R=fmalita@chromium.org
BUG=390488,636475

Review-Url: https://codereview.chromium.org/2254833002
Cr-Commit-Position: refs/heads/master@{#412583}

This wrapping was added in r355704 because at the time mojo::Callbacks
did not like being freed on arbitrary threads, which would happen if
they were passed to //device/usb APIs. This is no longer an issue so the
wrapping can be removed.

BUG=None

Review-Url: https://codereview.chromium.org/2236683002
Cr-Commit-Position: refs/heads/master@{#412582}

BUG=637923
TBR=sky@ for trivial services/ui/gpu update.

Review-Url: https://codereview.chromium.org/2248973005
Cr-Commit-Position: refs/heads/master@{#412581}

Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2249923003/ )

Reason for revert:
Has correctness issues on 10.10:

https://bugs.chromium.org/p/chromium/issues/detail?id=638526

Original issue's description:
> Reland of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2238113002/ )
>
> Reason for revert:
> Landing again, since main performance regressions have been dealt with.
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=636884
>
> Original issue's description:
> > Revert of Enable promotion of RenderPassDrawQuads to CALayers. (patchset #1 id:1 of https://codereview.chromium.org/2234513002/ )
> >
> > Reason for revert:
> > Causes performance regressions when there are a lot of filters. Probably needs better IOSurface caching.
> >
> > https://bugs.chromium.org/p/chromium/issues/detail?id=636884
> >
> > Original issue's description:
> > > Enable promotion of RenderPassDrawQuads to CALayers.
> > >
> > > BUG=581526
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
> > >
> > > Committed: https://crrev.com/c48bb2ddd6f847130de7956e9bf7e350d875b10c
> > > Cr-Commit-Position: refs/heads/master@{#411055}
> >
> > TBR=ccameron@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=581526
> >
> > Committed: https://crrev.com/314269eae868551bb560428fce916863e4d60cb4
> > Cr-Commit-Position: refs/heads/master@{#411505}
>
> TBR=ccameron@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=581526
>
> Committed: https://crrev.com/777aa9fb4a33a0ae71ed5363225d52ed807a5ff0
> Cr-Commit-Position: refs/heads/master@{#412144}

TBR=ccameron@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=581526

Review-Url: https://codereview.chromium.org/2255833002
Cr-Commit-Position: refs/heads/master@{#412580}

|content::| to "ui/events/blink"

This CL moves |ScopedWebInputEvent| and |WebInputEventTraits|
from |content::| to "ui/events/blink", so they can be accessed by
|InputHandlerProxy|.

Adds dependency:
  1. content/common : ui/events/blink
  2. content/renderer/mus : ui/events/blink

Concerns:
  1. Moving |WebInputEventTraits| seems redundant since we only
need |WebInputEventTraits::Delete/Clone|.
  2. "ui/events/blink" seems to be static linked, so it will cause each
file to grow.

After discussion with dtapuska@ and tdresser@ it doesn't really
matter whether we move it entirely or only part of it.
So the easier solution is to move it entirely for now, and handle it
later if it's actually causing problems.

BUG=637393

Review-Url: https://codereview.chromium.org/2240983003
Cr-Commit-Position: refs/heads/master@{#412579}

Hides ToS when Arc is managed, disable checkbox for Location Service
and B&R in case they are managed. Apply managed settings on each Arc
start.

TEST=Manually on device.
BUG=b/30469058
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2235293002
Cr-Commit-Position: refs/heads/master@{#412578}

Background tracing: Add config option to control whether or not to stop reactive tracing when a repeated trigger occurs

R=simonhatch@chromium.org
BUG=637129

Review-Url: https://codereview.chromium.org/2247033005
Cr-Commit-Position: refs/heads/master@{#412577}

https://boringssl.googlesource.com/boringssl/+log/96e1a25943ba98e644d71d23dd30815704da77a7..405da489002ca1fe5ee3f1c390b207d468f4a8e7

BUG=none

Review-Url: https://codereview.chromium.org/2253103002
Cr-Commit-Position: refs/heads/master@{#412576}

https://chromium.googlesource.com/skia.git/+log/d24ee1419f17..8d3f92a92be7

$ git log d24ee1419..8d3f92a92 --date=short --no-merges --format='%ad %ae %s'
2016-08-17 csmartdalton Make GrReducedClip's gen ID only apply to the element list
2016-08-17 robertphillips Kick the can down the road a bit w.r.t. fuzzer complaint
2016-08-17 bsalomon Fix tile bitmap code in SkGpuDevice to compute correct local coords.
2016-08-17 bsalomon Minor cleanup of GP classes in GrOvalRenderer
2016-08-17 msarett Modify SkPngCodec to recognize 565 images from the sBIT chunk

BUG=635787

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=robertphillips@google.com

Review-Url: https://codereview.chromium.org/2251113002
Cr-Commit-Position: refs/heads/master@{#412575}

There's a crash in
AutoplayUmaHelper::onVisibilityChangedForVideoMutedPlayMethod().
It might be possible that the callback is called after the observer
is released. This CL adds additional nullcheck to avoid the crash.

This CL also fixes a possible memory leak by changing
wrapPersistent to wrapWeakPersistent.

BUG=638595

Review-Url: https://codereview.chromium.org/2249223003
Cr-Commit-Position: refs/heads/master@{#412574}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6c31b348..a33f1674

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2255803002
Cr-Commit-Position: refs/heads/master@{#412573}

//components/test_runner signals that a test is finished if it receives a
notificationDone signal from Javascript at a time when (a) it is waiting for
such a signal, (b) it does not think it is in the midst of a load, and (c) it
has no work in its queue. However, the definition of (b) is flawed for
browser-side navigation. The current definition for being in the midst of a
load is the time between WebFrameClient::didStartProvisionalLoad() being called
and WebFrameClient::didStopLoading() being called. However, for browser-side
navigations there is a period of time when navigation is ongoing but the
renderer has not yet received the didStartProvisionalLoad() callback. If
//components/test_runner gets a notificationDone signal during this period, it
can erroneously think that the test is finished.

This CL fixes the problem by having WebFrameTestProxy implement
WebFrameClient::didStartLoading(), teaching //components/test_runner to be
aware of the time period where a navigation is occurring, and using that as
input to decide whether a test is finished when it receives a notificationDone
signal.

Review-Url: https://codereview.chromium.org/2147633003
Cr-Commit-Position: refs/heads/master@{#412572}

Currently this layout test canvas/philip/tests/2d.text.draw.text.metrics.html
gets different results on linux platform comparing to all the other
platforms. But when I open the test file directly on chrome, the result
is exactly the same as the results on the other platform. The reason is
that the content shell test runner has some flags enabled.

This CL rewrite the test in a more reasonable way.

BUG=277215

Review-Url: https://codereview.chromium.org/2232243002
Cr-Commit-Position: refs/heads/master@{#412571}

An ANGLE revert requires this test to be expected to fail.

BUG=638313
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2249823004
Cr-Commit-Position: refs/heads/master@{#412570}

Revert of cc: Move data to LayerTree from LayerTreeHost. (patchset #9 id:160001 of https://codereview.chromium.org/2183403002/ )

Reason for revert:
Invalid cast breaks CFI build, which is shipping on Linux soon

Original issue's description:
> cc: Move data to LayerTree from LayerTreeHost.
>
> Move bulk of the tree state from LayerTreeHost to LayerTree. The
> LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
> to push the corresponding properties to LayerTreeImpl during commit.
>
> BUG=628683
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b
> Cr-Commit-Position: refs/heads/master@{#412413}

TBR=enne@chromium.org,loyso@chromium.org,vollick@chromium.org,piman@chromium.org,khushalsagar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=628683

Review-Url: https://codereview.chromium.org/2253143002
Cr-Commit-Position: refs/heads/master@{#412569}

This was there so that crash client id could be cleared.
However, this was being called out of MetricsService::Stop(),
so it needed a special provision to not clear it when shutting
down, for example.

This change instead removes all of that plumbing and makes the
id clearing happen in the same place we clear the UMA client id,
when the user actually opts-out (as opposed to just metrics service
stopping). Unifies the prefs manipulation that happens when the
user changes the setting into a helper function.

As a follow up change after this lands, we should also make that
function be called on iOS.

BUG=635669
TBR=sgurun@chromium.org,nyquist@chromium.org,noyau@chromium.org

Review-Url: https://codereview.chromium.org/2248793002
Cr-Commit-Position: refs/heads/master@{#412568}