GitLab

After https://crrev.com/c/2566090, the per-NetworkContext
OriginAccessList and the per-factory OriginAccessList cover the same
permissions.  This means that there is no need to maintain both - to
prepare for the removal of `factory_bound_access_patterns`, this CL
switches `SetSecFetchSiteHeader` checks to be based on the
per-NetworkContext OriginAccessList.

Bug: 936310
Change-Id: I33a8631f2ec2dea110ed6ad12bec672e6b564a76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587394
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846452}

After https://crrev.com/c/2566090, the per-NetworkContext
OriginAccessList and the per-factory OriginAccessList cover the same
permissions.  This means that there is no need to maintain both and
therefore this CL removes the factory-bound access list.

Change-Id: Ib87f80c20a62b7ef9bcf002756ccbb5b1a88f72f
Fixed: 936310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573677
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846451}

Bug: 1127732
Change-Id: I9f0d75ea44896c09d281bea95d8a1f3bbfb7fd78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645270Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846450}

This change converts callbacks from base::Bind and base::Callback to
Once/Repeating in //chrome/browser/chromeos/drive.

Bug: 1148570
Change-Id: I3c3e2730a1f9b8ba655c818ee7991cbbba62d7f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645030
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846449}

Increasing logging for better debugging of printer status request
failures.

Bug: 1027400
Change-Id: I262c7b4502a6527c187997239b16588591066bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643303Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846448}

The cursors package was moved to accessibility/common, but did not
trigger presubmit upload Closure errors because no files were
technically touched in chromevox/ (deletion/move appears not to count).

@private means "private to that file" (aka, all classes can access
private members of other classes if they're in the same file).

cursor.js and range.js were split out from cursors.js leading to the
Closure errors.

R=akihiroota@chromium.org

AX-Relnotes: n/a
Change-Id: I140dfd153e307e0c3c8a244b57be7f3ac542231d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643572
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846447}

https://skia.googlesource.com/skia.git/+log/eeeaae9a029b..95c2994048cd

2021-01-23 egdaniel@google.com Revert "Run unit tests to verify SkSL folding behavior."
2021-01-23 mtklein@google.com Revert "Consolidate SkSL CPU and GPU test code."
2021-01-22 mtklein@google.com use ld2.4s/ld4.4s in load64/load128
2021-01-22 johnstiles@google.com Allow Metal shaders to return half4 colors.
2021-01-22 egdaniel@google.com Make sure we are using cached cpu memory for vulkan readback buffers.
2021-01-22 reed@google.com Migrate to drawImage w/ sampling
2021-01-22 ethannicholas@google.com Added basic SkSL DSL statements
2021-01-22 brianosman@google.com Improve memory layout handling in SPIRV generator
2021-01-22 adlai@google.com Merge adjacent GrOpsTasks with same target together

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: scroggo@google.com
Change-Id: If457b511dc89ce8eb677a83ddc52884a2d25501a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645459Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846446}

This removes process_name and thread_name from trace log, these fields
are now recorded in perfetto, so it's not necessary to record them
client side.

Change-Id: I6591c25d572cd97b54d024ffcb3dcc00597d63fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640819Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: Salvador Guerrero <salg@google.com>
Cr-Commit-Position: refs/heads/master@{#846445}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I1cf032404c4395e8c6c570e1a75397e776cc1877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645457Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846444}

This test is flaking too frequently to keep as RetryOnFailure.

TBR=kbr@chromium.org
BUG=1157136

Change-Id: I7bf819129c7136a7057eaeafaa60a9812c90fc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643763
Auto-Submit: Victor Miura <vmiura@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846443}

To make sure that the new ActiveTabPermissions_ExtensionServiceWorker
test stops failing, the CL makes the following changes:

1. Changing UpdateTabSpecificCorsOriginAccessLists in
   active_tab_permission_granter.cc to update the per-NetworkContext
   OriginAccessLists (rather than refreshing URLLoaderFactory objects
   and therefore their factory_bound_access_patterns).

   Updating the per-NetworkContext state is needed, because the factory
   of service workers cannot be refreshed (i.e. service workers do not
   have an equivalent of RFHI::UpdateSubresourceLoaderFactories).

   Avoiding relying on RFHI::UpdateSubresourceLoaderFactories means
   that it no longer needs to be exposed via //content/public API.

2. Changing PermissionsData::GetEffectiveHostPermissions to always
   include tab-specific permissions.

   This change is needed to ensure that the per-NetworkContext state
   (relied upon by the service worker - see item1 above) always
   includes all permissions relevant to an extension.

   This change is okay from the security perspective, because there is
   no real security boundary between different extension frames and/or
   workers.

Fixed: 1153952, 1159207
Change-Id: Ibbbd19cc0be0ed5f0771218cc9494b55e5ed24ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566090
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846442}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/53d05d72..83f44c53

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2cf195c8107883ab5c276ef6a5041c1103a685f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645452Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846441}

Roll ChromeOS Atom AFDO profile from 90-4384.0-1610968059-benchmark-90.0.4393.0-r1 to 90-4384.0-1610968059-benchmark-90.0.4395.3-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ie7379f16a468f171d6b497d7d259f045cbad9823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645632Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846440}

This is mainly for CompositeAfterPaint to fix the issue of always
repainting on scroll. By updating cull rect before paint, we know which
layer will change cull rect and needs repaint.

This will also simplify interest rect and cull rect calculation and
repaint on their change in pre-CompositeAfterPaint. It will unify
composited layer interest rect calculation and LayoutObject cull rect
calculation, and avoid whole subtree repaint on clip change.

For now the cull rects are used to set PaintLayer's NeedsRepaint flag
only. The next steps are to use the cull rects during painting and to
remove old cull rect calculation code.

Bug: 1046544
Change-Id: I433c7941ebd0a96bc1d75b79a3036511d857629a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629653
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846439}

TBR=aleventhal@chromium.org

Change-Id: I5d188d9751d9436992053981e99c0054bd44f89f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644892Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846438}

We've been relying on approvers from the PST timezone, but their work
hours hardly overlap with ours in JST and CET timezones. On occasion,
this led to once-per-day exchanges resulting in simple discussions
lasting a few days.

Bug: 1073933
Change-Id: I39572efc7ddff992a10fc9f43f918fffc0fd79b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642844
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846437}

CompatibleAlertDialogBuilder workaround is no longer needed due to
androidx.appcompat roll.

BUG=966002

No-Presubmit: true
Change-Id: Ie4c83d2152fd2980207722ad42fd1732c08d893a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606275
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846436}

Defines flagspecific highdpi config and creates a list of tests to be skipped for now. If the resource story changes, we would like to run all tests.

Bug: 1068400

Change-Id: I269fad237bd5c1d7fa0954cb3b406ae1bfc673d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583213Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Preethi Mohan <preethim@google.com>
Cr-Commit-Position: refs/heads/master@{#846435}

Roll Chrome Win32 PGO profile from chrome-win32-master-1611327254-197533b8b85e35cc3db30df56ae54c1d061aca59.profdata to chrome-win32-master-1611349106-8fe96193d16382de68a48df0056ee83eec7364b6.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Id13ec05f97da8c1b81043d502dccc6c587094938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645380Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#846434}

Some targets only exercised by Chromecast internal builds were broken by
the following change:

https://chromium-review.googlesource.com/c/chromium/src/+/2515787

Bug: 1169966
Tets: Cast internal CQ

Change-Id: I39957eb7f2b7d813b1f00a03598155e9c729c3f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643698
Commit-Queue: Sean Topping <seantopping@chromium.org>
Auto-Submit: Sean Topping <seantopping@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846433}

This is a reland of 6674e06c

Changes from the original CL:
The test will not be compiled in case there are no AR devices available,
since it is not possible to distinguish failure due to an issue with
enterprise policy preventing creation of immersive-ar sessions, from a
failure due to not having a device that supports AR.

Original change's description:
> WebXR: add enterprise policy for immersive-ar sessions
>
> This CL adds new enterprise policy that is used to gate access to
> immersive-ar sessions in WebXR Device API. The enterprise policy is
> per-profile, and is implemented by propagating the pref value from
> browser process to blink via WebPreferences.
>
> Additionally, the CL also introduces new AndroidBrowserTest that
> exercises the added glue code, with the assumption that the enterprise
> policy code that controls the pref is correct.
>
> Other changes:
> - add manifest entry in test jinja template in order for them to work on
>   newer Android versions
> - add DVLOGs in WebXR code paths to assist with debugging
>
> Bug: 1159067
> Change-Id: I27eba5fc0e7bae3dca2d47ca3fb2e935facbd37c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627778
> Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Owen Min <zmin@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845521}

Bug: 1159067
Change-Id: I36f955dba6ad4e6f6bc3f88c53875052f6eb19a9
TBR: dcheng@chromium.org, zmin@chromium.org, alcooper@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642995
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846432}

If the supplied id doesn't identify a crash file, then an
NPE is triggered. This adds an early out.

BUG: 1169894
TEST: CrashReporterTest.testBogusCrashId
Change-Id: I78defd46f82c22f79ece02d5191b27342e1144c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644464
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846431}

This is a reland of 3fe154df

Original change's description:
> [X11] Split PutImage requests into multiple requests if necessary
>
> R=sky
>
> Change-Id: I1befaef494c74797333d6bf02e204bcdc721e752
> Bug: 1164669
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643711
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#846344}

Bug: 1164669
Change-Id: I932bbeb1dd8be92067ab69ebf22ac19d95daa3e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644750Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846430}

QuotaManager will move behind a mojo interface. This interface's methods
must all be async, in order to avoid deadlock (storage service ->
browser access may be synch, so browser -> storage service access must
be async). In preparation for this change, only the quota system may
access QuotaManager directly. All other features will use
QuotaManagerProxy, which will only expose async methods.

This CL applies the plan to PepperFileSystemBrowserHost.

Bug: 1168597
Change-Id: I227b0ee9aad87b59a569f469370be4d0903280cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645492Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846429}