- 29 Jan, 2020 40 commits
-
-
Chan Li authored
This reverts commit 4e30f923. Reason for revert: The change breaks ozone_unittests on linux-chromeos-dbg. Sample failed build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16729 Findit analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.chromiumos/linux-chromeos-dbg/16729 Original change's description: > Replace drmModeSetCrtc by Atomic APIs > > If the device supports atomic APIs, use drmModeAtomicCommit to modeset > and disable instead of drmModeSetCrtc. > Abstracted Modeset and Disabled code to HDPM to handle both atomic and > legacy call. > Updated tests to support Connector and CRTC props. > > This is a reland of crrev.com/c/1715751 > > BUG=987274 > TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps, > HardwareDisplayPlaneManagerLegacyTest.Modeset, > HardwareDisplayPlaneManagerLegacyTest.DisableModeset, > HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on > Nautilus(Intel), Grunt(AMD) and Cave(Legacy). > > Change-Id: I8ac3f81a0c117f3b3489cc0168e934799f387891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028168 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Auto-Submit: Mark Yacoub <markyacoub@google.com> > Cr-Commit-Position: refs/heads/master@{#736438} TBR=dnicoara@chromium.org,markyacoub@google.com Change-Id: I4f2fdc4abbe9e88e5f33abd0cd31df3326f3c84d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028930Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736549}
-
Xinghui Lu authored
Bug: 1041912 Change-Id: I968bbd977896ba06020e190bd45d7e68bc0113f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018709 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#736548}
-
Steph Lee authored
Change-Id: I020f5d635ec4ea3b12410652cb64a64449565c22 Bug: 1013584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020893 Commit-Queue: Steph Lee <stephlee@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#736547}
-
Yi Gu authored
testExitPersistentFullscreenAllowsManualFullscreen is flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVymwELEgVGbGFrZSKPAWNocm9taXVtQGNocm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmZ1bGxzY3JlZW4uRnVsbHNjcmVlbk1hbmFnZXJUZXN0I3Rlc3RFeGl0UGVyc2lzdGVudEZ1bGxzY3JlZW5BbGxvd3NNYW51YWxGdWxsc2NyZWVuDA TBR=tedchoc@chromium.org Bug: 1046749 Change-Id: If5d65f76fc9cd2351c24a47dab06843b4b9bd16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028656Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736546}
-
Vasilii Sukhanov authored
Additionally, modify the generation prompt to have correct colors as well. Bug: 1043765 Change-Id: I3e9701489f1c0030bd88fe940e55b6318523924d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025599 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#736545}
-
Darwin Huang authored
It's possible this should have been a struct when it was created, but that time is long gone. ClipboardFormatType is now fairly complex and can hold multiple private members. Therefore, as per the Style Guide[1], this should now be a class instead of a struct. [1]: https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes Change-Id: I3eab2fc75d9660fbc5aa05322df7d12034d113fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020477Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736544}
-
Carlos IL authored
Add note about policy being removed in Chrome 84. Bug: 1043968 Change-Id: I6e8411f8cf92874845df2219392399c430aa9743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026193 Commit-Queue: Carlos IL <carlosil@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#736543}
-
Karthikeyan Ramasubramanian authored
Shutdown confirmation dialog is used to display/highlight specific information to the user prior to shutdown/restart eg. like a slow reboot following an OS update or similar use-cases. The shutdown confirmation dialog allows customized dialog title and message depending on the use-case. Bug: b/129056373 Change-Id: Ibaa9473e979314acf4856f6ac646cda209d0e303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001723 Commit-Queue: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#736542}
-
zhaoyangli authored
Essential changes in test and BUILD.gn files. Bug: 987646 Change-Id: I0db4f63318ddc6b72eb6d26a410600ffc3985aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027128 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#736541}
-
Steven Bennetts authored
When we converted network_config.js to use == instead of ===, we broke some subtle logic when using <network-config-select> with enum values: The <option> children of the <select> element will always have a string value, even if the value is set to a number. Thus the data binding will quietly replace the enums with strings. Thus was fine when using == (since "2" == 2 in JS) but breaks with ===. Since securityType_ is the only place where we use network-config-select with an enum, the simplest fix is to force it to an enum in updateSecurity_(). If we use network-config-select for any more enums, we should fix it to do the conversion if the items are numbers and not strings. Bug: 1046149 Change-Id: Iacdf4f45296483311566ab1b0748d6947ca1429b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027067Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736540}
-
Steven Bennetts authored
Bug: 1001996 Change-Id: I3a9022d6cd76be8ede2e6a847937163ebc23359d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025488 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#736539}
-
Henrique Nakashima authored
Glue code should determine these features and pass them to FeatureUtilities. Bug: 1012975 Change-Id: I8cdc4d76995af4eed9404ee411d704e454699fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025878Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#736538}
-
John Chen authored
Rebaseline of failures inside virtual directory. TBR=wangxianzhu@chromium.org Bug: 1028242 Change-Id: I7c7ab53afba4d4e3b8c68d2de6fb77ae08d54301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026609Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736537}
-
Yi Gu authored
FeedNewTabPageTest#testSignInPromo_DismissBySwipe is flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyfQsSBUZsYWtlInJjaHJvbWl1bUBjaHJvbWVfcHVibGljX3Rlc3RfYXBrQG9yZy5jaHJvbWl1bS5jaHJvbWUuYnJvd3Nlci5mZWVkLkZlZWROZXdUYWJQYWdlVGVzdCN0ZXN0U2lnbkluUHJvbW9fRGlzbWlzc0J5U3dpcGUM TBR=hnakashima@chromium.org Bug: 1046822 Change-Id: Id38369eac91c3c850ab941733c6800347adc7996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028653Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736536}
-
Ben Pastene authored
This reverts commit dec0aa0b. Reason for revert: breaks ARC boot up https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/2471 https://bugs.chromium.org/p/chromium/issues/detail?id=1046881#c4 Original change's description: > [PM] Add support for dedicated workers > > The WorkerWatcher observes dedicated workers through the > DedicatedWorkerService interface. > > Change-Id: If62d911e500def7ebb905311485a8d89eeaca8df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992208 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736411} TBR=pmonette@chromium.org,siggi@chromium.org BUG=1046881 Change-Id: I65f72d78ed50300d38f46b4fea2367211dcefb97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028301Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#736535}
-
Michael Thiessen authored
This change makes it so we don't have to mock the LibraryLoader in all Native Java Unittests that use GURL (which talks to the LibraryLoader to see if the libraries have been loaded). Bug: 783819 Change-Id: I56c60a0043c9547a98674fdb74096517bca8f355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025974 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736534}
-
Garrett Beaty authored
Change-Id: I5636711dfa423d0fce3aaef044b08aec9e0be0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928570 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#736533}
-
Daniel Clark authored
This change implements live-update and double-escape behavior for date and week control popups. When arrow keys are used to change the selection, the changes are immediately reflected on the in-page control (and input events are fired). When the user hits escape, if they have made changes these are reverted without closing the popup. A second escape (or the first one, if no changes were made) closes the popup. Behavior when clicking on a date is not changed; the popup is still submitted immediately (as opposed to other types like datetime-local where the user may want to go on to select other values after clicking the date). Initialization of these controls is changed such that if there is any valid date, one will be selected. This will be the nearest possible date to the value attribute if there is one, otherwise it will be the nearest possible to today's date. This avoids scenarios where we don't paint a focus ring because there is no starting selected date. I've moved the popup submission and cancellation behavior to the top-level key event handler to better match the style of the other refreshed controls. One of my new tests uncovered a potential performance issue where selectNearestValidRangeLookingForward(Backward) could spin for a long time if the min/max attributes were very far from Today. These functions now immediately clamp to within the min/max range to avoid this. Lastly, I'm suppressing a CSS background color animation that the refreshed calendar pickers were erroneously inheriting from the old calendar implementation. A corresponding update will follow to bring live-update and double-escape to the month control. Bug: 1045195 Change-Id: I487bc2cbaefc3056d4ee50898bb6d96f0c9c6182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024158Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#736532}
-
Xida Chen authored
I tried to change the content of the existing test here: https://chromium-review.googlesource.com/c/chromium/src/+/2005813 And that CL was reverted. The lesson learned was: don't modify the content of existing GPU pixel test, because sometimes the bot will still reference to the old result. Bug: None Change-Id: I09fa77648c4f1dd84f3d574030282831ea670181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027175Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#736531}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/740ed473dcba..4356490b7b66 git log 740ed473dcba..4356490b7b66 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 mbonadei@webrtc.org Revert "Reland "Only include overhead if using send side bandwidth estimation."" Created with: gclient setdep -r src/third_party/webrtc@4356490b7b66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I88fe4721d8f7f2467991b0cc05cc5adf4c654028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028650Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736530}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4bf20c76..3796f09f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa20e55fd945cfd9db2c8793ad0084445c89fe44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028607Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736529}
-
Carlos IL authored
Safe browsing webview tests were flaky with committed interstitials enabled caused by a lack of a reliable way to wait for an interstitial to show. This CL exposes IsShowingInterstitial from security_ interstitial_tab_helper.h and changes the tests to poll it before waiting for the visual state callback. Bug: 1046832 Change-Id: If82f7fbbd9896e4cc3611e48fe945c8581cd847a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027902 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736528}
-
Hongbo Song authored
This CL is to record input delay UKM which is defined as the duration between the hardware timestamp and the start of event processing on the main thread for the meaningful input. UKM Privacy Review: https://docs.google.com/document/d/1VQvmb3x7uGMmt2JvKt3_4zk1SPWHPB3yJSiyec7hY20 Bug: 1042004 Change-Id: I69eb91955f116e1f90b9b72a7d3dd13b449fa4ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008436Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#736527}
-
Avery Musbach authored
Bug: None Change-Id: I465a71521e9c5483c1d8a05c3dee94dd933b54dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024982Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#736526}
-
Xinghui Lu authored
Identity manager will be used to obtain access token in url lookup service. In this CL, identity manager is passed to url lookup service. Its actual usage will be implemented in a follow up CL. Bug: 1041912 Change-Id: Ie8205f587df358906f081134ccbcf96cb2d5929f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018595 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#736525}
-
cfredric authored
All callers pass in an empty NetworkIsolationKey, so this should not change any behavior. Bug: 997047 Change-Id: I2cc555ab5773b1a6a60036cb2eabdadb01723cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013742 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736524}
-
Yi Gu authored
This test is flaky on CrOS, Linux ASAN and TSAN: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRQsSBUZsYWtlIjpjaHJvbWl1bUBuZXRfdW5pdHRlc3RzQEhUVFBTRWFybHlEYXRhVGVzdC5UTFNFYXJseURhdGFUZXN0DA&show_all_occurrences=1 TBR=davidben@chromium.org Bug: 1021021 Change-Id: I723564681c23c9f964b5d98064017f69e3abcf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028729Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736523}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a74b12c57c26..5e883773e98e Created with: gclient setdep -r src-internal@5e883773e98e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044244 Tbr: jbudorick@google.com Change-Id: If0711a6d131878ebd57df57c972a19b63e8f8be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028021Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736522}
-
Olivier Li authored
This fixes the compilation problems on ios and corrects a couple typos. Compare patch sets 1 and 4 to see the differences between the original commit and the relands. Original change's description: > Basic implementation and tests for HangWatcher. > > This class is a successor to ThreadWatcher which aims to be more > versatile and provide a larger coverage for hang watching. > > Bug: 1034046 > Change-Id: I365fe8824eb34c37c75e6ddf6874ff26ecd494c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008189 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736080} Change-Id: I4785c8c489678fd537a0105d65419673fe383aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026316 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736521}
-
Ovidio Henriquez authored
This change extends the expiration for Web Bluetooth histograms for another year to allow the team to analyze the data gathered from the histograms and determine if the histogram is still worth keeping. Bug: 1036972, 1036971, 1036970, 1036969, 1036968, 1036967, 1036966 Change-Id: Ia5ef38ea195fca1953d88fa11a03c4e667c69d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007938 Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#736520}
-
Lijin Shen authored
Renaming text styles. To avoid a large change list, this CL only renames text styles prefixed by "Black". Bug: 775198 Change-Id: I5e049e5689a0c310fbb93b1c251dbbe1ff98bec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022349Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#736519}
-
Jan Wilken Dörrie authored
After https://crrev.com/i/2475792 removed the last remaining usages of formatUrlForSecurityDisplayOmitScheme from the internal code base this change now removes this deprecated API completely. Bug: 596488 Change-Id: I5c2ba2552ab0dfae0b87527999b2b8fcb858c5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026572 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736518}
-
Orin Jaworski authored
This CL creates and registers metadata for a new flag called omnibox-suggestion-button-row. Bug: 1046523 Change-Id: I96068d55562147a11f1fcf1524d4bb373a204875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026712 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736517}
-
Alex Ilin authored
This CL adds a new method ShowReauthPrompt() to SigninViewController. The callers cannot rely on Reauth prompt being displayed in a modal dialog, since for some accounts Reauth is always shown in a popup window. Bug: 1045515 Change-Id: Ida343ffae2cff59b51f4b4c7f12b1e27db3b8297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020764 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#736516}
-
Matt Menke authored
It's flaky, for reasons unknown. Disable it until I can figure out the problem. Disabling instead of reverting to CL that disabled it because the way it's failing indicates it's a test issue, rather than an issue with the code landed with the test. TBR=ericorth@chromium.org Bug: 1042354 Change-Id: I10c2b7c496da9f22726a622be2db932bcb1bef85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028264Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736515}
-
Yi Gu authored
This test started to be flaky after Jan 23. See bug for details. TBR=sky@chromium.org Bug: 790963 Change-Id: Ib3db249f3e380ac1c27490281242ed9186a7f367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028687Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736514}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/873d0470b40d..b8c0752438c0 git log 873d0470b40d..b8c0752438c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 rharrison@google.com Add back in deprecated APIs (#977) Created with: gclient setdep -r src/third_party/shaderc/src@b8c0752438c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I416f8c585a352f3cd58c2340df34c0650b2e7a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028020Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736513}
-
Christopher Cameron authored
The embedded metallib uses MTLLanguageVersion2_1, available only macOS 10.14+. Bug: 1046671 Change-Id: Iac72569f4d9ad25ced7c0284dbbfd790ab3ecd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028266Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#736512}
-
Daniel Rubery authored
We will be adding more details to the Advanced Protection FAQ page ( https://support.google.com/accounts/?p=ap_faq) about deep scanning. This CL adds a link with "Learn more" on the modal dialog, which links to this FAQ page. Screenshot: https://screenshot.googleplex.com/i5JHn4QZ42z.png Bug: 1020418 Change-Id: I5bccd307f82ea17dc0b77e0c0b9e52fe0d5ea6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026590 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736511}
-
Jérôme Lebel authored
authentication/signin:signin is the public target to depend on. authentication/signin:signin_headers contains the public headers. authentication/signin:signin_impl contains the sign-in implementation. Related to: crrev.com/c/2025547 Bug: 971989 Change-Id: If7cbaf76df94b4a2647d0f47f56912cd3f36d0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027809 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736510}
-