- 08 Jan, 2021 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610085553-90a8ab5c2cfb6eb3765af407df5af94b81fb1c7d.profdata to chrome-linux-master-1610107094-a1b03a814715c7959032a16f0512a58b7ebd318d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I442ceafbc45094fff8adbce5376ad9d0a1ce13b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618067Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841466}
-
arthursonzogni authored
Remove a test fixture trying to turn on the flag "EmbedderCSPEnforcement". It doesn't exist anymore. We got: ``` RuntimeEnabledFeature not recognized: EmbedderCSPEnforcement ``` Bug: None Change-Id: I703055949a6665aef5c089af17cf2ae50c3b2bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612855 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841465}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9ec63731. With Chromium commits locally applied on WPT: 9ec63731 "[selectors] Fix leaks on :focus-visible tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Id8e5a35932ab1693aee511f32fb8cec31fb2a2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615344Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841464}
-
Stephen McGruer authored
Bug: 1163537 Change-Id: Ibf607274909ddc7435f45dc55a005c5d4f14ff15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613148Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#841463}
-
Nohemi Fernandez authored
Currently, Chrome does not properly dismiss all of its views when the sign-in flow has been interrupted. Add a DCHECK to ensure all flows lead to proper dismissal. Bug: 1115997 Change-Id: I86151297b16c0a791b2e4b4b4671cf4c0dcbfb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617921 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#841462}
-
Robbie Gibson authored
Now, instead of having the BVC manually set the contentInset, it instead alerts the fullscreen controller that the thumb strip has appeared. The fullscreen controller can then use this to correctly set the insets itself, even when new tabs are added. Also, the BVC now keeps track of whether the thumb strip has caused the view to be translated, so it can re-apply this translation when adding a new web state. Fixed: 1155160 Change-Id: I827d9edf058667a535275367605518512ebca7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599866Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#841461}
-
Ewann Pellé authored
This reverts commit 60e867a2. Reason for revert: this CL breaks ios-simulator-noncq bot Original change's description: > [iOS] Updates system colours to use google material colours > > This CL replaces the existing system colours by Google material colours. > > Bug: 1155472 > Change-Id: Ia9c9e8f31d65fe1db70fd29ad94ca370d0aede07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595050 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Javier Flores <javierrobles@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840999} TBR=gambard@chromium.org,javierrobles@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,ewannpv@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1155472 Change-Id: Id0fc2b406f14f385366ed14d80fd704924c61aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617920Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#841460}
-
Gauthier Ambard authored
This CL extracts the JavaScript logic to find the DOM element on which the user is long pressing and creating the ContextMenuParams out of it. It is also renaming HTMLElementFetchRequest in CRWHTMLElementFetchRequest to respect ios/web standard. Bug: 1140387 Change-Id: I62e6e2df9be54f67706ff440354912b00d77337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580073 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841459}
-
Sergei Datsenko authored
This reverts commit ccba8bc4. Reason for revert: Causes Chrome to crash on Chrome OS: crbug.com/1164258 Original change's description: > Consolidate interactions with |CrasAudioHandler|. > > Previously 2 places in the code were interacting with |CrasAudioHandler|: > - |PlatformApiImpl| subscribes to device changes, and passes this > information to |AudioInputHost|. > - |AudioInputHost| posts the new hotword model to |CrasAudioHandler|. > > This made it hard/impossible to split |AudioInputHost| from > |PlatformApiImpl|, which is needed to handle audio input in the > Libassistant mojom service. > > To solve this I moved all interactions with |CrasAudioHandler| inside a > new class |AudioDevices|, of which an instance is owned by > |AudioInputHost|. > > This also allowed me to add a bunch of new unittests. > > deployed on real hardware. > > Bug: b/171748795 > Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" and manually > Change-Id: I8ec9cec6672236f6365345b292efbe828518be69 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610953 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841155} TBR=xiaohuic@chromium.org,meilinw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org Change-Id: I1f11ed9e14063f91e7f734caf0696748b3d3b7de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/171748795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615734 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#841458}
-
Sergei Datsenko authored
This reverts commit c307ddb3. Reason for revert: Blocks revert of crrev.com/c/2610953 Original change's description: > Move |AudioInputHost| to |AssistantManagerServiceImpl| > > The main goal is to ensure we can create |AudioInputHost| independently > of |PlatformApiImpl|. > > This CL also makes |AudioInputHost| virtual so it can be faked during > the unittests of |AssistantManagerServiceImpl|. > > Bug: b/171748795 > Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Ic41ff343b28dae801b0c5f4c8c6417267270d8a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610047 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841226} TBR=xiaohuic@chromium.org,meilinw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org Change-Id: Ibd2ba5ed1a0388bbf80289812f356ba353015b9c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/171748795 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615735Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/070ef598892a..3ce4e8ee1301 2021-01-07 primiano@google.com Enable enable_perfetto_trace_processor_httpd on Windows 2021-01-07 primiano@google.com Fix debug, fuzzer and bazel build 2021-01-07 primiano@google.com Merge "base: port UnixSocket to Windows" 2021-01-07 treehugger-gerrit@google.com Merge "gn: Also look for Visual Studio Community edition" 2021-01-07 hjd@google.com Merge "NDEBUG builds of traced should work with both DEBUG and NDEBUG clients" 2021-01-07 ssid@google.com Merge "Fix the chrome thread enum to string conversion" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879 Tbr: perfetto-bugs@google.com Test: Test: manual on Windows: open https://ui.perfetto.dev Change-Id: I5de830bda75ec754d5275a39a6e9172ee8cc21c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617655Reviewed-by:
-
Friedrich Horschig authored
Redundant line caused a consistent lint failure. NoTry: True Bug: 1046784 Change-Id: I74cf7cc3afeb2b01f5c7ca7c91335009078997ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617787Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#841455}
-
Ramin Halavati authored
Updates Guest profile lifetime browser test to remove duplicate code and fix failure for OTR Guest profiles when ephemeral Guest profiles are enabled. Bug: 1125474 Change-Id: If93e1c069b690831d1ae1aff1faa50679ce992ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616700 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#841454}
-
Alice Wang authored
This CL adds two fields of full and given names to AccountInfo java class so that we can use this information in ProfileDownloader in the future to update profile data. Bug: 1162563 Change-Id: I87cd0d86b254b711fbf4672a5911239e95c1404a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617703 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Alexander Timin authored
Register a log message handler in BrowserTestBase if --enable-tracing is passed and flush the trace when encountering a fatal message. R=eseckler@chromium.org,skyostil@chromium.org,nasko@chromium.org BUG=1157954 Change-Id: Ic28b108e9b15a38e4f2c94a4a713583b98fa1998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595384 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#841452}
-
Jacobo Aragunde Pérez authored
Bug: None Change-Id: I0a0764d6edb19dfb548f05209013b69feaa9b64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601360Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#841451}
-
Regan Hsu authored
Fixed: 1162309 Bug: 1106937 Change-Id: Ifa4751e146f9d363100adb6df99e66769e3ba4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613127 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841450}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/ffb3b84133b0..bf29902dbe3e 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 234c65c0f32c to 134a52003407 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I230855c1c8b0fc7f2ffd8a0bbee506b690f7f2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617898Reviewed-by:
-
Marc Treib authored
Bug: 1121258 Change-Id: Iafa37aa2e99ced4bedd4e220df0769c02b973874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595742 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Anne Lim <annelim@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#841448}
-
Andreea Costinas authored
MGS and Kiosk are pre-configured browsing sessions that aren’t tied to a user. This CL enables reusing the proxy credentials set via device policy SystemProxySettings to authenticate MGS/Kiosk devices to a remote proxy. go/system-proxy-share-policy-credentials Bug: 1132840 Tests: unittests, browsertests Change-Id: I197ec95bfd7da138aff5dd02caf2fe0921ed9df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596344Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#841447}
-
Tanmoy Mollik authored
Method OnPrimaryAccountSet/Cleared and OnUnconsentedPrimaryAccountChanged is deprecated. So this cl changes these calls to OnPrimaryAccountChanged. Bug: 1158855 Change-Id: I0d19f0dad84f128c554ace6942d4ec4e5e96e34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611740 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#841446}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/589e3dd96b0c..d0433378a468 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fhorschig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fhorschig@google.com Change-Id: I52f11fcf0e0da446f831ce1650920c40087463aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617315Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610074312-912225aaa44122e4b1a4b8a45da36dc4daa402b9.profdata to chrome-win32-master-1610085457-9d25c44b81df119265a48970c3964c59f218f094.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic38a49518b27fe9c177462f0b4828c31d431d6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617650Reviewed-by:
-
Delan Azabani authored
This implements the style support only, behind a flag, based on the ::target-text counterpart in <https://crrev.com/c/2463563>. The paint code for querying these selectors and paint invalidation, as well as the changes needed to limit the acceptable properties (à la <https://crrev.com/c/2489657>), will be written in another CL. Bug: 1035708 Change-Id: I77e530fbbb78fb20c05325ef75babde91e5ef831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606878 Auto-Submit: Delan Azabani <dazabani@igalia.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/master@{#841443}
-
Greg Thompson authored
It tells us that failures are due to I/O errors, access denied errors, and other things we can't do anything about (likely odd drivers, too). R=chromium-metrics-reviews@google.com, gab@chromium.org Bug: 1156213 Change-Id: If4fb97d44d8b9a59db48239c68e69a56f59cd462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609143 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#841442}
-
Maya Lekova authored
The feature is enabled by default, as is the current state of the flag in V8. This CL is not intended to change the default behavior, but to allow us to quickly turn the feature off in case of any performance regressions. Bug: v8:10765, chromium:1157044 Change-Id: Ib46d487ba094f08c27354c53f8b98e220fec627b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596264 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841441}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4681cecb4151..1607b3aa8ccd 2021-01-08 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-08T04:02:26). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1538678ee6d16803fd26f736adb9b612193dd1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616924Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies base::string16 to be an alias for std::u16string on non-Windows platforms. This allows the removal of a custom std::char_traits specialization for uint16_t, and now also allows the creation of base::string16s from char literals on all platforms, removing most of the need for helpers like base::ASCIIToUTF16. Lastly, this change also updates blink::WebUChar, ensuring it continues to be the exact same type as base::char16. Bug: 911896 Change-Id: Ifef35543e10cfee2b25f11984be289553532626e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586354Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#841439}
-
Nohemi Fernandez authored
In order to unify the Identity communication across Chrome platforms we expose the user's given name as an Identity property. Bug: 1148764 Change-Id: I96eb98e1ab6ce5f5f2fe5a01cb68b3e9744e63ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615158 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
Methods OnPrimaryAccountSet/Cleared() are deprecated, so this CL changes the chrome/browser/ui/webui/settings/* to override the method OnPrimaryAccountChanged(). Bug: 1163126 Change-Id: I423bf0ec29479c7942c4e4c5558f9e6ba68b3ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611267Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#841437}
-
Heng-Ruey Hsu authored
This is a reland of 3fc522ff. Original change's description: > Refactor delegate to support multiple clients and manipulate buffers > from corresponding clients according to the stream type. > > Bug: b:151047537 > Test: Manually test > Change-Id: I511be4f20f495a973141a7199f4b4c3c50871f5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351932 > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> > Reviewed-by: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835102} TBR=wtlee@chromium.org Bug: b:151047537 Test: Manually test, test pass on krane. Change-Id: I3ed17b631fa8f0bea63c4ad616c64ca2ee8ca77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612313Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841436}
-
Colin Blundell authored
This CL prepares for the upcoming usage of Gaia-keyed URL lookups in Weblayer by turning SafeBrowsingTokenFetcher into an interface and its implementation into a SafeBrowsingPrimaryAccountTokenFetcher subclass. This layer of abstraction is needed as WebLayer will not fetch access tokens via IdentityManager as the current implementation does. A followup CL will abstract the remaining dependences on //components/signin from safe_browsing_token_fetcher.h. Bug: 1080748 Change-Id: Ib9c0cb63a3e1364611c21a3cc069bab7bdba0e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613968 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841435}
-
Taylor Brandstetter authored
This branch now contains three cherry picked commits: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..a3c3ef666b7a Bug: chromium:1163228 Change-Id: Icd506393d323f0fa1dbeb12546a224d09c4a77be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617212Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#841434}
-
David Jean authored
Also includes two #ifdef-out of deprecated code unrelated to orientation. Bug: 1131852 Change-Id: Ia229a421d0b9f9e9d655791d43b0cb59c0b0e75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612898 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
The :focus-visible tests were modified recently, but that introduced some leaks that were detected by "WebKit Linux Leak" bot. The tests that were failing are using test_driver.click(). This patch modifies the tests, so they pass without issues when passing --enable-leak-detection to tools/run_web_tests.py in a release build. Bug: 1163172 Change-Id: I9b8b1d0459bf7598fc3330495f3cc3ea95d36dae Cq-Include-Trybots: luci.chromium.try:layout_test_leak_detection,leak_detection_linux Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617818Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#841432}
-
Wei Lee authored
There are some use cases which are not guarded by the lock, which might cause race condition since |camera_info_| might be accessed from different threads. In addition, when VendorTagOpsDelegate is reset, we should have a way to let caller know that the initialization state is reset so that we won't wait forever. Bug: b/174126439 Test: Build successfully Change-Id: I270c0989f04896b1fc3df28aa2243dce799b93ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602964Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841431}
-
Tanmoy Mollik authored
Method OnPrimaryAccountSet/Cleared and OnUnconsentedPrimaryAccountChanged is deprecated. So this cl changes these calls to OnPrimaryAccountChanged. Bug: 1158855 Change-Id: Iecb78851b28f90934fb0127b8210ceac5f886457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611097Reviewed-by:
-
Friedrich Horschig authored
The test seems to leak objects only occasionally, e.g. (leak detected: ({"numberOfLiveContextLifecycleStateObservers":[2,8], "numberOfLiveDocuments":[1,4], "numberOfLiveNodes":[4,2204], "numberOfLiveResourceFetchers":[1,4]}), text diff) NOTRY=true TBR=petermarshall@chromium.org Bug: 1046784 Change-Id: Iba2c7b27242a330ad1307ab6a2ea9c1fcec343e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617839Reviewed-by:Peter Marshall <petermarshall@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#841429}
-
Boris Sazonov authored
Changes AccountManagerAsh to use ReceiverSet instead of a single Receiver. This allows having multiple clients talking to the same AccountManagerAsh instance and also prepares the upcoming unification of AccountManagerFacade implementations. AccountManagerAsh ownership will be revised in subsequent CLs. Bug: 1161699, 1148448 Change-Id: Ida66bce494df802bf5ce4fd99f78d081a9540b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614788Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841428}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iaa235f3695bf7ff8303127bda64765ab3da7d7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617621Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841427}
-
