GitLab

BUG=477049

Review URL: https://codereview.chromium.org/1419083012

Cr-Commit-Position: refs/heads/master@{#361136}

The change was landed through the CL 1408923003

R=fmalita@chromium.org
BUG=546538

Review URL: https://codereview.chromium.org/1471003002

Cr-Commit-Position: refs/heads/master@{#361135}

The media playback test was recently added:
https://codereview.chromium.org/1431193005/

and requires specific switches:
* local file access required to load test media
* cma pipeline explicitly enabled in order to test that
* cast ozone platform enabled in order to test overlay frames

These tests have been failing on internal infrastructure (tot build)
because the switches were only configured in testing/buildbot (for
running on Chromium bots).

BUG=

Review URL: https://codereview.chromium.org/1466633004

Cr-Commit-Position: refs/heads/master@{#361134}

BUG=557285

Review URL: https://codereview.chromium.org/1465953003

Cr-Commit-Position: refs/heads/master@{#361133}

This CL:
- Removes weird OnFaviconAvailable() behavior if gfx::Image is empty.
- Merges: FaviconDriver::SetActiveFaviconValidity()
          FaviconDriver::SetActiveFaviconURL()
          FaviconDriver::SetActiveFaviconImage()
- Merges FaviconDriverObserver::OnFaviconAvailable() and
         FaviconDriverObserver::OnFaviconUpdated().

BUG=542057

Review URL: https://codereview.chromium.org/1407353012

Cr-Commit-Position: refs/heads/master@{#361132}

BUG=475442

Review URL: https://codereview.chromium.org/1471783002

Cr-Commit-Position: refs/heads/master@{#361131}

TEST=CronetUrlRequestTest.testMockClientCertificateRequested
BUG=558420

Review URL: https://codereview.chromium.org/1459993003

Cr-Commit-Position: refs/heads/master@{#361130}

This adds libffi-dev and libdrm-dev to the image
which were recently added with:
https://codereview.chromium.org/1464123002

R=thestig@chromium.org
BUG=559062

Review URL: https://codereview.chromium.org/1466383002

Cr-Commit-Position: refs/heads/master@{#361129}

Move addToSVGPathByteStream to SVGPath.cpp (the only place using it),
rename it to addPathByteStreams. Move the "regular" blending out into a
helper(blendPathByteStreams), and eliminate the redundant copy. Make the
functions more "functional" (return the result.)

Add a (private) setter for byte-stream data and use that to ensure
invalidation of the cached path. Also add an SVGPath::create(...)
accepting a SVGPathByteStream and use that in PathSVGInterpolation.

Inline mutableByteStream into the remaining user.

Review URL: https://codereview.chromium.org/1460253002

Cr-Commit-Position: refs/heads/master@{#361128}

BUG=559322

Review URL: https://codereview.chromium.org/1470503002

Cr-Commit-Position: refs/heads/master@{#361127}

crrev.com/1427963002 introduced a new memory-infra thread which runs
after all dump providers are finished. This measures the process total
memory usages. This was previously running at the start of a memory
dump. This means that the memory used while taking memory dump of other
providers will be included in the totals now and this metric has
regressed. This CL is a temporary change that reverts this behaviour so
that the perf bots are happy. Better fix for the problem will follow up
soon.

BUG=555584

Review URL: https://codereview.chromium.org/1466293002

Cr-Commit-Position: refs/heads/master@{#361126}

The race was fixed with https://codereview.chromium.org/355573006 ,
committed as
https://skia.googlesource.com/skia/+/e438ddbc7451ec80f953266409fea4695e78c8c2

This is effectively a revert of https://codereview.chromium.org/273523002 .

BUG=chromium:369257

Review URL: https://codereview.chromium.org/1467313002

Cr-Commit-Position: refs/heads/master@{#361125}

This CL including a layout test that does 2 things:
1. transfer an ImageBitmap to the worker and let worker transfer back to
   main, the main thread exam the transfered-back ImageBitmap to make
   sure the data is the same as the original ImageBitmap.
2. When worker receives the ImageBitmap from main, worker calls
   createImageBitmap() to create a new ImageBitmap and send it back to
   main

BUG=532142

Review URL: https://codereview.chromium.org/1423513005

Cr-Commit-Position: refs/heads/master@{#361124}

Validation already takes care of :valid/:invalid changes through
invalidation sets. This reduces the number of elements being recalculated
and gets rid of a SubtreeStyleChange which relies on sibling tree recalcs.

R=tkent@chromium.org
BUG=557440

Review URL: https://codereview.chromium.org/1458363003

Cr-Commit-Position: refs/heads/master@{#361123}

BUG=None

Review URL: https://codereview.chromium.org/1472853004

Cr-Commit-Position: refs/heads/master@{#361122}

We did use invalidation sets when adding/removing href from an anchor tag,
while the code that notifies that the visited state of a given url has
changed, use SubtreeStyleChange. This change gets rid of SubtreeStyleChange
which relies on sibling tree recalcs.

R=tkent@chromium.org
BUG=557440

Review URL: https://codereview.chromium.org/1459063004

Cr-Commit-Position: refs/heads/master@{#361121}

BUG=None

Review URL: https://codereview.chromium.org/1472863002

Cr-Commit-Position: refs/heads/master@{#361120}

Add new boolean to know if a GridSpan is definite or indefinite.
That way we don't need to use pointers and we can always have two
GridSpans in GridCoordinate, if the position is "auto" the GridSpan will
be marked as indefinite. This will allow in a follow-up patch to avoid
repeated calls to methods that resolve positions.

Most operations in GridSpan are restricted to definite GridSpans (access
to positions, iterator, etc.). For indefinite GridSpans we only need to
know that they're indefinite we shouldn't use the rest of the data.

No new tests, no change of behavior.

BUG=444011

Review URL: https://codereview.chromium.org/1459373002

Cr-Commit-Position: refs/heads/master@{#361119}

C++ 11 enables containers that contain move-only type, scoped_ptr.
So, Use std::map<key, scoped_ptr<Foo>> instead of ScopedPtrMap.

BUG=554291
TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/1468013002

Cr-Commit-Position: refs/heads/master@{#361118}

Fixes the clang/win build after https://codereview.chromium.org/1439443002/
clang rightfully complains that UiThreadHelper has virtual methods, is
deleted polymorphically, and doesn't have a virtual destructor:

..\..\base/sequenced_task_runner_helpers.h(40,5) :  error: delete called on 'const device::SerialIoHandlerWin::UiThreadHelper' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete reinterpret_cast<const T*>(object);
    ^
..\..\base/sequenced_task_runner_helpers.h(86,38) :  note: in instantiation of member function 'base::DeleteHelper<device::SerialIoHandlerWin::UiThreadHelper>::DoDelete' requested here
        from_here, &DeleteHelper<T>::DoDelete, object);
                                     ^
..\..\base/sequenced_task_runner.h(126,48) :  note: in instantiation of function template specialization 'base::subtle::DeleteHelperInternal<device::SerialIoHandlerWin::UiThreadHelper, bool>::DeleteViaSequencedTaskRunner<base::SequencedTaskRunner>' requested here
        subtle::DeleteHelperInternal<T, bool>::DeleteViaSequencedTaskRunner(
                                               ^
..\..\device\serial\serial_io_handler_win.cc(374,28) :  note: in instantiation of function template specialization 'base::SequencedTaskRunner::DeleteSoon<device::SerialIoHandlerWin::UiThreadHelper>' requested here
  ui_thread_task_runner()->DeleteSoon(FROM_HERE, helper_);
                           ^

Making the class final fixes this as it makes sure that nobody adds
a subclass of UiThreadHelper.

Also don't mix initializer styles for the different fields of this
class.

No intended behavior change.

BUG=82385
TBR=juncai

Review URL: https://codereview.chromium.org/1470983002 .

Cr-Commit-Position: refs/heads/master@{#361117}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/76efc8f2..a40b4f5c

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1472873002

Cr-Commit-Position: refs/heads/master@{#361116}

BUG=514767

Review URL: https://codereview.chromium.org/1423333006

Cr-Commit-Position: refs/heads/master@{#361115}

and when --use-gl=egl then the browser is showing garbage.

Indeed in GpuCommandBufferStub::OnInitialize the call to
context->Initialize(surface_.get(), gpu_preference_)" fails.
The error actually comes from eglMakeContext which returns
EGL_BAD_MATCH. Because surface config is not compatible with
context config.

Problem is that EGL_BUFFER_SIZE is always 32 for off screen
surfaces (see gl_surface_egl.cc::InitializeOneOff). Whereas
for on screen surfaces EGL_BUFFER_SIZE is the window depth.
This depth is by default 24 unless --enable-transparent-visuals
is passed to the command line.

When using mesa the error is raised here:
/* If the context has a config then it must match that of the two
* surfaces */
if (ctx->Config) {
if ((draw && draw->Config != ctx->Config) ||
  (read && read->Config != ctx->Config))
return _eglError(EGL_BAD_MATCH, "eglMakeCurrent");
from:
cgit.freedesktop.org/mesa/mesa/tree/src/egl/main/eglcontext.c#n630

This patch pass the main window depth from browser to gpu process
though a new switch kWindowDepth.
This allow GLSurfaceEGL::InitializeOneOff to select an EGLConfig
that matches with future ON screen surfaces's EGLConfig.

Also note that long term plan is to always enable transparent visual,
see http://crbug.com/369209.

This patch also move the kEnableTransparentVisuals switch from view
to x11 switches as it is defined to x11 only.

BUG=557389

R=jbauman@chromium.org, hendrikw@chromium.org, piman@chromium.org, sadrul@chromium.org, cwallez1@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/1429083002

TEST= chrome --use-gl=egl --use_virtualized_gl_contexts

Review URL: https://codereview.chromium.org/1429083002

Cr-Commit-Position: refs/heads/master@{#361114}

BUG=None

Review URL: https://codereview.chromium.org/1466343002

Cr-Commit-Position: refs/heads/master@{#361113}

https://chromium.googlesource.com/skia.git/+log/5931922997b8..8e8eda9d4d2e

$ git log 593192299..8e8eda9d4 --date=short --no-merges --format='%ad %ae %s'
2015-11-23 msarett Switch Skia's libjpeg-turbo to 1.4.2
2015-11-23 kkinnunen Fix GLInterfaceValidation test after "Remove GrContextFactory::getGLContext"

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1470953002

Cr-Commit-Position: refs/heads/master@{#361112}

BUG=553320

Review URL: https://codereview.chromium.org/1466363002

Cr-Commit-Position: refs/heads/master@{#361111}

This CL is a precursor to expanding Clank stability scope
to all OOM protected renderers that crash while Chrome is
in the foreground.

The difference in scope is effectively
the number of renderers that crash as its corresponding
tabs are all backgrounded. This transition time is one second before the OOM protection is dropped. Most,
if not all, such renderer crashes are due to the Android OOM
killer. Overall difference in proposed stability stats will
not be much different, and will be easily seen with the new
histogram.

Expanding scope allows us to have native record which of
the renderer crashes actually results in a minidump file
being generated, thus demystifying whether the renderer
was OOM killed or actually crashed. This native stat can
be made more robust in the future, but this CL paves the
foundation, assuming Tab.RendererExitStatus is comparable
to Tab.RendererCrashStatus.

Review URL: https://codereview.chromium.org/1447213002

Cr-Commit-Position: refs/heads/master@{#361110}

Unrecoverable SSL errors were broken in 	Merge 229993, by the upstream CL:
https://codereview.chromium.org/23965003/.
This fix removes the iOS specific interstitial.mm and uses interstitial_page_impl
instead.
It also adds support for unrecoverable errors, by returning a DENIED judgment
to some errors.

BUG=310607
TEST=Go to https://test-sspev.verisign.com/. Clicking on "Revoked" should trigger an unrecoverable error, clicking on "Expired" should trigger a recoverable error (with a "proceed anyway" button)

Review URL: https://chromereviews.googleplex.com/12347017

Review URL: https://codereview.chromium.org/1469063002

Cr-Commit-Position: refs/heads/master@{#361109}

Removes ServiceIsNullForTesting override in FaviconServiceFactory
to enable use of FaviconServiceFactory in tests.

BUG=557415

Review URL: https://codereview.chromium.org/1458703009

Cr-Commit-Position: refs/heads/master@{#361108}

BUG=551798
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1424213006

Cr-Commit-Position: refs/heads/master@{#361107}

BUG=None

Review URL: https://codereview.chromium.org/1471763004

Cr-Commit-Position: refs/heads/master@{#361106}

The only usage of this method is in iOS-specific code that knows that it's
talking to a WebOmniboxEditController, so it's unnecessary to fork
omnibox_edit_controller.h to expose this method.

BUG=305330

Review URL: https://codereview.chromium.org/1465253002

Cr-Commit-Position: refs/heads/master@{#361105}

BUG=None

Review URL: https://codereview.chromium.org/1469053002

Cr-Commit-Position: refs/heads/master@{#361104}

This CL changes the iOS port to use IOSChromeMetricsServiceClient rather than
its forked version of ChromeMetricsServiceClient. There is one intended
functional change in that
ChromeMetricsServiceClient::RecordCommandLineMetrics() was not ported to
IOSChromeMetricsServiceClient; see crbug.com/375794 for details.  Other than
that, there should be no functional changes.

BUG=512421, 375794

Review URL: https://codereview.chromium.org/1470963002

Cr-Commit-Position: refs/heads/master@{#361103}

Prior to this CL, when the ESC key was pressed, only the state presented by the
BVC was dismissed. Moreover, the BVC dismissed blindly all presented view
controller, such as the settings. It is the MainController responsibility to
close the settings, as it is the presenter.
This CL adds a new Chrome command that asks to dismiss all modals.

BUG=none
R=rohitrao@google.com

Review URL: https://chromereviews.googleplex.com/265777013

Review URL: https://codereview.chromium.org/1469903002

Cr-Commit-Position: refs/heads/master@{#361102}

BUG=558402

Review URL: https://codereview.chromium.org/1467573003

Cr-Commit-Position: refs/heads/master@{#361101}

BUG=

Review URL: https://codereview.chromium.org/1469813004

Cr-Commit-Position: refs/heads/master@{#361100}

Move from RenderProcessHostImpl::OnChannelEstablished to
RenderProcessHostImpl::OnProcessLaunched, so that it comes in before
the first burst of IPCs to the renderer.

Change token DCHECKs to CHECKs, because they will crash the renderer
later on.

BUG=554541

Review URL: https://codereview.chromium.org/1463853002

Cr-Commit-Position: refs/heads/master@{#361099}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e6029096..76efc8f2

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1469033002

Cr-Commit-Position: refs/heads/master@{#361098}

Reland of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #1 id:1 of https://codereview.chromium.org/1472713003/ )

Reason for revert:
Mac Builder (dbg) does not even compile now...

Original issue's description:
> Revert of NaCl: Update revision in DEPS, 546ef11 -> b6ec17d (patchset #2 id:20001 of https://codereview.chromium.org/1460063003/ )
>
> Reason for revert:
> I'm speculatively reverting this CL as the cause for the failing Mac10.6 Tests nacl_integration test. The whole test fails with this output:
> scons: done reading SConscript files.
> scons: Building targets ...
> Install file: "src/untrusted/pthread/pthread.h" as "scons-out/nacl-x86-64/include/pthread.h"
> Install file: "src/untrusted/pthread/semaphore.h" as "scons-out/nacl-x86-64/include/semaphore.h"
> Install file: "src/untrusted/stubs/crt1.x" as "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o"
> Func(["scons-out/nacl-x86-64/obj/tests/breakpad_crash_test/breakpad_untrusted_crash_test.out.tmp/crash_test.nmf"], [])
> Install file: "src/untrusted/nacl/nacl_random.h" as "scons-out/nacl-x86-64/include/nacl/nacl_random.h"
> Install file: "src/untrusted/nacl/nacl_dyncode.h" as "scons-out/nacl-x86-64/include/nacl/nacl_dyncode.h"
> WriteManifestList(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner_nmf_test_list.js"], [])
> Func(["scons-out/nacl_irt_test-x86-64/obj/tests/nacl_browser/inbrowser_test_runner/run_inbrowser_test_runner.out.tmp/random_test.nmf"], [])
> Install file: "scons-out/nacl-x86-64/obj/src/untrusted/stubs/crt1.o" as "scons-out/nacl-x86-64/lib/crt1.o"
> /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o src/untrusted/nacl/sigprocmask.c
> dyld: Library not loaded: /usr/lib/libedit.3.dylib
>   Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang
>   Reason: image not found
>
> I'm thinking this might be caused by "Fix PNaCl toolchain build on Mac" https://codereview.chromium.org/1458713003
> that e.g. includes this change:
> # Required SDK version and target version for Mac builds.
> # See MAC_SDK_FLAGS, below.
> MAC_SDK_MIN = '10.10'
> MAC_DEPLOYMENT_TARGET = '10.6'
>
> Original issue's description:
> > NaCl: Update revision in DEPS, 546ef11 -> b6ec17d
> >
> > This pulls in the following Native Client changes:
> >
> > 1a71811: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
> > 26a11d1: (stichnot@chromium.org) Update revision for PNaCl
> > 3658d8e: (phosek@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
> > 7a60f36: (mcgrathr@chromium.org) Remove an unused variable from src/shared/imc/win/nacl_imc.cc
> > 1b746e8: (mcgrathr@chromium.org) PNaCl: Update clang revision in pnacl/COMPONENT_REVISIONS
> > 0f0cb21: (mcgrathr@chromium.org) pnacl-strip: Handle --strip-unneeded switch
> > 9d811a5: (mcgrathr@chromium.org) toolchain_build: Disable gold build for Mac host
> > 7f130ff: (erikchen@chromium.org) Suppress Clang warning for dirfd() on OSX.
> > 18e2d27: (erikchen@chromium.org) Add code to check for the OS X version.
> > bad8503: (erikchen@chromium.org) Fix an invocation to find_sdk.py.
> > 079650c: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
> > 4dbae34: (mcgrathr@chromium.org) Fix PNaCl toolchain build on Mac
> > db88d57: (mcgrathr@chromium.org) Fix build/update_pnacl_tool_revisions.py for @-less user names
> > d5112f1: (mcgrathr@chromium.org) Update revision for PNaCl
> > b6ec17d: (erikchen@chromium.org) Make a NaCl descriptor for Mach-based shared memory.
> >
> > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/546ef11ffcbedf8c33bfa12643408c1182b6839e..b6ec17db8c2958f3455043e29000f17354336fb8
> >
> > BUG=none
> > TEST=browser_tests and nacl_integration
> > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build
> >
> > Committed: https://crrev.com/910bd999c1fed7f0211b636184072f35a506023f
> > Cr-Commit-Position: refs/heads/master@{#360958}
>
> TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> BUG=none
>
> Committed: https://crrev.com/a503d57f1c4ec0f07b064247ee82c3e7d4ecd9dc
> Cr-Commit-Position: refs/heads/master@{#361096}

TBR=dpranke@chromium.org,dschuff@chromium.org,mcgrathr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1472853002

Cr-Commit-Position: refs/heads/master@{#361097}