- 31 Jul, 2020 26 commits
-
-
Takashi Toyoshima authored
This change clarifies how the Origin header modification works with CORS checks. This wasn't a behavior change from the m79, but the existing behavior. Bug: 1105805 Change-Id: Id3f2e781759a458a8779492fd254cee0c87e3188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307022 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#793466}
-
Stephen Martinis authored
I forgot to update the reference to the root of the source directory when I moved the script previously. Bug: 1097180 Change-Id: I9b36cb19b627681e806336c94337ad33954d4ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330740 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793465}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I859b63f0e7bb1317084c1dc0f64bdfa4d569a108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325092 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#793464}
-
Jongmok Kim authored
Bug: 1100034 Change-Id: Id638fd2fe0f554d7c2c7f440dd27e26954fbec58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325457Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Jongmok Kim <jongmok.kim@navercorp.com> Cr-Commit-Position: refs/heads/master@{#793463}
-
Nate Fischer authored
https://crrev.com/c/2309813 recently changed fail_on_output to default to True, but this breaks the internal official build installer script (see bug for details). This sets this back to False at the call site to get the script working again. Fixed: 11115630 Test: install_webview.py -M 86 --bundle Change-Id: If5bc1646bcf6d4ac7e40ee224033cf678b073cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330813 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#793462}
-
Xing Liu authored
This CL tries to fix test failure on Android P, and reenable several tests. Bug: 1101413 Change-Id: I1f6a3730aac98411d322afbbe456343f491ceef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330612Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793461}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596131728-ae408445987ddd6aa50e0d258bdde96ebf55cf02.profdata to chrome-win32-master-1596139195-1e6f24fe599857a5d76e1ba28ac7e9b1f562f5e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I97cf33dadcd3d1ea844b94c35f2e4d6eb7f72ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793460}
-
Ernesto García authored
Renamed elide_after_interaction_animation to elide_after_web_contents_interaction_animation_ as suggested, to avoid confusion with hover_elide_or_unelide_animation_ Bug: 1106004 Change-Id: I1c1cba6e84f3d0a650905c26dff0fcc65709443c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330532Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Ernesto García <ernestognw@google.com> Cr-Commit-Position: refs/heads/master@{#793459}
-
Rakib M. Hasan authored
Bug: 1050754 Change-Id: I4bae307eb6e5a1758fb87377fce4c5f0fdd46536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330315 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#793458}
-
Kurt Catti-Schmidt authored
This crash occurs when BrowserAccessibility::AccessibilityPerformAction is provided with nodes that span more than one AXTree. BrowserAccessibility::AccessibilityPerformAction does not use the tree ID at all, and assumes all nodes are in the same tree. This is reasonable because most actions are on a single node. However, kSetSelection requires two nodes, and since it's not looking at tree ID's, there is an implicit assumption that the two nodes are in the same tree. When they are not, one of the two nodes is not found and this crash occurs. One possible fix here is to incorporate the tree ID's and allow for selection to span multiple trees. However, Blink doesn't allow for this. So instead, the fix here is to ensure that the selection start and selection end are in the same tree before calling AccessibilityPerformAction. This is done by using the tree ID from the start node and moving until it's at the end of its tree. I added methods in ax_position.h to perform this. I did a look over other calls to AccessibilityPerformAction, in the relevant files and they all appear to be safe from this issue, as they are operating on a single node. Bug: 1105229 Change-Id: I2fa21560ae6d18aa50097e2b3dcd3d2261c5733d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300266 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#793457}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f05e507a003..f6c424bb5923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib812af1a232ad3fdffd5084c534989033000bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330994Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ddb3ecf006e..7d4d01fbf84f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC petewil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1004848,chromium:1033067,chromium:1046746,chromium:1064151,chromium:1085419,chromium:1090082,chromium:1099917,chromium:1099982,chromium:1100456,chromium:1103655,chromium:1103833,chromium:1105907,chromium:1107615,chromium:1108576,chromium:1108791,chromium:1108957,chromium:1109044,chromium:1110346,chromium:1110902,chromium:1111004,chromium:1111025,chromium:1111363,chromium:1111501,chromium:912681 Tbr: petewil@google.com Change-Id: I51704bc0a1514dbe2d3558e2041391f351df198b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330910Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793455}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 599ebd7d. With Chromium commits locally applied on WPT: 6d63b58a "Split iceGatheringState tests into separate files & update expectations" 5f9b012c "Add wpt/css/css-multicol/multicol-overflow-clip-auto-sized.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I611c8d79a11b24ad77d37b3ea6fa262b1b831685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330690Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793454}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5a58acd2d744..f6c424bb5923 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7e02568081f8fcc20cd1a9731902602761362d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331090Reviewed-by:
-
Brian Sheedy authored
Re-enables testRender_SignInPromo, which was previously flaky due to input events causing captured screenshots to be slightly different. Now that we use Gold for the RenderTests, we can just approve multiple images for the test to work around that particular issue. Bug: 1057843, 898165, 848983 Change-Id: Ibf0df37d35bb7953a3760b68fbe4557f2868eed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327751 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#793452}
-
Bo Liu authored
Fix a few issues to better handle failure case. * Use MediumTest to get a longer timeout * Use CallbackHelper which has a timeout instead of waiting for draw indefinitely * Allow setting the render callback repeatedly and just use the new one Bug: 1107812 Change-Id: I19c7bed0409f8d1aa3200f06b4bcb9d90f4c5e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330530Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793451}
-
Scott Violet authored
BUG=1031060 TEST=covered by tests. Change-Id: Ifdb0db3241c09d8c70cc6e7953fc0278ee913f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330433 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#793450}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5527d5da8d83da1df825825fc46c70a07f0ab8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330932 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#793449}
-
Bo Majewski authored
Add a sandboxed (utility process) mojo service that generates bitmap thumbnails for PDF content delivered as a SkBitmap object. Bug: 903742 Change-Id: I7427f1ec1835d5b53d6498855dc3fc8d23460eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251524 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793448}
-
Pete Williamson authored
Bug: 1111575 Change-Id: I502b03e8fca3e398c7ad4e8820586cd9d2054c18 TBR: dtseng@chromium.org Change-Id: I502b03e8fca3e398c7ad4e8820586cd9d2054c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330937Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#793447}
-
Jeevan Shikaram authored
This patch adds a Mojo connection from the browser to the Android subsystem on Chrome OS for interfacing with the TWA that invoked the Chrome browser and is acting as a payment app. Implements the ARC bridge between chromium and ARC++ to allow the querying of the payment app on ARC++. Bug: 1061503 Change-Id: I495c6c586ec5c5d579de3bdfa32bbc7689219d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319518 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#793446}
-
Xiaoqian Dai authored
Bug: 1110381 Change-Id: Ia96cf27bd985f615341d13dcd76790db70d3fbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327136 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793445}
-
Carlos Frias authored
This CL introduces the following three new enterprise policies for controlling the Sensors permission access: DefaultSensorsSetting: Defines the default setting for the Sensors permission, possible values are Block or Allow all by default. SensorsAllowedForUrls: Defines the list of URL patterns that would always allow access to the sensors by granting its permission. SensorsBlockedForUrls: Defines the list of URL patterns that would always block access to the sensors by denying its permission. This new set of policies are implemented in a similar fashion as the policies already available for Notification access (DefaultNotificationsSetting, NotificationsAllowedForUrls and NotificationsBlockedForUrls). Testing for these policies is done by new browser test (SensorsPolicyTest) and the addition of new test cases in policy_test_cases.json. Bug: 1108589 Change-Id: I749e68f29b22bed3fbad1143e10877394f5ed95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316322 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793444}
-
Yuke Liao authored
An optional try job to compile lacros related test targets. Bug: 1110382 Change-Id: I39c36d5e01c11d5e9d04b96c53ec263593f5e539 Ignore-CQ-Freeze: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330431 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#793443}
-
Yuichiro Hanada authored
When ArcPreImeKeyEventSupport is enabled, key events not consumed by IME should be sent back to the proxy IME in Android side. This CL adds a way to override DispatchKeyEventPostIME() called by IME. Please refer to go/arc-key-event-dispatch for the details. Bug: b:148193316 Test: component_unittests Test: arc.PhysicalKeyboard with the feature flag enabled Test: arc.IMESwitchShortcut with the feature flag enabled Test: manual - text input on ARC++ apps still work Test: manual - Enter searches apps on search bar of PlayStore app. Change-Id: I764118eb7d26f2fc7a85c0a06360f0fb54fe0bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291291 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#793442}
-
Rakesh Soma authored
time as the last time token_handle was valid instead of a successful online login attempt from the end user. Bug: 1111151 Change-Id: I443c66ae77c41b670d9fa994fb9744eb0033ad5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328014 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#793441}
-
- 30 Jul, 2020 14 commits
-
-
Vasiliy Telezhnikov authored
Resource was returned by DisplayResourceProvider clients need to wait for SyncToken before reusing it. This CL fixes broken logic in VideoResourceUpdater related to it. Bug: 1111534 Change-Id: I1467474ecac65f1fe96c396180ba157e89435caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330581Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#793440}
-
Nate Fischer authored
This adds a screenshot of the WebView shell, sized to 362 pixels wide (for consistency the images in developer-ui.md). Fixed: 948428 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I95da967ff593766e2a6067c558e82b5a2a59ded5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330819 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Maggie Cai authored
This CL adds a sharesheet button in files app and handles it's visibility. In addition, the original share button will be hidden if the sharesheet button is available. This is implemented behind a flag Sharesheet. BUG=1097623 Change-Id: Iee1dcf5363cd22a53f7bd2ec30de51d052457cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322268Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#793438}
-
Yuwei Huang authored
This CL removes the gRPC support library from remoting/. Bug: 1103416 Change-Id: I1f0a3855414c651bd843270d3f96690d288b219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330440 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#793437}
-
John Z Wu authored
CWVPasswordController contained a bunch of duplicated code that is no longer needed. Bug: 1097353 Change-Id: I62f57d8dff5291d7aebaa24713ff1d8da82c1e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315252 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#793436}
-
Yulun Wu authored
All back gestures are recorded as dismissed by timeout because the nudge is logged as timed out as soon as nudge animations are finished. Additionally, kBackGestureStarted should not be used as a dismiss reason because it would override the intended metric, kPerformedGesture. Bug: 1101105 Change-Id: I667d02610bde3f7c159f4f63d9732e7bd6f855ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295928 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793435}
-
Dominic Schulz authored
We have some data stored in prefs keyed off the install_url. Until we can migrate that to BMO stuff, we shouldn't change the install_url. Bug: 1111171 Change-Id: I2af4191a6f2049f661870378df5d4d82beb63edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330656 Auto-Submit: Dominic Schulz <dominicschulz@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#793434}
-
Daniel Rubery authored
This allows Safe Browsing to continue reporting only the potentially dangerous files by filtering within the FileAnalyzer, but WebProtect can make decisions based on all files contained within the archive. Safe Browsing will filter the downloads in the browser process by only considering downloads with is_executable or is_archive set. WebProtect will not filter the archived binaries, so it will begin identifying encrypted downloads of a safe file type. Fixed: 1058210 Change-Id: I46274954f49f964fd350f3900dfc646c9670611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305209 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#793433}
-
Dan Harrington authored
Bug: 1044139 Change-Id: Iaec80af41c2c4ed300ab92db4fb23f0f52d96f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330439 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#793432}
-
David Van Cleve authored
We're shipping the pertinent change^ in M85 so this will allow a lifetime of three milestones. ^ https://www.chromestatus.com/feature/6251880185331712 Bug: 1014207 Change-Id: I01d2b0961aebdfda44fbed621d99b39428aec121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326091 Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#793431}
-
Henrique Nakashima authored
Not a clean revert as other dependent CLs over this. The code is a clean revert, but the build target that was split out in https://chromium-review.googlesource.com/c/chromium/src/+/2246983 is merged back into //chrome/browser. Also leave Profile#setLastUsedProfileForTesting() which has been used by many tests since then. Reason for revert: crbug.com/1108345 Original change's description: > Remove Profile reference from web_contents_state.cc > > Bug: 1090048 > Change-Id: I156fa5e8b6258d453c5809247e809a4ec7957125 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281307 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787271} Bug: 1090048 Change-Id: Iab4e650ed3fe9a559e58ea7462fad5199999ee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324105Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#793430}
-
Kevin Marshall authored
Defines a class "ScopedApi" provides RAII-based management of injected Chromecast bindings and their MessageChannels. Move BindingsManager to a component, rename it as cast_api_bindings::Manager. An alias subclass is added at its old location to allow the new name to be transitioned in a followup CL. Bug: 1104369 Change-Id: I1ecaff11dae85a3f62f75056a5c1d6005c3652c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303563Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#793429}
-
Mohammad Refaat authored
This is done by introducing a new property in previousSessionInfo, which will hold information about if the last session was a multiwindow session or not, using that we can determine the path that is used to load the session from. Bug: 1084484 Change-Id: I5cb0d5c34a66e6b31a585fdae0039a8339b0311f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320141 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#793428}
-
Mei Liang authored
crrev.com/c/2240422 adds a custom zoom in then fade out removal animation for the TabListRecyclerView. This animation has a compatibility issue with StartSurface and GTS when there is at least one Incognito tab. There is an unexpected scaling animation on Tab cards when switching between the normal and incognito TabModel. This CL reverts the scaling animation part of crrev.com/c/2240422. Bug: 1095948 Change-Id: Ic709bf2dcf644f32268fcb5231ce574afc23f9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329873 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793427}
-
