GitLab

The CL http://crrev.com/1638413003 will remove enhanced bookmarks but
the iOS code (and only the iOS code) dealing with bookmarks uses four
utility functions. This CL copies those functions to iOS before they
disapear.

BUG=None

Review URL: https://codereview.chromium.org/1647903002

Cr-Commit-Position: refs/heads/master@{#372081}

TBR=chongz@chromium.org, kinuko@chromium.org
BUG=582016

Review URL: https://codereview.chromium.org/1644643003

Cr-Commit-Position: refs/heads/master@{#372080}

Only import adblocker if we actually define any rules. If we define
rules, and fail to import adblockerparser, give detailed installation
instructions.

Fix typo that prevented the filtering from working in the model, and have the filtering actually use the new adblocker matcher rather than the old heuristic.

Review URL: https://codereview.chromium.org/1645953002

Cr-Commit-Position: refs/heads/master@{#372079}

BUG=570315

Review URL: https://codereview.chromium.org/1646503002

Cr-Commit-Position: refs/heads/master@{#372078}

virtual/threaded/printing/ellipsis-printing-style.html [ Skip ]
printing/ellipsis-printing-style.html [ Skip ]

Started happening after the rebaselines for the associated
CL [1] landed. The rebaselines are missing it seems.

[1] https://code.google.com/p/chromium/issues/detail?id=390040#c14

TBR=wkorman@chromium.org,chrishtr@chromium.org
BUG=390040
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1649563004

Cr-Commit-Position: refs/heads/master@{#372077}

Oilpan is enabled on ToT, and is reading from TestExpectations and has
no Expectations file of its own (for now).

Mark the tests as a flake, and place them in TestExpectations "Oilpan"
area of that file.  They fail both in Oilpan Win Release and Debug.

[ Win7 ] fast/text/emphasis-combined-text.html [ Pass Failure ]
[ Win7 ] fast/text/emphasis-vertical.html [ Pass Failure ]

since the following expectation already existed, and were retained for
issue 521730.

crbug.com/521730 [ Win10 ] fast/text/emphasis-combined-text.html [ Failure ]
crbug.com/521730 [ Win10 ] fast/text/emphasis-complex.html [ Failure ]

TBR=wkorman@chromium.org
BUG=574660
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1644953002

Cr-Commit-Position: refs/heads/master@{#372076}

If a ScriptRunner has been disposed of already, allow ScriptLoaders
to notify of their failure without asserting.

R=haraken
BUG=570012

Review URL: https://codereview.chromium.org/1642863002

Cr-Commit-Position: refs/heads/master@{#372075}

It's a part of larger task to move the whole initialization
on the separate thread. Previous CL introduced some hard to
track issues and broke some perf bots. This CL is first part
to make sure bots are fine. It moves gconf related
initialization on the file thread.

BUG=472183, 468989, 468112

Review URL: https://codereview.chromium.org/1640273002

Cr-Commit-Position: refs/heads/master@{#372074}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a7e38c146fe9..8e3a22b7dbec

$ git log a7e38c146..8e3a22b7d --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1649703003

Cr-Commit-Position: refs/heads/master@{#372073}

Revert of Remove references between RTCPeerConnection and RTCDataChannel. (patchset #3 id:40001 of https://codereview.chromium.org/1634073003/ )

Reason for revert:
It turns out that the underlying WebRTC DataChannel  objects does not maintain a reference to the WebRTC PeerConnection, so we do need to keep the reference in the blink layer.

PS2 was the correct patch.

Original issue's description:
> The underlying WebRTC objects maintain all the needed references.
> No references are actually needed in the blink layer.
>
> BUG=564965
>
> Committed: https://crrev.com/0004ce15cdf065966508c61a5265ae8662e363ed
> Cr-Commit-Position: refs/heads/master@{#371667}

TBR=tommi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=564965

Review URL: https://codereview.chromium.org/1641113002

Cr-Commit-Position: refs/heads/master@{#372072}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bbcc7be6..e77121fb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1641083002

Cr-Commit-Position: refs/heads/master@{#372071}

DCHECK_EQ gets confused with pending webrtc changes which make
VideoRendererInterface inherit VideoSinkInterface.

Review URL: https://codereview.chromium.org/1642873002

Cr-Commit-Position: refs/heads/master@{#372070}

Oilpan is enabled on ToT, and is reading from TestExpectations and
has no Expectations file of its own (for now).

Mark the test as a flake and place it in TestExpectations "Oilpan"
area of that file.

BUG=581974
TBR=kojii@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1641133002

Cr-Commit-Position: refs/heads/master@{#372069}

This test disables
NaClBrowserTestPnaclNonSfi.IrtManifestFile
NaClBrowserTestPnaclNonSfi.IrtException
NonSfiPackagedAppTest.SuccessfulLoad
which are failing on Linux. I cannot attribute the failure to a specific CL so
I have to disable them.

TBR=mseaborn@chromium.org,bbudge@chromium.org
BUG=579804

Review URL: https://codereview.chromium.org/1647773004

Cr-Commit-Position: refs/heads/master@{#372068}

WebRTC 11357:11409

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7e9eaec..6ca529d

Libjingle 11358:11412

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/b62ca7e..420a246

TBR=
BUG=

Review URL: https://codereview.chromium.org/1643933002

Cr-Commit-Position: refs/heads/master@{#372067}

Oilpan is enabled on ToT, and is reading from TestExpectations and
has no Expectations file of its own (for now).

Mark the test as a flake and place it in TestExpectations "Oilpan"
area of that file.

BUG=581974
TBR=kojii@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1648613002

Cr-Commit-Position: refs/heads/master@{#372066}

Move shape-outside/webkit-clip-path property
handling from LegacyCSSPropertyParser into CSSPropertyParser.
To make this possible I converted the code for
parsing <shape-box> and <basic-shape>.

Also add code that was missing for handling
repeating-linear-gradient().

BUG=499780

Review URL: https://codereview.chromium.org/1603193002

Cr-Commit-Position: refs/heads/master@{#372065}

Oilpan is enabled on ToT, and is reading from TestExpectations and
has no Expectations file of its own (for now).

Mark the test as a flake and place it in TestExpectations "Oilpan"
area of that file.

TBR=haraken@chromium.org,ksakamoto@chromium.org
BUG=299010
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1641123002

Cr-Commit-Position: refs/heads/master@{#372064}

This strips out a lot of dated content, focuses more
on practical usage, and significantly shortens the doc.

Less yawning for everyone!

BUG=None
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1641053003

Cr-Commit-Position: refs/heads/master@{#372063}

TBR=haraken@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=581987

Review URL: https://codereview.chromium.org/1642883002

Cr-Commit-Position: refs/heads/master@{#372062}

Revert of [mojo] Enable ServiceRegistryImpl to override remote services (patchset #12 id:220001 of https://codereview.chromium.org/1470153002/ )

Reason for revert:
Causing Oilpan leak bot failure

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/17113

Original issue's description:
> [mojo] Enable ServiceRegistryImpl to override remote services
>
> This adds a new AddServiceOverride method to ServiceRegistryImpl.
> The purpose of this is to allow testing code to intercept remote
> service connections and opaquely provide a mock implementation of
> any service.
>
> The new interface is also added to the ServiceRegistry's JS
> bindings.
>
> Committed: https://crrev.com/9b0d7173af550086d5688137752a6f70109e9c98
> Cr-Commit-Position: refs/heads/master@{#371736}

TBR=jam@chromium.org,reillyg@chromium.org,rockot@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review URL: https://codereview.chromium.org/1639233004

Cr-Commit-Position: refs/heads/master@{#372061}

Review URL: https://codereview.chromium.org/1643513002

Cr-Commit-Position: refs/heads/master@{#372060}

virtual/threaded/printing/ellipsis-printing-style.html
virtual/threaded/printing/iframe-print.html
printing/ellipsis-printing-style.html
printing/iframe-print.html

Started happening after the rebasleines for the associated
CL [1] landed.

[1] https://code.google.com/p/chromium/issues/detail?id=390040#c14

TBR=wkorman@chromium.org,chrishtr@chromium.org
BUG=390040
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1649713002

Cr-Commit-Position: refs/heads/master@{#372059}

Revert of Let notifyScriptLoadError() handle already detached ScriptLoaders. (patchset #3 id:40001 of https://codereview.chromium.org/1644483002/ )

Reason for revert:
The change here assumes PendingScripts are separately allocated objects, an M50 change. This makes for more difficult backporting. Unnecessarily so.

Hence reverting and will reland a variation ( https://codereview.chromium.org/1642863002/ ) that works for older branches.

Original issue's description:
> Let notifyScriptLoadError() handle already detached ScriptLoaders.
>
> If a ScriptRunner has been disposed of already, allow ScriptLoaders
> to notify of their failure without asserting.
>
> R=haraken
> BUG=570012
>
> Committed: https://crrev.com/e7bf58190483dffac8e78506884170720165b198
> Cr-Commit-Position: refs/heads/master@{#371772}

TBR=haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=570012

Review URL: https://codereview.chromium.org/1640263004

Cr-Commit-Position: refs/heads/master@{#372058}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e85d78f6..bbcc7be6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1638303004

Cr-Commit-Position: refs/heads/master@{#372057}

This reverts commit 13eeea65.

The original CL was suspected of causing an 18.4% regression in
dromaeo.domcoreattr at 370280:370316 on Android Galaxy s5, so reverting
this to see if the bots recover.

reverts: https://codereview.chromium.org/1602843003

BUG=580981

Review URL: https://codereview.chromium.org/1642473002

Cr-Commit-Position: refs/heads/master@{#372056}

Add WebFont.FontDisplayValue histogram that measures which fallback mode
is specified in font-display @font-face descriptor.

BUG=564447

Review URL: https://codereview.chromium.org/1647823003

Cr-Commit-Position: refs/heads/master@{#372055}

This change adds trace events to ThreadedDataProvider. Even though the
feature is still disabled by default, having trace events helps us
investigate the behavior locally.

BUG=581992, 277124
R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/1640283004

Cr-Commit-Position: refs/heads/master@{#372054}

The image encoder runs on a background worker thread, which is not attached to Oilpan.
Thus CanvasAsyncBlobCreator::m_callback touched by the image encoder must use CrossThreadPersistent.

BUG=581877

Review URL: https://codereview.chromium.org/1641743005

Cr-Commit-Position: refs/heads/master@{#372053}

Disable the test because it fails on Linux. See bug for details.

TBR=kelvinp@chromium.org
BUG=582005
notry=true

Review URL: https://codereview.chromium.org/1649683002

Cr-Commit-Position: refs/heads/master@{#372052}

On iOS, we know whether the page has displayed insecure content; this CL
propagates that information to SecurityStateModel::VisibleSecurityState.

As far as I can tell, the resulting value isn't used by anything on the iOS
port, so this CL will not result in any visible change at the current time.

Review URL: https://codereview.chromium.org/1578273002

Cr-Commit-Position: refs/heads/master@{#372051}

Revert of Add deprecation message for -webkit-background-composite (patchset #11 id:200001 of https://codereview.chromium.org/1585383003/ )

Reason for revert:
Broke fast/backgrounds/webkit-background-composite-deprecated.html most bots.  Example:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/48981

Original issue's description:
> Add deprecation message for -webkit-background-composite
>
> This patch is two fold:
> 1. Adds the capability of adding deprecation messages for CSSPropertyIDs
> as they are parsed.
> 2. Adds the relevant deprecation message for
> -webkit-background-composite. The reasons for which are highlighted here
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/thxrbc8XOmc
>
> BUG=498588
>
> Committed: https://crrev.com/6d2d7c3b60d3e5cd9b2efd7120cae737ad1e4329
> Cr-Commit-Position: refs/heads/master@{#372040}

TBR=alancutter@chromium.org,timloh@chromium.org,nainar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=498588

Review URL: https://codereview.chromium.org/1648593002

Cr-Commit-Position: refs/heads/master@{#372050}

The assert that is firing is very concerning and is still being
investigated.

BUG=577121

Review URL: https://codereview.chromium.org/1649443002

Cr-Commit-Position: refs/heads/master@{#372049}

This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.

BUG=581626

Review URL: https://codereview.chromium.org/1638303002

Cr-Commit-Position: refs/heads/master@{#372048}

Cr-Commit-Position: refs/heads/master@{#372047}

The CVDisplayLink is tied to a ScopedTypeRef data member of DisplayLinkMac.
However, there may be other references. Since there's no guarantee that
~DisplayLinkMac() will invoke the last CVDisplayLinkRelease(..) and clear
the callback automatically, clear it explicitly in ~DisplayLinkMac.

BUG=564780

Review URL: https://codereview.chromium.org/1637353002

Cr-Commit-Position: refs/heads/master@{#372046}

There are two element style recalc counters, one in Document, and one
in StyleResolver. The one in StyleResolver includes pseudo elements in
that count. We are unifying thesie counts keeping pseudo elements
included which means that the element recalc count will be higher for
tracing and the inspector, but unchanged for
internals.updateStyleAndReturnAffectedElementCount().

Also the StyleResolverStats is moved from StyleResolver to StyleEngine.
This means the stats will survive a clearResolver().

This change is motivated around item 6 and 9 in the design document for
crbug.com/401359.

R=dstockwell@chromium.org
BUG=401359

Review URL: https://codereview.chromium.org/1644543002

Cr-Commit-Position: refs/heads/master@{#372045}

Originally only sysex permission requests are exposed to the
content layer, but with this series of patches, all Web MIDI requests
will be exposed to the content layer so that each chromium embedder
can decide how to decide several permissions.

First of all, expose all requests outside Blink.
Changes for the permission service will follow as a separate patch.

BUG=535181

Review URL: https://codereview.chromium.org/1602703005

Cr-Commit-Position: refs/heads/master@{#372044}

Note: not adding a seperate Oilpan entry, just mark it flaky while
Oilpan is enabled on ToT.

TBR=eae@chromium.org,harken@chromium.org
BUG=581990
NOPRESUBMIT=true
NOTRY=true

Review URL: https://codereview.chromium.org/1643903002

Cr-Commit-Position: refs/heads/master@{#372043}

As per the CPP style guide, variables declared constexpr or const, and whose
value is fixed for the duration of the program, are named with a leading "k"
followed by mixed case. Since objects don't have a constant value for the
duration of the program, refactor "kTestString" to "test_string".

Review URL: https://codereview.chromium.org/1649573002

Cr-Commit-Position: refs/heads/master@{#372042}