GitLab

This most likely regeressed in
https://chromium-review.googlesource.com/c/chromium/src/+/2258955

In that CL, I moved the implementation of NavigateLocalAdsFrame() from
document.cc to oom_intervention_impl.cc. The only behavior change I can
see is that instead of giving FrameLoadRequest an origin context in its
constructor, I switched it to nullptr.

The crash reports aren't providing terribly useful stack traces, but my
guess is that this is crashing at
https://chromium.googlesource.com/chromium/src/+/962a6c5c187940f445c958c627875113ca31297a/content/renderer/render_frame_impl.cc#5685

RequestorOrigin() is DCHECKed non-null at the start of the function, but
I believe it would be null if FrameLoadRequest was given a nullptr
origin context.

Bug: 1101967
Change-Id: I573e8c13adc8d26fa10644f77c4b609ebfe0ccfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283257Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785783}

Bug: 1068400
Change-Id: I78bf887c091b2dc16b1b7bfd53c98e797b586148
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283049Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785782}

Uses a single method for determining whether a node is a text node throughout the accessibility codebase

This patch takes us one step closer to merging AXNodePosition with BrowserAccessibilityPosition.
A single method, AXNode::IsText(), is now used to determine whether a node in the accessibility tree is a text node.

Also, took the opportunity to search the entire codebase for narrower role checks and replace them with AXNode::IsText().
More specifically the following usage patterns were replaced:
role == ax::mojom::Role::kStaticText / kInlineTextBox / kListMarker
ax_role_properties > ui::IsText() / ui::IsTextOrLineBreak()

AX-Relnotes: n/a.

R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 1049261
Change-Id: Ie3ecda66e75a0df6c6f460c2d2855db6d1705ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282744
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785781}

No logic changed.
Signed-off-by: WangHui <wanghui210@huawei.com>
Change-Id: Iacf0dfa0e17195378c0cc998c00750196f3383a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282834Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785780}

Starting with iOS 11, apps can ask for write-only access to photos. This
CL switches ImageSaver to use the new write-only API. It also removes
calls to the read-write PHPhotoLibrary APIs and removes code that checks
the photos authorization state, since there is no way to check the value
of the write-only permission in advance.

BUG=1102479

Change-Id: I245149c8480e9e02fa0c6218aa652bd26c9f7c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283654
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785779}

This CL simplifies the visibility state of the player so that there are
fewer mVisible* lists and instead uses the visibility property of View.

Bug: 1099722
Change-Id: I57745d54f0e8447e9abc83c8e7394838a2a19c36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273460Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Fred Mello <fredmello@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785778}

Add non removable block device info to the probe service.

Bug: b:158658869
Change-Id: I6f125a5127372040c884f24a11ac38391beca753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268797
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785777}

... instead of WebMediaStreamSource.

CL also converts DidStopMediaStreamSource() in html_media_element_capture.cc.

BUG=704136
R=guidou@chromium.org

Change-Id: Id88fe7e809210885157af84a5dc7b746b0a7f18f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283583
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785776}

This reverts commit 39804b20.

Reason for reland: The code that was crashing before has been deleted.

Original change's description:
> Revert "Sync cleanup: Remove DEPRECATED_EXPERIMENTS ModelType"
> 
> This reverts commit df3250dd.
> 
> Reason for revert: Suspected of causing crashes, see crbug.com/1047879
> 
> Original change's description:
> > Sync cleanup: Remove DEPRECATED_EXPERIMENTS ModelType
> > 
> > It has been deprecated and unused for a while.
> > The specifics proto itself can't be removed yet because it's still used
> > on the server.
> > 
> > Bug: 1009361
> > Change-Id: Ic183a6e244435cfce60ccdda34bff3e22a032ff3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022670
> > Commit-Queue: Marc Treib <treib@chromium.org>
> > Reviewed-by: Jan Krcal <jkrcal@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#736397}
> 
> TBR=treib@chromium.org,jkrcal@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1009361, 1047879
> Change-Id: I762fbf6f1b4b752a47b34e6a101a066d0c78aebc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036005
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738205}

TBR=treib@chromium.org,jkrcal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1009361, 1047879
Change-Id: I104a665136b4b6e74b36c03e0bb09c8e57d76bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282816Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785775}

This CL does the following:
* Introduces OWNERS files in folders that did not have one.
* Adds WPT-NOTIFY to get bugs on failures from upstream.
* Sets speed-metrics-dev@ as the team.
* Updates some specific owners in some cases.

Change-Id: I6b0da49a7abb34e9b4a69513942f955967df6433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283418Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785774}

Add InstallResult and UninstallResult to histograms.xml and enums.xml
to collect the metrics of the results of Install and Uninstall calls
to dlcservice.
DLCs are ChromiumOS Software packages that are installed in the
stateful partition.
These metrics are needed to know if the installation or unistallation
of the DLC modules is successful or not.
Details on the DLC metrics can be found in
chromiumos/platform2/+/refs/heads/master/dlcservice/metrics.h or
chromium:2265289 and chromium:2246295 and chromium:2274742.

BUG=chromium:1069121
TEST=None

Change-Id: Ib710e5193e25c56667cc1cb864b9c31821b7cdf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267448
Commit-Queue: Andrew Lassalle <andrewlassalle@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785773}

This CL handles launching selected profile from the profile picker and
then closing the picker.

Bug: 1063856
Change-Id: I5bfd15a115503dad2749f21f159cb8df25ed0a05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279890
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785772}

After the changes to convert to SIMD several operations in
WebAudio oscillator node, GCC refuses to compile a call to _mm_cmplt_ps
since we try to store it in m128i, but mm_cmplt_ps returns an m128.

To fix that, we reinterpret_cast<__m128i>, as that's how we want to
interpret the bits.

Verified with webaudio/Oscillator/* web tests.

Bug: 819294
Change-Id: Ia00a7695476e84996548b6c679ffeedead49213b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247792Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#785771}

Similar to previous fix to oscillator node. In GCC, an implicit cast to
m128i of the result of mm_cmplt_ps is not valid. In this case, as the
next usage of the return value is already an m128, we just change the
type of the return value to m128 too.

Bug: 819294
Change-Id: I9ae9103a837920a5bfe432d7c81930bb4a5fce78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283211Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#785770}

This patch removes the 'toolbar textbox aplha' param from the native
methods since it is always 1 and the 'view height' param since it is
unused. The visibility param in the SceneLayer has also been removed
as it is handled by one of the SceneOverlay interface methods.

Bug: 1100332
Change-Id: Ia43c405ede070bc4d2ac3b95e00f7b35ac94628c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278168
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785769}

Work is on going to port this feature to other platforms, notably
OSX and CrOS. Extending the expiry will help developers.

Change-Id: Id24eb3e54e3db48bc4240268137ffd27761135b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284922Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Auto-Submit: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785768}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9eb2d25b67f1..1402ed576596

2020-07-07 rharrison@google.com Roll 6 dependencies and update expectations. (#1097)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: radial-bots+chrome-roll@google.com
Change-Id: Ifddd5d9105f5dd3e4769017990b350d374e090d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284801Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785767}

In the passwords settings page, the savePasswordsItem variable can be
unset when passwords are managed by policy. The
setSavePasswordsSwitchItemEnabled needs to check for that before
enabling/disabling it. Otherwise, it causes a nullptr crash when
swiping existing passwords to delete them.

Also fixes a bug introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/2219569
where the switch value would be reset to on when swiping a password.

Bug: 1101325
Change-Id: Icde314a7f1dccbee688f7fe882f44c7754c034b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281165Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785766}

https://crrev.com/544756 ("Make <foreignObject> a stacking context")
added svg-isolation-foreign-isolation.html which had an incorrect
expectation. ForeignObject should create a stacking context [1] and
everything that creates a stacking context is an 'isolated' group [2],
so foreignObject should isolate. Our implementation is correct for html
content in foreignObject but has a bug for svg content in foreignObject.
This patch creates WPT tests for these two scenarios, and marks the svg
variant as failing.

[1] https://svgwg.org/svg2-draft/single-page.html#render-EstablishingStackingContex
[2] https://drafts.fxtf.org/compositing-2/#csscompositingrules_CSS

Bug: 1102803, 1101002
Change-Id: Ia5baceccab0be09eeec5e4682f16247a2881509b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284631
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#785765}

There are reports that destroying Sequence can be expensive, and lock up
other threads. So destroy it outside of the gpu::Scheduler lock.

Bug: 916977
Change-Id: I774cf8188e81f5ebed5fd37edd45278b415df7cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277110
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785764}

Passing the current state is unnecessary; not all callers care, and
those that do can simply ask for the state, which is cheap.

Passing the Widget* in question is in some cases unnecessary as well.

The primary motivation for this minor cleanup is to minimize a future
CL's functional diff.

Bug: none
Change-Id: I7f526015c7c8ba238723f74e68bcadf8f5c9e944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283658
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785763}

Titles should be set if the title UI param is enabled regardless of
whether the suggestion is allowed to be default.

Bug: 1062446
Change-Id: I58b49813f365341aed060ea603eb6eba9b36aa46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278629
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785762}

This adds new breaking conditions for navigations while in the
RUNNING state.

For non-renderer-initiated navigations the flow now breaks in RUNNING
where previously only PROMPT was breaking.

Full list of what is allowed and what isn't can be found in
content/public/browser/navigation_handle.h (IsRendererInitiated)

Bug: b/159309621
Change-Id: I6b6055fd213ca48e0130c48c4d1daa606bdc0fe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283342
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785761}

The test was disabled on Windows a while ago due to flakiness. Since
significant amount of time already passed there is a chance that
flakiness already gone.

Bug: 1045619
Change-Id: I0abd1d751127ec2174e39f15eae773becc105690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283592Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#785760}

Bug: 1081786
Change-Id: I79065f3c4faabaed1f7b28b6db306ba736e0a797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278420Reviewed-by: Jon Mann <jonmann@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785759}

This CL implement the animation for tab switch from Omnibox suggestions.
Try to match the animation in IOS, if new tab's index is smaller than
old one, new tab slide in from left. If new tab's index is larger than
old one, new tab slide in from right.
Also, the animation time is matching IOS at
https://source.chromium.org/chromium/chromium/src/+/master:ios/chrome/browser/ui/tabs/switch_to_tab_animation_view.mm;l=15.


Bug:1092268, 1101517

Change-Id: I5b6c6fa8c290130a3f7fdbc9818a2ac40179cfef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276806
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785758}

This CL:
(1) Allows backward navigation on DontProceed if possible and there
is no suggested URL.
(2) Uses the button text 'Close page' instead of 'Back to safety'
in cases where the tab will be closed (no suggested URL and can't
go back).
(3) Records metrics when the interstitial is closed.
(4) Removes unused InterstitialParams reference, adds TODOs for
handling reloads/redirects and the DontProceed navigation, and
changes a function name for consistency.

Bug: 1058898
Change-Id: I5b017072a3b650cbf0479ab9df17ac91d9260a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274250
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785757}

When policy changing name, _CheckDeprecatedFutureField() function crash
as there is no |new_policy| instance.

Add a check in the first call to resolve the issue. Note that, for
renamed or new added policy, it should be verified by the second call
which always has the |new_policy| instance.

Bug: 1076560
Tbr: pastarmovj@chromium.org

Change-Id: I32d6e9b8b8b00cb9db4a1d34e0023aa8060fe6ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284611
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785756}

ShillServiceClient::ActivateCellularModem calls a deprecated
Shill method that returns an error.

This removes the functionality from Chrome and any classes that
call into it.

Bug: 1021688
Change-Id: Ideb04bbd3488e0bee1561fa25151a2ee8d5ac9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283308Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785755}

TBR=bling-team@google.com

Change-Id: I0267238c608257e109275d45e7274370100815c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284046Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785754}

... instead of WebMediaStreamSource.

BUG=704136
R=guidou@chromium.org

Change-Id: I1fa66c014c6b4be44d774dd7a5b81eb2da40a3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283390
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785753}

This change replicates an update in native SortAndCull method to
skip past specialized suggestions when partially grouping suggestions
by search vs url.

The specialized suggestion types that are intentionally skipped are:
- default match
- query tiles
- clipboard

Corresponding native change: https://crrev.com/c/2266012

Bug: 1091098
Change-Id: If9446f60561f013948876a7ec38ff87e0cd8deed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268228Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785752}

This CL connects the PasswordCheckFragmentView with the controller code
by introducing a ViewBinder to set properties.
Additionally, a view test covers that model data is rendered as
expected.

Bug: 1101256,1092444
Change-Id: Id3afbb6a559bbaf6c0c8e267ecec322f7a4b75a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279117
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785751}

Annotate SettingType constans with their availability regarding
WebLayer version.

In particular BASIC_SAFE_BROWSING_ENABLED is available since
M84, other settings are available since M85.

BUG=1102072

Change-Id: If37fd1d9d78c50eb7eef0f41a28eef8e03f3ce3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281341Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785750}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0b6df3ba1a45..8bf8ca6dc7f2

2020-07-07 aerotwist@chromium.org Fix tsconfig generation paths
2020-07-07 tvanderlippe@chromium.org Migrate IdentityFormatter to TypeScript
2020-07-07 tvanderlippe@chromium.org Add OWNERS for test/conductor
2020-07-07 alexrudenko@chromium.org Fix stylelint-config-standard issues in sources/javaScriptBreakpointsSidebarPane.css
2020-07-07 tvanderlippe@chromium.org Extract copy to resources into separate template
2020-07-07 alexrudenko@chromium.org Fix snippet saving and search

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1066415,chromium:1083142,chromium:1098730
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I2ed9710ec2ea19cb56e4a5a03066a9764b5bcde8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284793Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785749}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f5ed7a69d5d6..ba17d8bcf0dc

2020-07-07 johnkslang@users.noreply.github.com Merge pull request #2324 from ben-clayton/gitignore

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com
Change-Id: Iad350550445b947e608be6bb855e95366e948df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284798Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#785748}

This method was a relic from an earlier version of this code, when the
animation faded the path from a given starting color to a given ending
color. In that version, HasStarted() was necessary to avoid duplicate
animations, which would cause a flicker. For example, an initial user
interaction would start to animate the path from opaque to transparent,
and a subsequent user interaction while still animating could restart
the same animation, causing the path to flicker from a midpoint color
back to opaque to start the animation again. To avoid this flicker, I
introduced HasStarted() to avoid running a given animation more than
once.

But the new ElideAnimation version of the code animates from whatever
the current state is to the desired end state. This means that
restarting a duplicate animation is a no-op and doesn't cause any
flicker, so we can get rid of HasStarted(). I've also added unit tests
for the cases where HasStarted() was used.

Bug: 1099875
Change-Id: I53af1ae2437fbe24e6646c99d743f0af2a398ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278164
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785747}

Change-Id: I20b611fde0d4787a7c189ad858f2a0b10b3bee07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284493
Auto-Submit: Roberto Moura <mouraroberto@google.com>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785746}

Bug: 1068400
Change-Id: I0ad00960726f92cdc2862efa1060422612d65a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247403Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#785745}

Before this CL, BrowsingDataRemover did not expose the concept of
"deletion failure", i.e. when a requested deletion could not be
completed. (An example of such a deletion failure is a timeout, which
BrowsingDataRemoverImpl sets to 30 seconds.)

This CL adds the concept of "failed data types" to the API. They're
represented as a bitmask of DataTypes - the same format that's used to
request deletion in the various Remove*() methods.

So far, the only data type that will actually report deletion errors is
DATA_TYPE_PASSWORDS, but support for more types can easily be added.
None of the clients/observers does anything with the new information
yet; that's left for a future CL.

Bug: 1086433
Change-Id: I24b62c4da7d5c2739f47f3b599918d4643758411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260636Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785744}