- 23 May, 2019 40 commits
-
-
jonross authored
In order to support Mus, we added a series of methods to allow Aura to request the allocation of a new LocalSurfaceId. This allowed both aura/mus and cc/ to generate these Ids. As Aura was not responsible for ParentLocalSurfaceId allocation, the Window Service was. With the removal of Mus, this code path is no longer needed. This change reverts that path. Leaving cc/ solely in charge of child allocation. This change is a merged revert of four changes: Revert "chromeos: gets aura as mus client library working with client ids" This reverts commit 2b5a978b. Revert "chromeos: gets aura as mus client library working with client ids" This reverts commit 2b5a978b. Revert "cc: provides function to synchronously allocate LocalSurfaceIds" This reverts commit 39db70bb. Revert "Call function when LayerTreeHostImpl generates a LocalSurfaceId" This reverts commit 7a340f40 TEST=cc_unittests Bug: 958239 Change-Id: Ie81d68f9dc6a6ff0bc57acccc5e9182bf819af95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625394Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#662833}
-
Ned Williamson authored
This CL contains a basic fuzzer for WebGL shaders that shows some essential design ideas: 1) a protobuf spec defines how shaders will be generated 2) conversion from protobuf message to shader string is provided in its own library that has unit tests 3) we add a basic fuzzer to compile shader programs using libANGLE This is by no means complete and serves as a foundation for the fuzzer so subsequent CLs will be easier to review. Later CLs will slowly complete the core grammar for GLSL before incorporating some more complex testcases from the Khronos compliance suite. BUG=900487 Change-Id: I67df52a73926d22637afad9a966790f34011175c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623556 Commit-Queue: Ned Williamson <nedwill@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662832}
-
Shivani Sharma authored
This is a temporary fix so that the intervention does not break back button for pdfs. The root cause is that mouse click on pdf is not considered a user gesture (crbug.com/934637). Once this is fixed, then this CL's changes can be removed. Bug: 965434 Change-Id: I15d8392e98d1578a1c30f242c847fbcf8e4bd8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623137 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662831}
-
Vincent Boisselle authored
This reverts commit a2d78e6e. Reason for revert: breaks components_unittests:AutofillDownloadManagerTest.QueryAPITestWhenTooLongUrl unittest in android-kitkat-arm-rel See https://ci.chromium.org/p/chromium/builders/ci/android-kitkat-arm-rel/17779 Original change's description: > Reland "Reland "Added handling of large requests to Autofill API."" > > This is a reland of 4149e2e9 > > Original change's description: > > Reland "Added handling of large requests to Autofill API." > > > > This is a reland of c6677df1 > > > > Original change's description: > > > Added handling of large requests to Autofill API. > > > > > > Increased the limit of Query GET requests, added a POST Query fallback, and > > > added UMA metrics to keep track of URL length and associated events. > > > > > > This change might be needed when metadata is enabled. > > > > > > Bug: 948862 > > > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615 > > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#656080} > > > > Bug: 948862 > > Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > Cr-Commit-Position: refs/heads/master@{#656452} > > Bug: 948862 > Change-Id: I8fdc33c0e496862232dfed6e13349e55fbd36e07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594190 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Commit-Queue: Vincent Boisselle <vincb@google.com> > Cr-Commit-Position: refs/heads/master@{#662780} TBR=rogerm@chromium.org,ftirelo@chromium.org,vincb@google.com Change-Id: I0f5f9fb013fcb17b443e0def188f237707dfa5c0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628032 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662830}
-
Chris Morin authored
Simplify the upgrade failure handling by ignoring the result of the dbus call, and instead waiting for the ArcInstanceStopped signal before signaling a failure. Also check for disk space in Chrome instead of in session_manager. This is the first change in a series that will have Chrome call to Upstart directly to start the container, cutting out session_manager entirely. BUG=b:133248517 TEST=Run test cases and manually test container startup/shutdown. Change-Id: I7c5ef4be82b5fbb2deca1fae7a2a0ebc06952e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623631 Commit-Queue: Chris Morin <cmtm@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662829}
-
Robert Ma authored
* Also fetch DETAILED_ACCOUNTS in query_cl to make sure we have owner info (altough currently the only user of that method doesn't need it). * Do not fetch DETAILED_LABELS as we never use it. * Extract query options into a constant now that two methods use the same options. * Exclude WIP CLs in query_exportable_open_cls and get up to 500 CLs to reduce the chance of missing in-flight exportable CLs. Change-Id: I308f6d8e730940b15f40fdb0aa2d61f9b86d6369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626301 Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#662828}
-
Jon Mann authored
Bug: 966270 Change-Id: I12169fe0f9e56364c7839521e478008faf3be604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626638 Commit-Queue: Jon Mann <jonmann@chromium.org> Auto-Submit: Jon Mann <jonmann@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#662827}
-
Dana Fried authored
Make sure that the callback is not null, and that we use the widget that is reported being closed rather than calling GetWidget() - just in case the view has somehow come unglued from the widget. I really can't think of any other way this could crash. Bug: 966308 Change-Id: Ic0c2ee9adb8b1e26326c1300238db058e5022819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627817 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#662826}
-
Maksym Onufriienko authored
Added closeCurrentTab in smoke_egtest. Bug: 922813 Change-Id: I79f5066d068f38b97af4527b6c2b1562bd2a3a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625849 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#662825}
-
Dmitry Titov authored
Change-Id: I5f4a016bb924eaf227f4df23b1ffae37bc02cc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625815 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#662824}
-
Stephen Martinis authored
This is (as far as I know) the first time chromium is using containment, so I'm enabling on a bot which shouldn't affect the CQ that much. Once this lands, I'll enable on the rest of the CQ bots. Bug: 965222 Change-Id: Ie0f85f50eec68c4de89f12047209b9ad570ec129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626149Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#662823}
-
Andrew Grieve authored
This flag doesn't exist, and so test_runner.py has been passing it through as a chrome flag to tests :P Change-Id: I562e5c62a9a3fa7caf4b7bdfd49713d0f21d7774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625837 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662822}
-
Morten Stenshorne authored
A video element creates some children (flexboxes, etc.), and the video ought to be their containing "block" for all purposes, but LayoutVideo is not a LayoutBlock (it's LayoutReplaced), so it doesn't really work. Make sure that we don't skip upwards and escape from the innards of the video element and start adding percentage descendants to blocks that are not in the containing block chain of the video (the video may be out-of-flow positioned). Bug: 965032 Change-Id: Ic9fdb7b9dcff5724b9488d85dfafc9c87f4bee62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622806Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#662821}
-
Aga Wronska authored
Bug: 963696 Change-Id: Ib60cbe41bdd99d45625e6b0950c6bda738a06349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611026Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#662820}
-
rbpotter authored
Rename canUsePolyfill -> can_use_polyfill Bug: 925517 Change-Id: I0a5575f1193f4379c4cc8cd5fcc4ba1214145d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627854 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#662819}
-
Lily Chen authored
This change adds a virtual test suite which enables CookiesWithoutSameSiteMustBeSecure and adds a new tentative test to test that (with the feature enabled) cookies with SameSite=None must have the Secure attribute, and will be rejected otherwise. Bug: 961439 Change-Id: Icd99b6fc9ef38f72b648fb81f3fd0aa241e75a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612052 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#662818}
-
Abhishek Arya authored
R=rnk@chromium.org Bug: 915245 Change-Id: I715d3e0ea051e1032722e77795c11e58875b7413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627810Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#662817}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9fa0744e82b..6bb193c86a9a git log d9fa0744e82b..6bb193c86a9a --date=short --no-merges --format='%ad %ae %s' 2019-05-23 spang@chromium.org Vulkan: Implement glImportSemaphoreFdEXT Created with: gclient setdep -r src/third_party/angle@6bb193c86a9a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: Ie88022a70fc0e00f19abf48115aaa277a4f9ac15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662816}
-
Xi Han authored
Recently we noticed that the histogram data is lost when Chrome is running in the reduced mode and get killed before the full browser starts. This is because there isn't a SystemProfile set in the reduced mode. Thus, the previous data in the BrowserMetrics-active.pma file isn't picked up by Chrome the next time it is launched in the full browser mode. In this CL, we write the initial system profile to the mapped memory file, so Chrome will pick up the data when it restarts in the full browser mode. Note: the histogram data is only persistent on the memory mapped file, but not being uploaded when Chrome is running in the reduced mode. Bug: 959854 Change-Id: Idc1cea6edfa854edf94f791f2df8a9ebb6a0af8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601307Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662815}
-
Eric Willigers authored
When we have more than 10 files, or more than 50 megabytes in total file size, the share request in rejected. BUG=903010 Change-Id: Ib7a50e7fbfdd00fecb4eaa6a73f0dec00f6ea8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626913 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#662814}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, dropping the Bitmap in ViewResourceAdapter would make isDirty() return true, which would cause re-drawing the next time this UI resource is used in the compositor layer. There is another copy of the Bitmap in native land, so keeping the Java copy for longer than necessary is wasteful. This CL allows dropping the Bitmap without affecting isDirty(), so that we can drop it more frequently without causing re-draws. Bug: 965580 Change-Id: I41f930b0c034b7f373b4c9868ff29a85372a2074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622747 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#662813}
-
Xing Liu authored
When the feature is enabled, some tests will fail, this CL provides a temporary remedy for UpdateMenuItemHelperTest. Bug: 965106 Change-Id: Ie246ca1fdfdb91e317b17d5e3f0e95d9d60808bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625968 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#662812}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/2a20a6899d0b..f3f089d8833e git log 2a20a6899d0b..f3f089d8833e --date=short --no-merges --format='%ad %ae %s' 2019-05-23 Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@f3f089d8833e The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I1577aa616f30fab26d68641243cf26f20d3c289e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627950Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662811}
-
Pedro Amaral authored
The tab strip uses the BottomToolbarButton style. The label CL modified that style and it broke the tab strip buttons. This CL reverts the BottomToolbarButton style to what it used to be and introduces a new style, SplitToolbarButton, for use in the split toolbar. Bug: 966355, 966356, 966357 Change-Id: I83f53649fad8e109d0a267eb7fb26e8e4e5c286e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625966Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#662810}
-
Andrew Grieve authored
Change-Id: I788538d4a9036dae160ff5e2cb5a5bd2a1ad068d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622898 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#662809}
-
Jeffrey Cohen authored
The SendTabToSelf feature added the capability to track if a shared tab has been opened on the receiving device as preparatory work for exposing these shared tabs in a history UI. This CL exposes that existing functionality to the Java UI layer by adding it to the SendTabToSelfAndroidBridge. Bug: 961807 Change-Id: Ia8355a9eff4162a2036f669d2ead590d8289256c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611309 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#662808}
-
Ryan Hansberry authored
Bug: 966217 Change-Id: Ia6be6918ee66692608035e84c0d5fb7d12ab8775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626673Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#662807}
-
Dale Curtis authored
BUG=879406 TBR=liberato Change-Id: I9a25b69c03edb29e35fcdcb9eb5f69cf7626b461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627663Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#662806}
-
Hongchan Choi authored
When a page/frame is refreshed, some BaseAudioContexts from the previous page stay in WebAudioModel object. This is because of a flaky behavior of BaseAudioContext::ContextDestroyed(). To make it clear and consistent, this change will flush WebAudioModel whenever a page/frame is loaded. Bug: 965310 Test: Locally confirmed the view panel is updated when the frame is loaded. Change-Id: I6e35dc0694e743f80ee063e76b0b9affc74ea75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626531 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#662805}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e073100d205..617f67de972a Created with: gclient setdep -r src-internal@617f67de972a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:947531 TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Ied6fea4db31435728532d6648e5961ca69c1bba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627856Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662804}
-
Garfield Tan authored
BUG=b:132979912 TEST=CQ is more than enough. Change-Id: Idcb4be6661cfa7ea6f9eb2661499b3797f536eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626152Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Commit-Queue: Garfield Tan <xutan@chromium.org> Auto-Submit: Garfield Tan <xutan@chromium.org> Cr-Commit-Position: refs/heads/master@{#662803}
-
Kyle Milka authored
Bug: 937570 Change-Id: Iafb722681a1cbb420edf9b0d406e8591a27688ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626679 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#662802}
-
Steven Bennetts authored
This CL: * Introduces mojom::CrosNetworkConfig::SetNetworkTypeEnabledState to replace the enable/disableNetworkType APIs in networkingPrivate * Uses the API in NetworkFeaturePodController and removes the NetworkState dependencies. * Uses TrayNetworkStateModel in VPNFeaturePodController and removes NetworkState dependencies. * Cleans up some missing const qualifiers in TrayNetworkStateModel. Bug: 862420 Change-Id: Ib43092dde79f9c80477234020a49751bc4c3620e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623486Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#662801}
-
Moe Ahmadi authored
Fixes a bug where the option to offer Translate was enabled for the Translate target language because it was not being considered the last Translate-blocked language. - Changes LanguageItem.blocked to include those languages that are not supported by Translate server as well as the Translate target language. - Also removes a method from the consumer interface as the information on whether a language is the Translate target language can be passed on in the language item itself. Bug: 957688 Change-Id: Ib67ce8d8887c75a6adf5b0c5574ff4bda0494e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625918Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#662800}
-
Brian Sheedy authored
Disables the XR consent dialog browser tests due to flakiness that potentially causes false CQ rejections. TBR=billorr@chromium.org Bug: 966553 Change-Id: Ie00cbaac63ed9214ace6341474812abfe4b79fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627669Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#662799}
-
Krishna Govind authored
This reverts commit 2f05fdbf. Reason for revert: Breaks chrome translation, crbug 966547 Original change's description: > DevTools: Added GRD/GRDP files for all localizable strings in the DevTools. > > This change includes... > * A main GRD file for the DevTools (front_end/langpacks/devtools_ui_strings.grd) > * GRDP files organized by subfolder > * A node script that keeps the GRD/GRDP files in sync with the keys in the DevTools frontend > * A git cl presubmit --upload check that runs the node script > > Note: Subsequent changes will add a build step to generate a .pak file that contains these DevTools strings. You can read about the overall approach here (https://bugs.chromium.org/p/chromium/issues/detail?id=941561). > > > Details of this design: > ====================== > We followed a similar pattern used by WebUI where strings are encoded in GRIT GRD/P files, which are used by a localization service to perform translations. They are also consumed in the build step to generate a .pak file, which is loaded by the browser's resource system. > > Chromium documentation: > * https://www.chromium.org/developers/tools-we-use-in-chromium/grit/grit-users-guide > * https://www.chromium.org/developers/design-documents/ui-localization > > Frontend strings: > ----------------- > These are the localizable strings that are displayed to the user. > > GRDP <message> strings: > ----------------------- > Each frontend string has a corresponding <message> entry in a GRDP file. These entries are what the localization service will use to perform localizations. It's also the input to the GRIT compiler, which generates a .pak file, which is loaded by the browser's resource_bundle system. > > GRDP <messsage> placeholders: > ---------------------------- > Frontend strings use placeholders, which are used to substitute in values at runtime. > For example, > 'This string has %s two placeholder %.2f.' > > Since the order of the string may change in a different language, we need to encode the order of the placeholders. As such, in the GRDP file you'll find %s replaced with $[1-9]. > > For example, > 'This string has <ph name="ph1">$1s</ph> two placeholder <ph name="ph2">$2.2f</ph>.' > > Also, note that the precision and type of the placeholder is maintained (i.e. .2f). > > Detecting changes: > ----------------- > The check_localizable_resources.js script performs the following check and generates an error if there are any changes that need to be made to a GRDP file. > > 1. Parses the frontend strings and hashes them. > 2. Reads the messages from the GRDP files and hashes them. > 3. Uses a difference between these two sets to report which strings need to be added and/or removed from GRDP files. > > Optionally, the user can specify --autofix and it will automatically update the appropriate GRDP files. > > Presubmit check: > --------------- > Running git cl presubmit --upload will run the check_localizable_resources.js script with the --autofix argument. > > If there are any changes, they reported to the user like this. > > ** Presubmit ERRORS ** > Error: Found changes to localizable DevTools strings. > DevTools localizable resources checker has updated the appropriate grdp file(s). > Manually write a description for any new <message> entries. > Use git status to see what has changed. > > BUG=941561 > > Change-Id: I5ac1656a037a6aaffeb4f64b103c4daec28be39a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613921 > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#662371} TBR=alph@chromium.org,einbinder@chromium.org,exterkamp@chromium.org,jeffish@microsoft.com,lomitch@microsoft.com Change-Id: Ic4ca7d000d10b2bc61b585198469ca30f051dc62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627943Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#662798}
-
Majid Valipour authored
Bug: 930196 Change-Id: I670db243b71c4a99aaa31a942de3ed6cb06ebe34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614966 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#662797}
-
John Rummell authored
Add the UMA "Media.EME.MediaDrm.GetOriginIdResult" to record how the pre-provisioned origin ID was obtained (or if it failed). Tested manually by going to the Shaka demo site, playing some Widevine encrypted content, and then checking the UMA locally by viewing chrome://histograms. Bug: 963629 Test: tested manually and MediaDrmOriginIdManagerTest unit_tests pass Change-Id: Ia9df557283df72e7b90eaf004f839a127c15a2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614681Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#662796}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/58c71db1b344..c1b36669db55 git log 58c71db1b344..c1b36669db55 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 hbos@webrtc.org Revert "Delete STACK_ARRAY macro, and use of alloca" 2019-05-23 titovartem@webrtc.org Fix chromium autoroller to parse new clang revision format 2019-05-23 eladalon@webrtc.org RtpVideoSender nits 2019-05-23 srte@webrtc.org Cleanup of video packet overhead calculation. 2019-05-23 jakobi@webrtc.org Improve NetEq network adaptation in the beginning of the call. 2019-05-23 nisse@webrtc.org Delete STACK_ARRAY macro, and use of alloca 2019-05-23 sprang@webrtc.org Fix incorrect libvpx vp9 dynamic rate control settings 2019-05-23 mirtad@webrtc.org Add option to configure raw RTP packetization per payload type. 2019-05-23 crodbro@webrtc.org Add a config flag to disable the audio ALR probing request. 2019-05-23 nisse@webrtc.org Remove hex_encode functions with raw buffer output from the header file 2019-05-23 nisse@webrtc.org Delete unused method ModuleRtpRtcpImpl::SendCompoundRTCP 2019-05-23 ssilkin@webrtc.org Add sizes of spatial layer frames to EncodedImage 2019-05-23 noahric@chromium.org Lowercase windows includes in desktop_capture/. 2019-05-22 qingsi@webrtc.org Replace a broken assumption in candidate gathering for mDNS candidates. 2019-05-22 kwiberg@webrtc.org WebRTC Opus C interface: Add support for non-48 kHz encode sample rate 2019-05-22 hbos@webrtc.org Implement RTCMediaSourceStats and friends in standard getStats(). Created with: gclient setdep -r src/third_party/webrtc@c1b36669db55 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:944577 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieeb598b75d2baad4a0676b3fd6fffd3d69d59b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662795}
-
Austin Eng authored
https://dawn.googlesource.com/dawn.git/+log/1c85976abe4e..820a04b9ce6b git log 1c85976abe4e..820a04b9ce6b --date=short --no-merges --format='%ad %ae %s' 2019-05-22 brandon1.jones@intel.com Add Debug Marker Functionality for D3D12 2019-05-22 enga@chromium.org Implement CreateBufferMapped in dawn_wire CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: Iacf4cf59abf99912a270f57d7dcf54540fa6a1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627576Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#662794}
-