- 25 Jun, 2018 40 commits
-
-
Naoki Fukino authored
Android container now supports content urls with /external_files to access all files on emulated external storage. We need to convert URLs under /run/arc/sdcard/write/emulated/0 on Chrome OS side to the content URLs. To share the path to Android files, the definition of kAndroidFilesPath is moved from volume_manager to path_util. Bug: 855982 Test: Manually tested on Kevin and Eve with a patch ag/4411504 on Android. Change-Id: Idb6fbd9aa697c306d953b0bcb7cf332ec9a26c19 Reviewed-on: https://chromium-review.googlesource.com/1113169 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#570001}
-
Peter Beverloo authored
Change-Id: I1ec42b183f800555145b4a78db898d61efaab456 Reviewed-on: https://chromium-review.googlesource.com/1113183 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#570000}
-
yusukes authored
These days, 'using namespace' is banned even in .cc files and 'git cl lint' actually detects violations. This CL addresses that as well as some IWYU issues. https://google.github.io/styleguide/cppguide.html#Namespaces BUG=b:74499980 TEST=git cl lint, unit_tests Change-Id: I0277f6a471aaf7050929d3ea43050eb4b663a956 Reviewed-on: https://chromium-review.googlesource.com/1113209Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569999}
-
jdoerrie authored
TBR=sadrul Bug: 856079 Change-Id: If2a53d4409d22142f27fc13ebb2dfcaf82afcc54 Reviewed-on: https://chromium-review.googlesource.com/1113304Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569998}
-
Darren Shen authored
virtual/stable/http/tests/navigation/rename-subframe-goback.html times out on Linux. TBR=lukasza@chromium.org Bug: 855816 Change-Id: I56234dcc8c4adab0d2539a751467131fd2b8ceeb Reviewed-on: https://chromium-review.googlesource.com/1113161 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569997}
-
Matt Menke authored
It was used by the non-Mojo loading path, which was removed quite a while back. Bug: none Change-Id: I86c7b9b7cc950b3f89a00fcb57ff4f95a9a328b9 Reviewed-on: https://chromium-review.googlesource.com/1112465Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569996}
-
vitaliii authored
Connect ConsentSyncBridge to ConsentAuditor behind a feature on iOS. ConsentAuditor does not use the bridge at all yet. The bridge is wired to the auditor on all other platforms in https://chromium-review.googlesource.com/c/chromium/src/+/1084475. This CL is a part of a series to split user consents from user events into a separate datatype. Bug: 840357 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie47fb3241cfdd64f7962d9d8b62f28578a76c0a1 Reviewed-on: https://chromium-review.googlesource.com/1087269Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569995}
-
vitaliii authored
Previously I had to temporarily use USER_EVENTS in consent_sync_bridge_impl, because it was added before the new datatype. This CL fixes this. Bug: 840357 Change-Id: I4d21598c8155e44baa6b5d99de42416c00996243 Reviewed-on: https://chromium-review.googlesource.com/1095306Reviewed-by:
-
Mirko Bonadei authored
If Abseil is not built with Chromium, this CL defines GTEST_HAS_ABSL=1 which enables pretty printers for Abseil types. At the moment only absl:optional and absl::string_view are supported. If a new printer will be added to gtest/gtest-printers.h, the deps list in third_party/googletest/BUILD.gn will have to be updated. Bug: None Change-Id: Ib3cf0eacc286367be2cba0d7b0d3dd9598147bc7 Reviewed-on: https://chromium-review.googlesource.com/1027711Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#569993}
-
yusukes authored
With this, such IMEs will be excluded from the available IME list for English. BUG=b:74499980 TEST=unit_tests Change-Id: Ied09c0c787bf54527229133a1d792cabbc4aac7c Reviewed-on: https://chromium-review.googlesource.com/1113206Reviewed-by:
-
Gauthier Ambard authored
The condition for disabling the test was wrong, the test is failing on device. Bug: 855368 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6b3a5696e6cdec5b80e12bc3b74d81c443f8cd46 Reviewed-on: https://chromium-review.googlesource.com/1113186Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#569991}
-
Ilya Nikolaevskiy authored
Bug: 854735 Change-Id: I735d9140c5b6365ff3be9763138ac573e9180502 Reviewed-on: https://chromium-review.googlesource.com/1109967 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#569990}
-
yusukes authored
Android IMEs installed to Chrome OS will be associated with a special Chrome OS language name. This CL adds the fake language. BUG=b:74499980 TEST=ui_base_unittests Change-Id: If5f78cc22c8371ef6199b67563792bc008aaeab2 Reviewed-on: https://chromium-review.googlesource.com/1113205Reviewed-by:
-
Fergal Daly authored
The current NeedsRecheck checks whether the node's document version has increased by more than 1 but it does not notice when the node has moved to a new document. Since we cannot capture the original version of the final document for comparison, we have to assume that when the document changes, a recheck is needed. Bug: 837377 Change-Id: If83c4eaeb6b737768cc45c2f3a2241b03d3d2e75 Reviewed-on: https://chromium-review.googlesource.com/1109667Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569988}
-
Mohamed Amir Yosef authored
In order to compute the unique position of a newly created bookmark node, the unique positions of its siblings are required. This CL persists the unique position of synced bookmark nodes such that they are available across client restarts. Bug: 516866 Change-Id: I27c4ac9fbb25488792c6065dfd49069ef126863c Reviewed-on: https://chromium-review.googlesource.com/1107934 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Jerry Lin authored
This patch adds fuzzer for password_generator_fips181_unittest.cc. R=vabr@chromium.org Bug: 847200 Change-Id: I83823e2315c459963ff020604272613482f15e78 Reviewed-on: https://chromium-review.googlesource.com/1109596 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569986}
-
Darren Shen authored
This reverts commit c32a3d1e. Reason for revert: introduced flake, see https://crbug.com/855979 Original change's description: > Deflake one of TouchActionBrowserTest > > Some of the TouchActionBrowserTests are flaky. I was recently told by > sahel@ that setting speed_in_pixels_s to a very high number will ensure > there is one GSU only and will prevent the flaky. This does work, at > least locally. I have tried the test in this CL locally and it was > flaky without this change. With this change, I have ran this test 50 > times without any failure. > > This CL does that. Right now there are a few tests marked flaky, this > CL enables one of them first. I will monitor the flakiness dashboard > once this CL lands. If this does solve the problem, we will then enable > more tests. > > Bug: 833015 > Change-Id: I539703866094fb526e220c48aaf327836345b950 > Reviewed-on: https://chromium-review.googlesource.com/1101464 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567692} TBR=tdresser@chromium.org,xidachen@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 833015 Change-Id: I53852330fc0702b5e0c240afed40ef514c8a136f Reviewed-on: https://chromium-review.googlesource.com/1113217Reviewed-by:
-
Darren Shen authored
Timeout on linux. TBR=hiroshige@chromium.org Bug: 855860 Change-Id: Ieb872c12a54afa07baffbedb1f64a6280a489281 Reviewed-on: https://chromium-review.googlesource.com/1113158Reviewed-by:
-
Kent Tamura authored
All of PopupOpeningObserver implementors are on GC heap, and having raw pointers to them is dangerous. This CL is a preparation to make blink::FileInputType a PopupOpeningObserver. Bug: 637639 Change-Id: Iee014462716cc3c3de91ddf365ab8644e2de5f2e Reviewed-on: https://chromium-review.googlesource.com/1113084 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569983}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa532590..7619aff4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia9760c2fdb202815b3af93a1c716a63f9335f0a9 Reviewed-on: https://chromium-review.googlesource.com/1113032Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569982}
-
Darren Shen authored
Flaky test. TBR=fhorschig@chromium.org Bug: 855617 Change-Id: I72918666c6a50021cf26b76172a8f37d38572094 Reviewed-on: https://chromium-review.googlesource.com/1113164Reviewed-by:
-
Hiroki Nakagawa authored
This addresses recent WPT-side changes: https://github.com/web-platform-tests/wpt/issues/11222 These files test nested workers on dedicated workers and shared workers that haven't been implemented yet in Chromium. Bug: 31666, 655458 Change-Id: I52f75c3ee2e77b03861cdf6fb0e7d07de93c9d0f Reviewed-on: https://chromium-review.googlesource.com/1113160Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#569980}
-
Alexander Hendrich authored
Refactored optional attribute 'isAllowedUILocale' to 'isProhibitedUILocale' (default=false). Also set the attribute in c++ and pass it through LanguageSettingsPrivateAPI instead of accessing the pref in the UI code. Bug: 695042 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id904a54e4798bb9a951dd65f8748bd40867e4425 Reviewed-on: https://chromium-review.googlesource.com/1111710Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#569979}
-
Oscar Johansson authored
When building with Jumbo, kResizeAreaCorner in views/frame/opaque_browser_frame_view.cc and views/overlay/overlay_window_views.cc conflict. This commit solves the issue by moving the constants from the namespace to the place where it is used. Bug: 773275 Change-Id: I87195fe6f650088e7aaa6117ad44e9e919d17cc9 Reviewed-on: https://chromium-review.googlesource.com/1102499 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569978}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kAvatarIconSize in views/profiles/dice_accounts_menu.cc and webui/signin/user_manager_screen_handler.cc. This commit solves the issue by renaming the variables to something more file specific. Bug: 773275 Change-Id: Ibb0aa4bf8c65fcdc70d5b747cccea336ab77ca9b Reviewed-on: https://chromium-review.googlesource.com/1107708Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#569977}
-
Michael Spang authored
This enables initializing vulkan and offscreen rendering but not presentation. Bug: 851997 Test: ozone_demo gets past vulkan instance creation on eve build with vulkan support Change-Id: I14f56fb4e22c0cdc275aaead3e734f59e18722a9 Reviewed-on: https://chromium-review.googlesource.com/1104862 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#569976}
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kNameField in webui/certficates_handler.cc and webui/inspect_ui.cc. This commit solves the issue by renaming the variables to something more file specific. It also renames other variables in the same namespace, so the naming is locally consistent. Bug: 773275 Change-Id: I0b900803f4f84c058c43e1b5b3f395c8e14774f9 Reviewed-on: https://chromium-review.googlesource.com/1107929 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#569975}
-
Dominik Röttsches authored
In order to turn OOP FontConfig queries from Sandbox IPC filedescriptor based messages to Mojo messages, we need FontService to handle additional queries for font fallback, retrieving render style and performing font matching in a PPAPI context. These methods are moving from sandbox_ipc_linux.cc as well as font_utils_linux.h and will be temporarily duplicated until the methods will be removed from where they were duplicated from. For the design doc, please refer to crbug.com/839344. Bug: 849923 Change-Id: If0197eae2c9bba8495c065d641b3fef39e403a83 Reviewed-on: https://chromium-review.googlesource.com/1087951 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#569974}
-
Michael Spang authored
The page flip code mixes two error handling styles and in many cases returns the same status (or in some cases, inconsistent statuses) through the return value and also via the SwapCompletionCallback. The page flip code also supports two modes: real page flips and test page flips, which are used to validate configurations before use. Real page flips crash the GPU process if the return value indicates failure, but obviously this is not expected to occur so in practice those always return success, and pass status information through the SwapCompletionCallback. Test page flips are the opposite: they must return their status in the return value, and pass a dummy completion callback which ignores its arguments. There are actually no asynchronous failure cases, despite a fair amount of code trying to account for that possibility such as the coalescing of SwapResults in PageFlipRequest. We can take advantage of this to avoid passing the SwapCompletionCallback into most functions, and simply use the return value as the only status return. The only complication is that successful completion is always asynchronous, and may even require tracking multiple underlying page flip events, as in hardware mirroring scenarios. This patch handles that issue by registering PageFlipCallbacks for all of the individual page flip events as usual, but only passing ownership of the SwapCompletionCallback into the PageFlipRequest at the last minute, after all of the individual page flips have been submitted succesfully. After hiding the SwapCompletionCallback from most of the DRM internals, test page flips no longer need to construct a dummy SwapCompletionCallback. They also don't need to construct any PageFlipCallbacks, since they don't generate any page flip events - this simplifies that logic as well by moving construction of each PageFlipCallback to immediately after a successful page flip request. Moving creation of those callbacks later also removes any requirement to make manual calls to PageFlipRequest::Signal to fixup failure cases. Since failures of real page flips triggered by SchedulePageFlip() simply crash the process, there is no need for a return value. This patch moves the CHECK() which cause these crashes inside of SchedulePageFlip(), and removes the return value. As a result, TestPageFlip() and all of the internal methods called via ActualSchedulePageFlip() use return values exclusively for status information, and never see the SwapCompletionCallback. SchedulePageFlip(), on the other hand, receives the SwapCompletionCallack and uses it exclusively for its status, and returns void. Bug: 851997 Test: unit tests, various display configurations on cros Change-Id: I87408275b0958281ef79a6b5086a38b2c3c08ee1 Reviewed-on: https://chromium-review.googlesource.com/1104859 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This CL is a pure refacotring. Bug: 846618 Change-Id: Ia858ad02d5ae14db59eb5bc947d6463e08f98ae8 Reviewed-on: https://chromium-review.googlesource.com/1113090Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569972}
-
Michael Spang authored
Display configurator will not configure mirror pairs between devices (see AllDisplaysOnSameDevice() in ui/display), so remove code attempting to support this. Bug: 851997 Test: hardware mirroring on cros Change-Id: Ie2fdc9f42423be1cd8efe7c59d43001e6096e935 Reviewed-on: https://chromium-review.googlesource.com/1104858 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Jeremy Roman authored
RefPtr is now scoped_refptr. Change-Id: Ifdf5832c631254671a664beb185e001476cb9cb5 Reviewed-on: https://chromium-review.googlesource.com/1111900 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#569970}
-
Darren Shen authored
Flaky on mac and win7. TBR=adithyas@chromium.org Bug: 855873 Change-Id: I0d55390244a7e96e478a01bd5be254d958a41147 Reviewed-on: https://chromium-review.googlesource.com/1113082Reviewed-by:
-
Darren Shen authored
Flaky on Windows TBR=tangltom@chromium.org Bug: 855867 Change-Id: I32be5fa7473203dea8ab3dc25fbb9b5b68edd737 Reviewed-on: https://chromium-review.googlesource.com/1113087Reviewed-by:
-
Hiroki Nakagawa authored
This CL fixes ReferrerPolicy handling in module script loading. Before this CL, FetchClientSettingsObjectSnapshot's referrer policy is used, but this is wrong. The spec requires to use ScriptFetchOptions' referrer policy. // The "set up the module script request" algorithm: "Set request's cryptographic nonce metadata to options's cryptographic nonce, ..., and its referrer policy to options's referrer policy." https://html.spec.whatwg.org/multipage/webappapis.html#set-up-the-module-script-request Specifically, this CL introduces |referrer_policy_| field in ScriptFetchOptions class as spec'ed and propagates it to the entire path of module script loading. ScriptFetchOptions's referrer policy can be set to following values: - <script>'s "referrerpolicy" attribute is used for <script type='module'>. This hasn't been implemented yet (see https://crbug.com/841673), so the current document's referrer policy is used to keep the backward compatibility. // The "prepare a script" algorithm: "20. Let referrer policy be the current state of the element's referrerpolicy content attribute." "22. Let options be a script fetch options whose cryptographic nonce is cryptographic nonce, ..., and referrer policy is referrer policy." https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script - <link>'s "referrerpolicy" attribute is used for modulepreload. // The "Link type "modulepreload"" algorithm: "9. Let referrer policy be the current state of the element's referrerpolicy attribute." "10. Let options be a script fetch options whose cryptographic nonce is cryptographic nonce, ..., and referrer policy is referrer policy." https://html.spec.whatwg.org/multipage/links.html#link-type-modulepreload - The default referrer policy is used for module workers and worklets. This is the reason why this CL changes test expectations of workers and worklets. // The "fetch a module worker script graph" algorithm: "2. Let options be a script fetch options whose cryptographic nonce is the empty string, ..., and referrer policy is the empty string." https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-module-worker-script-tree Change-Id: Ic0f9e6667cd1b84f74d86fcc948451c1d2f8191f Bug: 842553, 855963 Reviewed-on: https://chromium-review.googlesource.com/1111743 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#569967}
-
Cathy Li authored
Bug: 852075 Change-Id: Ibdd7001d62b9adc0f3d2c74b12f77e904cf27d06 Reviewed-on: https://chromium-review.googlesource.com/1112706 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569966}
-
Michael Spang authored
There's a number of places that overlay stacks are copied inside the DRM code. Previously this was safe because overlay plane stacks were self-contained, but now they include unowned pointers to fences. Those fences are freed immediately after submitting a frame and left dangling in any copies of the overlay plane stack. Fix the code to duplicate the fences when copying planes. We should reduce the number of places we are copying overlay stacks, but that is not done here; this patch only makes copying safe again. It also makes copying an explicit call; the copy constructor is gone. TBR: dcastagna@chromium.org Bug: 851997 Test: Ran chrome & ozone_demo --use-gpu-fences on eve Change-Id: Ib21033aaf43a6765c3c46fce60991ada941ef343 Reviewed-on: https://chromium-review.googlesource.com/1097209 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Bug: 855117 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I730e489bf6880252ce5474551e4c624d9baa18d7 Reviewed-on: https://chromium-review.googlesource.com/1112704Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569964}
-
Ivan Afanasyev authored
|HandleLocalTime| uses |localtime| in the assumption that sandbox handler process is single-threaded. This assumption is not correct anymore. See |SandboxHostLinux::Init| and |ipc_thread_|. The proposed fix is to replace unsafe |localtime| function call with threadsafe |localtime_r| posix equivalent. Change-Id: I20c9576557df414b19c30c51ba233f62cfb8be28 Reviewed-on: https://chromium-review.googlesource.com/1111704Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Иван Афанасьев <ivafanas@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#569963}
-
Paul Dyson authored
Allow a SourceId to be obtained and the url set to app://[chrome|play]/id. Add a new SourceType to govern the creation of urls with scheme "app". Bug: 841671 Change-Id: I1ed98722cdeb78ffd9944548901089e28f64181a Reviewed-on: https://chromium-review.googlesource.com/1058736Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569962}
-
