GitLab

BUG=348137
TBR=nyquist

Review URL: https://codereview.chromium.org/189273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255452 0039d316-1c4b-4281-b951-d872f2087c98

All inputs except instr_stamp are passed in the command and instr_stamp
is a single fixed file, so this isn't necessary. No functionality change.

BUG=177552
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/180033009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255451 0039d316-1c4b-4281-b951-d872f2087c98

Fixes Escape key drag-and-drop cancellation handling.
(this is a followup fix for Issue 344289 and r254289)

SendXdndLeave(source_current_window_) in OnMoveLoopEnded.
(seems like a misnomer, this is the target drop window)
(alerts the target window to repaint and cleanup, etc.)

BUG=349151,344289
TEST=Dragging text, bookmarks, etc. from a Linux Aura browser window to the same window, other Chrome windows, and other application is cancelled correctly when pressing [Esc] (no lingering drop indicator, etc.).
R=erg@chromium.org

Review URL: https://codereview.chromium.org/181013011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255449 0039d316-1c4b-4281-b951-d872f2087c98

This will enable the installer on Windows to install the 200 percent assets.

BUG=349607
R=cpu@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/187823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255448 0039d316-1c4b-4281-b951-d872f2087c98

> Suppress memory issue in MachineStatisticsInitializer
> 
> BUG=349948
> TBR=dpolukhin@chromium.org
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/184243004

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/180723024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255447 0039d316-1c4b-4281-b951-d872f2087c98

The original CL wasn't the cause of the test failures on the Android bot.
Reverting the revert.

> Revert 255386 "Support ARGB_8888 by default in GLHelperReadbackS..."
> 
> This seems to have broken the pixel tests on the Android GPU bot.
> 
> > Support ARGB_8888 by default in GLHelperReadbackSupport
> > 
> > This is a work around for a driver bug on Galaxy Nexus
> > 
> > BUG=349667
> > 
> > Review URL: https://codereview.chromium.org/184103037
> 
> TBR=clholgat@chromium.org
> BUG=349667,350043
> 
> Review URL: https://codereview.chromium.org/179793010

TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/179793011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255446 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255445 0039d316-1c4b-4281-b951-d872f2087c98

TBR=titzer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/188643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255443 0039d316-1c4b-4281-b951-d872f2087c98

Both actions have a small fixed list of inputs. md5sum is only needed for
variable input lists (see bug). No behavior change.

BUG=177552
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/184103038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255436 0039d316-1c4b-4281-b951-d872f2087c98

Copy msvc*.dll from the build_dir to the installer_dir rather than straight to the installer_dir as some DLLs only live in the build_dir and aren't grabbed by CopyVisualStudioRuntimeDLLs().

NOTRY=True
BUG=349419

Review URL: https://codereview.chromium.org/186593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255435 0039d316-1c4b-4281-b951-d872f2087c98

TimelineBasedMeasurement lets us compute a variety of different metrics for pages that do complex sequences of interactions. Whereas traditional telemetry measurements focus on reporting a single type of value for many pages, this lets a page decide what types of metrics it emits based on the behaviors its page actually performs.

The contract is that the page emits
console.time/timeEnd calls of a certain format describing when it is doing
something worth noting, and what kind fo interaction it is doing. For instance,
if a drawer animation is runnign, it would emit:
  MeasurementRequest.Drawer/smoothness

This tells the timelineBasedMeasurement that the timeline data generated during this time
should be analyzed for smoothness information, with results benig reported as things like
Drawer.frame_time.

Depends on https://codereview.chromium.org/177093013

BUG=345922
NOTRY=True

Review URL: https://codereview.chromium.org/165673008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255434 0039d316-1c4b-4281-b951-d872f2087c98

This disk cache backend is no longer under development.

R=davidben@chromium.org,agayev@gmail.com
TEST=None

Review URL: https://codereview.chromium.org/182093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255433 0039d316-1c4b-4281-b951-d872f2087c98

In ChromeOS, do not show notifications for guest and default profiles. When
starting the privet notification service, check if the profile has an
authenticated username. If it does, it is a normal user account; otherwise it
isn't.

BUG=349098

Review URL: https://codereview.chromium.org/186983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255432 0039d316-1c4b-4281-b951-d872f2087c98

Fix null dereference issue in privet filesystem if listing a directory errors
out. Instead, signal an error.

BUG=

Review URL: https://codereview.chromium.org/180733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339320

Review URL: https://codereview.chromium.org/183893033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255429 0039d316-1c4b-4281-b951-d872f2087c98

The Android team is deprecating pthread_cond_timedwait_monotonic in favor of the more standard pthread_condattr_getclock.

Update usage in Chromium such that it will use the standards based code path when it's present.
    
Bug:349865

Review URL: https://codereview.chromium.org/183763031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255428 0039d316-1c4b-4281-b951-d872f2087c98

    
New benchmarks:
- rasterize_and_record.fast_path.key_silk_cases
- rasterize_and_record_micro.fast_path.key_silk_cases
- smoothness.fast_path.key_silk_cases
- smoothness.fast_path_gpu_rasterization.key_silk_cases
- thread_times.fast_path.key_silk_cases

Review URL: https://codereview.chromium.org/183413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255427 0039d316-1c4b-4281-b951-d872f2087c98

Versions that manifests without these values are no longer supported.

BUG=314162
TEST=Manually verified that the CDM still works using a manifest from M33.
R=sorin@chromium.org, xhwang@chromium.org

Review URL: https://codereview.chromium.org/180953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255426 0039d316-1c4b-4281-b951-d872f2087c98

Some code in PepperReverseInterface is more complicated than it needs to be.
I figured I'd clean this up a bit while I was looking at the manifest handling
logic.

BUG=
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/183793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255425 0039d316-1c4b-4281-b951-d872f2087c98

Add parsing logic to load a manifest specifying a service worker script.
This is a precursor to registering and using that script.

BUG=344917
R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/178253007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255424 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/186663009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255423 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the following flags:
--default-stub-network-state-idle
--enable-stub-interactive (for Shill only)
--enable-stub-portalled-wifi
--enabled-stub-network-types

With:
--shill-stub={options}

Specific option values are commented in the code.

BUG=345033
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/181413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255422 0039d316-1c4b-4281-b951-d872f2087c98

There is built-in logic to ignore a blacklist entry if related data is unavailable, so this CL doesn't have any effects.

> Don't blacklist accelerated 2d canvas if WinStats are unavailable.
> 
> BUG=349628
> TEST=gpu_unittests
> R=kbr@chromium.org
> 
> Review URL: https://codereview.chromium.org/183883026

TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/180723020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255421 0039d316-1c4b-4281-b951-d872f2087c98

This seems to have broken the pixel tests on the Android GPU bot.

> Support ARGB_8888 by default in GLHelperReadbackSupport
> 
> This is a work around for a driver bug on Galaxy Nexus
> 
> BUG=349667
> 
> Review URL: https://codereview.chromium.org/184103037

TBR=clholgat@chromium.org
BUG=349667,350043

Review URL: https://codereview.chromium.org/179793010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255420 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org
TBR=viettrungluu

Review URL: https://codereview.chromium.org/184563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255418 0039d316-1c4b-4281-b951-d872f2087c98

UserActionClient is used to navigate back/forward when the back/forward on a
supported mouse-device is clicked on X11. This can instead be achieved by
installing an event-handler on the browser window.

This does change the behaviour a little on ChromeOS: clicking these navigation
buttons when the cursor is not on top of the browser window will not navigate
after this change. I have confirmed with UX that this is a desirable change.

BUG=319636
R=sky@chromium.org

Previously landed in r255385, reverted in r255398 to allow another revert in r255399.

Review URL: https://codereview.chromium.org/183853037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255416 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255415 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=168641:168654&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/183803031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/180113011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255407 0039d316-1c4b-4281-b951-d872f2087c98

Patch is incorrect. Changing the behaviour of insets also breaks the
toolbar. Looks like I'm going to have to find all usage of
LabelButton::set_min_size() after all.

> linux_aura: Fix all instances of LabelButton sizing.
> 
> Previous attempts at fixing this involved tracking down each button
> which was setting the minimum size to 0,0. Those attempts are reverted,
> as I no longer think they're wrong. The actual fix is to pass through
> the views inset size instead of using the GTK inset size.
> 
> BUG=349183, 344498, 339247
> R=msw@chromium.org, sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/187133003

TBR=erg@chromium.org,msw@chromium.org,sky@chromium.org
BUG=349777

Review URL: https://codereview.chromium.org/188893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255406 0039d316-1c4b-4281-b951-d872f2087c98

Believed to be behind the failures in the Linux builder:

http://build.chromium.org/p/chromium/builders/Linux/builds/47996

Errors in the log:

.../actions/print_style.py: Has executable bit but not shebang or ELF header
.../histograms/print_style.py: Has executable bit but not shebang or ELF header

Refers to files in the CL.

> Change the user action file format from .txt to .xml.
>
> In this way, more information can be added (currently added 'description' and 'owner' for each action)
>
> A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms.
>
> BUG=340735
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/149503005

TBR=yiyaoliu@chromium.org

Review URL: https://codereview.chromium.org/188793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255404 0039d316-1c4b-4281-b951-d872f2087c98

No intended behavior change.

dex_action.gypi didn't pass its input_paths variable to dex.py,
but that was only set in a single place, and only to a single file there.
It was only used in java_apk.gypi which does manual threading of
stamp files to order actions (since it's a gypi, it can't easily use type
none targets with dependencies). Since dex.py doesn't look at this
stamp file at all, it doesn't need to rerun when the stamp file disappears.

To make this a bit more obvious, remove dex_action.gypi's input_paths
variable and set 'inputs' directly in the one place with the stamp file.
(dex.py will still rerun if the name of the stamp file changes, due to
regular timestamp handling.)

java_apk.gypi used to set input_paths to two files in proguard-enabled
files – change it to depend only on obfuscate_stamp in proguard builds,
as the step that writes that already depends on instr_stamp. (This isn't
necessary as the proguard state is part of the dex.py commandline, so
toggling between proguard and no proguard would rebuild correctly
anyways, but it's conceptually a bit nicer.)

Also set proguard_enabled_input_path unconditionally. Again, no behavior
change, but keeps the gyp a bit shorter.

BUG=177552
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255325

R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/183883024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255403 0039d316-1c4b-4281-b951-d872f2087c98

> ThreadWatcher: fixes Start/StopWatchingAll.
> 
> Start is deferred in relation to Stop, and when they're both called
> within the Start interval, the end result was started.
> 
> BUG=347887
> TEST=unit_tests --gtest_filter=ThreadWatcherList*
> 
> Review URL: https://codereview.chromium.org/183063007

BUG=347887,349987
TBR=bulach@chromium.org

Review URL: https://codereview.chromium.org/188643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255401 0039d316-1c4b-4281-b951-d872f2087c98

> Clean up WindowEventDispatcher some more.
> 
> . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore.
> . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down.
> . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched.
> 
> R=sky@chromium.org
> http://crbug.com/308843
> 
> Review URL: https://codereview.chromium.org/188223002

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/188843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255399 0039d316-1c4b-4281-b951-d872f2087c98

> aura: Remove client::UserActionClient.
> 
> UserActionClient is used to navigate back/forward when the back/forward on a
> supported mouse-device is clicked on X11. This can instead be achieved by
> installing an event-handler on the browser window.
> 
> This does change the behaviour a little on ChromeOS: clicking these navigation
> buttons when the cursor is not on top of the browser window will not navigate
> after this change. I have confirmed with UX that this is a desirable change.
> 
> BUG=319636
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/183853037

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/186123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255398 0039d316-1c4b-4281-b951-d872f2087c98

I was originally opposed to these since we didn't need them and they were complicated. But I'm wanting to use some of these functions in a different patch, so it seems like a good time to fill out the std::string-like finding functions for StringPiece16.

This deletes the old StringPieceDetails for which the only point was to share the common stuff between the two BasicStringPiece specializations.

I used the pattern of having two versions of each function declared in the header and then expanding the template in the .cc file, to avoid template bloat in the header.

This replaces all of the size_type goop with size_t. Chrome code assumes these are the same and we encourage people to just use size_t in loops, for example, rather than using the size_type of the template they're iterating over. This makes the code more readable in many places. It also solves a problem with declaration ordering since most of the functions that used size_type are now moved above where the size_type is actually declared.

R=viettrungluu@chromium.org
TBR=akalin, ben

Review URL: https://codereview.chromium.org/187793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255397 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255396 0039d316-1c4b-4281-b951-d872f2087c98

This includes PNaCl's merge of LLVM 3.4.

Due to Clang 3.4's new warnings, I've disabled some warnings in the
NaCl SDK's build of gtest, which gave:
gtest-filepath.cc:87:12: error: unused variable 'kPathSeparatorString' [-Werror,-Wunused-const-variable]

This pulls in the following Native Client changes:

r12811: (jfb) Update TOOL_REVISIONS for PNaCl r12786->r12809
r12812: (kschimpf) Test pnacl-compress fixpointing.
r12813: (jfb) Update TOOL_REVISIONS for PNaCl r12809->r12810
r12814: (dyen) Attempt to unify our platform/OS and architecture collapsing in python
r12815: (jvoung) Remove NACL_RODATA_FLAG to go between -Trodata-segment, and --section-start.
r12816: (mseaborn) PNaCl: Merge LLVM 3.4: update Git revs, driver scripts and test expectations
r12817: (jfb) Update TOOL_REVISIONS for PNaCl r12810->r12816 to bring in merge of LLVM 3.4
r12818: (mseaborn) Fix download_toolchains.py (breakage from r12814)
r12819: (mseaborn) PNaCl: LLVM 3.4 merge: Update test expectations for flaky tests on Cygwin
r12820: (mcgrathr) Update chrome_rev to current LKGR
r12822: (noelallen) Roll bionic
r12823: (mseaborn) IRT: Hide the "dev_getpid" IRT interface by default
r12824: (noelallen) Roll bionic toolchain into TOOL_REVs
r12825: (bradnelson) Adding timeout mechanism to command tester.
r12826: (jvoung) Apply -f*-sections and --gc-sections to IRT build.
r12827: (mseaborn) IRT: Disable various IRT interfaces for in-browser-translated PNaCl pexes
r12828: (jvoung) Remove -reduce-memory-footprint: just make it the default w/ streaming.
r12829: (sbc) Roll glibc version in tools/REVISIONS
r12830: (bradnelson) Fix multidomain_test flake on x86-32 windows.
r12831: (jvoung) Make pnacl-readelf a slightly better wrapper around readelf.
r12832: (mseaborn) PNaCl: Remove toolchain's dependency on x86-32 version of libtinfo on Linux
r12833: (bradnelson) Wait longer for debug_stub_tests, kill more effectively on windows.
r12834: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12835: (jfb) Update TOOL_REVISIONS for PNaCl r12816->r12832

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/187673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255395 0039d316-1c4b-4281-b951-d872f2087c98

The playlist goes wrong when the 'expanded' status is changed in some condition.

BUG=342610, chrome-os-partner:26202
TEST=manually tested

Review URL: https://codereview.chromium.org/185653014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255394 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255392 0039d316-1c4b-4281-b951-d872f2087c98