- 21 Nov, 2018 40 commits
-
-
Marc Treib authored
SyncUserSettings is a new class that encapsulates all the user-configurable knobs for Sync. It replaces a bunch of setters and getters directly on the SyncService. While I'm here, also - update a comment in GetSyncUsernameIfSyncingPasswords to be more specific, since the semantics here are a bit weird, and - remove a CanSyncFeatureStart check from ShouldAffiliationBasedMatchingBeActive since it's redundant with the check for IsSyncFeatureActive which is strictly stronger. Bug: 884159 Change-Id: Ibbb9a82a2d89520e1a349e29a1050cd84dd52ea5 Reviewed-on: https://chromium-review.googlesource.com/c/1344096Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#609964}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d11507507daa..fd17a12ec7ac git log d11507507daa..fd17a12ec7ac --date=short --no-merges --format='%ad %ae %s' 2018-11-20 benjhayden@chromium.org Add alerts-controls for v2spa 2018-11-20 mlippautz@chromium.org vinn: Roll Mac d8 to 7.0.276.40 2018-11-20 mlippautz@chromium.org vinn: Roll Linux d8 to 7.0.276.40 Created with: gclient setdep -r src/third_party/catapult@fd17a12ec7ac The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: If62503fef89ea0409ba690729cee0a6da769e6db Reviewed-on: https://chromium-review.googlesource.com/c/1345770Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609963}
-
Mohamed Amir Yosef authored
This CL converts SyncerError to a class. This is in preparation for a later patch that would add more data to the SyncerError class. Bug: 897049 Change-Id: Ie44fa2f65e92ee9ad9733cdd9586a8c7095befb4 Reviewed-on: https://chromium-review.googlesource.com/c/1344098 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609962}
-
Danan S authored
Bug: 904564 Change-Id: I653438bf5244bc98bcb742d9d986b4ea2bd4b40a Reviewed-on: https://chromium-review.googlesource.com/c/1334563 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#609961}
-
Carlos Caballero authored
Replace all the state checking and tracking code with the new and shiny OperationsController. Bug: 901345 Change-Id: I8023e78ebfee679fd565de465e810dbb9c6ee2ec Reviewed-on: https://chromium-review.googlesource.com/c/1341525 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#609960}
-
Christopher Cameron authored
When using RemoteMacViews, for a given widget, the widget's NSWindow and content NSView exist in the app shim process, while the tree of AXPlatformNodeCocoas exists in the browser process. In the browser process, the widget's NSWindow and content NSView are represented by NSAccessibilityRemoteUIElements in views::BridgedNativeWidgetHostImpl. Update AXPlatformNodeDelegateMac::GetParent and GetNSWindow to retrieve these values from views::BridgedNativeWidgetHostImpl. In AXPlatformNodeDelegate, replace the method GetTopLevelWidget with the method GetNSWindow and call this method in -[AXPlatformNodeCocoa AXWindow]. Replace all subclass implementations except for AXPlatformNodeDelegateMac with NOTREACHED. Bug: 900846 Change-Id: Ia0d26c4d118391ce66cc1e080ca3b62fb228aa8c Reviewed-on: https://chromium-review.googlesource.com/c/1338722 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609959}
-
Alexey Baskakov authored
- Use WebAppIconDownloader in WebAppDataRetriever. - Extract InstallFinalizer interface: WebAppInstallFinalizer is a BMO implementation. BookmarkAppInstallFinalizer will use extensions and CrxInstaller. Bug: 901226 Change-Id: Ie865bfd4facfc6f890ab92d5d6451a37a34979ea Reviewed-on: https://chromium-review.googlesource.com/c/1343410Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#609958}
-
Olivier Robin authored
Cannot reproduce failure. Tentatively reenable. Bug: 796082 Change-Id: I5ec7a55a723f91bb8a76e3f872abfe06eb7693c1 Reviewed-on: https://chromium-review.googlesource.com/c/1338080Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609957}
-
Rune Lillesveen authored
NeedsLayoutTreeUpdateForNode() is true if an ancestor returns true for NeedsAdjacentStyleRecalc(). For getComputedStyle we may start out with a tree where we don't need a full style/layout-tree update, but matching selectors as part of EnsureComputedStyle() up the ancestor chain may cause those flags to be set if we match adjacent selectors which were not previously matched. We need to ignore those flags for the sanity check in EnsureComputedStyle. This may be the situation in which the DCHECK triggers for 900138 as well. Bug: 906830, 900138 Change-Id: I51927fdb9f4bc44e3612628cf9b9710d26e2d8ea Reviewed-on: https://chromium-review.googlesource.com/c/1344130Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609956}
-
Yoshifumi Inoue authored
This patch changes "dfg-arguments-alias-activation.html" to utilize w3c test harnes for ease of maintenance and avoid timeout for dumping result. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1337224 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText Change-Id: I5fcd46f0dd31eb8869917af288d7ad385626612c Reviewed-on: https://chromium-review.googlesource.com/c/1345752Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609955}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0e604f9f1107..836674c28b1e git log 0e604f9f1107..836674c28b1e --date=short --no-merges --format='%ad %ae %s' 2018-11-20 geofflang@chromium.org Expose GL_CHROMIUM_compressed_texture_etc on top of ES drivers. 2018-11-20 geofflang@chromium.org Skip SetUp and TearDown in VulkanCommandBufferPerfTest if its flaky. 2018-11-20 geofflang@chromium.org Fix typo in OWNERS file email address. 2018-11-20 jmadill@chromium.org Use xxHash for faster hash map lookups. Created with: gclient setdep -r src/third_party/angle@836674c28b1e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie0a716588f37fa54c1e7a03a40a1acf909f25371 Reviewed-on: https://chromium-review.googlesource.com/c/1344901Reviewed-by:
-
Gauthier Ambard authored
This is needed to move the subclasses to UITableView one by one. Bug: 894791 Change-Id: I6790f649df2ca61cfd2551ac9afe6fff732a39dd Reviewed-on: https://chromium-review.googlesource.com/c/1344057 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609953}
-
Takuto Ikuta authored
NOTRY: true Change-Id: Ic123d54cbaaa56e28386d5377fb4f4421c847527 Reviewed-on: https://chromium-review.googlesource.com/c/1345170 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609952}
-
Antoine Labour authored
The default 3D texture's first level image was accidentally described as a 2D image. Oops. Bug: 907054 Change-Id: Ib2f016a668baeb7d83b7c70579fed17d6822e0b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345651 Commit-Queue: Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609951}
-
Yi Su authored
fail on small screens. The refactor work on Settings makes Privacy menu larger, thus the "Clear Browsing Data" button is hidden on iPhone 5s due to the screen size. The EG test, ClearBrowsingDataSettingsTestCase, doesn't scroll to find the button, so it failed. This CL will fix the bug and stop failures on iOS12beta. TBR=edchin@chromium.org Bug: 907194 Change-Id: I9fc50a0979b005bcc07628c0d7ae4b3be86050bf Reviewed-on: https://chromium-review.googlesource.com/c/1345071Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609950}
-
Jonathan Metzman authored
Don't allow building of afl_driver since it isn't intended to be built on Windows. Change-Id: I8aeb89b5cf98f1998258847b60a8e12a465d3ca9 Bug: 903078 Reviewed-on: https://chromium-review.googlesource.com/c/1342772 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609949}
-
Hayato Ito authored
This reverts commit 4da12d2d. Reason for revert: Flakiness of RlzLibTest.DelayedInitOnlyNoFirstRun The bug is https://crbug.com/907379 Culprit (70.0% confidence): r609428 Original change's description: > cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz > > |UpdateExistingAccessPointRlz| involves file I/O, so it should be > posted on a task runner that has MayBlock() in its TaskTraits. > |background_task_runner_| serves this purpose. > > Bug: 906293 > Change-Id: If36215767a0dbcfbad56c0432b16b584f6185376 > Reviewed-on: https://chromium-review.googlesource.com/c/1340607 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609428} TBR=rogerta@chromium.org,wzang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 906293 Change-Id: I20dbe6c1f73e3599aa30cf8b74512122ad2d0a25 Reviewed-on: https://chromium-review.googlesource.com/c/1345707Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#609948}
-
Martin Kreichgauer authored
The ContentBrowserClient in WebAuthn requests originating from the cryptotoken extension is not associated with any tab and therefore trying to show dialogs, such as the one for collecting attestation consent, will fail. cryptotoken has its own attestation consent dialog already, so we can safely disable attestation consent prompts if the caller origin is cryptotoken. Bug: 898718 Change-Id: Ic2d530665494cfa10ac4c3a7812e8284091e50fb Reviewed-on: https://chromium-review.googlesource.com/c/1340586 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#609947}
-
Peter Kasting authored
Per the linked bug, RenderTextMac is effectively dead. While I was touching render_text_unittest.cc anyway, I thought I'd help a little with the cleanup. Bug: 131618 Change-Id: I679ce91e4eebc9984ff44b0a8e899f0c36910ee7 Reviewed-on: https://chromium-review.googlesource.com/c/1343106 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#609946}
-
Hajime Hoshi authored
This might invoke V8, and V8 should not be executed on per-thread task runners. This CL gives a per-frame task runner at binding. Bug: 870606 Change-Id: Ib814c717e2805beca341a6ad1a10926b231c361f Reviewed-on: https://chromium-review.googlesource.com/c/1343878Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609945}
-
Greg Thompson authored
BUG=607592 R=zmin@chromium.org Change-Id: I1c1c346c39cfeed164e1a3a56513356a2a142a5e Reviewed-on: https://chromium-review.googlesource.com/c/1337491Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#609944}
-
Chase Phillips authored
Change-Id: I9e7274f3ac67f57f1d0c62eb9223f437e9b1da8b Reviewed-on: https://chromium-review.googlesource.com/c/1340832 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#609943}
-
Andreas Haas authored
This CL enables WebAssembly trap handlers on MacOS. In this CL we use the default trap handler provided by V8. Bug: chromium:906565 Change-Id: I2d007da1a86ca05010a0a7bf830586767f19a24d Reviewed-on: https://chromium-review.googlesource.com/c/1290955 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#609942}
-
Maggie Chen authored
This flag is no longer used in YUV draw quad and dc layer overlay. The first clean-up of this flag in video frame metadata has been checked in. This CL will remove this flag completely. Bug:1340270 Change-Id: Id5816ca0aaf4dc99f22988c4eba4ff5818a94678 Reviewed-on: https://chromium-review.googlesource.com/c/1340270 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Byoungkwon Ko authored
In jumbo build experiments, files get merged and variables and functions with the same name may end up in the same namespace/scope and conflict. This happens for g_singleton in : bluetooth_adapter_factory.cc bluetooth_adapter_factory_wrapper.cc [1] https://chromium.googlesource.com/chromium/src/+/lkgr/docs/jumbo.md Bug: 887254 Change-Id: I97ff48a6aae71be0b935db1f7623da7ef65bac97 Reviewed-on: https://chromium-review.googlesource.com/c/1325109Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Cr-Commit-Position: refs/heads/master@{#609940}
-
Kent Tamura authored
This CL has no behavior changes. Change-Id: I11622b7dd02221b7a449a784284595a7edbab5c3 Reviewed-on: https://chromium-review.googlesource.com/c/1345691Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#609939}
-
Sam McNally authored
Bug: 875402 Change-Id: I1404711a00a26ce65eae614fc4f027ddf240b136 Reviewed-on: https://chromium-review.googlesource.com/c/1345680Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609938}
-
Joel Hockey authored
Change-Id: If33a6bd0bd57a5c9313402a1b78b3f2d815f73e4 Reviewed-on: https://chromium-review.googlesource.com/c/1345681Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#609937}
-
Hirokazu Honda authored
V4L2VEA wrongly calls V4L2Device::V4L2PixFmtToVideoPixelFormat to VideoPixelFormat in VideoFrameLayout::Create. Just pass the VideoPixelFormat without calling. BUG=chromium:907132 TEST=VEA unittest on peach_pit Change-Id: I3800cc81403a19e7521f724f972f63e937f0873b Reviewed-on: https://chromium-review.googlesource.com/c/1345700Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609936}
-
John Z Wu authored
1. Add method for finding forms on the page and replace the old delegate approach. 2. Add delegate method to be fired whenever new form related elements are inserted into the page. Bug: 905546 Change-Id: I6b46bf396f8b34be71ef664a16840dddb5ace86a Reviewed-on: https://chromium-review.googlesource.com/c/1345810 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#609935}
-
Shik Chen authored
We need to wait until |camera_info_| is updated in OnGotCameraInfoOnIpcThread() before we fire ProcessDevicesChanged() to prevent the race condition. To easily reproduce the race without this CL, add --disable-features=MojoVideoCapture as the command line argument of Chrome. BUG=b:118418068,b:118408452,b:64996728,b:77833131 TEST=10.times do Plug the external camera Check the external camera is shown in settings Unplug the extencal camera Check the external camera is not shown in settings end Change-Id: I3774c456099724f2bb5ac2d21caf3229d0045a4e Reviewed-on: https://chromium-review.googlesource.com/c/1345677Reviewed-by:Ricky Liang <jcliang@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#609934}
-
Andrey Lushnikov authored
R=dgozman Change-Id: Ieef8860b2ee7e65f013e4a01144b7812f3cf5af9 Reviewed-on: https://chromium-review.googlesource.com/c/1345534Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#609933}
-
Adrienne Walker authored
ClientPaintCache::Purge was not modifying the map that it was generating PurgeData from. This meant that to generate a budget to remove, it would loop over the same element repeatedly and generate a large list of the same item to purge. (This is why this is intermintent and hard to repro.) However, it would then inform the service that this one entry was removed, but the client would still think it was there. If anything used it at that point, the client would assume it was cached, but the service would fail because it would not be cached. Bug: 906510 Change-Id: I71bf22833649875ea2486f5e8518b897f354b6c1 Reviewed-on: https://chromium-review.googlesource.com/c/1345418Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#609932}
-
Alex Danilo authored
A checkerboard background was introduced to help see transparent PNG images when using quick view in the FilesApp. If the image being decompressed is large, the checkerboard is visible until the image finishes decoding causing display flicker. This change detaches the image node from the tree and uses the decode() method on the image element to decode in the background and then reattach when ready, eliminating the flicker. and on real device. Bug: 645021 Test: ran all browser tests, verified manually on workstation Change-Id: Icd3dbdfb65015649acd539471ebe42cb8cf9a98e Reviewed-on: https://chromium-review.googlesource.com/c/1345378Reviewed-by: -
Reilly Grant authored
It is invalid for a WebIDL dictionary member that resolves to a nullable type to be marked with '?'. This change is effectively a no-op because these fields remain nullable. This patch implements the changes to the specification in: https://github.com/w3c/deviceorientation/pull/55 Change-Id: I43222ec37ec216f8cb2932aedbddfb307ec4374f Reviewed-on: https://chromium-review.googlesource.com/c/1239722 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Sreerenj Balachandran authored
For the Intra only frames in profile0, we assign the default color_space :BT_601 as per the spec. But there are lazily encoded streams with UNKNOWN color space information in non-intra-only frames and that will cause enum comparison mismatch for the current frame header with the frame in the reference list. So we relax the requirement a bit to cover more streams similar to the other media stacks like libvpx, gstreamer etc BUG=889768 R=dalecurtis@chromium.org, hiroh@chromium.org Change-Id: I5c343d03a941a3aa1447d4f0d3cd4979b92c4adb Reviewed-on: https://chromium-review.googlesource.com/c/1342776Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#609929}
-
Noel Gordon authored
Move this enum into its namespace file (extern import_history): avoids mistakes in our FilesApp BUILD file where developer forgot to add both these dependent extern files. These externs are used to closure compile parts of Files app including our JS unittests (this change is covered by two unittests for example) so they are useful (see bug). No change in test behavior, no new tests. Bug: 905934 Change-Id: I126d8486425fa16098eb16d52376a1622e656d14 Reviewed-on: https://chromium-review.googlesource.com/c/1345697 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Victor Miura authored
Adds repaint stories for 10 top desktop sites. Stories use snapshots made with 'snap-it', to reduce potential noise from page script. Local run-time on Linux: 4m9s BUG=906757 Change-Id: Ic08be0509f7cf66008ede33e2e26525856c58c9d Reviewed-on: https://chromium-review.googlesource.com/c/1343079 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#609927}
-
Nigel Tao authored
BUG=826982 Change-Id: I93e8b96ac058bc4c6d76cbd0af417727a0680b27 Reviewed-on: https://chromium-review.googlesource.com/c/1335071Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#609926}
-
Ben Wells authored
This option was added recently without any tests. This change adds a simple test for this. Bug: 902937 Change-Id: If35b91e8c43db434921a0a6b01beb708957aecb3 Reviewed-on: https://chromium-review.googlesource.com/c/1343813 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
-
