- 28 Sep, 2017 40 commits
-
-
Maks Orlovich authored
This is to permit less-confusing introduction of kSimpleEntryTotalFileCount which also counts the _s file. Bug: 636400 Change-Id: Id4bd67d2f2db4ab2c20a064ec49bdaea8c105e97 Reviewed-on: https://chromium-review.googlesource.com/690482Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#505079}
-
Xida Chen authored
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/69862 TBR=schenney@chromium.org NOTRY=true Bug: 755405 Change-Id: I86fa77bad65ad9290b598fd6d5e74bb806b030c7 Reviewed-on: https://chromium-review.googlesource.com/690516Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505078}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tbarzic@chromium.org Bug: 666525 Change-Id: I9411427ca99d25dd1081871d3db6400e8d16a418 Reviewed-on: https://chromium-review.googlesource.com/689131Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505077}
-
David Valleau authored
R=cros-printing-dev@chromium.org, skau@chromium.org The file printer_backend_proxy_chromeos.cc was moved to a different file in a recent CL so I have updated the docs. Bug: Change-Id: Ic5c834470e70f3be0cf4e2424957cdcca9a2e03d Reviewed-on: https://chromium-review.googlesource.com/688504Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#505076}
-
Xida Chen authored
TBR=schenney@chromium.org NOTRY=true Bug: 769729 Change-Id: I51576dffb92b28cfff21143517433c3b2e9ac00e Reviewed-on: https://chromium-review.googlesource.com/690745Reviewed-by:
-
Miriam Gershenson authored
It's not currently launched or planned to launch on Linux, and the config on Android is changing. Bug: 768874 Change-Id: I2664ab4ff54a155a2cd18a2047412d762404debb Reviewed-on: https://chromium-review.googlesource.com/685578 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505074}
-
Xianzhu Wang authored
1. Disable composited layers for frame scrollbars in PaintLayerCompositor for SPv2. 2. Issue DrawingRecorder for scrollbar backgrounds. This is mainly to reduce spv2 test failures. We still need a solution of scrollbar painting during composited scrolling for spv2. Bug: 757938 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If5885cfb9a7e3b5dacbac0d26b0b59dd89f42a79 Reviewed-on: https://chromium-review.googlesource.com/685267 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#505073}
-
Fredrik Söderquist authored
Extend the DCHECK to also cover SVG layout objects. The IsBox() check should cover the SVG root, and if it is zero-sized any descendant should not be considered to have a "non-empty" layout size. Overflow is disregarded (as it seems to be in general in this method.) Bug: 769459 Change-Id: Iea15b86032094a15608b614f5baa1057c5d6a686 Reviewed-on: https://chromium-review.googlesource.com/689997Reviewed-by:
-
Xida Chen authored
It has been very flaky. Please re-enable it with fix TBR=nednguyen@chromium.org NOTRY=true Bug: 769809 Change-Id: I7077fbfa752ca5c046ae63475d974896f42e1225 Reviewed-on: https://chromium-review.googlesource.com/690515Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#505071}
-
Marc-Antoine Courteau authored
If the state field is unpopulated, inserts a blank element at the beginning of the list of states, as the first element is selected by default when the UIPickerView is shown. R=mahmadi Bug: 767972 Change-Id: Iaa0c4bc29b863d8c521f3e9f0b826eb7ccef408d Reviewed-on: https://chromium-review.googlesource.com/689857Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#505070}
-
Koji Ishii authored
This patch fixes inline blocks with orthogonal writing mode: 1. Not to crash in ResolveInlineLength. 2. Uses the correct side of margins for the inline block. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I83abddd8e910985e6f9d9fba9f93954ef038e41d Reviewed-on: https://chromium-review.googlesource.com/688523Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#505069}
-
Jiaquan He authored
Change the accessibility rating text to the way Play Store is using. Bug: 756991 Change-Id: I812faf2e74233ba7f7d1407bea19e00bfbf538b9 Reviewed-on: https://chromium-review.googlesource.com/667785 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Vadim Tryshev <vadimt@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#505068}
-
Sammie Quon authored
Test: ash_unittests WindowSelectorTest.ExitOverviewWithKey Bug: 764995 Change-Id: Ice98b3451a11a526972c1c3cfc0a6a0a4d7399da Reviewed-on: https://chromium-review.googlesource.com/688021Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Valery Arkhangorodsky <varkha@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#505067}
-
Jun Cai authored
On Mac, currently when an entry is selected in the device chooser, the paired text is shown as light green. This CL changes its color to be white to increase the contrast. I uploaded a screenshot on the issue page. Bug: 711563 Change-Id: I4842bfe5e1ea04fcc0a868b8d6f16b8552bd2d20 Reviewed-on: https://chromium-review.googlesource.com/688753Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#505066}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=qinmin@chromium.org Bug: 666525 Change-Id: Iaefa09bfd0085d68c4b296e229197ed8171da6ca Reviewed-on: https://chromium-review.googlesource.com/688232Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505065}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/36dcd7f25d1f..3a5e1fee080c $ git log 36dcd7f25..3a5e1fee0 --date=short --no-merges --format='%ad %ae %s' 2017-09-28 liyuqian Simplify scan converter's args 2017-09-28 brianosman Revert "Make threaded proxy generation MDB-friendly, and defer instantiation" 2017-09-28 brianosman Make threaded proxy generation MDB-friendly, and defer instantiation 2017-09-27 benjaminwagner Update docs on Skia bots. 2017-09-28 robertphillips Add GrTextureProxyPriv Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I137b904ff0266a84ec2c4e7aa0c8f62153fc0db1 Reviewed-on: https://chromium-review.googlesource.com/690322Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505064}
-
Lei Zhang authored
If base::CreateTemporaryFile() fails, the caller should not try to use its out parameter. Change-Id: Ibd301e5dbeb173246c5b540c37417ea9ddc1513a Reviewed-on: https://chromium-review.googlesource.com/688226Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
-
Lei Zhang authored
Change-Id: I571e67eec15b56d0b1cb5ea652a2369fcf805654 Reviewed-on: https://chromium-review.googlesource.com/676258 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#505062}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rdsmith@chromium.org Bug: 666525 Change-Id: I97adc233a59bd7edc9a95fce1c2db458a2caf48f Reviewed-on: https://chromium-review.googlesource.com/688005Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505061}
-
Xida Chen authored
This reverts commit e9d46063. Reason for revert: <INSERT REASONING HERE> Causing test failure: https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/24998 Original change's description: > Reland "Make SECURITY_DCHECK play with Albatross." > > This is a reland of 06d64c00 > Original change's description: > > Make SECURITY_DCHECK play with Albatross. > > > > In Albatross builds, DCHECKs can be compiled in, but non-fatal. See > > https://docs.google.com/a/chromium.org/document/d/1QY4IbbJ8X6G-6-cMheEkP_mT7ZNPCuUJIW2sr_mEiH4 > > > > Bug: 596231 > > Change-Id: I84198f1d3f4122ac7a5bd8a90ed5ea96286b9022 > > Reviewed-on: https://chromium-review.googlesource.com/685498 > > Reviewed-by: Wez <wez@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#504638} > > Bug: 596231 > Change-Id: I2c1223ba264dbdb06e814b92b84adfe9c3c619b7 > Reviewed-on: https://chromium-review.googlesource.com/687874 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505025} TBR=wez@chromium.org,gab@chromium.org,jochen@chromium.org,siggi@chromium.org Change-Id: I121cee3d06ce27dcf04bec7a0074de658f6d3426 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 596231 Reviewed-on: https://chromium-review.googlesource.com/690220Reviewed-by:
-
Theresa Wellington authored
BUG=735556 Change-Id: Id46dce6cf2505e931ff3efd254937a71347746b9 Reviewed-on: https://chromium-review.googlesource.com/690735Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#505059}
-
Bernhard Bauer authored
Bug: 764083 Change-Id: Ib73b7405c39e480ca22e2a32fcbbf308300a2f37 Reviewed-on: https://chromium-review.googlesource.com/690375Reviewed-by:
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=mattm@chromium.org Bug: 666525 Change-Id: I85916b4a88e15fb8a079b557c4fd8451eed8a5cd Reviewed-on: https://chromium-review.googlesource.com/689022 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#505057}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 666525 Change-Id: Ie2ee9465ee7a8cca62b65d0852333ab9680ba6e3 Reviewed-on: https://chromium-review.googlesource.com/689020 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
gaschler authored
Adds a class ContextualSuggestion that replaces all uses of RemoteSuggestion in the ContextualContentSuggestionsService. Contextual suggestions do not fit well into RemoteSuggestion because they do not have categories, and their behavior is expected to diverge further in future. Also, caching non-copyable RemoteSuggestion would be inconvenient. Bug: 749988 Change-Id: I71b7a4630efcb6c8e1a69dd8cbb670b6d9fb72ed Reviewed-on: https://chromium-review.googlesource.com/689996 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#505055}
-
tzik authored
RefPtr<>::Get() is being renamed to get() for a preparation of the unification of RefPtr and scoped_refptr. This CL updates calles of Get() in core/ to use get(). Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I0393de185243f16e79d3dee967424752e62a04be Reviewed-on: https://chromium-review.googlesource.com/690135Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#505054}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 666525 Change-Id: Idf794d844071cc6a515b8366f0ebcf39c1f4c7e8 Reviewed-on: https://chromium-review.googlesource.com/689030Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505053}
-
bsheedy authored
Fixes a rare case of flakiness where testExitFullscreenAfterExitingVrFromCinemaMode was failing due to fullscreen not being exited instantaneously upon VR exit. Bug: Change-Id: Ia018676f5e1691805653d1313d4db41c34c9d00c Reviewed-on: https://chromium-review.googlesource.com/688300Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#505052}
-
Ken Rockot authored
Allocation padding was added to the global port map to avoid being stomped on by a UAF somewhere on Chrome for Android. The culprit has likely been found and a fix is imminent. See bug 673417 for details. BUG=740044,725605 TBR=jcivelli@chromium.org Change-Id: I934c0e7a6a84a7eb21a74d122f446e14275babbf Reviewed-on: https://chromium-review.googlesource.com/688492Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#505051}
-
Iulia Harasim authored
This CL adds a handful of tests for the personalized signin promos in Bookmarks. The tests verify whether: - The promo can be manually dismissed / the promo gets automatically dismissed after the impression limit has been reached. - The signin buttons fire the right intents when clicked. It also updates the API of AccountSigninActivity and replaces some anonymous classes in SigninAndSyncView with lambdas. Bug: 737743 Change-Id: I45d7dfd246f98e1a2ca4e3bf79616274c858d256 Reviewed-on: https://chromium-review.googlesource.com/686755 Commit-Queue: Iulia Harasim <iuliah@google.com> Reviewed-by:Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505050}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=xiyuan@chromium.org Bug: 666525 Change-Id: I10358379bca0403dc8a3d27fbfd02a632cce65d3 Reviewed-on: https://chromium-review.googlesource.com/689104Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505049}
-
Mostyn Bramley-Moore authored
Formerly known as Opera TV. TBR=jochen@chromium.org Change-Id: I22ffe796c455e75cba9e0624727ea6499097ac83 Reviewed-on: https://chromium-review.googlesource.com/689514Reviewed-by:
Mostyn Bramley-Moore <mostynb@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#505048}
-
Ella Ge authored
In this cl, we throw error in EventSender::AddTouchPoint to prevent touch_point_.size() exceed kTouchesLengthCap. Bug: 764921 Change-Id: Ifbb8db421f1a523e91a845284656b17d6269bb40 Reviewed-on: https://chromium-review.googlesource.com/687809Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#505047}
-
Xianzhu Wang authored
1. Skip virtual/new-remote-playback-pipeline/ which is under development. 2. Remove baselines for paint/invalidation/video-[un]mute-repaint.html and expect failures. The video implementation is being changed and we can't catch up with it. TBR=pdr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3f5cf22ddb879d77bfc78c86227b4ae06fa5d25d Reviewed-on: https://chromium-review.googlesource.com/690323Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505046}
-
John Chen authored
Add media trace events needed to calculate buffering time, dropped frame count, and seek time in media perf benchmarks. Bug: 700160 Change-Id: I340fe3763a73fe3a77e6a04d0d8761811ae6838e Reviewed-on: https://chromium-review.googlesource.com/674166 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#505045}
-
Xida Chen authored
TBR=chongz@chromium.org NOTRY=true Bug: 652536 Change-Id: Ib64364b32cbaeafa9423f87d4a6ed776f4fdbe44 Reviewed-on: https://chromium-review.googlesource.com/690439Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5738043d. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2515 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I5fe3217aabe3bc3d3804d4253d142c16cc3b03c7 Reviewed-on: https://chromium-review.googlesource.com/690218 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505043}
-
Xida Chen authored
It has been flaky. I will let this CL go through CQ to make sure there is no build failure TBR=dgn@chromium.org Bug: 769738 Change-Id: I495c98457d6139d6c46577d30d101b1ca4c4aa29 Reviewed-on: https://chromium-review.googlesource.com/690320Reviewed-by:
-
Gauthier Ambard authored
The NTP view cannot use the safeAreaInsets property directly as it is snapshotted before being inserted in the view hierarchy, and the safe area is only available for views in the view hierarchy. This CL introduces a property mirroring the safe area once the view is in the view hierarchy. But it is also set up with the value used in the first frame, allowing the snapshot to be done as if the view was in the view hierarchy. Bug: 767869 Change-Id: I605566105862e9f4c557736ec65df5f8ab1fc76b Reviewed-on: https://chromium-review.googlesource.com/681942 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#505041}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=msw@chromium.org Bug: 666525 Change-Id: I310eea6b9f3dba136c2d46df235d9ce51b47b7a6 Reviewed-on: https://chromium-review.googlesource.com/689100Reviewed-by:
-
