GitLab

TBR=isherman@chromium.org
BUG=104307

Review URL: http://codereview.chromium.org/8574006

TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/8468006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110093 0039d316-1c4b-4281-b951-d872f2087c98

TBR=isherman@chromium.org
BUG=104307

Review URL: http://codereview.chromium.org/8574006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110092 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jsbell@chromium.org
BUG=104306

Review URL: http://codereview.chromium.org/8572013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110091 0039d316-1c4b-4281-b951-d872f2087c98

than one of them has now flaked as per bug 104132.

TBR=dmazzoni@chromium.org
BUG=104132

Review URL: http://codereview.chromium.org/8568009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110090 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: http://codereview.chromium.org/8528036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103258
TEST=compiles

Review URL: http://codereview.chromium.org/8568008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103258
TEST=no change in sad tab behavior

Review URL: http://codereview.chromium.org/8477042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110086 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64263
TEST=None

R=willchan@chromium.org

Review URL: http://codereview.chromium.org/8552002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110085 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=pkasting@chromium.org


Review URL: http://codereview.chromium.org/8573001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110083 0039d316-1c4b-4281-b951-d872f2087c98

Adds a WebUIBrowserTest for WebUI Hung Renderer Dialog.

Also modifies HungRendererDialog to allow it to be called in a test without killing processes or restarting hang timers.

Fixed revert issue with win_aura.

BUG=102073
TEST=browser_tests HungRendererDialogUITest.*

Review URL: http://codereview.chromium.org/8555027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110082 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110081 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8565022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103941
TEST=Manual: in about:flags, enable WebUI lock screen, then lock screen; no 'Add user' button should be visible.

Review URL: http://codereview.chromium.org/8468004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110079 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110078 0039d316-1c4b-4281-b951-d872f2087c98

The ThreadSanitizer detected data races in the code and more work will be done
to make webrtc tracing work with Chromium.

TBR=niklase
BUG=103711
Review URL: http://codereview.chromium.org/8573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110077 0039d316-1c4b-4281-b951-d872f2087c98

Using the initializer list construct = {0} allows the object to be linker initialized.
Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design.
Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile)

BUG=94925
TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward.
TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org

Review URL: http://codereview.chromium.org/8491043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20044,chromium-os:22552,chromium-os:22825
TEST=Manual: tab order on the Login dialog should be: user pods, Shutdown/Add User buttons, Remove user buttons, status area.

Review URL: http://codereview.chromium.org/8567006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110074 0039d316-1c4b-4281-b951-d872f2087c98

Previously, all lines were joined together into a single hard-to-read
block. Change expanded state to make white-space significant so
multi-line error messages are on separate lines and network
configuration renders nicely.

BUG=chromium:104138
TEST=Put network configuration policy in place and check about:policy.


Review URL: http://codereview.chromium.org/8555009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110070 0039d316-1c4b-4281-b951-d872f2087c98

R=stevenjb@chromium.org
BUG=chromium-os:21760
TEST=Change the network state with a11y turned on


Review URL: http://codereview.chromium.org/8503041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Compiles and passes tests.


Review URL: http://codereview.chromium.org/8555012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110068 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110063 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove manually adjusting the vertical position of the subpage backdrop, as that's done via z-index now as well.

BUG=77791
TEST=no managed prefs banner ugliness


Review URL: http://codereview.chromium.org/8467029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8136027

TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/8564044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110059 0039d316-1c4b-4281-b951-d872f2087c98

I've preferred using kTimeoutMultiplier only once to duplicating it for each timeout.
This however makes InitializeTimeout(0, 0, &value) non-unipotent.

BUG=103371
Review URL: http://codereview.chromium.org/8510053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110058 0039d316-1c4b-4281-b951-d872f2087c98

This change widens the current suppression rule for bug 47949 and adds a new rule for it.

TBR=timurrrr,jhawkins
BUG=47949
TEST=make the "Webkit Mac (valgrind)" bot green.

Review URL: http://codereview.chromium.org/8564025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8136027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110056 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of http://codereview.chromium.org/8351048/ with minor changes
to fix the compilation errors on the shared builders.

BUG=102446
TEST=See bug description.

Review URL: http://codereview.chromium.org/8528053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104265
TBR=jeremya@chromium.org

Review URL: http://codereview.chromium.org/8528055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110054 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=none
TEST=Starting to drag a tile on NTP4 works when bubble is showing (and hides the
bubble without issue).


Review URL: http://codereview.chromium.org/8565014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8527018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82857
TEST=manual

Review URL: http://codereview.chromium.org/8526017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110049 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Remove unneeded forward declarations from chrome/browser/ui/gtk and chrome/browser/ui/cocoa.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110047 0039d316-1c4b-4281-b951-d872f2087c98

Task Manager:  Right click on the task manager list box when no item is selected should display column selection menu. But when any item is selected, the table context menu is displayed.

BUG=103649
TEST=None


Review URL: http://codereview.chromium.org/8510045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110046 0039d316-1c4b-4281-b951-d872f2087c98

This patch is 1 of 3 splitted patches made from http://codereview.chromium.org/8386031
cros_disks_client.cc is made by mixing and refactoring chromeos_mount.cc of libcros and chrome/browser/chromeos/cros/mount_library.cc
Added code is still not used.

BUG=chromium-os:16556
TEST=build success


Review URL: http://codereview.chromium.org/8499007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110045 0039d316-1c4b-4281-b951-d872f2087c98

with the download manager.  This change should have no effect on
when the user sees a warning or not.

BUG=102540
TEST=No visible change yet.


Review URL: http://codereview.chromium.org/8536041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unittests


Review URL: http://codereview.chromium.org/8533028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110043 0039d316-1c4b-4281-b951-d872f2087c98